[7u8] Request for review and approval/backport: 7146424, 7188114, 7151434 , 7170087 : Wildcard expansion for single entry classpath

[David Holmes]

Hi Kumar,

Seems okay to me.

David

On 16/08/2012 9:17 PM, Kumar Srinivasan wrote:
> This addresses Jim's comments (he is on vacation) anyone else wants to
> review ?
>
> Delta webrev since the last reviewed one.
> http://cr.openjdk.java.net/~ksrini/7146424/webrev.1/webrev.delta/index.html
>
> Full webrev is here:
> http://cr.openjdk.java.net/~ksrini/7146424/webrev.1/index.html
>
> 7151434 changeset
> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f68c854fa584
> and
> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f109feb13698
>
> Thanks
> Kumar
>> On 8/15/2012 12:53 PM, Seán Coffey wrote:
>>> Kumar,
>>>
>>> Looks like there are 3 bug IDs being backported then. Please ensure
>>> the 3 bug IDs get a 7u8 record (subCR)
>>> I've updated the subject line with the 3 IDs for reference purposes.
>> Ok
>>>
>>> Yes - it makes sense to backport 7151434 also. It's a bug fix I
>>> exchanged mail with you about earlier this year!
>>
>> Ok
>>
>>> Approved.
>>>
>> modified webrev forthcoming....
>>
>> Thanks
>> Kumar
>>> regards,
>>> Sean.
>>>
>>>
>>> On 15/08/2012 20:26, Kumar Srinivasan wrote:
>>>> Thanks Jim!
>>>>> -
>>>>> http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/src/share/bin/wildcard.c.frames.html
>>>>>
>>>>> This line was deleted in the jdk8 version but not in the jdk 7
>>>>> version:
>>>>>> 149 WIN32_FIND_DATA find_data;
>>>>
>>>> Good catch I will fix this..
>>>>> -
>>>>> http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/test/tools/launcher/Arrrghs.java.frames.html
>>>>>
>>>>> These lines were added in the jdk 8 version but not in the jdk 7
>>>>> version
>>>> This has not been added to jdk7, since this is a different bug fix
>>>> 7151434 which exists in jdk8 but not
>>>> in jdk7, since this is a simple bug fix I will back port this as
>>>> well to jdk7.
>>>>
>>>> Sean let me know asap if you don't want this in 7.
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151434
>>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f68c854fa584
>>>>
>>>>
>>>> Thanks
>>>>
>>>> Kumar
>>>>
>>>>>> 576 // 7151434, test for non-negative exit value for an
>>>>>> incorrectly formed
>>>>>> 577 // command line, '% java -jar -W', note the bogus -W
>>>>>> 578 tr = doExec(javaCmd, "-jar", "-W");
>>>>>> 579 tr.checkNegative();
>>>>>> 580 tr.contains("Unrecognized option: -W");
>>>>>> 581 if (!tr.testStatus)
>>>>>> 582 System.out.println(tr);
>>>>>
>>>>> Other than that, thumbs up
>>>>> - jjh
>>>>>
>>>>>
>>>>> On 8/14/2012 12:58 PM, Kumar Srinivasan wrote:
>>>>>> Hi All,
>>>>>>
>>>>>> This has been integrated into jdk8 the changesets are:
>>>>>>
>>>>>> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7188114
>>>>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3521fcad4b5f
>>>>>> went in cleanly into 7u-dev,
>>>>>>
>>>>>> This one is a separated changeset, such that we can record
>>>>>> the attribution credits, for review purposes I have merged it in
>>>>>> the webrev.
>>>>>>
>>>>>> [2] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7146424
>>>>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2dd41a2dfe54
>>>>>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-July/010941.html
>>>>>>
>>>>>> needed some cajoling as the line numbers were different.
>>>>>>
>>>>>> I folded in a a minor bug fix in launcher resources. and a test
>>>>>> ToolsOpts.java
>>>>>> the was useful in catching regression with this work.
>>>>>>
>>>>>> 7u-dev webrev is here:
>>>>>> http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/
>>>>>>
>>>>>> fyi: 8 webrevs are here:
>>>>>> http://cr.openjdk.java.net/~ksrini/7146424-jdk8/webrev.0/
>>>>>>
>>>>>> Thanks
>>>>>> Kumar
>>>>>>
>>>>>>
>>>>
>>>
>>
>