[7u6] Request for approval for CR 7157855: jvisualvm.1 not included in binaries

[Michael Fang]

Hi Andrew/Sean,

The review was posted on internal ReviewBoard and was reviewed by Dave 
(build) and Tomas (VisualVM). Next time I will remember to post to 
project alias.

thanks,

-michael

On 12年08月20日 03:24 下午, Seán Coffey wrote:
> I can't find the original jdk8 review thread either.
>
> Good catch Andrew. I've created a bug ID for you : (should be live in 
> next 1-2 days)
> 7192804 : Build should not install jvisualvm man page for OpenJDK
>
> Needs addressing in JDK8 and 7u. JDK8 will need addressing in the old 
> and new makefile systems.
>
> regards,
> Sean.
>
> On 20/08/2012 18:57, Andrew Hughes wrote:
>> ----- Original Message -----
>>> This fix is also addressed in jdk8 at the same time.
>>>
>>> Bug: http://bugs.sun.com/view_bug.do?bug_id=7157855
>>> Webrev: http://cr.openjdk.java.net/~mfang/7157855/
>>> Reviewers: katleman, thurka
>>>
>>> thanks,
>>>
>>> -michael
>>>
>> Do you have a link to where this was reviewed?  I don't see it in my 
>> inbox.
>>
>> There is a flaw in this patch.  jvisualvm is not part of OpenJDK so 
>> the man
>> page should not be installed if building OpenJDK.
>>
>> The same bug had to be rectified for javaws in 7021314: Build should 
>> not install javaws man page.
>>
>> I'll post a webrev but basically it needs to be surrounded by an 
>> #ifndef OPENJDK.