hg: jdk7u/jdk7u-dev/jdk: 7167780: Hang javasoft.sqe.tests.api.javax.swing.Timer.Ctor2Tests

[David Holmes]

Hi Vlad,

On 28/08/2012 4:37 PM, Vladislav Karnaukhov wrote:
> Hello Seán,
>
> the request was filed on swing-dev at openjdk.java.net alias and was
> reviewed and approved by Alexander Scherbatiy and Pavel Porvatov.

That's not the approval Sean was referring to. All jdk7u changesets have 
to be approved by the jdk7u maintainers.

http://openjdk.java.net/projects/jdk7u/groundrules.html

Further, I find this fix somewhat unsatisfactory - see the CR for my 
comments.

Cheers,
David

> Regards,
> - Vlad
>
> On 28.08.12 1:55, Seán Coffey wrote:
>> Alexander, Vlad,
>>
>> I didn't see an approval request filed to jdk7u-dev for this push. If
>> that's the case (and as per jdk7u ground rules), can you file an
>> approval request so that the jdk7u maintainers can retroactively
>> review and approve this issue ?
>>
>> regards,
>> Sean.
>>
>> On 27/08/2012 18:37, alexander.potochkin at oracle.com wrote:
>>> Changeset: 589c21e1aa30
>>> Author: vkarnauk
>>> Date: 2012-08-27 21:38 +0400
>>> URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/589c21e1aa30
>>>
>>> 7167780: Hang javasoft.sqe.tests.api.javax.swing.Timer.Ctor2Tests
>>> Reviewed-by: rupashka
>>>
>>> ! src/share/classes/javax/swing/TimerQueue.java
>>>
>