[7u4-osx] Please review: 7124089: launcher refactoring v1.0

Anthony Petrov anthony.petrov at oracle.com
Fri Jan 20 08:36:19 PST 2012


Hi Kumar,

The fix looks fine to me.

--
best regards,
Anthony

On 1/20/2012 8:24 PM, Kumar Srinivasan wrote:
> 
> Hi All,
> 
> Based on all the comments from Anthony, Joe and David,
> here is the modified version:
> 
> Highlights:
> 1. re-factored code in solaris directory  to be shared with macosx,
>     reducing duplication across the *nixes.
> 
> 2. adjusted the makefiles to allow the above
> 
> 2. eliminated all conditionals from the shared  java.c
> 
> 3. added a new launcher regression test for the macosx specific -X options
>  
> For those who have already reviewed the 0th version, here is an
> incremental webrev to make it easier reviewing the differences.
> http://cr.openjdk.java.net/~ksrini/7124089/webrev.1/webrev.delta/index.html
> 
> Here is the complete webrev:
> http://cr.openjdk.java.net/~ksrini/7124089/webrev.1/index.html
> 
> Thanks
> Kumar
> 
> 



More information about the jdk7u-dev mailing list