[jdk7u-dev] Please review the fix for 7126832

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed Jan 25 15:43:04 PST 2012


Looks good to me.

-- Jon

On 01/25/2012 10:29 AM, Jim Holmlund wrote:
> Here is the bug:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7126832
>
> Here is the webrev
> http://cr.openjdk.java.net/~jjh/7126832/
>
> The fix is the same as the fix in jdk8 with one exception:
> - in JDK 8, the compile(...) methods in Main.java return Result 
> whereas in JDK 7 they return int
> - the patch adds a new compile method, so in 8 this new method is
>          public Result compile(String[] args,   .....
>
>   whereas in 7u-dev, it is
>          public int compile(String[] args,   .....
>
> Here is the patch in jdk 8:
> http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ac36176b7de0
>
> Testing:
>    - langtools built and regression tests run on Windows
>
> Thanks
> - jjh
>
>




More information about the jdk7u-dev mailing list