[7u-osx] Request for approval for 7131793: [macosx] some cleanup in OGL pipeline code
Sergey Bylokhov
sergey.bylokhov at oracle.com
Mon Jan 30 01:52:05 PST 2012
30.01.2012 13:44, Sergey Bylokhov wrote:
> Hi Dmitry,
> I have a question about CGLLayer.m
>
> 124JNFCallVoidMethod(env, [self.javaLayer jObjectWithEnv:env],
> jm_drawInCGLContext);
>
> Should we delete a local reference which returned from [self.javaLayer
> jObjectWithEnv:env]? And check it for null?
JNFJObjectWrapper.h
......
- (jobject) jObjectWithEnv:(JNIEnv *)env; // returns a new local-ref,
must be released with DeleteLocalRef
......
>
>
> 30.01.2012 13:54, Dmitry Cherepanov wrote:
>> This is a request to push the following fix to jdk7u-osx:
>>
>> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7131793
>>
>> Webrev: http://cr.openjdk.java.net/~dcherepanov/7131793/webrev.2
>>
>> Technical review:
>> http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-January/002537.html
>>
>> Thanks,
>> Dmitry
>
>
--
Best regards, Sergey.
More information about the jdk7u-dev
mailing list