Request for review: 7123229: (coll) EnumMap.containsValue(null) returns true

[Neil Richards]

On Tue, 2012-01-31 at 10:38 +0000, Alan Bateman wrote:
> Thanks for getting this one fixed. One thing I notice is that your 
> change-set comment has you listed in the Contributed-by field and as the 
> author at the same time.

Hi Alan,
I had thought that always having "Contributed-by" was the correct thing
to do.

As you called it out, I re-read the relevant bit in the OpenJDK
Developers Guide [1] ("Formatting a Changeset Comment"), and now see
that I was mistaken:

        "It <the contributed-by line> should be included only when the
        author or authors of the change do not have commit rights to the
        target repository and thus would not otherwise receive
        acknowledgement."

Thanks for the correction.

Regards,
Neil

[1] http://openjdk.java.net/guide/producingChangeset.html

-- 
Unless stated above:
IBM email: neil_richards at uk.ibm.com
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU