[7u8] Request for approval: 7032018: The file list in JFileChooser does not have an accessible name

Pavel Porvatov pavel.porvatov at oracle.com
Wed Jul 18 01:41:53 PDT 2012


Hi Charles,

Looks good for me.

See also comments below...
> Hi all,
>
> Requesting for approval to push the changes to add accessible name for 
> JFileChooser.
>
> Changeset in jdk8 @ 
> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/16c3dcad4252
> Changeset for jdk7u-dev @ 
> http://cr.openjdk.java.net/~littlee/jdk7u/102/webrev.00/ 
> <http://cr.openjdk.java.net/%7Elittlee/jdk7u/102/webrev.00/>
>
> Reviewed by
> Pavel Porvatov
>
> P.S. I see file 
> "src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties" 
> has been changed to windows mode. (^M shows in my emacs). It is 
> introduced by committing 7093156: NLS Please change the mnemonic 
> assignment system to avoid translation issue (Swing files). Can we 
> change it back?
>
I think that's a good idea. Incorrect line separators were fixed in jdk8 
with http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4b470e9017da

Regards, Pavel



More information about the jdk7u-dev mailing list