[7u8] Request for approval: 7032018: The file list in JFileChooser does not have an accessible name

[Sean Coffey]

Hi Neil,

Good point, 7174970 is already in 7u.

I'm ok with option 1 below. Correction of EOL characters should have no 
functional impact and helps to keep the code tidy also.
I would have thought jcheck[1] would flag such issues but perhaps it 
doesn't cover EOL sequences.

Regards,
Sean.

[1] http://openjdk.java.net/projects/code-tools/jcheck/

On 19/07/2012 06:59, Neil Richards wrote:
> Hi Sean,
> Pavel refers to the change for 7174970 [1] as fixing the EOL issue (that
> Charles identifies) in basic.properties in the openjdk8 code stream.
> (It also addresses the same issue in the basic_*.properties files in
> that code stream).
>
> I see that the change for 7174970 has already been migrated to jdk7u-dev
> [2], but that it did not correct the corresponding EOL issue with
> basic.properties there.
>
> Therefore, as it currently stands, basic.properties still has
> windows-style EOL sequences in jdk7u-dev.
> (The other basic_*.properties files in jdk7u-dev have unix-style EOL
> sequences, as is generally desired).
>
> So, just to clarify, is your approval to:
>       1. push to jdk7u-dev the change for 7032018 incorporating the
>          remaining EOL correction (to basic.properties), or
>       2. push just the change for 7032018, leaving the EOL correction to
>          a subsequent (yet to be defined) changeset ?
>
> Regards,
> Neil
>
> [1] http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4b470e9017da
> [2] http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/762ae4a20c8b
>
> On Wed, 2012-07-18 at 11:12 -0700, Sean Coffey wrote:
>> Approved for 7u8 Charles.
>>
>> I've created a 7u8 bug record and will update once I see your push.
>>
>> regards,
>> Sean.
>>
>> On 18/07/2012 01:49, Charles Lee wrote:
>>> On 07/18/2012 04:41 PM, Pavel Porvatov wrote:
>>>> Hi Charles,
>>>>
>>>> Looks good for me.
>>>>
>>>> See also comments below...
>>>>> Hi all,
>>>>>
>>>>> Requesting for approval to push the changes to add accessible name
>>>>> for JFileChooser.
>>>>>
>>>>> Changeset in jdk8 @
>>>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/16c3dcad4252
>>>>> Changeset for jdk7u-dev @
>>>>> http://cr.openjdk.java.net/~littlee/jdk7u/102/webrev.00/
>>>>> <http://cr.openjdk.java.net/%7Elittlee/jdk7u/102/webrev.00/>
>>>>>
>>>>> Reviewed by
>>>>> Pavel Porvatov
>>>>>
>>>>> P.S. I see file
>>>>> "src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic.properties"
>>>>> has been changed to windows mode. (^M shows in my emacs). It is
>>>>> introduced by committing 7093156: NLS Please change the mnemonic
>>>>> assignment system to avoid translation issue (Swing files). Can we
>>>>> change it back?
>>>>>
>>>> I think that's a good idea. Incorrect line separators were fixed in
>>>> jdk8 with http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4b470e9017da
>>>>
>>>> Regards, Pavel
>>>>
>>> Hi Pavel,
>>>
>>> Thanks for the information. I will try to raise a request for
>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/4b470e9017da after this
>>> issue has been committed.
>>>
>