[7u6] Request for Approval : 7173432: Remove String.count/String.offset

Alan Bateman Alan.Bateman at oracle.com
Fri Jun 1 00:25:38 PDT 2012


On 01/06/2012 06:47, Mike Duigou wrote:
> Hi,
>
> This is a request to include a bug fix into JDK 7u6:
> 6924259: Handle insertion of null key at HashMap resize
>
> This is a bug fix for the recently integrated CR#7126277 which fixes a bug uncovered during integration testing.
>
> There is a webrev of the fix plus a regression test open for review. I still need a reviewer in addition to approval before I can commit.
>
> http://cr.openjdk.java.net/~mduigou/7173422/0/webrev/
>
> This fix blocks the b13 build. When ready I will push to:
> ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk
>
> Thanks!
>
> Mike
This doesn't seem to be in jdk8 yet but as it's a blocker issue then I'm 
sure that an exception can be made.

The change looks good to me. Minor comment on the test is that it would 
be nice to indent the second and third lines of the summary to make it 
easier to read. Also very minor nit is that you probably need a space in 
"while(" and "if(!" and "if(".

-Alan.



More information about the jdk7u-dev mailing list