[7u6] Request for approval / patch for review : 7178548 : Hashtable ignores threshold default

Seán Coffey sean.coffey at oracle.com
Thu Jun 21 13:43:22 PDT 2012


Mike,

http://cr.openjdk.java.net/~mduigou/7178548/0/webrev/src/share/classes/java/util/concurrent/ConcurrentHashMap.java.cdiff.html 
<http://cr.openjdk.java.net/%7Emduigou/7178548/0/webrev/src/share/classes/java/util/concurrent/ConcurrentHashMap.java.cdiff.html>

>                try {
>                    threshold = (null != altThreshold)
>                            ? Integer.parseInt(altThreshold)
>                            : 1;
Should that 1 in ConcurrentHashMap also be reverting to an 
ALTERNATE_HASHING_THRESHOLD type value ? (of 512)

regards,
Sean.

On 20/06/2012 23:16, Mike Duigou wrote:
> Hello all;
>
> This is a small patch for review for 7u6 to correct a problem with the handling of the alternative hashing threshold.
>
> http://cr.openjdk.java.net/~mduigou/7178548/0/webrev/
>
> The patch also includes a suggested documentation fix and an minor change in WeakHashMap noted in earlier reviews that was too insiginificant for it's own issue.
>
> This change is not a back port because jkd8 uses a different implementation and is unaffected.
>
> When approved and reviewedI intend to push it to
>    ssh://hg.openjdk.java.net/jdk7u/jdk7u-dev-gate/jdk
>
> Regards,
>
> Mike



More information about the jdk7u-dev mailing list