Review OSX universal mode patch

David Holmes david.holmes at oracle.com
Thu May 10 01:16:44 PDT 2012


Hi Henri,

On 10/05/2012 5:09 PM, Henri Gomez wrote:
> Could someone review my patches to bring back universal mode
> (32/64bits) to OSX for OpenJDK 7 (u branch)
>
> http://openjdk-osx-build.googlecode.com/svn/trunk/patches-jdk7u-osx/universal-build.patch
>
> Now os.arch is reported as i386 if data.model is 32 and as x86_64 is
> data.model is 64bits.

The setting of the os.arch property in 
src/solaris/native/java/lang/java_props_md.c should be handled by 
setting ARCHPROP appropriately in jdk/make/common/Platform.gmk, not by 
ifdefs in the C file.

Can't comment on anything else as I don't grok this "universal" build 
business.

David

> It should fix problem with JRuby :
>
> https://github.com/jruby/jruby/commit/9e05b5f1791917cdc3487b3ddfd78956c4bb92c0#commitcomment-1306674
>
> Cheers



More information about the jdk7u-dev mailing list