Review OSX universal mode patch

[Henri Gomez]

> LP64=1 shows this is not actually a 32-bit build; as does the fact it is
> using amd64.
>
> ARCH=i386 is generally not the correct value for 32-bit x86 builds. LIBARCH
> ends up as i386 but ARCH should be i586 (or i686) if I recall correctly for
> hotspot. Trying to force a 32-bit build when the host platform is 64-bit is
> a form of cross-compilation that doesn't presently work for any OpenJDK
> architecture (the JDK requires different settings to Hotspot).

providing ARCH=i586 produce same error :

	echo "  DYLD_LIBRARY_PATH=.:${DYLD_LIBRARY_PATH:+$DYLD_LIBRARY_PATH:}\${JAVA_HOME}/jre/lib/native_threads:\${JAVA_HOME}/jre/lib:${DYLD_LIBRARY_PATH:+$DYLD_LIBRARY_PATH:}\${JAVA_HOME}/jre/lib/amd64/native_threads:\${JAVA_HOME}/jre/lib/amd64:";
\
	echo "  export DYLD_LIBRARY_PATH"; \
	echo "fi"; \
	echo ""; \
	echo "# Use the gamma launcher and JAVA_HOME to run the test"; \
	echo ""; \
	echo "./\${GAMMA_PROG} -Xbatch -showversion Queens < /dev/null"; \
	) > test_gamma
chmod +x test_gamma
touch bsd_amd64_compiler2/profiled
cd bsd_amd64_compiler2/product && make  " LP64=1 "
cd /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-i586/hotspot/outputdir/bsd_amd64_compiler2/product/../generated;
 cp /Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/platform_amd64
/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/build/macosx-i586/hotspot/outputdir/bsd_amd64_compiler2/product/../generated/platform.current
make[8]: *** No rule to make target
`/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/src/cpu/i586/vm/x86_64.ad',
needed by `../generated/adfiles/bsd_x86_64.ad'.  Stop.
make[8]: *** Waiting for unfinished jobs....
make[7]: *** [ad_stuff] Error 2
make[6]: *** [product] Error 2
make[5]: *** [generic_build2] Error 2
make[4]: *** [product] Error 2
make[3]: *** [all_product_universal] Error 2
make[2]: *** [universal_product] Error 2
make[1]: *** [hotspot-build] Error 2
make: *** [build_product_image] Error 2

LP64 is set even if 32bits mode is defined.

chmod +x test_gamma
touch bsd_amd64_compiler2/optimized
[ -d bsd_amd64_compiler2/product ] || { mkdir -p bsd_amd64_compiler2/product; }
cd bsd_amd64_compiler2/product && make -f
/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/makefiles/buildtree.make
Makefile flags.make flags_vm.make vm.make adlc.make jvmti.make sa.make
dtrace.make env.sh env.csh jdkpath.sh .dbxrc test_gamma
GAMMADIR=/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot
OS_FAMILY=bsd SRCARCH=x86 BUILDARCH=amd64 LIBARCH=amd64 VARIANT=tiered
HOTSPOT_RELEASE_VERSION=23.0-b21 HOTSPOT_BUILD_VERSION=
JRE_RELEASE_VERSION=1.7.0-jdk7u6-b08-20120510 TARGET=product
Creating Makefile ...
( \
	echo "# Generated by
/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/makefiles/buildtree.make";
\
	echo; \
	echo include flags.make; \
	echo; \
	echo "include \$(GAMMADIR)/make/bsd/makefiles/top.make"; \
	) > Makefile
Creating flags.make ...
( \
	echo "# Generated by
/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/makefiles/buildtree.make";
\
	echo; \
	echo "Platform_file =
/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/platform_amd64"
| sed 's|/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot|$(GAMMADIR)|';
\
	sed -n '/=/s/^ */Platform_/p' <
/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot/make/bsd/platform_amd64;
\
	echo; \
	echo "GAMMADIR =
/Users/henri/Documents/jenkins/data/jobs/openjdk-jdk7u-jdk7u/workspace/hotspot";
\
	echo "SYSDEFS = \$(Platform_sysdefs)"; \
	echo "SRCARCH = x86"; \
	echo "BUILDARCH = amd64"; \
	echo "LIBARCH = amd64"; \
	echo "TARGET = product"; \
	echo "HS_BUILD_VER = 23.0-b21"; \
	echo "JRE_RELEASE_VER = 1.7.0-jdk7u6-b08-20120510"; \
	echo "SA_BUILD_VERSION = 23.0-b21"; \
	echo "HOTSPOT_BUILD_USER = henri"; \