[7u6] Request for approval for CR 7093156 - NLS: Please change the mnemonic assignment system to avoid translation issue (Swing files)

[Edvard Wendelin]

Looks good! Approved. 

On May 12, 2012, at 12:45 PM, Alexander Scherbatiy wrote:

> Hello,
> 
> This is a request from the NLS team to backport  a JDK 8 fix into JDK 7u6.
> 
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7093156
> webrev: http://cr.openjdk.java.net/~alexsch/7093156/webrev7.01
> review: http://mail.openjdk.java.net/pipermail/swing-dev/2012-May/002049.html
> 
> JDK 8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/cbf39e7a7535
> 
> 
> The original JDK 8 patch is rejected when it is applied to JDK 8 because the property files are slightly different between JDK 7 and JDK 8
> (for example the JDK 8 basic.properties file has 2 extra properties and the metal.properties file has some extra mnemonics).
> 
> The properties from the following folders are updated:
>   src/share/classes/com/sun/java/swing/plaf/gtk
>   src/share/classes/com/sun/swing/internal/plaf
> 
> According to the request from the NLS team the properties, mnemonics and mnemonic indexes are unified from the
>   xxxText, xxxMnemonic and xxxMnemonicIndex to xxx.titleAndMnemonic (different patterns with the different suffixes are checked).
> 
> The TextAndMnemonicHashMap class is added to the UIDefaults class that now parse requested keys and returns values from the unified properties.
> 
> The fix is tested by the test that loads all old properties and check that UIManager.get() methods returns the same values as before:
>   http://cr.openjdk.java.net/~alexsch/7093156/test/02/SwingResourcesTest.java
> 
> Thanks,
> Alexandr.
> 
>