Request for approval: 6610897: New constructor in sun.tools.java.ClassPath builds a path using File.separator instead of File.pathSeparator

Deven You youdwei at linux.vnet.ibm.com
Thu Nov 1 19:55:00 PDT 2012


Hi Alan,

Thanks very much for your correction. I have updated the webre[1] 
according to your comments. Please review it.

[1] http://cr.openjdk.java.net/~youdwei/ojdk-505/7u/webrev.02/ 
<http://cr.openjdk.java.net/%7Eyoudwei/ojdk-505/7u/webrev.02/>

On 11/01/2012 03:50 PM, Alan Bateman wrote:
> On 01/11/2012 06:20, Deven You wrote:
>> Hi All,
>>
>> This is  a request for approval to push the fix of 6610897 from jdk8 
>> to jdk7u, could anyone take a look?
>>
>> Link to the bug: 
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6610897
>>
>> Webrev for jdk7u: 
>> http://cr.openjdk.java.net/~youdwei/ojdk-505/7u/webrev/ 
>> <http://cr.openjdk.java.net/%7Eyoudwei/ojdk-505/7u/webrev/>
>> The webrev for jdk7u is the same as of jdk8.
>>
>> Changeset in jdk8: 
>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c98a013ec628
>>
>>
>> Review thread for jdk8 starts at:
>>
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-April/009765.html 
>>
>>
>> Thanks a lot!
> This is an odd one to backport as there isn't anything in the JDK 
> impacted by this, it can only be tests or code using sun.* classes 
> directly. As it's completely harmless then I don't object of course.
>
> One thing to know is that the original change pushed the test to an 
> odd location and it was moved subsequently moved, see:
>
> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92c6d920efe0
>
> If I think you could hg export/import that one too, assuming 6610897 
> is actually needed.
>
> BTW: Your webrev for jdk7u-dev seems to have picked up a change for 
> something else, at least I assume 
> test/sun/management/AgentCMETest.java should not be there.
>
> -Alan.
>




More information about the jdk7u-dev mailing list