[7u10] Request for approval: 7024118: possible hardcoded mnemonic for JFileChooser metal and motif l&f

Seán Coffey sean.coffey at oracle.com
Mon Oct 1 03:07:57 PDT 2012


thanks for reviewing Pavel.

Shu Jun - Approved for jdk7u-dev. With the introduction of JIRA [1], bug 
reports are automatically updated with changeset link and fixed status 
when a changeset is pushed. No actions should be necessary on my side. 
+1 for productivity gains :-D

Sean.

[1] 
http://mail.openjdk.java.net/pipermail/announce/2012-September/000137.html

On 01/10/12 10:41, Pavel Porvatov wrote:
> Hi Seán,
>> cc'ing Pavel here. As per mail thread[1], this backport request 
>> raised concerns in July. Were they ironed out ? Any pointer to 
>> review/approve thread if so ?
>>
>> Ideally - this issue may warrant a separate review thread on 
>> swing-dev at this stage.
>>
>> Pavel - Are you ok with latest webrev ?
> The fix looks good for me.
>
> Regards, Pavel
>
>>
>> Regards,
>> Sean.
>>
>> [1] 
>> http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-July/003865.html
>>
>> On 17/09/2012 07:59, Shi Jun Zhang wrote:
>>> Hi all,
>>>
>>> I'd like to request for approval to push the following change into 
>>> 7u10.
>>>
>>> Changeset in jdk8
>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/7fbc8d86c477
>>>
>>> Webrev
>>> http://cr.openjdk.java.net/~zhangshj/jdk7u/7024118/webrev.00/
>>>
>>> Reviewed by alexp
>>>
>>> Review thread
>>> http://mail.openjdk.java.net/pipermail/swing-dev/2011-August/001697.html 
>>>
>>>
>>
>




More information about the jdk7u-dev mailing list