[7u12] Request for approval for CR 7192804 - Build should not install jvisualvm man page for OpenJDK

[Andrew Hughes]

----- Original Message -----
> Approved for jdk7u-dev.
> 
> regards,
> Sean.
> 
> On 10/10/2012 16:39, Andrew Hughes wrote:
> > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7192804
> > Webrev: http://cr.openjdk.java.net/~andrew/7192804/webrev.01/
> > OpenJDK8 Thread:
> > http://mail.openjdk.java.net/pipermail/build-dev/2012-August/006645.html
> > OpenJDK8 Changeset:
> > http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/baf30df50ce3
> >
> > Rationale:
> >
> > The fix for 7157855 added a VisualVM man page into the installed
> > man pages for
> > all builds.  However, VisualVM is not part of OpenJDK builds.  This
> > patch changes
> > the Makefile so that jvisualvm.1 is only installed on non-OpenJDK
> > builds.
> >
> > Differences from 8:
> >
> > The patch is as-is on 8, except that the change to
> > makefiles/Images.gmk (part of the new
> > build system only in 8) has been dropped.
> >
> > Testing:
> >
> > An OpenJDK build on x86_64+GNU/Linux shows that jvisualvm.1 is no
> > longer installed with this
> > patch applied.  There is no way of testing the proprietary build.
> >
> 
> 

Strange, I've only just seen this approval, despite it being sent the
day after.  Maybe it got stuck in the pipes or something...

Anyway, pushed now:

http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/06c648337d2b

Thanks,
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07