[7u12] Request for approval :8000178 (bf) Backout 7190219 fix for jdk7u (JCK issue)

[Edvard Wendelin]

Approved.

On Oct 24, 2012, at 11:20 AM, Seán Coffey <sean.coffey at oracle.com> wrote:

> 
> Looking to back out this fix from 7u for now.
> Review link is here : http://mail.openjdk.java.net/pipermail/nio-dev/2012-October/001944.html
> 
> Alan Bateman has reviewed on nio thread.
> webrev : http://cr.openjdk.java.net/~coffeys/webrev.8000178/ <http://cr.openjdk.java.net/%7Ecoffeys/webrev.8000178/>
> bug report : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8000178
> 
> Regards,
> Sean.
> 
> -------- Original Message --------
> Subject: 	RFR : (bf) Backout 7190219 fix for jdk7u (JCK issue)
> Date: 	Fri, 05 Oct 2012 18:10:13 +0100
> From: 	Seán Coffey <sean.coffey at oracle.com>
> To: 	Jonathan Lu <luchsh at linux.vnet.ibm.com>, nio-dev <nio-dev at openjdk.java.net>
> 
> 
> 
> Jonathan,
> 
> I'm looking to back this fix out of jdk7u-dev since it's causing a JCK failure. The JCK test itself is too strict but we should play safe and revert behaviour for 7u now until the JCK issue is resolved.
> 
> There's a JCK bug following the JCK test issue  (7199569)
> 
> ===
> JCK test api/java_nio/CharBuffer/index.html#Methods2[appendCharSequence0006]
> assumes that ReadOnlyBufferException has some priority over BufferOverflowException if an application attempts to put a String into a read-only CharBuffer that has insufficient space. The spec does not explicitly state, which exception should be thrown if several constraints are violated at the same time, so the test should be fixed/relaxed.
> ====
> 
> Here's the backout webrev : (obtained with hg backout (& interrupted))
> http://cr.openjdk.java.net/~coffeys/webrev.8000178/ <http://cr.openjdk.java.net/%7Ecoffeys/webrev.8000178/>
> 
> JDK bug report : 8000178 (not visible yet)
> 
> ==========
> The fix for 7190219 causes a JCK failure.
> api/java_nio/CharBuffer/index.html#Methods2[appendCharSequence0006]
> 
> That JCK test in itself is too strict and is under review via Bug ID 7199569. For the purpose of update release though, we should withdraw the 7190219 fix.
> ==========
> 
> regards,
> Sean.
> 
> 
>