{mailer issue} Fwd: Re: Request for approval: 7190219 (bf) CharBuffer.put(String, int, int) modifies position even if BufferOverflowException thrown

[Seán Coffey]

On a totally unrelated note...

I cc'ed Alan in the below email but the openJDK mailer seems to strip 
out cc recipients if they're on the openJDK alias. (from what I can make 
out) - This doesn't help folks who might have filters set up for "to or 
cc:" fields.

any ideas on whether this can be changed ? I'm not sure if it was always 
happening. I've only seen it occur in past ~1-2 months.

regards,
Sean.

-------- Original Message --------
Subject: 	Re: Request for approval: 7190219 (bf) CharBuffer.put(String, 
int, int) modifies position even if BufferOverflowException thrown
Date: 	Tue, 04 Sep 2012 13:55:09 +0100
From: 	Seán Coffey <sean.coffey at oracle.com>
To: 	Neil Richards <neil.richards at ngmr.net>
CC: 	jdk7u-dev at openjdk.java.net



Hey Neil,

I wouldn't regard this as a risky fix and don't see a problem with it
going into jdk7u-dev now (before phase2 approval process begins in mid
September) It also benefits from having a unit testcase. Testing (jtreg
tests) in the jdk8/tl repos would have occurred on a regular basis also
since the fix was push there.

Alan was initial reviewer and may wish to comment (cc'ed)

regards,
Sean.

On 04/09/2012 13:30, Neil Richards wrote:
> On Mon, 2012-09-03 at 09:58 +0100, Seán Coffey wrote:
>> Approved for jdk7u-dev. (7u10)
>>
>> I've created a bug record for this and will mark as fixed once I see
>> your push.
>> cc'ing initial reviewer also.
>>
>> regards,
>> Sean.
>>
>> On 03/09/2012 05:18, Jonathan Lu wrote:
>>> Hi folks,
>>>
>>> Here's a request of porting the fix of 7190219 back to JDK7, could you
>>> please review it?
>>>
>>> Bug: http://bugs.sun.com/view_bug.do?bug_id=7190219
>>>
>>> Change set: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf0c6f91bc22
>>>
>>> Thread where it was reviewed:
>>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-August/011087.html
>>>
>>>
>>> Thanks,
>>> Jonathan
>>>
> Hi Sean,
> It looks like this changeset has not yet been promoted from the
> component (tl) forest to the master jdk8 repository.
>
> Please confirm, in light of this, if you'd like this change to be
> applied to jdk7u at this point, or if you would like it to spend some
> (more) time being proved in the jdk8 stream prior to this happening.
>
> Regards,
> Neil
>