RFR (XS): 7023754 JConsole Javascript plugin demo throws exception on window.print

Erik Gahlin erik.gahlin at oracle.com
Mon Aug 19 11:16:13 PDT 2013


Thanks Andreas,

Here is an updated webrev with an updated copyright header.
http://cr.openjdk.java.net/~egahlin/7023754_2/

The same issue was fixed with
"8016531: jconsole-plugin script demo does not work with nashorn"
http://cr.openjdk.java.net/~sundar/8016531/webrev.01/

but it also applies to Rhino.

I still need ok from a jdk7u (r)eviewer and/or backport approval to 
proceed  - can I ask for this please?

Thanks
Erik

Andreas Rieber skrev 2013-08-17 09:54:
> Hi Erik,
>
> the fix looks close to the one fixed in jdk8. Just the year update in 
> copyright header is missing.
>
> Andreas
>
> On 17.08.13 00:11, Erik Gahlin wrote:
>> Could I please have a review of a fix that allows a script in the
>> jconsole script plug-in to call print method in ScriptShellPanel class.
>>
>> Bug:
>> http://monaco.us.oracle.com/detail.jsf?cr=7023754
>
> http://bugs.sun.com/view_bug.do?bug_id=7023754
>
>>
>> Webrev:
>> http://cr.openjdk.java.net/~egahlin/7023754/src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptShellPanel.java.sdiff.html 
>>
>>
>>
>> Tested by running reproducer in bug report.
>>
>> Thanks
>> Erik
>




More information about the jdk7u-dev mailing list