[7u-dev] Request for approval for JDK-7175464 - entrySetView field is never updated in NavigableSubMap

[Mike Duigou]

Thank you for catching this Doug. I missed your original post on this topic during my Christmas vacation. (http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-December/013127.html for those following along at home) 

I will definitely hold off and follow up on the potentially bad patch to Java 8. I have created an issue to resolve the test breakage, JDK-8007889

Mike

On Feb 8 2013, at 11:43 , Doug Lea wrote:

> On 02/08/13 14:33, Mike Duigou wrote:
>> Hello all;
>> 
>> I would like to backport this change from Java 8. It has been baking in JDK8 for about two months with no problems.
>> 
> 
> I think it may have problems.
> As I mentioned in a post a few months ago, it seems
> to be responsible for breakage in a TCK/JCK test;
> One derived from a jsr166 tck test at
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/test/tck/TreeSubSetTest.java?view=log
> 
> You need the file for context, but it looks like:
> 
>    public void testDescendingSerialization() throws Exception {
>        NavigableSet x = dset5();
>        NavigableSet y = serialClone(x);
> 
>        assertTrue(x != y);
>        assertEquals(x.size(), y.size());
>        assertEquals(x.toString(), y.toString());
>        assertEquals(x, y);
>        assertEquals(y, x);
>        while (!x.isEmpty()) {
>            assertFalse(y.isEmpty());
>            assertEquals(x.pollFirst(), y.pollFirst());
>        }
>        assertTrue(y.isEmpty());
>    }
> 
> 
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175464
>> 
>> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bf6ceb6b8f80
>> 
>> The change was previously reviewed by Alan Bateman, Paul Sandoz and David Holmes before going in to Java 8.
>> 
>> Mike
>> 
>