[7u] Review request for 8008764

[Michael Fang]

Thanks Naoto.

-michael

On 13年02月27日 01:07 下午, Naoto Sato wrote:
> Looks good to me.
>
> Naoto
>
> On 2/27/13 11:20 AM, Michael Fang wrote:
>> Hi Naoto,
>>
>> For now, I have reverted accessibility_ja.properties back to the
>> previous version of file. Here's the updated webrev:
>> http://cr.openjdk.java.net/~mfang/8008764/webrev.jdk.01/
>>
>> I have also submitted a bug for the English resource file:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8009168
>> 8009168: accessibility.properties syntax issue
>>
>> thanks,
>>
>> -michael
>>
>> On 13年02月27日 10:15 上午, Michael Fang wrote:
>>> Hi Naoto,
>>>
>>> You are right, I also just realized about this.
>>>
>>> toggle expand = toggle expand
>>> will be interpreted as
>>> key: toggle
>>> value: expand = toggle expand.
>>>
>>> I will file a new bug for dev team who created this file.
>>>
>>> thanks,
>>>
>>> -michael
>>>
>>> On 13年02月27日 10:10 上午, Naoto Sato wrote:
>>>> I think that a key in .properties simply cannot have a plain blank
>>>> character. It has to be escaped with a single backquote like,
>>>> "toggle\ expand"
>>>>
>>>> Naoto
>>>>
>>>> On 2/26/13 8:03 PM, Michael Fang wrote:
>>>>> Hi Naoto,
>>>>>
>>>>> Looks like it may be related to the space between toggle and 
>>>>> expand on
>>>>> the property key of English resource file. I will check with
>>>>> translation
>>>>> team whether their tool can handle this. In the mean time I will 
>>>>> ask QA
>>>>> team to file a bug.
>>>>>
>>>>> English:
>>>>> toggle expand=toggle expand
>>>>>
>>>>> $ grep toggle `find . | grep access` | grep expand
>>>>> ./jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility_pt_BR.properties:toggle 
>>>>>
>>>>>
>>>>> expandir=alternar expans\u00E3o
>>>>> ./jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_CN.properties:toggle 
>>>>>
>>>>>
>>>>> expand=\u5207\u6362\u5C55\u5F00
>>>>> ./jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility_fr.properties:toggle 
>>>>>
>>>>>
>>>>> expand=basculer le d\u00E9veloppement
>>>>> ./jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility_it.properties:toggle 
>>>>>
>>>>>
>>>>> expand=abilita/disabilita espansione
>>>>> ./jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility_es.properties:toggle 
>>>>>
>>>>>
>>>>> expand=activar/desactivar ampliaci\u00F3n
>>>>> ./jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_TW.properties:toggle 
>>>>>
>>>>>
>>>>> expand=\u5207\u63DB\u64F4\u5C55
>>>>> ./jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility_de.properties:toggle 
>>>>>
>>>>>
>>>>> expand=ein-/ausblenden
>>>>>
>>>>> other files:
>>>>> ./jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility_ja.properties:toggle 
>>>>>
>>>>>
>>>>> \u30C8\u30B0\u30EB\u5C55\u958B
>>>>> ./jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility_ko.properties:toggle 
>>>>>
>>>>>
>>>>> \uD655\uC7A5=\uD1A0\uAE00 \uD655\uC7A5
>>>>> ./jdk/src/share/classes/com/sun/accessibility/internal/resources/accessibility_sv.properties:toggle 
>>>>>
>>>>>
>>>>> ut\u00F6ka=v\u00E4xla ut\u00F6ka
>>>>>
>>>>> thanks,
>>>>>
>>>>> -michael
>>>>>
>>>>> On 13年02月26日 07:24 下午, Michael Fang wrote:
>>>>>> Thanks Naoto.
>>>>>>
>>>>>> I will check with translation team about what happened.
>>>>>>
>>>>>> thanks,
>>>>>>
>>>>>> -michael
>>>>>>
>>>>>> On 13年02月26日 06:58 下午, Naoto Sato wrote:
>>>>>>> Hi Michael,
>>>>>>>
>>>>>>> Since I am a Japanese, I just skimmed "ja" translations. The first
>>>>>>> file seems to contain an incorrect entry.
>>>>>>>
>>>>>>> src/share/classes/com/sun/accessibility/internal/resources/accessibility_ja.properties 
>>>>>>>
>>>>>>>
>>>>>>> (sdiff):
>>>>>>>
>>>>>>> ---
>>>>>>> 105 toggle expand=トグル展開    105 toggle トグル展開
>>>>>>> ---
>>>>>>>
>>>>>>> Looks like the new file lacks the equal ('=') and some part of the
>>>>>>> key. This makes me wonder whether this is just a mere editorial 
>>>>>>> error
>>>>>>> by a translator, or some bug in the tools used for the translation
>>>>>>> process...
>>>>>>>
>>>>>>> Naoto
>>>>>>>
>>>>>>> On 2/26/13 4:37 PM, Michael Fang wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> Please help to code review the changes for the following CR:
>>>>>>>>
>>>>>>>> 8008764 : 7uX l10n resource file translation update
>>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008764
>>>>>>>>
>>>>>>>> The webrev is located at:
>>>>>>>> http://cr.openjdk.java.net/~mfang/8008764/
>>>>>>>> The diffs have been converted to UTF-8 encoding for easier
>>>>>>>> review. In
>>>>>>>> the repository, they still use standard encoding for their file
>>>>>>>> type.
>>>>>>>>
>>>>>>>> Since we perform resource file translation updates separately for
>>>>>>>> jdk8
>>>>>>>> and jdk7u, these changes are specific to jdk7u and not ported
>>>>>>>> back from
>>>>>>>> jdk8.
>>>>>>>>
>>>>>>>> thanks,
>>>>>>>>
>>>>>>>> -michael
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>