[7u] Review request for 8019541
Michael Fang
michael.fang at oracle.com
Wed Jul 3 14:24:02 PDT 2013
Thanks Naoto.
-michael
On 07/03/13 14:11, Naoto Sato wrote:
> Thank you for the confirmation. Looks good to me.
>
> Naoto
>
> On 7/3/13 12:51 PM, Michael Fang wrote:
>> Thank you Naoto for the review. Using simple diff, it's showing some
>> spacing difference (but not on webrev).
>>
>> ===================================================================================
>>
>>
>> comparing
>> ./jdk/src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java
>> < old
>> > new
>> ===================================================================================
>>
>>
>> 74c74
>> < "[-digestalg <算法>] 摘要算法的名称"},
>> ---
>> > "[-digestalg <算法>] 摘要算法的名称"},
>> 76c76
>> < "[-sigalg <算法>] 签名算法的名称"},
>> ---
>> > "[-sigalg <算法>] 签名算法的名称"},
>>
>> thanks,
>>
>> -michael
>>
>> On 07/03/13 11:25, Naoto Sato wrote:
>>> Hi Michael,
>>>
>>> Looks like the following file does not contain any meaningful change:
>>>
>>> (jdk)/src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java
>>>
>>>
>>> Other changes look good to me (haven't looked at the translation
>>> itself).
>>>
>>> Naoto
>>>
>>> On 7/2/13 8:42 PM, Michael Fang wrote:
>>>> Hi all,
>>>>
>>>> Please help to code review the changes for the following CR:
>>>>
>>>> 8019541 : 7u40 l10n resource file translation update
>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019541
>>>>
>>>> The webrev is located at:
>>>> http://cr.openjdk.java.net/~mfang/8019541/
>>>>
>>>> Since we perform resource file translation updates separately for jdk8
>>>> and jdk7u, these changes are specific to jdk7u and not ported back
>>>> from
>>>> jdk8 (but they are mostly the same as jdk8).
>>>>
>>>> thanks,
>>>>
>>>> -michael
>>>
>>
>
More information about the jdk7u-dev
mailing list