[7u40] Request for approval: 8019381: HashMap.isEmpty is non-final, potential issues for get/remove

[Seán Coffey]

thanks for the update Mike. Let's follow up with QA then.

regards,
Sean.

On 12/07/13 05:33, Mike Duigou wrote:
> On Jul 10 2013, at 20:06 , Shi Jun Zhang wrote:
>
>> On 7/11/2013 2:18 AM, Seán Coffey wrote:
>>> Shi Jun Zhang,
>>>
>>> Let me get QA approval for this issue and I'll get back to you shortly. Is this a must fix request for 7u40 ?
>>>
>>> regards,
>>> Sean.
>>>
>>> On 10/07/13 09:34, Shi Jun Zhang wrote:
>>>> Hi,
>>>>
>>>> I'd like to request for approval to push the following change into 7u40.
>>>>
>>>> Changeset in jdk 8
>>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ed111451b77a
>>>>
>>>> webrev for jdk7u
>>>> http://cr.openjdk.java.net/~zhangshj/jdk7u/8019381/webrev.00/
>>>>
>>>> Reviewed by chegar, mduigou
>>>>
>>>> Review thread
>>>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018450.html
>>>>
>>>> There are some differences between webrev for jdk7u and jdk8. The reason is that some change in jdk8 which invokes isEmpty() is only fixed in jdk8 and not back ported to jdk7u. The jtreg test is modified accordingly.
>>>>
>> Hi Sean,
>>
>> It's not a must fix for 7u40, I think it's OK to put it in later release.
> I disagree that it can wait for a later release. We should include this fix in 7u40 if at all possible. It is a serious regression for implementations which extend HashMap.
>
> Mike
>