[7u40] Request for approval: 8014891 (jaxp) : Redundant setting of external access properties in setFeatures

[huizhe wang]

On 5/21/2013 9:42 AM, Seán Coffey wrote:
> Approved.

Thanks!
>
> For reference and as required [1], here's the review thread : 
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-May/017185.html

Thanks for the reference link! I'll remember doing this in the future.

> You've used the "noreg-existing" label. I haven't seen that one before 
> and it's not on the list of documented noreg-* keywords.
>
> That said, I see 31 bugs in JIRA with the same label. We can sort this 
> out offline.

You're right, I thought "existing" made sense :-)  I've changed that to 
noreg-sqe.

Regards,
Joe

>
> regards,
> Sean.
>
> http://openjdk.java.net/projects/jdk7u/approval-template.html
>
> On 21/05/2013 17:24, huizhe wang wrote:
>> JDK8 changeset:
>> http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a7cec93e4682
>>
>> On 5/20/2013 4:16 PM, huizhe wang wrote:
>>> Hi,
>>>
>>> I'd like to backport JDK-8014891 to 7u40, removing redundant setting 
>>> of access properties from the setFeatures method. This is a fix to 
>>> the previous jaxp 1.5 patch. The change is identical to that in JDK8.
>>>
>>> Bug: https://jbs.oracle.com/bugs/browse/JDK-8014891
>>>
>>> webrevs:
>>> http://cr.openjdk.java.net/~joehw/jdk8/8014891/webrev/
>>>
>>>
>>> Thanks,
>>> Joe
>>
>