[jdk7u-dev] Request for approval : 8027860 : [TEST_BUG] File not closed in javax/xml/jaxp/parsers/8022548/XOMParserTest.java

[huizhe wang]

Hi Sean,

Sorry for the confusion. I thought I'd push a 2nd patch to the original 
8024876, so I used the old email thread and copied the webrev to 
http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/. But as you may 
see from Alan's last comment, I needed a new bug id (8027860) for this one.

Thanks for the approval.

Joe

On 11/5/2013 1:04 PM, Seán Coffey wrote:
> Sorry - My fault - 8027680 relates to 8027860 - swap of digits. I need 
> to turn on the lights! You are using the master bug ID.
>
> webrev link is broken but the jdk8 changeset is sufficient :
> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8a044db575c
>
> The review thread refers to the related bug ID : 8024876
> Since it's a direct backport, there's no need for a review of this 
> testcase fix up.
>
> Approved.
>
> regards,
> Sean.
>
>
> On 05/11/13 20:51, Seán Coffey wrote:
>> Joe,
>>
>> the webrev link given is broken. The jdk 8 one is here for reference :
>> http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/
>>
>> In any case 8027860 is already marked resolved for 7u60. I'm not sure 
>> what you're requesting.
>>
>> 8027860 is also a backport ID. Please do not reference backport IDs 
>> (always use the master bug ID)
>> Please re-submit your 7u-dev approval request with corrected 
>> information and subject.
>>
>> regards,
>> Sean.
>>
>> On 05/11/13 20:05, huizhe wang wrote:
>>> Hi,
>>>
>>> I'd like to request for approval to backport 8027860 to 7u-dev/7u60. 
>>> This is a quick fix to make sure files opened in the test are closed 
>>> properly.
>>>
>>> Here's the bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8027860
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~joehw/jdk8/8027860/webrev/
>>>
>>> Link to review thread :
>>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-November/022839.html 
>>>
>>>
>>> The fix was already pushed to jdk8:
>>>
>>> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8a044db575c
>>>
>>>
>>> The code changes in JDK7 are identical as that in JDK8.
>>>
>>> Thanks,
>>> Joe
>>
>