Question on 8024648 : 8016131 breaks Zero port

[Andrew Hughes]

----- Original Message -----
> 
> Please create the patch against this repo:
> 
> http://hg.openjdk.java.net/hsx/jdk7u/hotspot
> 
> see attached for some background about that
> 

Here's the webrev:

http://cr.openjdk.java.net/~andrew/jdk7u/8024648/

My OpenJDK username is andrew (should already be included in the commit)

The changes are as follows:

* Bring in defs.make to a number of makefiles which expect JVM_VARIANT_ZERO
or JVM_VARIANT_ZEROSHARK to be set, but don't parse the makefile that sets
it. This is a regression caused by the new build which instead sets these
via configure and $(SPEC). There is code for handling the old build
(ZERO_BUILD=true) in defs.make but it isn't brought in. (see 7141246)
* Update the call_wrapper function following 8024648.

I've updated the bug summary to reflect that it fixes changes from both
bugs, but we can split them into two separate bugs if you prefer. Without
the 7141246 fix, the build fails in seconds.

With the webrev applied:

$ /mnt/builder/hsx-jdk7u/j2sdk-image/bin/java -version
openjdk version "1.7.0-internal"
OpenJDK Runtime Environment (build 1.7.0-internal-andrew_2014_02_06_19_43-b00)
OpenJDK 64-Bit Zero VM (build 24.80-b01, interpreted mode)

$ /mnt/builder/hsx-jdk7u/j2sdk-image/bin/java HelloWorld
Hello World

> Thanks
> Alejandro
> 
> On 2/6/2014 11:08 AM, Andrew Hughes wrote:
> >
> > ----- Original Message -----
> >> On 17/01/14 21:34, Andrew wrote:
> >>> ----- Original Message -----
> >>>> Omair, Andrew,
> >>>>
> >>>> Are one of you handling this fix for 7u forest ? It's still marked as
> >>>> unresolved.
> >>>>
> >>> We're both pretty snowed under with the security updates at the moment.
> >>>
> >>> I don't think it'd be a matter of just blindly backporting a fix.  I'd
> >>> need
> >>> to make sure Zero builds on 7u60 as changes have no doubt gone in since,
> >>> which have probably broken things further.
> >>>
> >>> What's the forest for u60 at the moment?  Has it forked?  How do I go
> >>> about
> >>> actually getting fixes in?
> >> 7u60 forest should fork on January 22nd :
> >> http://mail.openjdk.java.net/pipermail/jdk7u-dev/2014-January/008272.html
> >>
> >> If you provide the final patch to Alejandro, he can help to get this fix
> >> tested and pushed.
> >>
> > Working on this now. Should have a fix by the end of the week.
> >
> >> regards,
> >> Sean.
> >>>> regards,
> >>>> Sean.
> >>>>
> >>>> On 17/12/2013 17:35, Seán Coffey wrote:
> >>>>> Correct - and in the case of hotspot fixes, you can push them over to
> >>>>> alejandro.murillo at oracle.com
> >>>>>
> >>>>> regards,
> >>>>> Sean.
> >>>>>
> >>>>> On 17/12/2013 17:31, Andrew wrote:
> >>>>>> ----- Original Message -----
> >>>>>>> https://bugs.openjdk.java.net/browse/JDK-8024648
> >>>>>>>
> >>>>>>> Andrew, Omair,
> >>>>>>>
> >>>>>>> I was cleaning up some 7u60 bug records today. Have you got plans to
> >>>>>>> contribute a fix for JDK-8024648 ? It looks like JDK-8022188 would
> >>>>>>> resolve the issue also but neither fix is in the jdk7u-dev codebase
> >>>>>>> yet.
> >>>>>>>
> >>>>>>> regards,
> >>>>>>> Sean.
> >>>>>>>
> >>>>>> I was under the impression that HotSpot fixes were brought in via
> >>>>>> bulk import
> >>>>>> and we weren't allowed to commit individual fixes?
> >>
> 
> --
> Alejandro
> 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07