[7u60] Request for approval: 8019184: MethodHandles.catchException() fails when methods have 8 args + varargs

[Christian Thalinger]

On Feb 12, 2014, at 2:47 PM, Jeff Dinkins <jeff.dinkins at oracle.com> wrote:

> 
> Thank you. Looks good - approved for 7u60.

Thanks.

> 
> BTW, minor nit (and I might be wrong if this was originally put back to 8 last year):
> 
> On the new file, it has:  Copyright (c) 2013
> 
> Perhaps should be 2014?

It was pushed in 2013:

author	twisti
Wed Jul 03 11:35:06 2013 -0700 (7 months ago)

and the file wasn’t touched in 2014 so it’s fine.

> 
> -jeff
> 
> 
> On Feb 12, 2014, at 4:14 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>> On Feb 12, 2014, at 1:06 PM, Jeff Dinkins <jeff.dinkins at oracle.com> wrote:
>> 
>>> 
>>> I might have missed it in the bug, but - where is the review (and who are the review approvers?)
>> 
>> No, you did not miss it; I forgot to paste the link.  Here is the review thread:
>> 
>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-July/010118.html
>> 
>>> 
>>> thanks,
>>> 
>>> -jeff
>>> 
>>> On Feb 12, 2014, at 1:53 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>> 
>>>> This change was intended to end up in 7u40 but for some reason we missed it.  The original bug which went into 8 is:
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8019184
>>>> 
>>>> and the pushed changeset:
>>>> 
>>>> http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bd6949f9dbb2
>>>> 
>>>> This is the new 7u60 backport with approval:
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8034024
>>>> 
>>>> 
>>> 
>> 
>