[7u-dev] Request for approval (8019800 approval) RR(XS): Test sun/tools/jcmd/jcmd-f.sh failing after JDK-8017011
Staffan Larsen
staffan.larsen at oracle.com
Tue Feb 18 05:32:13 PST 2014
On 18 feb 2014, at 14:23, Seán Coffey <sean.coffey at oracle.com> wrote:
>
> On 18/02/2014 13:06, Staffan Larsen wrote:
>> The fix is in the jdk repo, not in hotspot. Is it the repo or the Component in Jira that decides if approvals are needed?
> good point Staffan. Given that the fix is self contained, jdk7u-dev would be fine for push also. Consider it approved for that. Answer to your question would depend on the nature of the fix. i.e. a hotspot fix that requires altering of jdk/test files would all get pushed to hsx forest, otherwise - we have synchronization issues.
Thanks for clarifying.
> Should JDK-8019800 be re-categorized to core-svc -> tools ?
Yes. I’ll do that.
/Staffan
>
> regards,
> Sean.
>
>> /Staffan
>>
>> On 18 feb 2014, at 13:48, Seán Coffey <sean.coffey at oracle.com> wrote:
>>
>>> Results look good Dmitry. Since this is in hotspot category, you can push to the hsx team forest.
>>> You don't need approval on this mailing list. Alejandro will get fix into 7u master via the bulk push request.
>>>
>>> regards,
>>> Sean.
>>>
>>> On 18/02/2014 09:49, Dmitry Samersoff wrote:
>>>> Sean,
>>>>
>>>> OK. Thank you for doing it.
>>>>
>>>> -Dmitry.
>>>>
>>>> On 2014-02-18 13:47, Seán Coffey wrote:
>>>>> Dmitry,
>>>>>
>>>>> I've seen this type of testcase fail alot. I'm going to pull down your
>>>>> patch and run a JPRT job on it. Will get back to you.
>>>>>
>>>>> regards,
>>>>> Sean.
>>>>>
>>>>> On 18/02/2014 09:43, Dmitry Samersoff wrote:
>>>>>> Seán,
>>>>>>
>>>>>> Updated CR with 8-na, updated webrev (in-place, press shift-reload) with
>>>>>> changes to ProblemList.txt
>>>>>>
>>>>>> -Dmitry
>>>>>>
>>>>>>
>>>>>> On 2014-02-18 13:19, Seán Coffey wrote:
>>>>>>> Dmitry,
>>>>>>>
>>>>>>> Is this issue applicable for JDK 8u and JDK 9 ? There's no 8-na label on
>>>>>>> the bug report.
>>>>>>> Also - the testcase is listed in ProblemList.txt and hence doesn't run
>>>>>>> through JPRT.
>>>>>>>
>>>>>>> Are you going to remove it from ProblemList if it's now working ? (i.e.
>>>>>>> all JPRT runs pass)
>>>>>>>
>>>>>>> regards,
>>>>>>> Sean.
>>>>>>>
>>>>>>> On 18/02/2014 07:54, Dmitry Samersoff wrote:
>>>>>>>> Please approve.
>>>>>>>>
>>>>>>>> On 2014-02-14 22:21, Dmitry Samersoff wrote:
>>>>>>>>> Hi Everyone,
>>>>>>>>>
>>>>>>>>> Please review the fix.
>>>>>>>>>
>>>>>>>>> The fix remove a colon (:) from file with reference output.
>>>>>>>>>
>>>>>>>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8019800/webrev.01/
>>>>>>>>>
>>>>>>>>> -Dmitry
>>>>>>>>>
>
More information about the jdk7u-dev
mailing list