[7u60] Request for approval for 8017498: JVM crashes when native code calls sigaction(sig) where sig>=0x20

[Chan, Sunny]

Sorry I don't have an OpenJDK id. This is my first "contributions" to OpenJDK. 

Would I need to work with Alejandro on this?

-----Original Message-----
From: Seán Coffey [mailto:sean.coffey at oracle.com] 
Sent: 15 January 2014 18:56
To: Chan, Sunny [Tech]; Alejandro E Murillo
Cc: 'jdk7u-dev at openjdk.java.net'
Subject: Re: [7u60] Request for approval for 8017498: JVM crashes when native code calls sigaction(sig) where sig>=0x20

Hi Sunny,

all 3 bug fixes have been approved for jdk7u-dev. Please push the changesets to the hotspot team forest. Do you have an OpenJDK id ? 
Alejandro may have to work this one given the hotspot factor.

https://bugs.openjdk.java.net/browse/JDK-8017498
https://bugs.openjdk.java.net/browse/JDK-8020791
https://bugs.openjdk.java.net/browse/JDK-8021296

Regards,
Sean.

On 07/01/14 13:22, Seán Coffey wrote:
> Hi Sunny,
>
> as per the current 7u60 putback process [1], these three bugs need to 
> have the '7u60-critical-request' label added to the master bug record.
> I've just done that now. Once they're marked approved, let's revisit 
> this thread.
>
> Since the fixes are in the hotspot area, the backports should be 
> pushed to the hotspot team integration forest.
> alejandro.murillo at oracle.com can help you with that nearer push time.
>
> regards,
> Sean.
>
> [1]
> http://mail.openjdk.java.net/pipermail/jdk7u-dev/2013-November/008070.
> html
>
> On 02/01/14 02:25, Chan, Sunny wrote:
>> Hi all,
>>
>> This is a request to backport a jdk8 fix into jdk7u60, along with 
>> subsequent changes to the regression tests:
>>
>> 8017498 : JVM crashes when native code calls sigaction(sig) where
>> sig>=0x20
>> https://bugs.openjdk.java.net/browse/JDK-8017498
>>
>> The current jsig implementation is unable to deal with sigaction 
>> request if signumber is > 32. The patch modifies the signal handler 
>> so that signal > 32, which is not used in the JVM, to ignore and 
>> install the handler request directly.
>>
>> This fix is already included in jdk8's hotspot as:
>> http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/732af649bc3a
>>
>> The discussion thread for Java 8 can be found here:
>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-July/
>> 008031.html
>>
>>
>> Notice that current the regression tests that Calvin has provided has 
>> a few issues and this has been fixed in the following subsequent
>> updates:
>>
>> Bug fix 1 (native code failed to compile on some platform, 8020791):
>> http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/72727c4b6dec
>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-July/
>> 008312.html
>>
>>
>> Bug fix 2 (failed to find gcc, 8021296):
>> http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/f9ee986a9fea
>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-July/
>> 008421.html
>>
>>
>> I have verified that if you applied the original bug fix and then 
>> subsequent testbug fix to the JDK 7 branch, it applies cleanly and 
>> resolved the issues.
>>
>> Thanks.
>>
>> Sunny Chan, Executive Director, Technology Goldman Sachs (Asia) 
>> L.L.C. | 68th Floor | Cheung Kong Center | 2 Queens Road Central | 
>> Hong Kong
>> email:  sunny.chan at gs.com | Tel: +852 2978 6481 | Fax: +852 2978 0633
>>
>> This message may contain information that is confidential or 
>> privileged.  If you are not the intended recipient, please advise the 
>> sender immediately and delete this message.  See 
>> http://www.gs.com/disclaimer/email for further information on 
>> confidentiality and the risks inherent in electronic communication.
>>
>