[7u-dev] Request for approval for CR 7160604: Using non-opaque windows - popups are initially not painted correctly

[Anton Litvinov]

Hello Rob,

When I sent this request, both code reviewers Sergey Bylokhov and 
Alexander Scherbatiy were in the recipients of this e-mail. If it is 
considered that changing lambda expression (anonymous method) for 
implementation of Runnable interface in the regression test is a change 
requiring a separate code review, then this separate code review will be 
done.

Anton Litvinov

On 5/22/2014 8:46 PM, Rob McKenna wrote:
> Hi Anton,
>
> Though this particular case seems straightforward enough, the OpenJDK 
> maintainers feel that there is scope for subtle bugs in lambda 
> conversions and would prefer it if you had official reviewer sign-off 
> on the change.
>
> A general rule of thumb: if the code requires changes, it should be 
> re-reviewed.
>
>     -Rob
>
> On 22/05/14 16:27, Anton Litvinov wrote:
>> Hello,
>>
>> I would like to request for approval to push a backport of the fix 
>> from JDK 8 to JDK 7. The backport fix is the same with the original 
>> fix, except for the regression test 
>> "test/javax/swing/JPopupMenu/7160604/bug7160604.java", where the 
>> original lambda expression
>>
>> 50         SwingUtilities.invokeLater(() -> {
>>
>> was changed for
>>
>> 50         SwingUtilities.invokeLater(new Runnable() {
>> 51             @Override
>> 52             public void run() {
>>
>> because JDK 7 does not support lambda expressions.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-7160604
>> Webrev: http://cr.openjdk.java.net/~alitvinov/7160604/jdk7/webrev.00
>> JDK 8 webrev: http://cr.openjdk.java.net/~bagiras/7160604.2
>> JDK 8 review thread:
>>     Approval 1 - 
>> http://mail.openjdk.java.net/pipermail/awt-dev/2013-November/006381.html
>>     Approval 2 - 
>> http://mail.openjdk.java.net/pipermail/awt-dev/2013-November/006396.html
>> Reviewers: serb, alexsch
>>
>> Thank you,
>> Anton
>