From vladimir.kozlov at oracle.com Sat Nov 1 00:19:33 2014 From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com) Date: Sat, 01 Nov 2014 00:19:33 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 8041984: CompilerThread seems to occupy all CPU in a very rare situation Message-ID: <201411010019.sA10JXBV017703@aojmv0008> Changeset: 861532140bbd Author: kvn Date: 2014-10-24 10:28 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/861532140bbd 8041984: CompilerThread seems to occupy all CPU in a very rare situation Summary: Add new timeout checks to EA. Reviewed-by: iveresov, drchase ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp From aleksej.efimov at oracle.com Sat Nov 1 22:19:26 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Sun, 02 Nov 2014 01:19:26 +0300 Subject: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i Message-ID: <54555C6E.80907@oracle.com> Hello, Please, approve a JDK 7u-dev backport of tzdata2014i integration fix. The fix is almost identical to JDK8 with one difference: there is no generic names in JDK7 and changes related to them are not applicable. The JPRT build and all related timezone tests passes, JTREG tests also shows no failure. Thank you, Aleksej JDK7 changes: http://cr.openjdk.java.net/~aefimov/8059206/7/webrev.00 JDK9 chageset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/539a30f006f3 Review thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2014-October/001566.html JBS bug: https://bugs.openjdk.java.net/browse/JDK-8059206 From sean.coffey at oracle.com Mon Nov 3 09:14:23 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 03 Nov 2014 09:14:23 +0000 Subject: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i In-Reply-To: <54555C6E.80907@oracle.com> References: <54555C6E.80907@oracle.com> Message-ID: <5457476F.5050902@oracle.com> Approved pending a peer review of the JDK7u changes. regards, Sean. On 01/11/2014 22:19, Aleksej Efimov wrote: > Hello, > > Please, approve a JDK 7u-dev backport of tzdata2014i integration fix. > The fix is almost identical to JDK8 with one difference: there is no > generic names in JDK7 and changes related to them are not applicable. > The JPRT build and all related timezone tests passes, JTREG tests also > shows no failure. > > Thank you, > Aleksej > > JDK7 changes: http://cr.openjdk.java.net/~aefimov/8059206/7/webrev.00 > JDK9 chageset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/539a30f006f3 > Review thread: > http://mail.openjdk.java.net/pipermail/i18n-dev/2014-October/001566.html > JBS bug: https://bugs.openjdk.java.net/browse/JDK-8059206 From sean.coffey at oracle.com Tue Nov 4 16:51:54 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 04 Nov 2014 16:51:54 +0000 Subject: [7u-dev] Request for approval : 8056026 Debug security logging should print Provider used for each crypto operation Message-ID: <5459042A.6020300@oracle.com> I'd like to backport this enhancement to jdk7u-dev. The fix from jdk8u applies cleanly with the exception of copyright years that had a conflict. webrev : http://t4.ie.oracle.com/home/sean/jdk7u-dev/jdk/webrev.8056026.7u/webrev/ review thread : http://mail.openjdk.java.net/pipermail/security-dev/2014-September/011193.html bug ID : https://bugs.openjdk.java.net/browse/JDK-8056026 regards, Sean. From sean.coffey at oracle.com Tue Nov 4 17:43:52 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 04 Nov 2014 17:43:52 +0000 Subject: [jdk7u-dev] Request for approval : 6458027: Disabling IPv6 on a specific network interface causes problems Message-ID: <54591058.80304@oracle.com> I'd like to backport this to jdk7u. The patch from JDK 8 applies cleanly and I'm currently running tests on the change. bug ID : https://bugs.openjdk.java.net/browse/JDK-6458027 JDK 8 changeset : http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/db0fc2b71298 review thread : http://mail.openjdk.java.net/pipermail/net-dev/2013-September/007300.html regards, Sean. From rob.mckenna at oracle.com Tue Nov 4 17:51:40 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 04 Nov 2014 17:51:40 +0000 Subject: [jdk7u-dev] Request for approval : 6458027: Disabling IPv6 on a specific network interface causes problems In-Reply-To: <54591058.80304@oracle.com> References: <54591058.80304@oracle.com> Message-ID: <5459122C.7020109@oracle.com> Approved. -Rob On 04/11/14 17:43, Se?n Coffey wrote: > I'd like to backport this to jdk7u. The patch from JDK 8 applies > cleanly and I'm currently running tests on the change. > > bug ID : https://bugs.openjdk.java.net/browse/JDK-6458027 > JDK 8 changeset : > http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/db0fc2b71298 > review thread : > http://mail.openjdk.java.net/pipermail/net-dev/2013-September/007300.html > > regards, > Sean. From sean.coffey at oracle.com Tue Nov 4 18:35:07 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 04 Nov 2014 18:35:07 +0000 Subject: [7u-dev] Request for approval : 8056026 Debug security logging should print Provider used for each crypto operation In-Reply-To: <5459042A.6020300@oracle.com> References: <5459042A.6020300@oracle.com> Message-ID: <54591C5B.1070404@oracle.com> With the correct webrev link... http://cr.openjdk.java.net/~coffeys/webrev.8056026.7u/webrev/ regards, Sean. On 04/11/2014 16:51, Se?n Coffey wrote: > I'd like to backport this enhancement to jdk7u-dev. The fix from jdk8u > applies cleanly with the exception of copyright years that had a > conflict. > > webrev : > http://t4.ie.oracle.com/home/sean/jdk7u-dev/jdk/webrev.8056026.7u/webrev/ > review thread : > http://mail.openjdk.java.net/pipermail/security-dev/2014-September/011193.html > bug ID : https://bugs.openjdk.java.net/browse/JDK-8056026 > > regards, > Sean. From rob.mckenna at oracle.com Tue Nov 4 18:40:51 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 04 Nov 2014 18:40:51 +0000 Subject: [7u-dev] Request for approval : 8056026 Debug security logging should print Provider used for each crypto operation In-Reply-To: <54591C5B.1070404@oracle.com> References: <5459042A.6020300@oracle.com> <54591C5B.1070404@oracle.com> Message-ID: <54591DB3.40903@oracle.com> Approved. -Rob On 04/11/14 18:35, Se?n Coffey wrote: > With the correct webrev link... > http://cr.openjdk.java.net/~coffeys/webrev.8056026.7u/webrev/ > > regards, > Sean. > > On 04/11/2014 16:51, Se?n Coffey wrote: >> I'd like to backport this enhancement to jdk7u-dev. The fix from >> jdk8u applies cleanly with the exception of copyright years that had >> a conflict. >> >> webrev : >> http://t4.ie.oracle.com/home/sean/jdk7u-dev/jdk/webrev.8056026.7u/webrev/ >> review thread : >> http://mail.openjdk.java.net/pipermail/security-dev/2014-September/011193.html >> bug ID : https://bugs.openjdk.java.net/browse/JDK-8056026 >> >> regards, >> Sean. > From sean.coffey at oracle.com Tue Nov 4 18:44:30 2014 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 04 Nov 2014 18:44:30 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8056026: Debug security logging should print Provider used for each crypto operation Message-ID: <201411041844.sA4IiUSi000385@aojmv0008> Changeset: 6e2e762deb80 Author: vinnie Date: 2014-11-04 17:11 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6e2e762deb80 8056026: Debug security logging should print Provider used for each crypto operation Reviewed-by: mullan ! src/share/classes/java/security/KeyPairGenerator.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/MessageDigest.java ! src/share/classes/java/security/SecureRandom.java ! src/share/classes/java/security/Signature.java ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/KeyAgreement.java ! src/share/classes/javax/crypto/KeyGenerator.java ! src/share/classes/javax/crypto/Mac.java ! src/share/classes/sun/security/util/Debug.java From aleksej.efimov at oracle.com Tue Nov 4 20:23:50 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Tue, 04 Nov 2014 23:23:50 +0300 Subject: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i In-Reply-To: <5457476F.5050902@oracle.com> References: <54555C6E.80907@oracle.com> <5457476F.5050902@oracle.com> Message-ID: <545935D6.2010100@oracle.com> Hi, Can I ask for the review of this almost-unaltered JDK7 backport? With Best Regards, Aleksej On 03.11.2014 12:14, Se?n Coffey wrote: > Approved pending a peer review of the JDK7u changes. > > regards, > Sean. > > On 01/11/2014 22:19, Aleksej Efimov wrote: >> Hello, >> >> Please, approve a JDK 7u-dev backport of tzdata2014i integration fix. >> The fix is almost identical to JDK8 with one difference: there is no >> generic names in JDK7 and changes related to them are not applicable. >> The JPRT build and all related timezone tests passes, JTREG tests >> also shows no failure. >> >> Thank you, >> Aleksej >> >> JDK7 changes: http://cr.openjdk.java.net/~aefimov/8059206/7/webrev.00 >> JDK9 chageset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/539a30f006f3 >> Review thread: >> http://mail.openjdk.java.net/pipermail/i18n-dev/2014-October/001566.html >> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8059206 > From sean.coffey at oracle.com Tue Nov 4 21:18:51 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 04 Nov 2014 21:18:51 +0000 Subject: [7u-dev] Request for approval: 8082744 jdk.net.Sockets.setOption/getOption does not support IP_TOS Message-ID: <545942BB.1090707@oracle.com> I'd like to backport this fix to jdk7u-dev. The 8u change applies cleanly to jdk7u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8062744 JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/30c2d576a1be Review thread: http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008743.html regards, Sean. From sean.coffey at oracle.com Tue Nov 4 21:20:46 2014 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 04 Nov 2014 21:20:46 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 2 new changesets Message-ID: <201411042120.sA4LKk6c024685@aojmv0008> Changeset: 3d2c4cf5454f Author: msheppar Date: 2013-09-16 14:51 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3d2c4cf5454f 6458027: Disabling IPv6 on a specific network interface causes problems Summary: added a check to test if an interface is configured for IPv6 to native code TwoStacklainDatagramSocketImpl: getMulticastInterface, setMulticastInterface Reviewed-by: chegar, michaelm ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c + test/java/net/MulticastSocket/SetGetNetworkInterfaceTest.java Changeset: 131aaf11f6f4 Author: coffeys Date: 2014-11-04 21:17 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/131aaf11f6f4 Merge From rob.mckenna at oracle.com Tue Nov 4 22:06:57 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 04 Nov 2014 22:06:57 +0000 Subject: [7u-dev] Request for approval: 8082744 jdk.net.Sockets.setOption/getOption does not support IP_TOS In-Reply-To: <545942BB.1090707@oracle.com> References: <545942BB.1090707@oracle.com> Message-ID: <54594E01.6030601@oracle.com> Approved. -Rob On 04/11/14 21:18, Se?n Coffey wrote: > I'd like to backport this fix to jdk7u-dev. The 8u change applies > cleanly to jdk7u-dev. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062744 > JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/30c2d576a1be > Review thread: > http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008743.html > > regards, > Sean. From poonam.bajaj at oracle.com Wed Nov 5 00:43:46 2014 From: poonam.bajaj at oracle.com (Poonam Bajaj) Date: Tue, 04 Nov 2014 16:43:46 -0800 Subject: [7u-dev] Request for approval : JDK-8046275 : Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes Message-ID: <545972C2.1070506@oracle.com> Please approve this backport for jdk7u-dev: JDK-8046275 : Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-November/016131.html 8u changeset: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/ad51f24671c2 Thanks, Poonam From yuka.kamiya at oracle.com Wed Nov 5 02:56:05 2014 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Wed, 05 Nov 2014 11:56:05 +0900 Subject: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i In-Reply-To: <545935D6.2010100@oracle.com> References: <54555C6E.80907@oracle.com> <5457476F.5050902@oracle.com> <545935D6.2010100@oracle.com> Message-ID: <545991C5.1000907@oracle.com> Hi, The fix for 7u looks ok to me. Thanks, -- Yuka On 2014/11/05 5:23, Aleksej Efimov wrote: > Hi, > > Can I ask for the review of this almost-unaltered JDK7 backport? > > With Best Regards, > Aleksej > > On 03.11.2014 12:14, Se?n Coffey wrote: >> Approved pending a peer review of the JDK7u changes. >> >> regards, >> Sean. >> >> On 01/11/2014 22:19, Aleksej Efimov wrote: >>> Hello, >>> >>> Please, approve a JDK 7u-dev backport of tzdata2014i integration >>> fix. The fix is almost identical to JDK8 with one difference: there >>> is no generic names in JDK7 and changes related to them are not >>> applicable. >>> The JPRT build and all related timezone tests passes, JTREG tests >>> also shows no failure. >>> >>> Thank you, >>> Aleksej >>> >>> JDK7 changes: http://cr.openjdk.java.net/~aefimov/8059206/7/webrev.00 >>> JDK9 chageset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/539a30f006f3 >>> Review thread: >>> http://mail.openjdk.java.net/pipermail/i18n-dev/2014-October/001566.html >>> >>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8059206 >> > From sean.coffey at oracle.com Wed Nov 5 08:55:38 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 05 Nov 2014 08:55:38 +0000 Subject: [7u-dev] Request for approval : JDK-8046275 : Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes In-Reply-To: <545972C2.1070506@oracle.com> References: <545972C2.1070506@oracle.com> Message-ID: <5459E60A.7040903@oracle.com> Approved. regards, Sean. On 05/11/2014 00:43, Poonam Bajaj wrote: > Please approve this backport for jdk7u-dev: > > JDK-8046275 : > Fastdebug build failing on jdk9/hs/ control jobs after pulling some > hs-comp changes > Review thread: > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-November/016131.html > 8u changeset: > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/ad51f24671c2 > > Thanks, > Poonam > > From sean.coffey at oracle.com Wed Nov 5 09:01:14 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 05 Nov 2014 09:01:14 +0000 Subject: [7u-dev] Request for approval: 8062744 jdk.net.Sockets.setOption/getOption does not support IP_TOS In-Reply-To: <54594E01.6030601@oracle.com> References: <545942BB.1090707@oracle.com> <54594E01.6030601@oracle.com> Message-ID: <5459E75A.8070308@oracle.com> Thanks Rob - I got the bug ID wrong in the subject field. Correcting that here for records purposes... regards, Sean. On 04/11/2014 22:06, Rob McKenna wrote: > Approved. > > -Rob > > On 04/11/14 21:18, Se?n Coffey wrote: >> I'd like to backport this fix to jdk7u-dev. The 8u change applies >> cleanly to jdk7u-dev. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8062744 >> JDK 9 changeset: >> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/30c2d576a1be >> Review thread: >> http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008743.html >> >> regards, >> Sean. > From sean.coffey at oracle.com Wed Nov 5 09:04:58 2014 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Wed, 05 Nov 2014 09:04:58 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 2 new changesets Message-ID: <201411050904.sA594wtB017333@aojmv0008> Changeset: 2b595d4b5986 Author: michaelm Date: 2014-11-04 17:08 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/2b595d4b5986 8062744: jdk.net.Sockets.setOption/getOption does not support IP_TOS Reviewed-by: chegar, alanb ! src/share/classes/jdk/net/Sockets.java + test/jdk/net/Sockets/SupportedOptions.java Changeset: b93731db7aae Author: coffeys Date: 2014-11-05 09:01 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b93731db7aae Merge From aleksej.efimov at oracle.com Wed Nov 5 10:02:54 2014 From: aleksej.efimov at oracle.com (aleksej.efimov at oracle.com) Date: Wed, 05 Nov 2014 10:02:54 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8059206: (tz) Support tzdata2014i Message-ID: <201411051002.sA5A2sTq028187@aojmv0008> Changeset: 3796111298d5 Author: aefimov Date: 2014-11-05 13:01 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3796111298d5 8059206: (tz) Support tzdata2014i Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java From aleksej.efimov at oracle.com Wed Nov 5 10:13:52 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Wed, 05 Nov 2014 13:13:52 +0300 Subject: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i In-Reply-To: <545991C5.1000907@oracle.com> References: <54555C6E.80907@oracle.com> <5457476F.5050902@oracle.com> <545935D6.2010100@oracle.com> <545991C5.1000907@oracle.com> Message-ID: <5459F860.1050507@oracle.com> Yuka, Thank you for reviewing this fix. Best Regards, Aleksej On 11/05/2014 05:56 AM, Yuka Kamiya wrote: > Hi, > > The fix for 7u looks ok to me. > > Thanks, > -- > Yuka > > On 2014/11/05 5:23, Aleksej Efimov wrote: >> Hi, >> >> Can I ask for the review of this almost-unaltered JDK7 backport? >> >> With Best Regards, >> Aleksej >> >> On 03.11.2014 12:14, Se?n Coffey wrote: >>> Approved pending a peer review of the JDK7u changes. >>> >>> regards, >>> Sean. >>> >>> On 01/11/2014 22:19, Aleksej Efimov wrote: >>>> Hello, >>>> >>>> Please, approve a JDK 7u-dev backport of tzdata2014i integration >>>> fix. The fix is almost identical to JDK8 with one difference: there >>>> is no generic names in JDK7 and changes related to them are not >>>> applicable. >>>> The JPRT build and all related timezone tests passes, JTREG tests >>>> also shows no failure. >>>> >>>> Thank you, >>>> Aleksej >>>> >>>> JDK7 changes: http://cr.openjdk.java.net/~aefimov/8059206/7/webrev.00 >>>> JDK9 chageset: >>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/539a30f006f3 >>>> Review thread: >>>> http://mail.openjdk.java.net/pipermail/i18n-dev/2014-October/001566.html >>>> >>>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8059206 >>> >> > From mikhail.cherkasov at oracle.com Wed Nov 5 12:10:36 2014 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Wed, 05 Nov 2014 15:10:36 +0300 Subject: [7u-dev] Request for approval: JDK-8041987 [macosx] setDisplayMode crashes Message-ID: <545A13BC.3030001@oracle.com> Hello all, This is a request for approval to backport a fix to the JDK7u-dev repository. The bug:https://bugs.openjdk.java.net/browse/JDK-8041987 webrev: http://cr.openjdk.java.net/~mcherkas/8041987/webrev.01/ review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2014-April/007624.html changeset: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/3145e119d375 Thanks, Mikhail. From rob.mckenna at oracle.com Wed Nov 5 13:04:49 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 05 Nov 2014 13:04:49 +0000 Subject: [7u-dev] Request for approval: JDK-8041987 [macosx] setDisplayMode crashes In-Reply-To: <545A13BC.3030001@oracle.com> References: <545A13BC.3030001@oracle.com> Message-ID: <545A2071.6030802@oracle.com> Approved. -Rob On 05/11/14 12:10, mikhail cherkasov wrote: > Hello all, > > This is a request for approval to backport a fix to the JDK7u-dev > repository. > > The bug:https://bugs.openjdk.java.net/browse/JDK-8041987 > webrev: http://cr.openjdk.java.net/~mcherkas/8041987/webrev.01/ > review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2014-April/007624.html > changeset: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/3145e119d375 > > Thanks, > Mikhail. > > > From poonam.bajaj at oracle.com Wed Nov 5 18:48:03 2014 From: poonam.bajaj at oracle.com (poonam.bajaj at oracle.com) Date: Wed, 05 Nov 2014 18:48:03 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 8046275: Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes Message-ID: <201411051848.sA5Im3e6002416@aojmv0008> Changeset: 9d2b485d2a58 Author: poonam Date: 2014-11-05 06:13 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/9d2b485d2a58 8046275: Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes Summary: Add missing check for Opaque nodes from loop predicates in clone_loop(). Reviewed-by: kvn ! src/share/vm/opto/loopopts.cpp From vladimir.kozlov at oracle.com Thu Nov 6 01:43:59 2014 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 05 Nov 2014 17:43:59 -0800 Subject: [7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with Message-ID: <545AD25F.2020000@oracle.com> Backport to 7u request. Changes were pushed into jdk9 few months ago and 8u 2 months ago. Nightly testing is fine. Changes are applied cleanly to 7u sources. The problem in 7u80 is caused by recent backport of JDK-8030976 changes [1]. https://bugs.openjdk.java.net/browse/JDK-8058107 http://cr.openjdk.java.net/~rbackman/8046289.3/ Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-June/014889.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/6ad207fd3e26 jdk8u changeset: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/f6f9aec27858 Thanks, Vladimir [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/33878f8ae419 From vladimir.kozlov at oracle.com Thu Nov 6 01:48:54 2014 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Wed, 05 Nov 2014 17:48:54 -0800 Subject: Resend: [7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with In-Reply-To: <545AD25F.2020000@oracle.com> References: <545AD25F.2020000@oracle.com> Message-ID: <545AD386.5000903@oracle.com> Please, ignore previous mail. I messed up links. Backport to 7u request. Changes were pushed into jdk9 few months ago and 8u 2 months ago. Nightly testing is fine. Changes are applied cleanly to 7u sources. The problem in 7u80 is caused by recent backport of JDK-8030976 changes [1]. https://bugs.openjdk.java.net/browse/JDK-8046289 http://cr.openjdk.java.net/~rbackman/8046289.3/ Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-June/014889.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/08250e173426 jdk8u changeset: http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/42460b71ba70 Thanks, Vladimir [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/33878f8ae419 From sean.coffey at oracle.com Thu Nov 6 09:15:49 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 06 Nov 2014 09:15:49 +0000 Subject: Resend: [7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with In-Reply-To: <545AD386.5000903@oracle.com> References: <545AD25F.2020000@oracle.com> <545AD386.5000903@oracle.com> Message-ID: <545B3C45.1090601@oracle.com> You might want to add a noreg- label to the bug report. The testbug label should be removed also since this affects product code. Approved. regards, Sean. On 06/11/2014 01:48, Vladimir Kozlov wrote: > Please, ignore previous mail. I messed up links. > > Backport to 7u request. Changes were pushed into jdk9 few months ago > and 8u 2 months ago. Nightly testing is fine. Changes are applied > cleanly to 7u sources. > > The problem in 7u80 is caused by recent backport of JDK-8030976 > changes [1]. > > https://bugs.openjdk.java.net/browse/JDK-8046289 > > http://cr.openjdk.java.net/~rbackman/8046289.3/ > > Review thread: > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-June/014889.html > > > jdk9 changeset: > http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/08250e173426 > > jdk8u changeset: > http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/42460b71ba70 > > Thanks, > Vladimir > > [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/33878f8ae419 From david.buck at oracle.com Thu Nov 6 12:44:14 2014 From: david.buck at oracle.com (david buck) Date: Thu, 06 Nov 2014 21:44:14 +0900 Subject: [7u-dev] Request for approval: Message-ID: <545B6D1E.9000505@oracle.com> Hi! Please approve my backport from JDK8 to JDK7 of this very safe and simple change: Bug Report: https://bugs.openjdk.java.net/browse/JDK-8058715 JDK8 change: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/ef6b27d844cc JDK8 fix applies cleanly to JDK7 source. Cheers, -Buck From david.buck at oracle.com Thu Nov 6 12:46:17 2014 From: david.buck at oracle.com (david buck) Date: Thu, 06 Nov 2014 21:46:17 +0900 Subject: [7u-dev] Request for approval: 8058715: stability issues when being launched as an embedded JVM via JNI In-Reply-To: <545B6D1E.9000505@oracle.com> References: <545B6D1E.9000505@oracle.com> Message-ID: <545B6D99.5060003@oracle.com> Resending with correct subject line. Sorry. On 2014/11/06 21:44, david buck wrote: > Hi! > > Please approve my backport from JDK8 to JDK7 of this very safe and > simple change: > > Bug Report: > https://bugs.openjdk.java.net/browse/JDK-8058715 > > JDK8 change: > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/ef6b27d844cc > > JDK8 fix applies cleanly to JDK7 source. > > Cheers, > -Buck From sean.coffey at oracle.com Thu Nov 6 12:52:51 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 06 Nov 2014 12:52:51 +0000 Subject: [7u-dev] Request for approval: 8058715: stability issues when being launched as an embedded JVM via JNI In-Reply-To: <545B6D99.5060003@oracle.com> References: <545B6D1E.9000505@oracle.com> <545B6D99.5060003@oracle.com> Message-ID: <545B6F23.80000@oracle.com> I thought it was another case of colleague attacks/hugs! [1] Review thread : http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013056.html Approved. regards, Sean. [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2014-November/002370.html On 06/11/2014 12:46, david buck wrote: > Resending with correct subject line. Sorry. > > On 2014/11/06 21:44, david buck wrote: >> Hi! >> >> Please approve my backport from JDK8 to JDK7 of this very safe and >> simple change: >> >> Bug Report: >> https://bugs.openjdk.java.net/browse/JDK-8058715 >> >> JDK8 change: >> http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/ef6b27d844cc >> >> JDK8 fix applies cleanly to JDK7 source. >> >> Cheers, >> -Buck From david.buck at oracle.com Thu Nov 6 12:57:54 2014 From: david.buck at oracle.com (david.buck at oracle.com) Date: Thu, 06 Nov 2014 12:57:54 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 8058715: stability issues when being launched as an embedded JVM via JNI Message-ID: <201411061257.sA6CvsXt017251@aojmv0008> Changeset: 4800ce2a2849 Author: dbuck Date: 2014-11-06 04:57 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/4800ce2a2849 8058715: stability issues when being launched as an embedded JVM via JNI Summary: Use mmap call without MAP_FIXED so we avoid corrupting already allocated memory Reviewed-by: coleenp, dsimms ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp From david.buck at oracle.com Thu Nov 6 13:01:07 2014 From: david.buck at oracle.com (david buck) Date: Thu, 06 Nov 2014 22:01:07 +0900 Subject: [7u-dev] Request for approval: 8058715: stability issues when being launched as an embedded JVM via JNI In-Reply-To: <545B6F23.80000@oracle.com> References: <545B6D1E.9000505@oracle.com> <545B6D99.5060003@oracle.com> <545B6F23.80000@oracle.com> Message-ID: <545B7113.10802@oracle.com> Hi Sean! Thank you for the approval. (Un)fortunately no, I am not a risk of hug attacks today. I forgot to mention that I also updated the copyright year for this file by hand before pushing. Cheers, -Buck On 2014/11/06 21:52, Se?n Coffey wrote: > I thought it was another case of colleague attacks/hugs! [1] > Review thread : > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013056.html > > > Approved. > > regards, > Sean. > > [1] > http://mail.openjdk.java.net/pipermail/jdk8u-dev/2014-November/002370.html > > On 06/11/2014 12:46, david buck wrote: >> Resending with correct subject line. Sorry. >> >> On 2014/11/06 21:44, david buck wrote: >>> Hi! >>> >>> Please approve my backport from JDK8 to JDK7 of this very safe and >>> simple change: >>> >>> Bug Report: >>> https://bugs.openjdk.java.net/browse/JDK-8058715 >>> >>> JDK8 change: >>> http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/ef6b27d844cc >>> >>> JDK8 fix applies cleanly to JDK7 source. >>> >>> Cheers, >>> -Buck > From andreas.eriksson at oracle.com Thu Nov 6 13:37:01 2014 From: andreas.eriksson at oracle.com (Andreas Eriksson) Date: Thu, 06 Nov 2014 14:37:01 +0100 Subject: RFR: JDK7 backport of 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error Message-ID: <545B797D.70907@oracle.com> Hi, Could someone please review this jdk7 backport of JDK-8020675 please. Summary: invalid jar file in the bootclasspath could lead to jvm fatal error removed offending EXCEPTION_MARK calls and code cleanup One code change necessary for the backport was in method ClassLoader::load_classfile. The change was to use CHECK_(instanceKlassHandle()) instead of CHECK_NULL. See the mail thread at http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-November/015825.html for more information. Also, I'm not sure how to update the copyright years. In the jdk8 changeset they are updated from 2012 to 2013. In this backport, should I update the JDK7 copyright years from 2011 to 2013, or to 2014 or just leave them at 2011? Webrev: http://cr.openjdk.java.net/~aeriksso/8020675/webrev.00/ Regards, Andreas From vladimir.kempik at oracle.com Thu Nov 6 14:29:34 2014 From: vladimir.kempik at oracle.com (Vladimir Kempik) Date: Thu, 06 Nov 2014 17:29:34 +0300 Subject: [7u-dev] Request for approval: 8059216: Make PrintGCApplicationStoppedTime print information about stopping threads Message-ID: <545B85CE.40502@oracle.com> Hello, please approve this backport of the fix to jdk7u-dev. The bug: https://bugs.openjdk.java.net/browse/JDK-8059216 The review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-October/012770.html The jdk8u changeset: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/6f06ebb09080 The jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/200f943f2264 Thanks, Vladimir From vladimir.kempik at oracle.com Thu Nov 6 14:30:27 2014 From: vladimir.kempik at oracle.com (Vladimir Kempik) Date: Thu, 06 Nov 2014 17:30:27 +0300 Subject: [7u-dev] Request for approval: 8059216: Make PrintGCApplicationStoppedTime print information about stopping threads In-Reply-To: <545B85CE.40502@oracle.com> References: <545B85CE.40502@oracle.com> Message-ID: <545B8603.2080701@oracle.com> The webrev - http://cr.openjdk.java.net/~vkempik/8059216/jdk7/8059216/webrev.00/ On 06.11.2014 17:29, Vladimir Kempik wrote: > Hello, > > please approve this backport of the fix to jdk7u-dev. > > The bug: > https://bugs.openjdk.java.net/browse/JDK-8059216 > The review thread: > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-October/012770.html > > > The jdk8u changeset: > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/6f06ebb09080 > The jdk9 changeset: > http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/200f943f2264 > > > Thanks, > Vladimir > From sean.coffey at oracle.com Thu Nov 6 14:32:55 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 06 Nov 2014 14:32:55 +0000 Subject: [7u-dev] Request for approval: 8059216: Make PrintGCApplicationStoppedTime print information about stopping threads In-Reply-To: <545B8603.2080701@oracle.com> References: <545B85CE.40502@oracle.com> <545B8603.2080701@oracle.com> Message-ID: <545B8697.3030702@oracle.com> Master bug needs a noreg- label. Approved. regards, Sean. On 06/11/2014 14:30, Vladimir Kempik wrote: > The webrev - > http://cr.openjdk.java.net/~vkempik/8059216/jdk7/8059216/webrev.00/ > On 06.11.2014 17:29, Vladimir Kempik wrote: >> Hello, >> >> please approve this backport of the fix to jdk7u-dev. >> >> The bug: >> https://bugs.openjdk.java.net/browse/JDK-8059216 >> The review thread: >> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-October/012770.html >> >> >> The jdk8u changeset: >> http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/6f06ebb09080 >> The jdk9 changeset: >> http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/200f943f2264 >> >> >> Thanks, >> Vladimir >> > From daniel.daugherty at oracle.com Thu Nov 6 14:54:27 2014 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 06 Nov 2014 07:54:27 -0700 Subject: RFR: JDK7 backport of 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error In-Reply-To: <545B797D.70907@oracle.com> References: <545B797D.70907@oracle.com> Message-ID: <545B8BA3.5020804@oracle.com> On 11/6/14 6:37 AM, Andreas Eriksson wrote: > Hi, > > Could someone please review this jdk7 backport of JDK-8020675 > please. > Summary: > invalid jar file in the bootclasspath could lead to jvm fatal error > removed offending EXCEPTION_MARK calls and code cleanup > > One code change necessary for the backport was in method > ClassLoader::load_classfile. > The change was to use CHECK_(instanceKlassHandle()) instead of > CHECK_NULL. > See the mail thread at > http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-November/015825.html > for more information. > > Also, I'm not sure how to update the copyright years. > In the jdk8 changeset they are updated from 2012 to 2013. > In this backport, should I update the JDK7 copyright years from 2011 > to 2013, or to 2014 or just leave them at 2011? The original change was made in 2013 so that's the copyright year that should "follow" the code... Dan > > Webrev: http://cr.openjdk.java.net/~aeriksso/8020675/webrev.00/ > > Regards, > Andreas > > > From vladimir.kempik at oracle.com Thu Nov 6 16:12:27 2014 From: vladimir.kempik at oracle.com (vladimir.kempik at oracle.com) Date: Thu, 06 Nov 2014 16:12:27 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 8059216: Make PrintGCApplicationStoppedTime print information about stopping threads Message-ID: <201411061612.sA6GCSw4025440@aojmv0008> Changeset: 94f796f95cbc Author: vkempik Date: 2014-10-28 18:41 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/94f796f95cbc 8059216: Make PrintGCApplicationStoppedTime print information about stopping threads Reviewed-by: dholmes, brutisso ! src/share/vm/services/runtimeService.cpp ! src/share/vm/services/runtimeService.hpp From mikhail.cherkasov at oracle.com Thu Nov 6 18:55:20 2014 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Thu, 06 Nov 2014 21:55:20 +0300 Subject: [7u-dev] Request for approval: 8062021: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 Message-ID: <545BC418.30306@oracle.com> Hi there, I would like to backport this fix from jdk8: bug: https://bugs.openjdk.java.net/browse/JDK-8062021 review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2014-October/008617.html jdk8 changeset: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/df79e4dd6a2b Thanks, Mikhail. From sean.coffey at oracle.com Thu Nov 6 18:57:03 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 06 Nov 2014 18:57:03 +0000 Subject: [7u-dev] Request for approval: 8062021: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 In-Reply-To: <545BC418.30306@oracle.com> References: <545BC418.30306@oracle.com> Message-ID: <545BC47F.8070709@oracle.com> Approved. regards, Sean. On 06/11/2014 18:55, mikhail cherkasov wrote: > Hi there, > > I would like to backport this fix from jdk8: > > bug: https://bugs.openjdk.java.net/browse/JDK-8062021 > review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2014-October/008617.html > jdk8 changeset: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/df79e4dd6a2b > > Thanks, > Mikhail. From vladimir.kozlov at oracle.com Fri Nov 7 01:48:30 2014 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 06 Nov 2014 17:48:30 -0800 Subject: Resend: [7u-dev] Request for approval for 8046289: compiler/6340864/TestLongVect.java timeout with In-Reply-To: <545B3C45.1090601@oracle.com> References: <545AD25F.2020000@oracle.com> <545AD386.5000903@oracle.com> <545B3C45.1090601@oracle.com> Message-ID: <545C24EE.4090203@oracle.com> Thank you, Sean On 11/6/14 1:15 AM, Se?n Coffey wrote: > You might want to add a noreg- label to the bug report. The testbug > label should be removed also since this affects product code. I replaced testbug with noreg-sqe since we have the test. > > Approved. Thanks, Vladimir > > regards, > Sean. > > On 06/11/2014 01:48, Vladimir Kozlov wrote: >> Please, ignore previous mail. I messed up links. >> >> Backport to 7u request. Changes were pushed into jdk9 few months ago >> and 8u 2 months ago. Nightly testing is fine. Changes are applied >> cleanly to 7u sources. >> >> The problem in 7u80 is caused by recent backport of JDK-8030976 >> changes [1]. >> >> https://bugs.openjdk.java.net/browse/JDK-8046289 >> >> http://cr.openjdk.java.net/~rbackman/8046289.3/ >> >> Review thread: >> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-June/014889.html >> >> >> jdk9 changeset: >> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/08250e173426 >> >> jdk8u changeset: >> http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/42460b71ba70 >> >> Thanks, >> Vladimir >> >> [1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/33878f8ae419 > From vladimir.kozlov at oracle.com Fri Nov 7 03:29:44 2014 From: vladimir.kozlov at oracle.com (vladimir.kozlov at oracle.com) Date: Fri, 07 Nov 2014 03:29:44 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 8046289: compiler/6340864/TestLongVect.java timeout with Message-ID: <201411070329.sA73Ti0m001721@aojmv0008> Changeset: 3ae4d3bcedb8 Author: rbackman Date: 2014-06-23 13:33 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/3ae4d3bcedb8 8046289: compiler/6340864/TestLongVect.java timeout with Reviewed-by: iveresov, vlivanov ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse2.cpp From david.buck at oracle.com Fri Nov 7 10:37:58 2014 From: david.buck at oracle.com (david buck) Date: Fri, 07 Nov 2014 19:37:58 +0900 Subject: [7u-dev] request for approval: 8062608: BCEL corrupts debug data of methods that use generics Message-ID: <545CA106.2000703@oracle.com> Hi! Please approve this backport from jdk8 to jdk7u-dev bug url: https://bugs.openjdk.java.net/browse/JDK-8062608 JDK8 changeset: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/02d2df45bda8 review thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029540.html Changes apply cleanly. Builds and passes testcase from the bug report. Cheers, -Buck From sean.coffey at oracle.com Fri Nov 7 10:47:59 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 07 Nov 2014 10:47:59 +0000 Subject: [7u-dev] request for approval: 8062608: BCEL corrupts debug data of methods that use generics In-Reply-To: <545CA106.2000703@oracle.com> References: <545CA106.2000703@oracle.com> Message-ID: <545CA35F.1000606@oracle.com> Approved. regards, Sean. On 07/11/14 10:37, david buck wrote: > Hi! > > Please approve this backport from jdk8 to jdk7u-dev > > bug url: https://bugs.openjdk.java.net/browse/JDK-8062608 > JDK8 changeset: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/02d2df45bda8 > review thread : > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029540.html > > > Changes apply cleanly. Builds and passes testcase from the bug report. > > Cheers, > -Buck From david.buck at oracle.com Fri Nov 7 10:50:25 2014 From: david.buck at oracle.com (david.buck at oracle.com) Date: Fri, 07 Nov 2014 10:50:25 +0000 Subject: hg: jdk7u/jdk7u-dev/jaxp: 8062608: BCEL corrupts debug data of methods that use generics Message-ID: <201411071050.sA7AoPUB012943@aojmv0008> Changeset: 3779d11092de Author: dbuck Date: 2014-11-07 01:18 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/3779d11092de 8062608: BCEL corrupts debug data of methods that use generics Summary: Fixed MethodGen constructor to not overwrite LocalVariableTable. Reviewed-by: joehw ! src/com/sun/org/apache/bcel/internal/generic/MethodGen.java From anton.litvinov at oracle.com Fri Nov 7 13:52:09 2014 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Fri, 07 Nov 2014 16:52:09 +0300 Subject: Request for approval for CR 8061954: 7u76 - deployment warning dialogs do not work on Linux Message-ID: <545CCE89.70206@oracle.com> Hello, I would like to request for approval to push the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8061954 Webrev: http://cr.openjdk.java.net/~alitvinov/8061954/webrev.00 Review thread: Approval 1 - http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008662.html Approval 2 - http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008665.html Reviewers: ant, serb Thank you, Anton From anton.litvinov at oracle.com Fri Nov 7 13:56:53 2014 From: anton.litvinov at oracle.com (Anton Litvinov) Date: Fri, 07 Nov 2014 16:56:53 +0300 Subject: [7u-dev] Request for approval for CR 8061954: 7u76 - deployment warning dialogs do not work on Linux Message-ID: <545CCFA5.2020901@oracle.com> Hello, I would like to request for approval to push the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8061954 Webrev: http://cr.openjdk.java.net/~alitvinov/8061954/webrev.00 Review thread: Approval 1 - http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008662.html Approval 2 - http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008665.html Reviewers: ant, serb Thank you, Anton From rob.mckenna at oracle.com Fri Nov 7 14:05:36 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 07 Nov 2014 14:05:36 +0000 Subject: Request for approval for CR 8061954: 7u76 - deployment warning dialogs do not work on Linux In-Reply-To: <545CCE89.70206@oracle.com> References: <545CCE89.70206@oracle.com> Message-ID: <545CD1B0.6090907@oracle.com> Approved. -Rob On 07/11/14 13:52, Anton Litvinov wrote: > Hello, > > I would like to request for approval to push the following fix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8061954 > Webrev: http://cr.openjdk.java.net/~alitvinov/8061954/webrev.00 > Review thread: > Approval 1 - > http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008662.html > Approval 2 - > http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008665.html > Reviewers: ant, serb > > Thank you, > Anton From rob.mckenna at oracle.com Fri Nov 7 14:06:06 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 07 Nov 2014 14:06:06 +0000 Subject: [7u-dev] Request for approval for CR 8061954: 7u76 - deployment warning dialogs do not work on Linux In-Reply-To: <545CCFA5.2020901@oracle.com> References: <545CCFA5.2020901@oracle.com> Message-ID: <545CD1CE.7070304@oracle.com> Hadn't noticed the missing version. Thanks Anton. Approved. -Rob On 07/11/14 13:56, Anton Litvinov wrote: > Hello, > > I would like to request for approval to push the following fix. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8061954 > Webrev: http://cr.openjdk.java.net/~alitvinov/8061954/webrev.00 > Review thread: > Approval 1 - > http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008662.html > Approval 2 - > http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008665.html > Reviewers: ant, serb > > Thank you, > Anton From anton.litvinov at oracle.com Fri Nov 7 14:14:54 2014 From: anton.litvinov at oracle.com (anton.litvinov at oracle.com) Date: Fri, 07 Nov 2014 14:14:54 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8061954: 7u76 - deployment warning dialogs do not work on Linux Message-ID: <201411071414.sA7EEsW7015447@aojmv0008> Changeset: dfee4e9b2372 Author: alitvinov Date: 2014-11-07 17:13 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/dfee4e9b2372 8061954: 7u76 - deployment warning dialogs do not work on Linux Reviewed-by: ant, serb ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XContentWindow.java + test/java/awt/Focus/NPEInKFMOnButtonClickInDialogTest/NPEInKFMOnButtonClickInDialogTest.java From mikhail.cherkasov at oracle.com Fri Nov 7 15:25:42 2014 From: mikhail.cherkasov at oracle.com (mikhail.cherkasov at oracle.com) Date: Fri, 07 Nov 2014 15:25:42 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8062021: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 Message-ID: <201411071525.sA7FPgtC000411@aojmv0008> Changeset: b68414df3c3f Author: mcherkas Date: 2014-11-06 21:52 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b68414df3c3f 8062021: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 Reviewed-by: ant, serb ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java + test/java/awt/Frame/DisposeStressTest/DisposeStressTest.html + test/java/awt/Frame/DisposeStressTest/DisposeStressTest.java From andreas.eriksson at oracle.com Mon Nov 10 13:04:53 2014 From: andreas.eriksson at oracle.com (Andreas Eriksson) Date: Mon, 10 Nov 2014 14:04:53 +0100 Subject: [7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error Message-ID: <5460B7F5.50009@oracle.com> Hi, I'd like approval for backporting JDK-8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error. Backport reviewed by Calvin Cheung. Webrev: http://cr.openjdk.java.net/~aeriksso/8020675/webrev.01/ Review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013094.html JDK8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/7e7dd25666da#l1.157 Regards, Andreas From sean.coffey at oracle.com Mon Nov 10 13:38:46 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 10 Nov 2014 13:38:46 +0000 Subject: [7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error In-Reply-To: <5460B7F5.50009@oracle.com> References: <5460B7F5.50009@oracle.com> Message-ID: <5460BFE6.3090308@oracle.com> Approved. I'm assuming this patch applies cleanly. If not, please obtain a peer review before pushing. regards, Sean. On 10/11/14 13:04, Andreas Eriksson wrote: > Hi, > > I'd like approval for backporting JDK-8020675 > - invalid jar file > in the bootclasspath could lead to jvm fatal error. > Backport reviewed by Calvin Cheung. > > Webrev: http://cr.openjdk.java.net/~aeriksso/8020675/webrev.01/ > Review thread: > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013094.html > JDK8 changeset: > http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/7e7dd25666da#l1.157 > > Regards, > Andreas From andreas.eriksson at oracle.com Mon Nov 10 13:41:25 2014 From: andreas.eriksson at oracle.com (Andreas Eriksson) Date: Mon, 10 Nov 2014 14:41:25 +0100 Subject: [7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error In-Reply-To: <5460BFE6.3090308@oracle.com> References: <5460B7F5.50009@oracle.com> <5460BFE6.3090308@oracle.com> Message-ID: <5460C085.8050507@oracle.com> As I mentioned in the mail, the backport has been reviewed by Calvin Cheung, is that not enough? - Andreas On 2014-11-10 14:38, Se?n Coffey wrote: > Approved. I'm assuming this patch applies cleanly. If not, please > obtain a peer review before pushing. > > regards, > Sean. > > On 10/11/14 13:04, Andreas Eriksson wrote: >> Hi, >> >> I'd like approval for backporting JDK-8020675 >> - invalid jar file >> in the bootclasspath could lead to jvm fatal error. >> Backport reviewed by Calvin Cheung. >> >> Webrev: http://cr.openjdk.java.net/~aeriksso/8020675/webrev.01/ >> Review thread: >> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013094.html >> JDK8 changeset: >> http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/7e7dd25666da#l1.157 >> >> Regards, >> Andreas > From sean.coffey at oracle.com Mon Nov 10 13:42:54 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 10 Nov 2014 13:42:54 +0000 Subject: [7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error In-Reply-To: <5460C085.8050507@oracle.com> References: <5460B7F5.50009@oracle.com> <5460BFE6.3090308@oracle.com> <5460C085.8050507@oracle.com> Message-ID: <5460C0DE.8050308@oracle.com> Missed that. Apologies. I thought the links referred to the JDK 8 review. You're good to push then. regards, Sean. On 10/11/14 13:41, Andreas Eriksson wrote: > As I mentioned in the mail, the backport has been reviewed by Calvin > Cheung, is that not enough? > > - Andreas > > On 2014-11-10 14:38, Se?n Coffey wrote: >> Approved. I'm assuming this patch applies cleanly. If not, please >> obtain a peer review before pushing. >> >> regards, >> Sean. >> >> On 10/11/14 13:04, Andreas Eriksson wrote: >>> Hi, >>> >>> I'd like approval for backporting JDK-8020675 >>> - invalid jar >>> file in the bootclasspath could lead to jvm fatal error. >>> Backport reviewed by Calvin Cheung. >>> >>> Webrev: http://cr.openjdk.java.net/~aeriksso/8020675/webrev.01/ >>> Review thread: >>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013094.html >>> JDK8 changeset: >>> http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/7e7dd25666da#l1.157 >>> >>> Regards, >>> Andreas >> > From lana.steuck at oracle.com Mon Nov 10 17:56:49 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 10 Nov 2014 17:56:49 +0000 Subject: hg: jdk7u/jdk7u/hotspot: 6 new changesets Message-ID: <201411101756.sAAHuopN018122@aojmv0008> Changeset: 8209313924a6 Author: kevinw Date: 2014-10-17 12:34 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/8209313924a6 8058927: ATG throws ClassNotFoundException Reviewed-by: coleenp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp + test/runtime/LoadClass/ShowClassLoader.java Changeset: 21a476d3a51c Author: kvn Date: 2014-10-02 11:36 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/21a476d3a51c 8059299: assert(adr_type != NULL) failed: expecting TypeKlassPtr Summary: Use top() for dead paths when initializing Phi node of exceptions klasses in Parse::catch_inline_exceptions(). Reviewed-by: jrose, vlivanov ! src/share/vm/opto/doCall.cpp + test/compiler/exceptions/CatchInlineExceptions.java Changeset: 33878f8ae419 Author: sgabdura Date: 2014-10-23 10:53 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/33878f8ae419 8030976: Untaken paths should be more vigorously pruned at highest optimization level Reviewed-by: kvn, rbackman, roland, vlivanov ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 82ee04e1f525 Author: dbuck Date: 2014-10-31 14:40 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/82ee04e1f525 8060169: Update the Crash Reporting URL in the Java crash log Summary: Update the URL for HotSpot bug reports. Reviewed-by: dcubed, rdurbin ! src/share/vm/runtime/arguments.cpp Changeset: 861532140bbd Author: kvn Date: 2014-10-24 10:28 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/861532140bbd 8041984: CompilerThread seems to occupy all CPU in a very rare situation Summary: Add new timeout checks to EA. Reviewed-by: iveresov, drchase ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: 9d2b485d2a58 Author: poonam Date: 2014-11-05 06:13 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/9d2b485d2a58 8046275: Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes Summary: Add missing check for Opaque nodes from loop predicates in clone_loop(). Reviewed-by: kvn ! src/share/vm/opto/loopopts.cpp From lana.steuck at oracle.com Mon Nov 10 17:56:57 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 10 Nov 2014 17:56:57 +0000 Subject: hg: jdk7u/jdk7u/jdk: 13 new changesets Message-ID: <201411101756.sAAHuvxW018324@aojmv0008> Changeset: 2557d9bd981c Author: dmarkov Date: 2014-10-23 11:00 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/2557d9bd981c 7033533: realSync() doesn't work with Xfce Reviewed-by: anthony, serb, leonidr ! src/solaris/classes/sun/awt/X11/XRootWindow.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: 4a63bc29ab49 Author: dmarkov Date: 2014-10-23 11:03 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/4a63bc29ab49 8051857: OperationTimedOut exception inside from XToolkit.syncNativeQueue call Reviewed-by: alexsch, serb ! src/solaris/native/sun/awt/awt_util.h ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: 6c4164200421 Author: igerasim Date: 2014-10-24 19:38 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/6c4164200421 8057530: (process) Runtime.exec throws garbled message in jp locale 8016579: (process) IOException thrown by ProcessBuilder.start() method is incorrectly encoded Reviewed-by: alanb ! make/java/nio/Makefile ! src/share/native/java/io/io_util.c ! src/share/native/java/io/io_util.h ! src/solaris/native/java/io/io_util_md.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/lang/ProcessImpl_md.c Changeset: acb5d48ed0da Author: coffeys Date: 2014-07-23 20:14 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/acb5d48ed0da 8051614: smartcardio TCK tests fail due to lack of 'reset' permission Reviewed-by: valeriep ! src/share/classes/sun/security/smartcardio/CardImpl.java Changeset: 319ceec1d2f8 Author: mcherkas Date: 2014-10-29 23:33 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/319ceec1d2f8 8041572: [macosx] huge native memory leak in AWTWindow.m Reviewed-by: pchelko, serb ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 60862437eca9 Author: aefimov Date: 2014-10-15 16:32 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/60862437eca9 8033627: UTC+02:00 time zones are not detected correctly on Windows Reviewed-by: peytoia ! src/windows/lib/tzmappings Changeset: 286376bf2e1e Author: okutsu Date: 2014-10-15 14:06 +0900 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/286376bf2e1e 8060006: No Russian time zones mapping for Windows Reviewed-by: peytoia, aefimov ! src/windows/lib/tzmappings Changeset: 6e2e762deb80 Author: vinnie Date: 2014-11-04 17:11 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/6e2e762deb80 8056026: Debug security logging should print Provider used for each crypto operation Reviewed-by: mullan ! src/share/classes/java/security/KeyPairGenerator.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/MessageDigest.java ! src/share/classes/java/security/SecureRandom.java ! src/share/classes/java/security/Signature.java ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/KeyAgreement.java ! src/share/classes/javax/crypto/KeyGenerator.java ! src/share/classes/javax/crypto/Mac.java ! src/share/classes/sun/security/util/Debug.java Changeset: 3d2c4cf5454f Author: msheppar Date: 2013-09-16 14:51 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/3d2c4cf5454f 6458027: Disabling IPv6 on a specific network interface causes problems Summary: added a check to test if an interface is configured for IPv6 to native code TwoStacklainDatagramSocketImpl: getMulticastInterface, setMulticastInterface Reviewed-by: chegar, michaelm ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c + test/java/net/MulticastSocket/SetGetNetworkInterfaceTest.java Changeset: 131aaf11f6f4 Author: coffeys Date: 2014-11-04 21:17 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/131aaf11f6f4 Merge Changeset: 2b595d4b5986 Author: michaelm Date: 2014-11-04 17:08 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/2b595d4b5986 8062744: jdk.net.Sockets.setOption/getOption does not support IP_TOS Reviewed-by: chegar, alanb ! src/share/classes/jdk/net/Sockets.java + test/jdk/net/Sockets/SupportedOptions.java Changeset: b93731db7aae Author: coffeys Date: 2014-11-05 09:01 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/b93731db7aae Merge Changeset: 3796111298d5 Author: aefimov Date: 2014-11-05 13:01 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/3796111298d5 8059206: (tz) Support tzdata2014i Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java From lana.steuck at oracle.com Mon Nov 10 18:03:05 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 10 Nov 2014 10:03:05 -0800 (PST) Subject: jdk7u-b03: jdk7u-dev Message-ID: <201411101803.sAAI35ff020080@jano-app.us.oracle.com> http://hg.openjdk.java.net/jdk7u/jdk7u/rev/4093bbbc9000 http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/bcbd241df6cd http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/3796111298d5 http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/e24556d88882 http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/1853995499ce http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/9d2b485d2a58 http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/fc6a39d6be24 --- All the fixes will be tested during promotion (no PIT testing at this point): List of all fixes: =================== JDK-8051857 client-libs OperationTimedOut exception inside from XToolkit.syncNativeQueue call JDK-8041572 client-libs [macosx] huge native memory leak in AWTWindow.m JDK-7033533 client-libs realSync() doesn't work with Xfce JDK-8016579 core-libs (process) IOException thrown by ProcessBuilder.start() method is incorrectly encoded JDK-8057530 core-libs (process) Runtime.exec throws garbled message in jp locale JDK-8059206 core-libs (tz) Support tzdata2014i JDK-6458027 core-libs Disabling IPv6 on a specific network interface causes problems JDK-8060006 core-libs No Russian time zones mapping for Windows JDK-8033627 core-libs UTC+02:00 time zones are not detected correctly on Windows JDK-8062744 core-libs jdk.net.Sockets.setOption/getOption does not support IP_TOS JDK-8061643 deploy JavaWS fails with proxy autoconfig due to missing "resolve" permission JDK-8044702 deploy Large property value is not passed to jnlp applet since 7u65 b01 JDK-8033245 deploy RFE: Instructions Not Clear For Adding Site To ESL JDK-8058927 hotspot ATG throws ClassNotFoundException JDK-8041984 hotspot CompilerThread seems to occupy all CPU in a very rare situation JDK-8046275 hotspot Fastdebug build failing on jdk9/hs/ control jobs after pulling some hs-comp changes JDK-8030976 hotspot Untaken paths should be more vigorously pruned at highest optimization level JDK-8060169 hotspot Update the Crash Reporting URL in the Java crash log JDK-8059299 hotspot assert(adr_type != NULL) failed: expecting TypeKlassPtr JDK-8056026 security-libs Debug security logging should print Provider used for each crypto operation JDK-8051614 security-libs smartcardio TCK tests fail due to lack of 'reset' permission From pooja.chopra at oracle.com Mon Nov 10 16:59:56 2014 From: pooja.chopra at oracle.com (pooja chopra) Date: Mon, 10 Nov 2014 22:29:56 +0530 Subject: [7u] Review Request: JDK-8064454 Fix type in langtools for tools/javac/innerClassFile/Driver.sh Message-ID: <5460EF0C.6090501@oracle.com> Hello, Please review a fix for the issue: 8064454 [TEST_BUG] Test tools/javac/innerClassFile/Driver.sh fails with exit code 1 Test bug fix. https://bugs.openjdk.java.net/browse/JDK-8064454 The webrev is: http://cr.openjdk.java.net/~kshefov/8064454/webrev.00/ Thanks Pooja From david.buck at oracle.com Tue Nov 11 09:35:38 2014 From: david.buck at oracle.com (david buck) Date: Tue, 11 Nov 2014 18:35:38 +0900 Subject: [7u-dev] request for approval: 8064516: BCEL still corrupts generic methods if bytecode offsets are modified Message-ID: <5461D86A.1000801@oracle.com> Hi! May I please have approval to backport this fix from JDK8 to JDK7? Fix applies cleanly. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8064516 JDK8 changeset: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/572db6f408a2 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029602.html Cheers, -Buck From sean.coffey at oracle.com Tue Nov 11 09:44:16 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 11 Nov 2014 09:44:16 +0000 Subject: [7u-dev] request for approval: 8064516: BCEL still corrupts generic methods if bytecode offsets are modified In-Reply-To: <5461D86A.1000801@oracle.com> References: <5461D86A.1000801@oracle.com> Message-ID: <5461DA70.1000604@oracle.com> Approved. Please add a noreg- label to master bug record. regards, Sean. On 11/11/2014 09:35, david buck wrote: > Hi! > > May I please have approval to backport this fix from JDK8 to JDK7? Fix > applies cleanly. > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8064516 > > JDK8 changeset: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/572db6f408a2 > > review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029602.html > > Cheers, > -Buck From david.buck at oracle.com Tue Nov 11 09:47:37 2014 From: david.buck at oracle.com (david.buck at oracle.com) Date: Tue, 11 Nov 2014 09:47:37 +0000 Subject: hg: jdk7u/jdk7u-dev/jaxp: 8064516: BCEL still corrupts generic methods if bytecode offsets are modified Message-ID: <201411110947.sAB9lbDk002562@aojmv0008> Changeset: 02e31e03f896 Author: dbuck Date: 2014-11-11 01:46 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/02e31e03f896 8064516: BCEL still corrupts generic methods if bytecode offsets are modified Summary: Added comprehensive support for LocalVariableTypeTable to MethodGen. Reviewed-by: joehw ! src/com/sun/org/apache/bcel/internal/classfile/DescendingVisitor.java ! src/com/sun/org/apache/bcel/internal/generic/MethodGen.java From aleksej.efimov at oracle.com Wed Nov 12 10:24:25 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Wed, 12 Nov 2014 13:24:25 +0300 Subject: [7u-dev] request for approval: 8059327: XML parser returns corrupt attribute value Message-ID: <54633559.9080906@oracle.com> Hi! May I please have approval to backport 8059327 fix from JDK8 to JDK7? Fix applies cleanly. Testing (JPRT+JTREG) shows no failures with new and other xml related tests. Bug URL: https://bugs.openjdk.java.net/browse/JDK-8059327 JDK8 changesets: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/3eaaa67e886e http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/48d5653ac014 JDK9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029555.html Best Regards, Aleksej From sean.coffey at oracle.com Wed Nov 12 11:09:33 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 12 Nov 2014 11:09:33 +0000 Subject: [7u-dev] request for approval: 8059327: XML parser returns corrupt attribute value In-Reply-To: <54633559.9080906@oracle.com> References: <54633559.9080906@oracle.com> Message-ID: <54633FED.5020907@oracle.com> Approved. On a side note, I notice that alot of new incoming testng tests don't use the "@bug" label convention. QA and other teams use that tag for metrics. Something to keep an eye on. regards, Sean. On 12/11/14 10:24, Aleksej Efimov wrote: > Hi! > > May I please have approval to backport 8059327 fix from JDK8 to JDK7? > Fix applies cleanly. > Testing (JPRT+JTREG) shows no failures with new and other xml related > tests. > > Bug URL: > https://bugs.openjdk.java.net/browse/JDK-8059327 > > JDK8 changesets: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/3eaaa67e886e > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/48d5653ac014 > > JDK9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029555.html > > > Best Regards, > Aleksej From aleksej.efimov at oracle.com Thu Nov 13 13:02:20 2014 From: aleksej.efimov at oracle.com (aleksej.efimov at oracle.com) Date: Thu, 13 Nov 2014 13:02:20 +0000 Subject: hg: jdk7u/jdk7u-dev/jaxp: 8059327: XML parser returns corrupt attribute value Message-ID: <201411131302.sADD2NQV022045@aojmv0008> Changeset: 1e0a9e7cd016 Author: aefimov Date: 2014-11-12 13:02 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/1e0a9e7cd016 8059327: XML parser returns corrupt attribute value Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XML11EntityScanner.java ! src/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java From aleksej.efimov at oracle.com Thu Nov 13 13:02:52 2014 From: aleksej.efimov at oracle.com (aleksej.efimov at oracle.com) Date: Thu, 13 Nov 2014 13:02:52 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8059327: XML parser returns corrupt attribute value Message-ID: <201411131302.sADD2rsY022165@aojmv0008> Changeset: df7bf5b610ee Author: aefimov Date: 2014-11-12 13:02 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/df7bf5b610ee 8059327: XML parser returns corrupt attribute value Reviewed-by: lancea + test/javax/xml/jaxp/testng/TEST.properties + test/javax/xml/jaxp/testng/parse/XMLEntityScannerLoad.java From mikhail.cherkasov at oracle.com Fri Nov 14 14:15:13 2014 From: mikhail.cherkasov at oracle.com (mikhail.cherkasov at oracle.com) Date: Fri, 14 Nov 2014 14:15:13 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8001633: Wrong alt processing during switching between windows. Message-ID: <201411141415.sAEEFDrS019576@aojmv0008> Changeset: 3b6300ae4fe5 Author: mcherkas Date: 2014-11-14 18:12 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3b6300ae4fe5 8001633: Wrong alt processing during switching between windows. Reviewed-by: ant, pchelko ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsRootPaneUI.java ! src/share/classes/java/awt/event/KeyEvent.java ! src/share/classes/sun/awt/AWTAccessor.java + test/javax/swing/plaf/windows/WindowsRootPaneUI/AltKeyProccessingNPETest/AltKeyProccessingNPETest.java From andreas.eriksson at oracle.com Fri Nov 14 15:03:21 2014 From: andreas.eriksson at oracle.com (Andreas Eriksson) Date: Fri, 14 Nov 2014 16:03:21 +0100 Subject: [7u-dev] Request for approval for CR 8058583: Remove CompilationRepeat Message-ID: <546619B9.9040008@oracle.com> Hi, I'd like approval for a jdk7 backport of CR 8058583: Remove CompilationRepeat Backport reviewed by Nils Eliasson. Webrev: http://cr.openjdk.java.net/~aeriksso/8058583/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-November/016281.html Regards, Andreas From dalibor.topic at oracle.com Fri Nov 14 15:09:03 2014 From: dalibor.topic at oracle.com (dalibor topic) Date: Fri, 14 Nov 2014 16:09:03 +0100 Subject: [7u-dev] Request for approval for CR 8058583: Remove CompilationRepeat In-Reply-To: <546619B9.9040008@oracle.com> References: <546619B9.9040008@oracle.com> Message-ID: <54661B0F.4060903@oracle.com> Approved. On 14.11.2014 16:03, Andreas Eriksson wrote: > Hi, > > I'd like approval for a jdk7 backport of CR 8058583: Remove > CompilationRepeat > > Backport reviewed by Nils Eliasson. > Webrev: http://cr.openjdk.java.net/~aeriksso/8058583/webrev.00/ > Review thread: > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2014-November/016281.html > > > Regards, > Andreas -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Oracle is committed to developing practices and products that help protect the environment From sean.coffey at oracle.com Mon Nov 17 10:42:21 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 17 Nov 2014 10:42:21 +0000 Subject: [7u-dev] Request for approval : 8047340 - (process) Runtime.exec() fails in Turkish locale Message-ID: <5469D10D.3040101@oracle.com> I'd like to push this fix to jdk7u-dev. It's already addressed in JDK 8 via JDK-8000975 webrev : http://cr.openjdk.java.net/~coffeys/webrev.8047340.7u/webrev/ bug report : https://bugs.openjdk.java.net/browse/JDK-8047340 review thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029659.html regards, Sean. From rob.mckenna at oracle.com Mon Nov 17 14:51:13 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 17 Nov 2014 14:51:13 +0000 Subject: [7u-dev] Request for approval : 8047340 - (process) Runtime.exec() fails in Turkish locale In-Reply-To: <5469D10D.3040101@oracle.com> References: <5469D10D.3040101@oracle.com> Message-ID: <546A0B61.8000801@oracle.com> Approved. -Rob On 17/11/14 10:42, Se?n Coffey wrote: > I'd like to push this fix to jdk7u-dev. It's already addressed in JDK > 8 via JDK-8000975 > > webrev : http://cr.openjdk.java.net/~coffeys/webrev.8047340.7u/webrev/ > bug report : https://bugs.openjdk.java.net/browse/JDK-8047340 > review thread : > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029659.html > > regards, > Sean. From sean.coffey at oracle.com Mon Nov 17 14:54:15 2014 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Mon, 17 Nov 2014 14:54:15 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8047340: (process) Runtime.exec() fails in Turkish locale Message-ID: <201411171454.sAHEsGxB005620@aojmv0008> Changeset: 8f7559387f84 Author: coffeys Date: 2014-11-17 10:39 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/8f7559387f84 8047340: (process) Runtime.exec() fails in Turkish locale Reviewed-by: martin ! src/solaris/classes/java/lang/UNIXProcess.java.bsd ! src/solaris/classes/java/lang/UNIXProcess.java.linux ! src/solaris/classes/java/lang/UNIXProcess.java.solaris ! test/java/lang/ProcessBuilder/Basic.java From rickard.backman at oracle.com Wed Nov 19 11:26:51 2014 From: rickard.backman at oracle.com (rickard.backman at oracle.com) Date: Wed, 19 Nov 2014 11:26:51 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 8058583: Remove CompilationRepeat Message-ID: <201411191126.sAJBQpoW020997@aojmv0008> Changeset: 546d5fb8cc54 Author: aeriksso Date: 2014-11-19 10:22 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/546d5fb8cc54 8058583: Remove CompilationRepeat Reviewed-by: neliasso, kvn ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/runtime/arguments.cpp From poonam.bajaj at oracle.com Wed Nov 19 14:47:18 2014 From: poonam.bajaj at oracle.com (Poonam Bajaj) Date: Wed, 19 Nov 2014 06:47:18 -0800 Subject: [7u-dev] Request for approval for 6976528: PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been cleared Message-ID: <546CAD76.7020604@oracle.com> Hello, Requesting approval for this simple backport to 7u. The code changes remove the unnecessary asserts. The patch applies cleanly to jdk7u repo. Bug:JDK-6976528 : PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been cleared Webrev: http://cr.openjdk.java.net/~poonam/6976528/webrev.00/ jdk8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/82657b6a8cc0 Thanks, Poonam From rob.mckenna at oracle.com Wed Nov 19 15:50:43 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 19 Nov 2014 15:50:43 +0000 Subject: [7u-dev] Request for approval for 6976528: PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been cleared In-Reply-To: <546CAD76.7020604@oracle.com> References: <546CAD76.7020604@oracle.com> Message-ID: <546CBC53.6090100@oracle.com> Approved. Needs a valid noreg label. -Rob On 19/11/14 14:47, Poonam Bajaj wrote: > Hello, > > Requesting approval for this simple backport to 7u. The code changes > remove the unnecessary asserts. The patch applies cleanly to jdk7u repo. > > Bug:JDK-6976528 : > PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been > cleared > Webrev: http://cr.openjdk.java.net/~poonam/6976528/webrev.00/ > jdk8 changeset: > http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/82657b6a8cc0 > > Thanks, > Poonam > From poonam.bajaj at oracle.com Wed Nov 19 22:04:46 2014 From: poonam.bajaj at oracle.com (poonam.bajaj at oracle.com) Date: Wed, 19 Nov 2014 22:04:46 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 6976528: PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been cleared Message-ID: <201411192204.sAJM4kNF005590@aojmv0008> Changeset: aa79052bdf62 Author: poonam Date: 2014-11-19 10:32 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/aa79052bdf62 6976528: PS: assert(!limit_exceeded || softrefs_clear) failed: Should have been cleared Reviewed-by: johnc ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/memory/collectorPolicy.cpp From rob.mckenna at oracle.com Wed Nov 19 22:55:13 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 19 Nov 2014 22:55:13 +0000 Subject: [7u-dev] Request for approval: 8013485 - javac can't handle annotations with a from a previous compilation unit Message-ID: <546D1FD1.6090202@oracle.com> Hi folks, Requesting approval for this straightforward backport to 7: https://bugs.openjdk.java.net/browse/JDK-8013485 http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/780014a234fa -Rob From naoto.sato at oracle.com Wed Nov 19 23:07:13 2014 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 19 Nov 2014 15:07:13 -0800 Subject: [7u-dev] Request for approval: 8013485 - javac can't handle annotations with a from a previous compilation unit In-Reply-To: <546D1FD1.6090202@oracle.com> References: <546D1FD1.6090202@oracle.com> Message-ID: <546D22A1.1070702@oracle.com> Approved. Naoto On 11/19/14, 2:55 PM, Rob McKenna wrote: > Hi folks, > > Requesting approval for this straightforward backport to 7: > > https://bugs.openjdk.java.net/browse/JDK-8013485 > http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/780014a234fa > > -Rob > From rob.mckenna at oracle.com Wed Nov 19 23:17:27 2014 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Wed, 19 Nov 2014 23:17:27 +0000 Subject: hg: jdk7u/jdk7u-dev/langtools: 8013485: javac can't handle annotations with a from a previous compilation unit Message-ID: <201411192317.sAJNHRYq018990@aojmv0008> Changeset: 9755f64a08e2 Author: jfranck Date: 2013-05-08 14:10 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/9755f64a08e2 8013485: javac can't handle annotations with a from a previous compilation unit Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/clinit/AnnoWithClinit1.java + test/tools/javac/annotations/clinit/AnnoWithClinitFail.java + test/tools/javac/annotations/clinit/AnnoWithClinitFail.out From ivan.gerasimov at oracle.com Thu Nov 20 12:38:46 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Thu, 20 Nov 2014 15:38:46 +0300 Subject: [7u-dev] Request for Approval: 8050983: Misplaced parentheses in sun.net.www.http.HttpClient break HTTP PUT streaming Message-ID: <546DE0D6.2050505@oracle.com> Hello! Would you please approve backporting this fix to jdk7u-dev? The change from jdk8 applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8050983 Jdk8 change: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b0e7095469b3 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/488295a6b59c Review: http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008756.html Sincerely yours, Ivan From rob.mckenna at oracle.com Thu Nov 20 15:56:56 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 20 Nov 2014 15:56:56 +0000 Subject: [7u-dev] Request for Approval: 8050983: Misplaced parentheses in sun.net.www.http.HttpClient break HTTP PUT streaming In-Reply-To: <546DE0D6.2050505@oracle.com> References: <546DE0D6.2050505@oracle.com> Message-ID: <546E0F48.9040000@oracle.com> Approved. -Rob On 20/11/14 12:38, Ivan Gerasimov wrote: > Hello! > > Would you please approve backporting this fix to jdk7u-dev? > The change from jdk8 applies cleanly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8050983 > Jdk8 change: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b0e7095469b3 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/488295a6b59c > Review: > http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008756.html > > Sincerely yours, > Ivan > From david.katleman at oracle.com Thu Nov 20 17:54:01 2014 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 20 Nov 2014 17:54:01 +0000 Subject: hg: jdk7u/jdk7u: Added tag jdk7u80-b03 for changeset 4093bbbc9000 Message-ID: <201411201754.sAKHs1X7013455@aojmv0008> Changeset: 928d01695cd2 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/rev/928d01695cd2 Added tag jdk7u80-b03 for changeset 4093bbbc9000 ! .hgtags From david.katleman at oracle.com Thu Nov 20 17:54:05 2014 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 20 Nov 2014 17:54:05 +0000 Subject: hg: jdk7u/jdk7u/corba: Added tag jdk7u80-b03 for changeset fc6a39d6be24 Message-ID: <201411201754.sAKHs5MM013526@aojmv0008> Changeset: d9ddd2aec6be Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/corba/rev/d9ddd2aec6be Added tag jdk7u80-b03 for changeset fc6a39d6be24 ! .hgtags From david.katleman at oracle.com Thu Nov 20 17:54:09 2014 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 20 Nov 2014 17:54:09 +0000 Subject: hg: jdk7u/jdk7u/hotspot: Added tag jdk7u80-b03 for changeset 9d2b485d2a58 Message-ID: <201411201754.sAKHs9V1013608@aojmv0008> Changeset: 38294f25c7a8 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/38294f25c7a8 Added tag jdk7u80-b03 for changeset 9d2b485d2a58 ! .hgtags From david.katleman at oracle.com Thu Nov 20 17:54:12 2014 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 20 Nov 2014 17:54:12 +0000 Subject: hg: jdk7u/jdk7u/jaxp: Added tag jdk7u80-b03 for changeset 1853995499ce Message-ID: <201411201754.sAKHsC87013661@aojmv0008> Changeset: d21a5188bf59 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxp/rev/d21a5188bf59 Added tag jdk7u80-b03 for changeset 1853995499ce ! .hgtags From david.katleman at oracle.com Thu Nov 20 17:54:16 2014 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 20 Nov 2014 17:54:16 +0000 Subject: hg: jdk7u/jdk7u/jaxws: Added tag jdk7u80-b03 for changeset e24556d88882 Message-ID: <201411201754.sAKHsGPB013716@aojmv0008> Changeset: aaa0e97579b6 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jaxws/rev/aaa0e97579b6 Added tag jdk7u80-b03 for changeset e24556d88882 ! .hgtags From david.katleman at oracle.com Thu Nov 20 17:54:20 2014 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 20 Nov 2014 17:54:20 +0000 Subject: hg: jdk7u/jdk7u/jdk: Added tag jdk7u80-b03 for changeset 3796111298d5 Message-ID: <201411201754.sAKHsKrF013773@aojmv0008> Changeset: cba625be1713 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/cba625be1713 Added tag jdk7u80-b03 for changeset 3796111298d5 ! .hgtags From david.katleman at oracle.com Thu Nov 20 17:54:24 2014 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Thu, 20 Nov 2014 17:54:24 +0000 Subject: hg: jdk7u/jdk7u/langtools: Added tag jdk7u80-b03 for changeset bcbd241df6cd Message-ID: <201411201754.sAKHsOde013825@aojmv0008> Changeset: b2cf7f00a624 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u/langtools/rev/b2cf7f00a624 Added tag jdk7u80-b03 for changeset bcbd241df6cd ! .hgtags From lana.steuck at oracle.com Fri Nov 21 00:36:08 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 21 Nov 2014 00:36:08 +0000 Subject: hg: jdk7u/jdk7u-dev: Added tag jdk7u80-b03 for changeset 4093bbbc9000 Message-ID: <201411210036.sAL0a9v4022565@aojmv0008> Changeset: 928d01695cd2 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/rev/928d01695cd2 Added tag jdk7u80-b03 for changeset 4093bbbc9000 ! .hgtags From lana.steuck at oracle.com Fri Nov 21 00:36:09 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 21 Nov 2014 00:36:09 +0000 Subject: hg: jdk7u/jdk7u-dev/corba: Added tag jdk7u80-b03 for changeset fc6a39d6be24 Message-ID: <201411210036.sAL0a9N0022579@aojmv0008> Changeset: d9ddd2aec6be Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/corba/rev/d9ddd2aec6be Added tag jdk7u80-b03 for changeset fc6a39d6be24 ! .hgtags From lana.steuck at oracle.com Fri Nov 21 00:36:11 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 21 Nov 2014 00:36:11 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 2 new changesets Message-ID: <201411210036.sAL0aBgB022611@aojmv0008> Changeset: 38294f25c7a8 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/38294f25c7a8 Added tag jdk7u80-b03 for changeset 9d2b485d2a58 ! .hgtags Changeset: ed02162f7694 Author: lana Date: 2014-11-20 14:01 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/ed02162f7694 Merge From lana.steuck at oracle.com Fri Nov 21 00:36:16 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 21 Nov 2014 00:36:16 +0000 Subject: hg: jdk7u/jdk7u-dev/jaxp: 2 new changesets Message-ID: <201411210036.sAL0aGaC022803@aojmv0008> Changeset: d21a5188bf59 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/d21a5188bf59 Added tag jdk7u80-b03 for changeset 1853995499ce ! .hgtags Changeset: 3f6f05383179 Author: lana Date: 2014-11-20 14:01 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/3f6f05383179 Merge From lana.steuck at oracle.com Fri Nov 21 00:36:18 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 21 Nov 2014 00:36:18 +0000 Subject: hg: jdk7u/jdk7u-dev/langtools: 2 new changesets Message-ID: <201411210036.sAL0aICU022813@aojmv0008> Changeset: b2cf7f00a624 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/b2cf7f00a624 Added tag jdk7u80-b03 for changeset bcbd241df6cd ! .hgtags Changeset: 20376611cb3b Author: lana Date: 2014-11-20 14:01 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/20376611cb3b Merge From lana.steuck at oracle.com Fri Nov 21 00:36:17 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 21 Nov 2014 00:36:17 +0000 Subject: hg: jdk7u/jdk7u-dev/jaxws: Added tag jdk7u80-b03 for changeset e24556d88882 Message-ID: <201411210036.sAL0aH2e022810@aojmv0008> Changeset: aaa0e97579b6 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxws/rev/aaa0e97579b6 Added tag jdk7u80-b03 for changeset e24556d88882 ! .hgtags From lana.steuck at oracle.com Fri Nov 21 00:36:19 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 21 Nov 2014 00:36:19 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 2 new changesets Message-ID: <201411210036.sAL0aJml022823@aojmv0008> Changeset: cba625be1713 Author: katleman Date: 2014-11-20 09:53 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/cba625be1713 Added tag jdk7u80-b03 for changeset 3796111298d5 ! .hgtags Changeset: bf3af4e1335c Author: lana Date: 2014-11-20 14:01 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/bf3af4e1335c Merge From ivan.gerasimov at oracle.com Fri Nov 21 08:08:53 2014 From: ivan.gerasimov at oracle.com (ivan.gerasimov at oracle.com) Date: Fri, 21 Nov 2014 08:08:53 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8050983: Misplaced parentheses in sun.net.www.http.HttpClient break HTTP PUT streaming Message-ID: <201411210808.sAL88sxV028371@aojmv0008> Changeset: cc7c09cc2393 Author: igerasim Date: 2014-11-21 11:08 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/cc7c09cc2393 8050983: Misplaced parentheses in sun.net.www.http.HttpClient break HTTP PUT streaming Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/HttpClient.java ! test/sun/net/www/http/HttpClient/StreamingRetry.java From ivan.gerasimov at oracle.com Sat Nov 22 22:00:03 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Sun, 23 Nov 2014 01:00:03 +0300 Subject: [7u-dev] Request for Approval: 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 Message-ID: <54710763.90807@oracle.com> Hello! Would you please approve backporting this fix to 7u-dev? The patch applies cleanly. CCC in its final state. Bug: https://bugs.openjdk.java.net/browse/JDK-8064667 Jdk8 change: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/fa6adc194d48 Jdk9 change: N/A (only 7 and 8) Review: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013285.html Sincerely yours, Ivan From rob.mckenna at oracle.com Sun Nov 23 18:52:33 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Sun, 23 Nov 2014 18:52:33 +0000 Subject: [7u-dev] Request for Approval: 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 In-Reply-To: <54710763.90807@oracle.com> References: <54710763.90807@oracle.com> Message-ID: <54722CF1.1060005@oracle.com> Approved. -Rob On 22/11/14 22:00, Ivan Gerasimov wrote: > Hello! > > Would you please approve backporting this fix to 7u-dev? > The patch applies cleanly. > CCC in its final state. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8064667 > Jdk8 change: > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/fa6adc194d48 > Jdk9 change: N/A (only 7 and 8) > Review: > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013285.html > > Sincerely yours, > Ivan From ivan.gerasimov at oracle.com Sun Nov 23 20:18:15 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Sun, 23 Nov 2014 23:18:15 +0300 Subject: [7u-dev] Request for Approval: 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 In-Reply-To: <54722CF1.1060005@oracle.com> References: <54710763.90807@oracle.com> <54722CF1.1060005@oracle.com> Message-ID: <54724107.8060906@oracle.com> Thanks Rob! Do you know, is the correct repository for backports in the hotspot area is http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/ ? I see that for 8u the fix was pushed into jdk8u/hs-dev/hotspot, but I can't find anything like that for 7. Sincerely yours, Ivan On 23.11.2014 21:52, Rob McKenna wrote: > Approved. > > -Rob > > On 22/11/14 22:00, Ivan Gerasimov wrote: >> Hello! >> >> Would you please approve backporting this fix to 7u-dev? >> The patch applies cleanly. >> CCC in its final state. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8064667 >> Jdk8 change: >> http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/fa6adc194d48 >> Jdk9 change: N/A (only 7 and 8) >> Review: >> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013285.html >> >> Sincerely yours, >> Ivan > > > From rob.mckenna at oracle.com Sun Nov 23 21:35:56 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Sun, 23 Nov 2014 21:35:56 +0000 Subject: [7u-dev] Request for Approval: 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 In-Reply-To: <54724107.8060906@oracle.com> References: <54710763.90807@oracle.com> <54722CF1.1060005@oracle.com> <54724107.8060906@oracle.com> Message-ID: <5472533C.3060402@oracle.com> Yup! As a quick check you can have a look at the repo to see the last few checkins and look at the bugs to see where they were first pushed. -Rob On 23/11/14 20:18, Ivan Gerasimov wrote: > Thanks Rob! > > Do you know, is the correct repository for backports in the hotspot > area is http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/ ? > I see that for 8u the fix was pushed into jdk8u/hs-dev/hotspot, but I > can't find anything like that for 7. > > Sincerely yours, > Ivan > > On 23.11.2014 21:52, Rob McKenna wrote: >> Approved. >> >> -Rob >> >> On 22/11/14 22:00, Ivan Gerasimov wrote: >>> Hello! >>> >>> Would you please approve backporting this fix to 7u-dev? >>> The patch applies cleanly. >>> CCC in its final state. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8064667 >>> Jdk8 change: >>> http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/fa6adc194d48 >>> Jdk9 change: N/A (only 7 and 8) >>> Review: >>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013285.html >>> >>> Sincerely yours, >>> Ivan >> >> >> > From mikhail.cherkasov at oracle.com Mon Nov 24 09:59:14 2014 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Mon, 24 Nov 2014 12:59:14 +0300 Subject: [7u-dev] Request for approval: 8001633: Wrong alt processing during switching between windows. Message-ID: <54730172.7010000@oracle.com> Hello all, I would like to request for an approval to push a backport of the fix from JDK 8 to JDK 7. The backport was changed, the original testcase was replaced with a new one. Bug: https://bugs.openjdk.java.net/browse/JDK-8001633 Review: http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008684.html Webrev: http://cr.openjdk.java.net/~mcherkas/8001633/jdk7/webrev.00/ review for jdk8: http://mail.openjdk.java.net/pipermail/awt-dev/2012-October/003732.html jdk8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/3d22bd7d6678 PS: I forget that request is needed even if a fix had separate review for jdk7. the fix has already been pushed, sorry for inconvenience. Thanks, Mikhail. From sean.coffey at oracle.com Mon Nov 24 11:00:15 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 24 Nov 2014 11:00:15 +0000 Subject: [7u-dev] Request for approval: 8001633: Wrong alt processing during switching between windows. In-Reply-To: <54730172.7010000@oracle.com> References: <54730172.7010000@oracle.com> Message-ID: <54730FBF.7010505@oracle.com> Thanks for following up with the approval request. Approved. regards, Sean. On 24/11/14 09:59, mikhail cherkasov wrote: > Hello all, > > I would like to request for an approval to push a backport of the fix > from JDK 8 to JDK 7. > The backport was changed, the original testcase was replaced with a > new one. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8001633 > Review: > http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008684.html > Webrev: http://cr.openjdk.java.net/~mcherkas/8001633/jdk7/webrev.00/ > > review for jdk8: > http://mail.openjdk.java.net/pipermail/awt-dev/2012-October/003732.html > jdk8 changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/3d22bd7d6678 > > PS: I forget that request is needed even if a fix had separate review > for jdk7. > the fix has already been pushed, sorry for inconvenience. > > > Thanks, > Mikhail. > From kevin.walls at oracle.com Mon Nov 24 11:43:35 2014 From: kevin.walls at oracle.com (KEVIN WALLS) Date: Mon, 24 Nov 2014 11:43:35 +0000 Subject: RFR: 8061785: [TEST_BUG] serviceability/sa/jmap-hashcode/Test8028623.java has utf8 character corrupted by earlier merge Message-ID: <547319E7.8030900@oracle.com> Hi, I'd like to request approval to push this small proactive change to a test into http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot The test contains an embedded utf8 character, to test a jmap/SA heap dumping fix. The test is not broken here in 7u-dev, but in another clone I saw this character get corrupted by a merge: it was rewritten as literal ?? question marks. To avoid the same thing happening again we can change it to a \uXXXX format. The change below I tested to check the test still correctly fails on a non-fixed JVM, and passes on a fixed one (original issue: https://bugs.openjdk.java.net/browse/JDK-8028623). bug: https://bugs.openjdk.java.net/browse/JDK-8061785 change: $ hg diff diff --git a/test/serviceability/sa/jmap-hashcode/Test8028623.java b/test/serviceability/sa/jmap-hashcode/Test8028623.java --- a/test/serviceability/sa/jmap-hashcode/Test8028623.java +++ b/test/serviceability/sa/jmap-hashcode/Test8028623.java @@ -38,12 +38,12 @@ public class Test8028623 { - public static int ? = 1; + public static int \u00CB = 1; public static String dumpFile = "heap.out"; public static void main (String[] args) { - System.out.println(?); + System.out.println(\u00CB); try { int pid = ProcessTools.getProcessId(); ---------------------------------------------------------------------------------------------- Thanks Kevin From ivan.gerasimov at oracle.com Mon Nov 24 13:34:12 2014 From: ivan.gerasimov at oracle.com (ivan.gerasimov at oracle.com) Date: Mon, 24 Nov 2014 13:34:12 +0000 Subject: hg: jdk7u/jdk7u-dev/hotspot: 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 Message-ID: <201411241334.sAODYCol017874@aojmv0008> Changeset: f49c3e79b676 Author: igerasim Date: 2014-11-24 16:33 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/f49c3e79b676 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 Reviewed-by: coleenp, ccheung ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/globals.hpp + test/runtime/CheckEndorsedAndExtDirs/EndorsedExtDirs.java From shobhit.s.gupta at oracle.com Mon Nov 24 12:34:15 2014 From: shobhit.s.gupta at oracle.com (shobhit gupta) Date: Mon, 24 Nov 2014 18:04:15 +0530 Subject: [7u80] Request for Approval : JDK-8026865 : [TESTBUG] 'compiler/print/PrintInlining.java' should specify -XX:+UnlockDiagnosticVMOptions Message-ID: <547325C7.9080205@oracle.com> Please approve backport ofJDK-8026865 to 7u80. Bug: https://bugs.openjdk.java.net/browse/JDK-8026865 Webrev:http://cr.openjdk.java.net/~kshefov/8026865/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2013-October/012301.html Changeset:http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/52575a17a36c The patch applies cleanly to 7u80. Thanks, Shobhit Gupta From sean.coffey at oracle.com Mon Nov 24 14:30:28 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 24 Nov 2014 14:30:28 +0000 Subject: [7u80] Request for Approval : JDK-8026865 : [TESTBUG] 'compiler/print/PrintInlining.java' should specify -XX:+UnlockDiagnosticVMOptions In-Reply-To: <547325C7.9080205@oracle.com> References: <547325C7.9080205@oracle.com> Message-ID: <54734104.7020002@oracle.com> Approved. regards, Sean. On 24/11/14 12:34, shobhit gupta wrote: > Please approve backport ofJDK-8026865 > to 7u80. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8026865 > Webrev:http://cr.openjdk.java.net/~kshefov/8026865/webrev.00/ > Review thread: > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2013-October/012301.html > Changeset:http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/52575a17a36c > > The patch applies cleanly to 7u80. > > Thanks, > Shobhit Gupta > From sean.coffey at oracle.com Mon Nov 24 14:32:20 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 24 Nov 2014 14:32:20 +0000 Subject: RFR: 8061785: [TEST_BUG] serviceability/sa/jmap-hashcode/Test8028623.java has utf8 character corrupted by earlier merge In-Reply-To: <547319E7.8030900@oracle.com> References: <547319E7.8030900@oracle.com> Message-ID: <54734174.4090307@oracle.com> I wasn't sure if this was a review or approval request Kevin. Change looks fine to me in any case. Approved. regards, Sean. On 24/11/14 11:43, KEVIN WALLS wrote: > Hi, > > I'd like to request approval to push this small proactive change to a > test into > > http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot > > > The test contains an embedded utf8 character, to test a jmap/SA heap > dumping fix. The test is not broken here in 7u-dev, but in another > clone I saw this character get corrupted by a merge: it was rewritten > as literal ?? question marks. To avoid the same thing happening > again we can change it to a \uXXXX format. > > The change below I tested to check the test still correctly fails on a > non-fixed JVM, and passes on a fixed one (original issue: > https://bugs.openjdk.java.net/browse/JDK-8028623). > > bug: > https://bugs.openjdk.java.net/browse/JDK-8061785 > > change: > > $ hg diff > diff --git a/test/serviceability/sa/jmap-hashcode/Test8028623.java > b/test/serviceability/sa/jmap-hashcode/Test8028623.java > --- a/test/serviceability/sa/jmap-hashcode/Test8028623.java > +++ b/test/serviceability/sa/jmap-hashcode/Test8028623.java > @@ -38,12 +38,12 @@ > > public class Test8028623 { > > - public static int ? = 1; > + public static int \u00CB = 1; > public static String dumpFile = "heap.out"; > > public static void main (String[] args) { > > - System.out.println(?); > + System.out.println(\u00CB); > > try { > int pid = ProcessTools.getProcessId(); > > > > ---------------------------------------------------------------------------------------------- > > Thanks > Kevin From vicente.romero at oracle.com Mon Nov 24 19:16:38 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Mon, 24 Nov 2014 11:16:38 -0800 Subject: [7u-dev] Request for Review: JDK-8065674: javac generates incorrect LVT table for trivial cases Message-ID: <54738416.6010905@oracle.com> Please review the proposed fix for the bug in the subject. Details below: JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 Webrev: http://cr.openjdk.java.net/~vromero/8065674/webrev.00/ This patch should fix several issues with LVT generation in JDK7. Please see the code at the JBS entry or the tests provided in this patch to have an idea of the current code patterns for which the LVT is being ill-generated. Thanks, Vicente From jonathan.gibbons at oracle.com Tue Nov 25 01:32:36 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 24 Nov 2014 17:32:36 -0800 Subject: [7u-dev] Request for Review: JDK-8065674: javac generates incorrect LVT table for trivial cases In-Reply-To: <54738416.6010905@oracle.com> References: <54738416.6010905@oracle.com> Message-ID: <5473DC34.7090905@oracle.com> Looks OK to me. -- Jon On 11/24/2014 11:16 AM, Vicente-Arturo Romero-Zaldivar wrote: > Please review the proposed fix for the bug in the subject. Details below: > > JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 > Webrev: http://cr.openjdk.java.net/~vromero/8065674/webrev.00/ > > This patch should fix several issues with LVT generation in JDK7. > Please see the code at the JBS entry or the tests provided in this > patch to have an idea of the current code patterns for which the LVT > is being ill-generated. > > Thanks, > Vicente > From vicente.romero at oracle.com Tue Nov 25 01:41:22 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Mon, 24 Nov 2014 17:41:22 -0800 Subject: [7u-dev] Request for Approval: 8065674: javac generates incorrect LVT table for trivial cases Message-ID: <5473DE42.40002@oracle.com> Please approve the push of the fix for: JDK-8065674: javac generates incorrect LVT table for trivial cases JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 Webrev: http://cr.openjdk.java.net/~vromero/8065674/webrev.00/ Approval mail: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2014-November/010024.html Thanks, Vicente PD: Rob, I don't have pushing privileges on 7, could you please push it for me? From vicente.romero at oracle.com Tue Nov 25 01:41:47 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Mon, 24 Nov 2014 17:41:47 -0800 Subject: [7u-dev] Request for Review: JDK-8065674: javac generates incorrect LVT table for trivial cases In-Reply-To: <5473DC34.7090905@oracle.com> References: <54738416.6010905@oracle.com> <5473DC34.7090905@oracle.com> Message-ID: <5473DE5B.4070809@oracle.com> On 11/24/2014 05:32 PM, Jonathan Gibbons wrote: > JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 > Webrev: http://cr.openjdk.java.net/~vromero/8065674/webrev.00/ Thanks for the approval, Vicente From rob.mckenna at oracle.com Tue Nov 25 02:03:13 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 25 Nov 2014 02:03:13 +0000 Subject: [7u-dev] Request for Approval: 8065674: javac generates incorrect LVT table for trivial cases In-Reply-To: <5473DE42.40002@oracle.com> References: <5473DE42.40002@oracle.com> Message-ID: <5473E361.8000407@oracle.com> Approved and yes. Thanks Vicente. -Rob On 25/11/14 01:41, Vicente-Arturo Romero-Zaldivar wrote: > Please approve the push of the fix for: > > JDK-8065674: javac generates incorrect LVT table for trivial cases > JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 > Webrev: http://cr.openjdk.java.net/~vromero/8065674/webrev.00/ > Approval mail: > http://mail.openjdk.java.net/pipermail/jdk7u-dev/2014-November/010024.html > > Thanks, > Vicente > > PD: Rob, I don't have pushing privileges on 7, could you please push > it for me? From aleksej.efimov at oracle.com Tue Nov 25 12:11:09 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Tue, 25 Nov 2014 15:11:09 +0300 Subject: [7u-dev] Request for approval: 8064560: (tz) Support tzdata2014j Message-ID: <547471DD.3050807@oracle.com> Hello, Please, approve a backport of tzdata2014j related changes to jdk7u-dev. The JDK8 fix applies cleanly with unshuffled path to tz data storage (make/data/tzdata->make/sun/javazic/tzdata). Testing: JPRT and JTREG [1] tests shows no tz related failures. Bug: https://bugs.openjdk.java.net/browse/JDK-8064560 JDK8 changeset: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/9c926f0dd726 JDK9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029678.html Thank you, Aleksej [1] JTREG test sets executed: test/sun/util/resources/TimeZone test/sun/util/calendar test/closed/java/util/TimeZone test/java/util/TimeZone test/java/util/Calendar test/java/util/Formatter test/sun/util/resources/TimeZone test/closed/java/text/Format/DateFormat test/closed/java/uti/Calendar From sean.coffey at oracle.com Tue Nov 25 12:36:39 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 25 Nov 2014 12:36:39 +0000 Subject: [7u-dev] Request for approval: 8064560: (tz) Support tzdata2014j In-Reply-To: <547471DD.3050807@oracle.com> References: <547471DD.3050807@oracle.com> Message-ID: <547477D7.7050205@oracle.com> Approved. regards, Sean. On 25/11/2014 12:11, Aleksej Efimov wrote: > Hello, > Please, approve a backport of tzdata2014j related changes to > jdk7u-dev. The JDK8 fix applies cleanly with unshuffled path to tz > data storage (make/data/tzdata->make/sun/javazic/tzdata). Testing: > JPRT and JTREG [1] tests shows no tz related failures. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8064560 > JDK8 changeset: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/9c926f0dd726 > JDK9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029678.html > > > Thank you, > Aleksej > > [1] JTREG test sets executed: test/sun/util/resources/TimeZone > test/sun/util/calendar test/closed/java/util/TimeZone > test/java/util/TimeZone test/java/util/Calendar > test/java/util/Formatter test/sun/util/resources/TimeZone > test/closed/java/text/Format/DateFormat test/closed/java/uti/Calendar From aleksej.efimov at oracle.com Tue Nov 25 14:04:50 2014 From: aleksej.efimov at oracle.com (aleksej.efimov at oracle.com) Date: Tue, 25 Nov 2014 14:04:50 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8064560: (tz) Support tzdata2014j Message-ID: <201411251404.sAPE4ox9019997@aojmv0008> Changeset: a812404727c0 Author: aefimov Date: 2014-11-25 17:04 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/a812404727c0 8064560: (tz) Support tzdata2014j Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/southamerica From ivan.gerasimov at oracle.com Wed Nov 26 11:36:00 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 26 Nov 2014 14:36:00 +0300 Subject: [7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection Message-ID: <5475BB20.4000506@oracle.com> Hello! Would you please approve the (almost) direct backport from jdk 8u to 7u? The difference, comparing to 8u changeset, is due to change in Class.java, (which is already there in 8) and in GenericDeclRepository.java due to genericification. The patch is essentially the same as the one proposed by Martin in the bug summary. Bug: https://bugs.openjdk.java.net/browse/JDK-8064391 Webrev: http://cr.openjdk.java.net/~igerasim/8064391/0/webrev/ Sincerely yours, Ivan From sean.coffey at oracle.com Wed Nov 26 11:59:56 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 26 Nov 2014 11:59:56 +0000 Subject: [7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection In-Reply-To: <5475BB20.4000506@oracle.com> References: <5475BB20.4000506@oracle.com> Message-ID: <5475C0BC.5050009@oracle.com> Thanks for handling this Ivan. Looks good to me. Hopefully you can get another reviewer. Approved. regards, Sean. On 26/11/14 11:36, Ivan Gerasimov wrote: > Hello! > > Would you please approve the (almost) direct backport from jdk 8u to 7u? > > The difference, comparing to 8u changeset, is due to change in > Class.java, (which is already there in 8) and in > GenericDeclRepository.java due to genericification. > > The patch is essentially the same as the one proposed by Martin in the > bug summary. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8064391 > Webrev: http://cr.openjdk.java.net/~igerasim/8064391/0/webrev/ > > Sincerely yours, > Ivan > From martinrb at google.com Wed Nov 26 15:41:38 2014 From: martinrb at google.com (Martin Buchholz) Date: Wed, 26 Nov 2014 07:41:38 -0800 Subject: [7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection In-Reply-To: <5475BB20.4000506@oracle.com> References: <5475BB20.4000506@oracle.com> Message-ID: Approved! On Wed, Nov 26, 2014 at 3:36 AM, Ivan Gerasimov wrote: > Hello! > > Would you please approve the (almost) direct backport from jdk 8u to 7u? > > The difference, comparing to 8u changeset, is due to change in Class.java, > (which is already there in 8) and in GenericDeclRepository.java due to > genericification. > > The patch is essentially the same as the one proposed by Martin in the bug > summary. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8064391 > Webrev: http://cr.openjdk.java.net/~igerasim/8064391/0/webrev/ > > Sincerely yours, > Ivan > From erik.gahlin at oracle.com Wed Nov 26 17:35:57 2014 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Wed, 26 Nov 2014 18:35:57 +0100 Subject: [7u-dev] Request for approval: 8065909: test/sun/tools/jconsole/ImmutableResourceTest.sh failing Message-ID: <54760F7D.5090203@oracle.com> [7u-dev] Request for approval for CR 8020675 - invalid jar file in the bootclasspath could lead to jvm fatal error Hi, Could you please approve a backport of a JDK8 test fix. Patch didn't apply cleanly, but JDK8 fix was a complete rewrite (from hard coded strings to a reflection mechanism) so code could be copied as is, except: - update copyright year to 2014 - leave out AIX from OS check, as I believe it's not available in JDK 7 - sun/tools/jconsole/ImmutableResourceTest.sh was already removed from JDK 7 ProblemList.txt Thanks Erik Bug: https://bugs.openjdk.java.net/browse/JDK-8065909 Webrev: JDK7: http://cr.openjdk.java.net/~egahlin/8065909/ Webrev: JDK8: http://cr.openjdk.java.net/~egahlin/7172176_3/ Review: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-June/006272.html From erik.gahlin at oracle.com Wed Nov 26 17:40:43 2014 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Wed, 26 Nov 2014 18:40:43 +0100 Subject: [7u-dev] Request for approval: 8065909: test/sun/tools/jconsole/ImmutableResourceTest.sh failing In-Reply-To: <54760F7D.5090203@oracle.com> References: <54760F7D.5090203@oracle.com> Message-ID: <5476109B.6010800@oracle.com> Please ignore first part, copy and paste error from a previous approval. Thanks Erik Erik Gahlin skrev 2014-11-26 18:35: > [7u-dev] Request for approval for CR 8020675 - invalid jar file in the > bootclasspath could lead to jvm fatal error Hi, > > Could you please approve a backport of a JDK8 test fix. Patch didn't > apply cleanly, but JDK8 fix was a complete rewrite (from hard coded > strings to a reflection mechanism) so code could be copied as is, except: > > - update copyright year to 2014 > - leave out AIX from OS check, as I believe it's not available in JDK 7 > - sun/tools/jconsole/ImmutableResourceTest.sh was already removed from > JDK 7 ProblemList.txt > > Thanks > Erik > > Bug: https://bugs.openjdk.java.net/browse/JDK-8065909 > Webrev: JDK7: http://cr.openjdk.java.net/~egahlin/8065909/ > Webrev: JDK8: http://cr.openjdk.java.net/~egahlin/7172176_3/ > Review: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-June/006272.html From ivan.gerasimov at oracle.com Wed Nov 26 17:48:54 2014 From: ivan.gerasimov at oracle.com (ivan.gerasimov at oracle.com) Date: Wed, 26 Nov 2014 17:48:54 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8064391: More thread safety problems in core reflection Message-ID: <201411261748.sAQHmsXu022482@aojmv0008> Changeset: 4728d748209d Author: igerasim Date: 2014-11-26 20:47 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/4728d748209d 8064391: More thread safety problems in core reflection Summary: Make fields final or volatile to ensure thread safety Reviewed-by: jfranck ! src/share/classes/java/lang/Class.java ! src/share/classes/sun/reflect/generics/factory/CoreReflectionFactory.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/LazyReflectiveObjectGenerator.java ! src/share/classes/sun/reflect/generics/repository/AbstractRepository.java ! src/share/classes/sun/reflect/generics/repository/ClassRepository.java ! src/share/classes/sun/reflect/generics/repository/GenericDeclRepository.java ! src/share/classes/sun/reflect/generics/scope/AbstractScope.java ! src/share/classes/sun/reflect/generics/tree/ClassSignature.java From rob.mckenna at oracle.com Wed Nov 26 18:48:29 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 26 Nov 2014 18:48:29 +0000 Subject: [7u-dev] Request for approval: 8065909: test/sun/tools/jconsole/ImmutableResourceTest.sh failing In-Reply-To: <5476109B.6010800@oracle.com> References: <54760F7D.5090203@oracle.com> <5476109B.6010800@oracle.com> Message-ID: <5476207D.2060409@oracle.com> You seem to be using the backport id. Please use the master id with the push. Approved assuming the test passes! -Rob On 26/11/14 17:40, Erik Gahlin wrote: > Please ignore first part, copy and paste error from a previous approval. > > Thanks > Erik > > Erik Gahlin skrev 2014-11-26 18:35: >> [7u-dev] Request for approval for CR 8020675 - invalid jar file in >> the bootclasspath could lead to jvm fatal error Hi, >> >> Could you please approve a backport of a JDK8 test fix. Patch didn't >> apply cleanly, but JDK8 fix was a complete rewrite (from hard coded >> strings to a reflection mechanism) so code could be copied as is, >> except: >> >> - update copyright year to 2014 >> - leave out AIX from OS check, as I believe it's not available in JDK 7 >> - sun/tools/jconsole/ImmutableResourceTest.sh was already removed >> from JDK 7 ProblemList.txt >> >> Thanks >> Erik >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8065909 >> Webrev: JDK7: http://cr.openjdk.java.net/~egahlin/8065909/ >> Webrev: JDK8: http://cr.openjdk.java.net/~egahlin/7172176_3/ >> Review: >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-June/006272.html > From erik.gahlin at oracle.com Wed Nov 26 19:07:15 2014 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Wed, 26 Nov 2014 20:07:15 +0100 Subject: [7u-dev] Request for approval: 8065909: test/sun/tools/jconsole/ImmutableResourceTest.sh failing In-Reply-To: <5476207D.2060409@oracle.com> References: <54760F7D.5090203@oracle.com> <5476109B.6010800@oracle.com> <5476207D.2060409@oracle.com> Message-ID: <547624E3.8020704@oracle.com> Thanks, push will be with master id. Passes tests on all platforms. Erik Rob McKenna skrev 2014-11-26 19:48: > You seem to be using the backport id. Please use the master id with > the push. > > Approved assuming the test passes! > > -Rob > > On 26/11/14 17:40, Erik Gahlin wrote: >> Please ignore first part, copy and paste error from a previous approval. >> >> Thanks >> Erik >> >> Erik Gahlin skrev 2014-11-26 18:35: >>> [7u-dev] Request for approval for CR 8020675 - invalid jar file in >>> the bootclasspath could lead to jvm fatal error Hi, >>> >>> Could you please approve a backport of a JDK8 test fix. Patch didn't >>> apply cleanly, but JDK8 fix was a complete rewrite (from hard coded >>> strings to a reflection mechanism) so code could be copied as is, >>> except: >>> >>> - update copyright year to 2014 >>> - leave out AIX from OS check, as I believe it's not available in JDK 7 >>> - sun/tools/jconsole/ImmutableResourceTest.sh was already removed >>> from JDK 7 ProblemList.txt >>> >>> Thanks >>> Erik >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8065909 >>> Webrev: JDK7: http://cr.openjdk.java.net/~egahlin/8065909/ >>> Webrev: JDK8: http://cr.openjdk.java.net/~egahlin/7172176_3/ >>> Review: >>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-June/006272.html >> > From rob.mckenna at oracle.com Wed Nov 26 20:19:07 2014 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Wed, 26 Nov 2014 20:19:07 +0000 Subject: hg: jdk7u/jdk7u-dev/langtools: 8065674: javac generates incorrect LVT table for trivial cases Message-ID: <201411262019.sAQKJ7Tg022742@aojmv0008> Changeset: 979f55cda0e2 Author: robm Date: 2014-11-26 17:03 +0000 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/979f55cda0e2 8065674: javac generates incorrect LVT table for trivial cases Reviewed-by: jjg Contributed-by: vicente.romero at oracle.com ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java + test/tools/javac/flow/DARanges.java + test/tools/javac/flow/LVTHarness.java + test/tools/javac/flow/tests/TestCaseConditional.java + test/tools/javac/flow/tests/TestCaseDoLoop.java + test/tools/javac/flow/tests/TestCaseFor.java + test/tools/javac/flow/tests/TestCaseForEach.java + test/tools/javac/flow/tests/TestCaseIf.java + test/tools/javac/flow/tests/TestCaseIfElse.java + test/tools/javac/flow/tests/TestCaseLocalInInnerBlock.java + test/tools/javac/flow/tests/TestCaseSwitch.java + test/tools/javac/flow/tests/TestCaseTry.java + test/tools/javac/flow/tests/TestCaseWhile.java From jaroslav.bachorik at oracle.com Thu Nov 27 12:29:29 2014 From: jaroslav.bachorik at oracle.com (jaroslav.bachorik at oracle.com) Date: Thu, 27 Nov 2014 12:29:29 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 7172176: test/sun/tools/jconsole/ImmutableResourceTest.sh failing Message-ID: <201411271229.sARCTThL003402@aojmv0008> Changeset: af7c2b5cd307 Author: egahlin Date: 2014-11-27 04:24 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/af7c2b5cd307 7172176: test/sun/tools/jconsole/ImmutableResourceTest.sh failing Reviewed-by: mchung, mfang ! test/ProblemList.txt ! test/sun/tools/jconsole/ResourceCheckTest.java ! test/sun/tools/jconsole/ResourceCheckTest.sh From ivan.gerasimov at oracle.com Thu Nov 27 12:45:37 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Thu, 27 Nov 2014 15:45:37 +0300 Subject: [7u-dev] Request for Approval: 8001579: Cleanup warnings in security native code Message-ID: <54771CF1.3080402@oracle.com> Hello! Would you please give me an approval to backport the fix for JDK-8001579? I have a strong belief this will fix an 'access violation' bug JDK-8049839 that was reported several times for jdk7. The patch applies cleanly. BUG: https://bugs.openjdk.java.net/browse/JDK-8001579 Jdk8 change: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/59e88d3b9b17 Review: http://mail.openjdk.java.net/pipermail/security-dev/2012-November/005903.html Sincerely yours, Ivan From sean.coffey at oracle.com Thu Nov 27 12:55:54 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 27 Nov 2014 12:55:54 +0000 Subject: [7u-dev] Request for Approval: 8001579: Cleanup warnings in security native code In-Reply-To: <54771CF1.3080402@oracle.com> References: <54771CF1.3080402@oracle.com> Message-ID: <54771F5A.1060306@oracle.com> Approved. regards, Sean. On 27/11/2014 12:45, Ivan Gerasimov wrote: > Hello! > > Would you please give me an approval to backport the fix for JDK-8001579? > > I have a strong belief this will fix an 'access violation' bug > JDK-8049839 that was reported several times for jdk7. > > The patch applies cleanly. > > BUG: https://bugs.openjdk.java.net/browse/JDK-8001579 > Jdk8 change: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/59e88d3b9b17 > Review: > http://mail.openjdk.java.net/pipermail/security-dev/2012-November/005903.html > > Sincerely yours, > Ivan From ivan.gerasimov at oracle.com Thu Nov 27 17:23:24 2014 From: ivan.gerasimov at oracle.com (ivan.gerasimov at oracle.com) Date: Thu, 27 Nov 2014 17:23:24 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8001579: Cleanup warnings in security native code Message-ID: <201411271723.sARHNPJs005941@aojmv0008> Changeset: b2a3cf632477 Author: igerasim Date: 2014-11-27 20:22 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b2a3cf632477 8001579: Cleanup warnings in security native code Reviewed-by: chegar, alanb, vinnie ! src/share/native/sun/security/jgss/wrapper/GSSLibStub.c ! src/share/native/sun/security/jgss/wrapper/NativeUtil.c ! src/share/native/sun/security/pkcs11/wrapper/p11_convert.c ! src/share/native/sun/security/pkcs11/wrapper/p11_crypt.c ! src/share/native/sun/security/pkcs11/wrapper/p11_digest.c ! src/share/native/sun/security/pkcs11/wrapper/p11_general.c ! src/share/native/sun/security/pkcs11/wrapper/p11_sessmgmt.c ! src/share/native/sun/security/pkcs11/wrapper/p11_sign.c ! src/share/native/sun/security/pkcs11/wrapper/p11_util.c ! src/solaris/native/sun/security/pkcs11/j2secmod_md.c ! src/solaris/native/sun/security/pkcs11/wrapper/p11_md.c From ivan.gerasimov at oracle.com Fri Nov 28 13:37:59 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 28 Nov 2014 16:37:59 +0300 Subject: [7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection Message-ID: <54787AB7.2070604@oracle.com> Hello! Would you please approve the backport from jdk 8u to 7u? The patch didn't apply cleanly due to generics in these two files: src/share/classes/sun/reflect/BootstrapConstructorAccessorImpl.java src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java All the other changes are identical. Bug: https://bugs.openjdk.java.net/browse/JDK-8062771 Jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1e5c2bd424d5 Jdk 8u changeset: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/fc4f55464170 Webrev: http://cr.openjdk.java.net/~igerasim/8062771/1/webrev/ Jdk 9 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029485.html Jdk 8u Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029901.html Sincerely yours, Ivan From sean.coffey at oracle.com Fri Nov 28 14:10:15 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 28 Nov 2014 14:10:15 +0000 Subject: [7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection In-Reply-To: <54787AB7.2070604@oracle.com> References: <54787AB7.2070604@oracle.com> Message-ID: <54788247.1090507@oracle.com> Looks fine to me Ivan. Please get jdk7u reviewer to review. Approved. regards, Sean. On 28/11/2014 13:37, Ivan Gerasimov wrote: > Hello! > > Would you please approve the backport from jdk 8u to 7u? > > The patch didn't apply cleanly due to generics in these two files: > src/share/classes/sun/reflect/BootstrapConstructorAccessorImpl.java > src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java > > All the other changes are identical. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062771 > Jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1e5c2bd424d5 > Jdk 8u changeset: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/fc4f55464170 > Webrev: http://cr.openjdk.java.net/~igerasim/8062771/1/webrev/ > Jdk 9 Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029485.html > Jdk 8u Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029901.html > > Sincerely yours, > Ivan > > > From martinrb at google.com Fri Nov 28 18:08:23 2014 From: martinrb at google.com (Martin Buchholz) Date: Fri, 28 Nov 2014 10:08:23 -0800 Subject: [7u-dev] Request for Review + Request for Approval to Backport: 8064391: More thread safety problems in core reflection In-Reply-To: <54787AB7.2070604@oracle.com> References: <54787AB7.2070604@oracle.com> Message-ID: Approved! On Fri, Nov 28, 2014 at 5:37 AM, Ivan Gerasimov wrote: > Hello! > > Would you please approve the backport from jdk 8u to 7u? > > The patch didn't apply cleanly due to generics in these two files: > src/share/classes/sun/reflect/BootstrapConstructorAccessorImpl.java > src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java > > All the other changes are identical. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062771 > Jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1e5c2bd424d5 > Jdk 8u changeset: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/fc4f55464170 > Webrev: http://cr.openjdk.java.net/~igerasim/8062771/1/webrev/ > Jdk 9 Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029485.html > Jdk 8u Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029901.html > > Sincerely yours, > Ivan > > > From ivan.gerasimov at oracle.com Fri Nov 28 20:23:25 2014 From: ivan.gerasimov at oracle.com (ivan.gerasimov at oracle.com) Date: Fri, 28 Nov 2014 20:23:25 +0000 Subject: hg: jdk7u/jdk7u-dev/jdk: 8062771: Core reflection should use final fields whenever possible Message-ID: <201411282023.sASKNPPw011762@aojmv0008> Changeset: 5c00040ffa9c Author: igerasim Date: 2014-11-28 23:21 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/5c00040ffa9c 8062771: Core reflection should use final fields whenever possible Reviewed-by: martin, jfranck ! src/share/classes/sun/reflect/BootstrapConstructorAccessorImpl.java ! src/share/classes/sun/reflect/InstantiationExceptionConstructorAccessorImpl.java ! src/share/classes/sun/reflect/Label.java ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java ! src/share/classes/sun/reflect/NativeMethodAccessorImpl.java ! src/share/classes/sun/reflect/ReflectionFactory.java ! src/share/classes/sun/reflect/SignatureIterator.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/GenericArrayTypeImpl.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ! src/share/classes/sun/reflect/generics/scope/DummyScope.java ! src/share/classes/sun/reflect/generics/tree/ArrayTypeSignature.java ! src/share/classes/sun/reflect/generics/tree/BooleanSignature.java ! src/share/classes/sun/reflect/generics/tree/BottomSignature.java ! src/share/classes/sun/reflect/generics/tree/ByteSignature.java ! src/share/classes/sun/reflect/generics/tree/CharSignature.java ! src/share/classes/sun/reflect/generics/tree/ClassTypeSignature.java ! src/share/classes/sun/reflect/generics/tree/DoubleSignature.java ! src/share/classes/sun/reflect/generics/tree/FloatSignature.java ! src/share/classes/sun/reflect/generics/tree/FormalTypeParameter.java ! src/share/classes/sun/reflect/generics/tree/IntSignature.java ! src/share/classes/sun/reflect/generics/tree/LongSignature.java ! src/share/classes/sun/reflect/generics/tree/MethodTypeSignature.java ! src/share/classes/sun/reflect/generics/tree/ShortSignature.java ! src/share/classes/sun/reflect/generics/tree/SimpleClassTypeSignature.java ! src/share/classes/sun/reflect/generics/tree/TypeVariableSignature.java ! src/share/classes/sun/reflect/generics/tree/VoidDescriptor.java ! src/share/classes/sun/reflect/misc/MethodUtil.java + test/java/lang/reflect/Generics/ThreadSafety.java