[PATCH] macosx build fix

Andrew Hughes gnu.andrew at redhat.com
Thu Aug 27 17:07:19 UTC 2015



----- Original Message -----
> Hi Andrew,
> 
> On 08/27/2015 04:49 PM, Andrew Hughes wrote:
> >
> >
> > ----- Original Message -----
> >> Hi Andrew,
> >>
> >> On 08/26/2015 03:56 PM, Andrew Hughes wrote:
> >>> ----- Original Message -----
> >>>> Hi,
> >>>>
> >>>> jdk7 build is currently broken on Mac, this patch fixes it:
> >>>>
> >>>> diff -r 334ea703b2f0 make/sun/lwawt/FILES_export_macosx.gmk
> >>>> --- a/make/sun/lwawt/FILES_export_macosx.gmk	Sat Aug 22 01:24:45 2015
> >>>> +0100
> >>>> +++ b/make/sun/lwawt/FILES_export_macosx.gmk	Mon Aug 24 18:53:41 2015
> >>>> +0300
> >>>> @@ -156,7 +156,7 @@
> >>>>             sun/lwawt/macosx/LWCToolkit.java \
> >>>>             sun/lwawt/macosx/CInputMethod.java \
> >>>>             sun/lwawt/macosx/CInputMethodDescriptor.java \
> >>>> -        sun/lwawt/macosx/event/NSEvent.java \
> >>>> +        sun/lwawt/macosx/NSEvent.java \
> >>>>             \
> >>>>             sun/awt/DebugSettings.java \
> >>>>             sun/awt/EmbeddedFrame.java \
> >>>>
> >>>> Please let me know if JBS issue or any other follow-up is required from
> >>>> me.
> >>>>
> >>>> --
> >>>> -Alex
> >>>>
> >>>
> >>> This needs an OpenJDK bug ID, then you're ok to push it to the 7u tree.
> >>> List me as the reviewer.
> >>
> >> I created JDK-8134610 (copying metadata from JDK-8133990 that is
> >> similar). I am not an author on jdk7u project (will need at least two
> >> sponsored jdk7u contributions to become one) so I cannot export a
> >> changeset. Thanks.
> >
> > aph can make you an author; see http://openjdk.java.net/bylaws#project-lead
> 
> I need at least two sponsored jdk7u contributions to apply for an Author
> status, currently have zero.

No, you don't. aph can simply appoint you.

> 
> > You can't push a changeset right now, but I see no reason you can't create
> > the
> > changeset and post a webrev, so one of us can commit it on your behalf.
> 
> I cannot create a mercurial changeset under my name, sponsor needs to
> create a changeset under his name and place contributor name under
> "Contributed-by:".
> 
> Uploaded webrev - http://cr.openjdk.java.net/~akasko/jdk7u/macfix/webrev/
> 

That's for people without an OpenJDK account. You have one.

Pushed: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/3bf99e4002e2

> Thanks.
> 
> --
> -Alex
> 

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07



More information about the jdk7u-dev mailing list