Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

Seán Coffey sean.coffey at oracle.com
Fri Jan 30 12:18:18 UTC 2015


Alan,

hadn't spotted the race issue. I guess we could delay setting 
ver_initialized until OSVERSIONINFO is populated.
Alternatively - like you say, I think we can revert back to the simpler 
edit :

http://cr.openjdk.java.net/~coffeys/webrev.8060170.7u.v2/webrev/
I'll run with this version unless I hear objections.

regards,
Sean.

On 29/01/2015 17:31, Alan Bateman wrote:
> On 26/01/2015 13:48, Seán Coffey wrote:
>> Valeriy,
>>
>> those changes look fine to me and I've verified that they run through 
>> testing fine also. webrev here for reference :
>> http://cr.openjdk.java.net/~coffeys/webrev.8060170.7u.v3/webrev/
>>
>> Can I have a jdk7u reviewer for this change ?
>>
> There is a race in socket0 with the OS version check. Would it be 
> simpler to drop that just have WASOPNOTSUPP and WSAEINVAL cause the 
> option to be disabled?
>
> -Alan



More information about the jdk7u-dev mailing list