[PATCH] jdk7u91-b01 retro-active security patch review

[Andrew Hughes]

----- Original Message -----
> Unanswered patch on webrev-dev looks related:
> http://mail.openjdk.java.net/pipermail/webrev-dev/2015-November/000134.html
> 
> My own old copy of webrev is working for me, so I dare not touch it!
> 
> ---

Yep, I found the same thing digging into the script a bit myself. The semantics
of --follow have indeed changed. For index.html, the script produces hg calls like:

hg log --follow  --rev 114 --rev 115 --rev 116 --rev 117 --rev 118 --rev 119 --rev 120 --rev 121 --rev 122 --rev 123 --template 'rev {rev} : {desc}' .hgtags

which, on both Mercurial 3.4.2 (the version I had before) and 3.6.1 (the one I
just upgraded to), the --follow causes it to ignore the revisions and just print
the whole history of the file. Dropping it makes it work as it should and the
webrevs I just posted for 6 [0] look a lot better. It was previously used to
follow files across renames, and I even had it turned on by default for that
reason, but they changed the semantics in Mercurial.  I think I'd rather it
was right for most files and the odd history from a moved file was missing.
It seems unlikely someone would alter a file and then move it in the same
set of changesets anyway.

If it's working for you, you must have an older version of Mercurial. It may
also be that it only shows up when working with committed changesets. I suspect
our case of doing a webrev for tens of committed changesets is far less common
than ones created for changes still in the working tree ;)

I'll see if I can resurrect that thread. I didn't even realise it had its own
mailing list. Good find!

> Thanks for your work on jdk7u91 - we are happily using it without problems!

You're welcome. This is great to hear! :-D

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07