Request for Approval: 4858370: JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

[Severin Gehwolf]

On Mon, 2016-04-11 at 09:40 -0400, Andrew Hughes wrote:
> ----- Original Message -----
> > 
> > On Wed, 2016-04-06 at 13:33 -0400, Andrew Hughes wrote:
> > > 
> > > 
> > > ----- Original Message -----
> > > > 
> > > > 
> > > > On Mon, 2016-04-04 at 13:41 -0400, Andrew Hughes wrote:
> > > > > 
> > > > > 
> > > > > 
> > > > > ----- Original Message -----
> > > > > > 
> > > > > > 
> > > > > > 
> > > > > > Hi,
> > > > > > 
> > > > > > Please approve and sponsor the following backport for JDK-4858370 to
> > > > > > JDK 7u-dev. It's the same patch as went into JDK 8. It only differs
> > > > > > from the 9 version in the test and in the same way as JDK 8's version
> > > > > > differed from 9.
> > > > > > 
> > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-4858370
> > > > > > webrev:
> > > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-4858370/webrev.jdk7.01/
> > > > > > hg-export:
> > > > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-4858370/JDK-4858370-jdk8-jdk.export.patch
> > > > > > 
> > > > > > Original review thread for JDK 9 is here:
> > > > > > http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-March/019155.html
> > > > > > 
> > > > > > JDK 8 backport request thread is here:
> > > > > > http://mail.openjdk.java.net/pipermail/jdk8u-dev/2016-March/005216.html
> > > > > > 
> > > > > > Please let me know if there are questions.
> > > > > > 
> > > > > > Thanks,
> > > > > > Severin
> > > > > > 
> > > > > Approved.
> > > > Thanks, Andrew!
> > > > 
> > > > I'd need somebody to push it for me, though.
> > > > 
> > > > Cheers,
> > > > Severin
> > > > 
> > > Done: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/a47eba38b96e
> > This fix has been backed out in 9[1] and is in progress of being backed
> > out in 8[2] due to test regressions. I think we should do the same in
> > 7. Thoughts?
> > 
> > Thanks,
> > Severin
> > 
> > [1] https://bugs.openjdk.java.net/browse/JDK-8153673
> > [2] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2016-April/005270.html
> > 
> I was thinking the same yesterday. I tend to agree, as we have a security
> update coming out in under two weeks.
> 
> Is there a backout bug ID and I'll push using that?

https://bugs.openjdk.java.net/browse/JDK-8153673 is the JDK 9 backout bug.

Cheers,
Severin

> Thanks,