RFA 8204142: AWT hang occurs when sequenced events arrive out of sequence in multiple AppContexts

[Andrew John Hughes]

On 02/04/2019 20:29, Martin Balao wrote:
> Hi Andrew,
> 
> Thanks for your review.
> 
> On 4/2/19 3:20 PM, Andrew John Hughes wrote:
>>
>> I think this should really be an addition of a Red Hat 2019 line.
>>
> 
> Tests were contributed by Oracle and an independent contributor. See
> "@author" tag. That's why they have an Oracle copyright.
> 

I'm aware of that.

I'm referring to the changes in
src/share/classes/java/awt/SequencedEvent.java.

>>>
>>>  * Missing @Override added to "evaluate" method
>>>
>>
>> There's a few missing on the run methods in the test cases too
>> (basically places where a lambda has had to be converted)
>>
> 
> Done. No one should be missing now (I counted 12 occurrences of lambda
> functions and 12 overrides).
> 

That looks good now.
>  *
> http://cr.openjdk.java.net/~mbalao/webrevs/8204142/8204142.webrev.06.jdk7u/
> 
> Thanks,
> Martin.-
> 

Add your copyright to the fix itself and I think this is good to go.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew