From serge.chernyshev at bell-sw.com Thu Dec 10 06:59:43 2020 From: serge.chernyshev at bell-sw.com (Sergey Chernyshev) Date: Thu, 10 Dec 2020 09:59:43 +0300 Subject: [7u] RFR 8035166: Remove dependency on EC classes from pkcs11 provider Message-ID: <0c19e0bf-19d3-6ab2-a4db-014b37d5600c@bell-sw.com> Dear colleagues, Please review the backport of JDK-8035166 to 7u. Bug: https://bugs.openjdk.java.net/browse/JDK-8035166 7u webrev: http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.00 jdk8u commit: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b8ad41e9571f 11u commit: https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/daa21271c03b The patch did not apply cleanly. Here's the summary of conflicts resolved, compared to 11u: * the patch doesn't apply to DOMKeyValue.java (the changed part removed in 8046724). * SupportedEllipticCurvesExtension.java is not present in 7u * context difference in ECKeyPairGenerator.java * sun.security.util.ArrayUtil needs to be imported in ECPrivateKeyImpl.java * copyright notes in SunECEntries, ECParameters, NamedCurve, CurveDB were updated The tests in jdk/test were run. This included the following security and crypto tests: com/sun/crypto/provider/* com/sun/security/* java/security/* javax/crypto/* javax/net/ssl/* javax/security/* javax/xml/crypto/* sun/security/* The are no new failures compared to the build without the fix. Thank you. -- Best regards, Sergey Chernyshev Bellsoft LLC From alexey at azul.com Fri Dec 11 10:17:14 2020 From: alexey at azul.com (Alexey Bakhtin) Date: Fri, 11 Dec 2020 10:17:14 +0000 Subject: [7u] RFR 8035166: Remove dependency on EC classes from pkcs11 provider Message-ID: <67405630-AB05-4992-A26C-B074475D0279@azul.com> Hello Serge, I see several issues with this patch: sun/security/ec/ECPrivateKeyImpl.java - ECUtil class is not referenced in the ECPrivateKeyImpl class. Import can be removed org/jcp/xml/dsig/internal/dom/DOMKeyValue.java - DomKeyValue class should be updated to instantiate ECParameters and NamedCurve classes in the correct namespace This class is modified in the original JDK9 patch [1] but missed in the JDK11 and JDK8 because of different XML Dsig implementation. [1] - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/87fac66a55b4 Regards Alexey From serge.chernyshev at bell-sw.com Fri Dec 11 14:12:37 2020 From: serge.chernyshev at bell-sw.com (Sergey Chernyshev) Date: Fri, 11 Dec 2020 17:12:37 +0300 Subject: [7u] RFR 8035166: Remove dependency on EC classes from pkcs11 provider In-Reply-To: <67405630-AB05-4992-A26C-B074475D0279@azul.com> References: <67405630-AB05-4992-A26C-B074475D0279@azul.com> Message-ID: Hello Alexey, Thanks for pointing this out. I updated the webrev here: http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.01/ Thank you. On 11.12.2020 13:17, Alexey Bakhtin wrote: > Hello Serge, > > I see several issues with this patch: > > sun/security/ec/ECPrivateKeyImpl.java > - ECUtil class is not referenced in the ECPrivateKeyImpl class. Import can be removed > > org/jcp/xml/dsig/internal/dom/DOMKeyValue.java > - DomKeyValue class should be updated to instantiate ECParameters and NamedCurve classes in the correct namespace > This class is modified in the original JDK9 patch [1] but missed in the JDK11 and JDK8 because of different XML Dsig implementation. > > [1] - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/87fac66a55b4 > > Regards > Alexey -- Best regards, Sergey Chernyshev Bellsoft LLC From alexey at azul.com Fri Dec 11 14:46:47 2020 From: alexey at azul.com (Alexey Bakhtin) Date: Fri, 11 Dec 2020 14:46:47 +0000 Subject: [7u] RFR 8035166: Remove dependency on EC classes from pkcs11 provider In-Reply-To: References: <67405630-AB05-4992-A26C-B074475D0279@azul.com> Message-ID: Looks good to me now. Thank you Alexey > On 11 Dec 2020, at 17:12, Sergey Chernyshev wrote: > > Hello Alexey, > > Thanks for pointing this out. I updated the webrev here: > > http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.01/ > > Thank you. > > > On 11.12.2020 13:17, Alexey Bakhtin wrote: >> Hello Serge, >> >> I see several issues with this patch: >> >> sun/security/ec/ECPrivateKeyImpl.java >> - ECUtil class is not referenced in the ECPrivateKeyImpl class. Import can be removed >> >> org/jcp/xml/dsig/internal/dom/DOMKeyValue.java >> - DomKeyValue class should be updated to instantiate ECParameters and NamedCurve classes in the correct namespace >> This class is modified in the original JDK9 patch [1] but missed in the JDK11 and JDK8 because of different XML Dsig implementation. >> >> [1] - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/87fac66a55b4 >> >> Regards >> Alexey > > -- > Best regards, > Sergey Chernyshev > Bellsoft LLC From abrygin at azul.com Fri Dec 11 15:37:23 2020 From: abrygin at azul.com (Andrew Brygin) Date: Fri, 11 Dec 2020 18:37:23 +0300 Subject: [7u] RFR 8035166: Remove dependency on EC classes from pkcs11 provider In-Reply-To: References: <67405630-AB05-4992-A26C-B074475D0279@azul.com> Message-ID: <936a6b49-94ad-0ce6-43ad-88e57fd9b19f@azul.com> Hello, Alexey, thank you for the review. Sergey, thank you for contributing the fix. Before you push this change in 7u, could you please clarify the purpose of this backport? Do you plan to backport any followup fixes into 7u? Do you have any assessment whether any third-party software could be affected by this change? Thanks, Andrew On 11/12/2020 17:46, Alexey Bakhtin wrote: > Looks good to me now. > > Thank you > Alexey > >> On 11 Dec 2020, at 17:12, Sergey Chernyshev wrote: >> >> Hello Alexey, >> >> Thanks for pointing this out. I updated the webrev here: >> >> http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.01/ >> >> Thank you. >> >> >> On 11.12.2020 13:17, Alexey Bakhtin wrote: >>> Hello Serge, >>> >>> I see several issues with this patch: >>> >>> sun/security/ec/ECPrivateKeyImpl.java >>> - ECUtil class is not referenced in the ECPrivateKeyImpl class. Import can be removed >>> >>> org/jcp/xml/dsig/internal/dom/DOMKeyValue.java >>> - DomKeyValue class should be updated to instantiate ECParameters and NamedCurve classes in the correct namespace >>> This class is modified in the original JDK9 patch [1] but missed in the JDK11 and JDK8 because of different XML Dsig implementation. >>> >>> [1] - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/87fac66a55b4 >>> >>> Regards >>> Alexey >> >> -- >> Best regards, >> Sergey Chernyshev >> Bellsoft LLC > From serge.chernyshev at bell-sw.com Fri Dec 11 20:46:47 2020 From: serge.chernyshev at bell-sw.com (Sergey Chernyshev) Date: Fri, 11 Dec 2020 23:46:47 +0300 Subject: [7u] RFR 8035166: Remove dependency on EC classes from pkcs11 provider In-Reply-To: <936a6b49-94ad-0ce6-43ad-88e57fd9b19f@azul.com> References: <67405630-AB05-4992-A26C-B074475D0279@azul.com> <936a6b49-94ad-0ce6-43ad-88e57fd9b19f@azul.com> Message-ID: <9170a0ca-723b-d10f-6831-5c4eb6373dd9@bell-sw.com> Hello Andrew, The main goal is to backport JDK-8233228 to 7u, which depends on this issue. The same fix was pushed earlier this week to 8u: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b8ad41e9571f I am not aware of any 3rd party software that can be affected by the change. This seems unlikely that the classes moved from sunec.jar to rt.jar are accessed from anywhere outside OpenJDK. Alexey, thank you for review. On 11.12.2020 18:37, Andrew Brygin wrote: > Hello, > > Alexey, thank you for the review. > > Sergey, thank you for contributing the fix. Before you push this change > in 7u, could you please clarify the purpose of this backport? Do you > plan to backport any followup fixes into 7u? Do you have any assessment > whether any third-party software could be affected by this change? > > Thanks, > Andrew > > On 11/12/2020 17:46, Alexey Bakhtin wrote: >> Looks good to me now. >> >> Thank you >> Alexey >> >>> On 11 Dec 2020, at 17:12, Sergey Chernyshev wrote: >>> >>> Hello Alexey, >>> >>> Thanks for pointing this out. I updated the webrev here: >>> >>> http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.01/ >>> >>> Thank you. >>> >>> >>> On 11.12.2020 13:17, Alexey Bakhtin wrote: >>>> Hello Serge, >>>> >>>> I see several issues with this patch: >>>> >>>> sun/security/ec/ECPrivateKeyImpl.java >>>> - ECUtil class is not referenced in the ECPrivateKeyImpl class. Import can be removed >>>> >>>> org/jcp/xml/dsig/internal/dom/DOMKeyValue.java >>>> - DomKeyValue class should be updated to instantiate ECParameters and NamedCurve classes in the correct namespace >>>> This class is modified in the original JDK9 patch [1] but missed in the JDK11 and JDK8 because of different XML Dsig implementation. >>>> >>>> [1] - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/87fac66a55b4 >>>> >>>> Regards >>>> Alexey >>> -- >>> Best regards, >>> Sergey Chernyshev >>> Bellsoft LLC -- Best regards, Sergey Chernyshev Bellsoft LLC From dcherepanov at azul.com Mon Dec 14 18:12:29 2020 From: dcherepanov at azul.com (Dmitry Cherepanov) Date: Mon, 14 Dec 2020 21:12:29 +0300 Subject: [7u] RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b Message-ID: <6341d5df-263a-ae08-8ed8-582602117d0e@azul.com> Please review the backport for 8254177 to 7u. Bug: https://bugs.openjdk.java.net/browse/JDK-8254177 8u commit: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/93840580183a Webrev: http://cr.openjdk.java.net/~dcherepanov/openjdk7u/8254177/webrev.v1/ The patch for 8u doesn't apply cleanly to 7u. The following modifications were done: 1) adjusted paths for tzdata files (make/data/tzdata -> make/sun/javazic/tzdata) 2) adjusted paths for resource files ??? (src/share/classes/sun/util/resources/[de | es | fr | ?] -> src/share/classes/sun/util/resources) 3) ignored changes in files:? src/aix/lib/tzmappings and test/sun/util/calendar/* 4) updated the list of tzdata files in make/sun/javazic/Makefile (excluded pacificnew/systemv) Sanity checked that there's no references left in the code to the removed files pacificnew/systemv and the removed timezone US/Pacific-New. Ran relevant regression tests, not issues found. Thanks, Dmitry P.S. RFRs for updates to tzdata2020c/tzdata2020d will be submitted separately. From dcherepanov at azul.com Tue Dec 15 14:34:59 2020 From: dcherepanov at azul.com (Dmitry Cherepanov) Date: Tue, 15 Dec 2020 17:34:59 +0300 Subject: [7u] RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c Message-ID: Bug: https://bugs.openjdk.java.net/browse/JDK-8254982 8u commit: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/25cd39ef5b98 Webrev: http://cr.openjdk.java.net/~dcherepanov/openjdk7u/8254982/webrev.v1/ The patch for 8u doesn't apply cleanly to 7u. The following modifications were done: 1) adjusted paths for tzdata files (make/data/tzdata -> make/sun/javazic/tzdata) 2) test/sun/util/calendar/* ??????? Not applicable to 7u Ran relevant regression tests (including BasicDateTime), not issues found. Thanks, Dmitry From dcherepanov at azul.com Tue Dec 15 14:37:23 2020 From: dcherepanov at azul.com (Dmitry Cherepanov) Date: Tue, 15 Dec 2020 17:37:23 +0300 Subject: [7u] RFR: 8255226: (tz) Upgrade time-zone data to tzdata2020d Message-ID: Bug: https://bugs.openjdk.java.net/browse/JDK-8255226 8u commit: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ef358e4669db Webrev: http://cr.openjdk.java.net/~dcherepanov/openjdk7u/8255226/webrev.v1/ The patch for 8u doesn't apply cleanly to 7u. The following modifications were done: 1) adjusted paths for tzdata files (make/data/tzdata -> make/sun/javazic/tzdata) 2) src/share/classes/sun/util/calendar/ZoneInfoFile.java ??? test/sun/util/calendar/* ??????? Not applicable to 7u Ran relevant regression tests, not issues found. Thanks, Dmitry From abrygin at azul.com Tue Dec 15 15:04:29 2020 From: abrygin at azul.com (Andrew Brygin) Date: Tue, 15 Dec 2020 18:04:29 +0300 Subject: [7u] RFR 8035166: Remove dependency on EC classes from pkcs11 provider In-Reply-To: <9170a0ca-723b-d10f-6831-5c4eb6373dd9@bell-sw.com> References: <67405630-AB05-4992-A26C-B074475D0279@azul.com> <936a6b49-94ad-0ce6-43ad-88e57fd9b19f@azul.com> <9170a0ca-723b-d10f-6831-5c4eb6373dd9@bell-sw.com> Message-ID: Hello Sergey, thanks for the clarification, I see that JDK-8035166 is a prerequisite for JDK-8233228. The 8u backport for JDK-8035166 has been pushed into jdk8u-dev, and has fixVersion openjdk8u292 (April 2021). Most likely, 8u backport of JDK-8233228 will be available in the same release. It would be natural that these fixes should appear in 7u only after 8u, in April 2021. Unfortunately, at the moment jdk7u does not have a dev repo to accumulate fixes for next release. If you do not mind, I would propose to postpone the push of JDK-8035166 to the April release cycle? What do you think? Thanks, Andrew On 11/12/2020 23:46, Sergey Chernyshev wrote: > Hello Andrew, > > The main goal is to backport JDK-8233228 to 7u, which depends on this issue. > > The same fix was pushed earlier this week to 8u: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b8ad41e9571f > > I am not aware of any 3rd party software that can be affected by the > change. This seems unlikely that the classes moved from sunec.jar to > rt.jar are accessed from anywhere outside OpenJDK. > > Alexey, thank you for review. > > > On 11.12.2020 18:37, Andrew Brygin wrote: >> Hello, >> >> Alexey, thank you for the review. >> >> Sergey, thank you for contributing the fix. Before you push this change >> in 7u, could you please clarify the purpose of this backport? Do you >> plan to backport any followup fixes into 7u? Do you have any assessment >> whether any third-party software could be affected by this change? >> >> Thanks, >> Andrew >> >> On 11/12/2020 17:46, Alexey Bakhtin wrote: >>> Looks good to me now. >>> >>> Thank you >>> Alexey >>> >>>> On 11 Dec 2020, at 17:12, Sergey Chernyshev wrote: >>>> >>>> Hello Alexey, >>>> >>>> Thanks for pointing this out. I updated the webrev here: >>>> >>>> http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.01/ >>>> >>>> Thank you. >>>> >>>> >>>> On 11.12.2020 13:17, Alexey Bakhtin wrote: >>>>> Hello Serge, >>>>> >>>>> I see several issues with this patch: >>>>> >>>>> sun/security/ec/ECPrivateKeyImpl.java >>>>> - ECUtil class is not referenced in the ECPrivateKeyImpl class. Import can be removed >>>>> >>>>> org/jcp/xml/dsig/internal/dom/DOMKeyValue.java >>>>> - DomKeyValue class should be updated to instantiate ECParameters and NamedCurve classes in the correct namespace >>>>> This class is modified in the original JDK9 patch [1] but missed in the JDK11 and JDK8 because of different XML Dsig implementation. >>>>> >>>>> [1] - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/87fac66a55b4 >>>>> >>>>> Regards >>>>> Alexey >>>> -- >>>> Best regards, >>>> Sergey Chernyshev >>>> Bellsoft LLC > From abrygin at azul.com Tue Dec 15 15:10:11 2020 From: abrygin at azul.com (Andrew Brygin) Date: Tue, 15 Dec 2020 18:10:11 +0300 Subject: [7u] RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b In-Reply-To: <6341d5df-263a-ae08-8ed8-582602117d0e@azul.com> References: <6341d5df-263a-ae08-8ed8-582602117d0e@azul.com> Message-ID: <5eab5cee-c687-ff8c-a134-0f89c3e7ff36@azul.com> Hello Dmitry, thanks for the backport. The change looks fine to me. Thanks, Andrew On 14/12/2020 21:12, Dmitry Cherepanov wrote: > Please review the backport for 8254177 to 7u. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8254177 > 8u commit: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/93840580183a > Webrev: > http://cr.openjdk.java.net/~dcherepanov/openjdk7u/8254177/webrev.v1/ > > The patch for 8u doesn't apply cleanly to 7u. The following > modifications were done: > > 1) adjusted paths for tzdata files (make/data/tzdata -> > make/sun/javazic/tzdata) > > 2) adjusted paths for resource files > ??? (src/share/classes/sun/util/resources/[de | es | fr | ?] -> > src/share/classes/sun/util/resources) > > 3) ignored changes in files:? src/aix/lib/tzmappings and > test/sun/util/calendar/* > > 4) updated the list of tzdata files in make/sun/javazic/Makefile > (excluded pacificnew/systemv) > > Sanity checked that there's no references left in the code to the > removed files pacificnew/systemv and the removed timezone US/Pacific-New. > > Ran relevant regression tests, not issues found. > > Thanks, > > Dmitry > > P.S. RFRs for updates to tzdata2020c/tzdata2020d will be submitted > separately. From abrygin at azul.com Tue Dec 15 19:41:29 2020 From: abrygin at azul.com (Andrew Brygin) Date: Tue, 15 Dec 2020 22:41:29 +0300 Subject: [7u] RFR: 8254982: (tz) Upgrade time-zone data to tzdata2020c In-Reply-To: References: Message-ID: <7432c14f-e0ba-5252-29f7-70a6470b650e@azul.com> Hello Dmitry, thanks for the backport. The change looks fine to me. Thanks, Andrew On 15/12/2020 17:34, Dmitry Cherepanov wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8254982 > 8u commit: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/25cd39ef5b98 > Webrev: > http://cr.openjdk.java.net/~dcherepanov/openjdk7u/8254982/webrev.v1/ > > The patch for 8u doesn't apply cleanly to 7u. The following > modifications were done: > > 1) adjusted paths for tzdata files (make/data/tzdata -> > make/sun/javazic/tzdata) > > 2) test/sun/util/calendar/* > ??????? Not applicable to 7u > > Ran relevant regression tests (including BasicDateTime), not issues found. > > Thanks, > > Dmitry From abrygin at azul.com Tue Dec 15 19:42:05 2020 From: abrygin at azul.com (Andrew Brygin) Date: Tue, 15 Dec 2020 22:42:05 +0300 Subject: [7u] RFR: 8255226: (tz) Upgrade time-zone data to tzdata2020d In-Reply-To: References: Message-ID: <3c4481a6-703d-370c-ddba-ca2031d555b2@azul.com> Hello Dmitry, thanks for the backport. The change looks fine to me. Thanks, Andrew On 15/12/2020 17:37, Dmitry Cherepanov wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8255226 > 8u commit: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ef358e4669db > Webrev: > http://cr.openjdk.java.net/~dcherepanov/openjdk7u/8255226/webrev.v1/ > > The patch for 8u doesn't apply cleanly to 7u. The following > modifications were done: > > 1) adjusted paths for tzdata files (make/data/tzdata -> > make/sun/javazic/tzdata) > > 2) src/share/classes/sun/util/calendar/ZoneInfoFile.java > ??? test/sun/util/calendar/* > ??????? Not applicable to 7u > > Ran relevant regression tests, not issues found. > > Thanks, > > Dmitry From dcherepanov at azul.com Wed Dec 16 10:31:28 2020 From: dcherepanov at azul.com (dcherepanov at azul.com) Date: Wed, 16 Dec 2020 10:31:28 +0000 Subject: hg: jdk7u/jdk7u/jdk: 3 new changesets Message-ID: <202012161031.0BGAVShP006994@aojmv0008.oracle.com> Changeset: 0ddce006f4ee Author: dcherepanov Date: 2020-12-16 13:19 +0300 URL: https://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/0ddce006f4ee 8254177: (tz) Upgrade time-zone data to tzdata2020b Summary: Remove obsolete systemv & pacificnew files and US/Pacific-New zone Reviewed-by: bae ! make/sun/javazic/Makefile ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/africa ! make/sun/javazic/tzdata/antarctica ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! make/sun/javazic/tzdata/leapseconds ! make/sun/javazic/tzdata/northamerica - make/sun/javazic/tzdata/pacificnew ! make/sun/javazic/tzdata/southamerica - make/sun/javazic/tzdata/systemv ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: 1518bb2996f5 Author: dcherepanov Date: 2020-12-03 16:43 +0000 URL: https://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/1518bb2996f5 8254982: (tz) Upgrade time-zone data to tzdata2020c Reviewed-by: bae ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/europe ! test/java/util/Formatter/BasicDateTime.java Changeset: 102b03f903a3 Author: dcherepanov Date: 2020-12-11 17:06 +0000 URL: https://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/102b03f903a3 8255226: (tz) Upgrade time-zone data to tzdata2020d Reviewed-by: bae ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/asia ! make/sun/javazic/tzdata/europe From dcherepanov at azul.com Wed Dec 16 10:34:27 2020 From: dcherepanov at azul.com (Dmitry Cherepanov) Date: Wed, 16 Dec 2020 13:34:27 +0300 Subject: [7u] RFR: 8255226: (tz) Upgrade time-zone data to tzdata2020d In-Reply-To: <3c4481a6-703d-370c-ddba-ca2031d555b2@azul.com> References: <3c4481a6-703d-370c-ddba-ca2031d555b2@azul.com> Message-ID: Thanks Andrew, pushed all three patches. Dmitry On 15.12.2020 22:42, Andrew Brygin wrote: > Hello Dmitry, > > thanks for the backport. The change looks fine to me. > > Thanks, > Andrew > > On 15/12/2020 17:37, Dmitry Cherepanov wrote: >> Bug: https://bugs.openjdk.java.net/browse/JDK-8255226 >> 8u commit: https://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ef358e4669db >> Webrev: >> http://cr.openjdk.java.net/~dcherepanov/openjdk7u/8255226/webrev.v1/ >> >> The patch for 8u doesn't apply cleanly to 7u. The following >> modifications were done: >> >> 1) adjusted paths for tzdata files (make/data/tzdata -> >> make/sun/javazic/tzdata) >> >> 2) src/share/classes/sun/util/calendar/ZoneInfoFile.java >> ??? test/sun/util/calendar/* >> ??????? Not applicable to 7u >> >> Ran relevant regression tests, not issues found. >> >> Thanks, >> >> Dmitry From gnu.andrew at redhat.com Wed Dec 16 20:42:00 2020 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 16 Dec 2020 20:42:00 +0000 Subject: [7u] RFR 8035166: Remove dependency on EC classes from pkcs11 provider In-Reply-To: References: <67405630-AB05-4992-A26C-B074475D0279@azul.com> <936a6b49-94ad-0ce6-43ad-88e57fd9b19f@azul.com> <9170a0ca-723b-d10f-6831-5c4eb6373dd9@bell-sw.com> Message-ID: <20201216204200.GG205629@rincewind> On 18:04 Tue 15 Dec , Andrew Brygin wrote: > Hello Sergey, > > thanks for the clarification, I see that JDK-8035166 is a prerequisite > for JDK-8233228. > > The 8u backport for JDK-8035166 has been pushed into jdk8u-dev, and has > fixVersion openjdk8u292 (April 2021). Most likely, 8u backport of > JDK-8233228 will be available in the same release. > > It would be natural that these fixes should appear in 7u only after 8u, > in April 2021. Unfortunately, at the moment jdk7u does not have a dev > repo to accumulate fixes for next release. If you do not mind, I would > propose to postpone the push of JDK-8035166 to the April release cycle? > What do you think? > > Thanks, > Andrew > I'm still quite nervous about even including this in 8u, so I would definitely wait until it has had more time to soak there before considering it for 7u. I'll be reviewing JDK-8233228 for 8u shortly and it'll very likely be in 8u292. I wish there was a way of working around the need to move the classes into rt.jar, but I can't see one, other than duplicating the code and having to maintain two copies. Thanks, -- Andrew :) Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 From serge.chernyshev at bell-sw.com Mon Dec 21 22:41:16 2020 From: serge.chernyshev at bell-sw.com (Sergey Chernyshev) Date: Tue, 22 Dec 2020 01:41:16 +0300 Subject: [7u] RFR 8035166: Remove dependency on EC classes from pkcs11 provider In-Reply-To: <20201216204200.GG205629@rincewind> References: <67405630-AB05-4992-A26C-B074475D0279@azul.com> <936a6b49-94ad-0ce6-43ad-88e57fd9b19f@azul.com> <9170a0ca-723b-d10f-6831-5c4eb6373dd9@bell-sw.com> <20201216204200.GG205629@rincewind> Message-ID: <16e7025e-e9be-9ec6-7eb0-53cc297159c8@bell-sw.com> Dear colleagues, Thank you for your feedback and review. I assume the target release for 7u-8035166 can be April 2021. I postpone the RFR for JDK-8233228 7u backport, until the review of 8u-8233228 is finished. The fixes are identical, except for a few context changes. Thanks, Serge On 16.12.2020 23:42, Andrew Hughes wrote: > On 18:04 Tue 15 Dec , Andrew Brygin wrote: >> Hello Sergey, >> >> thanks for the clarification, I see that JDK-8035166 is a prerequisite >> for JDK-8233228. >> >> The 8u backport for JDK-8035166 has been pushed into jdk8u-dev, and has >> fixVersion openjdk8u292 (April 2021). Most likely, 8u backport of >> JDK-8233228 will be available in the same release. >> >> It would be natural that these fixes should appear in 7u only after 8u, >> in April 2021. Unfortunately, at the moment jdk7u does not have a dev >> repo to accumulate fixes for next release. If you do not mind, I would >> propose to postpone the push of JDK-8035166 to the April release cycle? >> What do you think? >> >> Thanks, >> Andrew >> > I'm still quite nervous about even including this in 8u, so I would > definitely wait until it has had more time to soak there before > considering it for 7u. > > I'll be reviewing JDK-8233228 for 8u shortly and it'll very likely be > in 8u292. I wish there was a way of working around the need to move > the classes into rt.jar, but I can't see one, other than duplicating > the code and having to maintain two copies. > > Thanks, -- Best regards, Sergey Chernyshev Bellsoft LLC