[7u] RFR 8035166: Remove dependency on EC classes from pkcs11 provider
Sergey Chernyshev
serge.chernyshev at bell-sw.com
Fri Dec 11 20:46:47 UTC 2020
Hello Andrew,
The main goal is to backport JDK-8233228 to 7u, which depends on this issue.
The same fix was pushed earlier this week to 8u:
http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/b8ad41e9571f
I am not aware of any 3rd party software that can be affected by the
change. This seems unlikely that the classes moved from sunec.jar to
rt.jar are accessed from anywhere outside OpenJDK.
Alexey, thank you for review.
On 11.12.2020 18:37, Andrew Brygin wrote:
> Hello,
>
> Alexey, thank you for the review.
>
> Sergey, thank you for contributing the fix. Before you push this change
> in 7u, could you please clarify the purpose of this backport? Do you
> plan to backport any followup fixes into 7u? Do you have any assessment
> whether any third-party software could be affected by this change?
>
> Thanks,
> Andrew
>
> On 11/12/2020 17:46, Alexey Bakhtin wrote:
>> Looks good to me now.
>>
>> Thank you
>> Alexey
>>
>>> On 11 Dec 2020, at 17:12, Sergey Chernyshev <serge.chernyshev at bell-sw.com> wrote:
>>>
>>> Hello Alexey,
>>>
>>> Thanks for pointing this out. I updated the webrev here:
>>>
>>> http://cr.openjdk.java.net/~alexsch/sercher/8035166.7u/webrev.01/
>>>
>>> Thank you.
>>>
>>>
>>> On 11.12.2020 13:17, Alexey Bakhtin wrote:
>>>> Hello Serge,
>>>>
>>>> I see several issues with this patch:
>>>>
>>>> sun/security/ec/ECPrivateKeyImpl.java
>>>> - ECUtil class is not referenced in the ECPrivateKeyImpl class. Import can be removed
>>>>
>>>> org/jcp/xml/dsig/internal/dom/DOMKeyValue.java
>>>> - DomKeyValue class should be updated to instantiate ECParameters and NamedCurve classes in the correct namespace
>>>> This class is modified in the original JDK9 patch [1] but missed in the JDK11 and JDK8 because of different XML Dsig implementation.
>>>>
>>>> [1] - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/87fac66a55b4
>>>>
>>>> Regards
>>>> Alexey
>>> --
>>> Best regards,
>>> Sergey Chernyshev
>>> Bellsoft LLC
--
Best regards,
Sergey Chernyshev
Bellsoft LLC
More information about the jdk7u-dev
mailing list