[RFR 7u] 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth

[Andrew John Hughes]

On 31/10/2019 15:40, Martin Balao wrote:
> Hi Andrew,
> 
> Now that we have 8017773 [1] in 7u, can I have a review for the 8218854
> [2] 7u backport?
> 
> As previously said [3], these are the reasons why 8u patch did not apply
> cleanly:
> 
>  * Copyright date in freetypeScaler.c
> 
>  * MaxAdvanceIsMax jtreg header to run on jdk7u (removed jdk.version.major).
> 
> Webrev.01 (rebased against latest revision):
> 
>  *
> http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.jdk7u.jdk.webrev.01
> 
> Thanks,
> Martin.-
> 
> --
> [1] - http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/a48fd0b4f7b1
> [2] - https://bugs.openjdk.java.net/browse/JDK-8218854
> [3] -
> https://mail.openjdk.java.net/pipermail/jdk7u-dev/2019-October/010965.html
> 

Looks ok to me. I'll include this with the CPU fixes.

Any idea why "@requires jdk.version.major >= 8" was added in the first
place? It seems odd, given the tests are housed with a particular JDK
version (and thus require backports such as this for use in other versions).

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew