jdk8/jdk8/langtools: 15 new changesets
jitesh.bharat.dundas at accenture.com
jitesh.bharat.dundas at accenture.com
Wed Aug 17 02:20:58 PDT 2011
Hello,
This is regarding the second changeset:_
There is a function entered :-
private void parseSerialFieldString() {
int len = text.length();
+ if (len == 0) {
+ return;
+ }
1) I want to know if there is a need for a null check to be put in place for "text". Also,
2) IS there a need to use the trim method call before using the text.length ?
text.length();
should be
int len = text.trim().length();
3) Also,
ByteArrayOutputStream stdout = new ByteArrayOutputStream();
- PrintStream prev = System.out;
+ PrintStream prevOut = System.out;
System.setOut(new PrintStream(stdout));
+
+ ByteArrayOutputStream stderr = new ByteArrayOutputStream();
+ PrintStream prevErr = System.err;
+ System.setErr(new PrintStream(stderr));
Why is there no try-catch block present in this code snippet. IS there any other way of error handling being used here?
What if the handle is not there or the stream fails to open? If this is a valid error, please put in a try-catch block with specific exceptions for this..
Please let me know if you need anything else from my side.
Thanks & Regards,
Jitesh Dundas,
Accenture | Mumbai - MDC4.07.480 | Cell: +91 9004618282
-----Original Message-----
From: jdk8-dev-bounces at openjdk.java.net [mailto:jdk8-dev-bounces at openjdk.java.net] On Behalf Of lana.steuck at oracle.com
Sent: Wednesday, August 17, 2011 3:47 AM
To: jdk8-changes at openjdk.java.net; jdk8-dev at openjdk.java.net
Subject: hg: jdk8/jdk8/langtools: 15 new changesets
Changeset: b0909f992710
Author: ksrini
Date: 2011-06-30 14:33 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/b0909f992710
7059905: (javadoc) promote method visibility for netbeans usage
Reviewed-by: jjg, bpatel
! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java
! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java
! src/share/classes/com/sun/tools/javadoc/DocEnv.java
! src/share/classes/com/sun/tools/javadoc/DocImpl.java
! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java
! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java
! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java
Changeset: 409b104f8b86
Author: ksrini
Date: 2011-07-01 13:34 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/409b104f8b86
6735320: StringIndexOutOfBoundsException for empty @serialField tag
Reviewed-by: jjg, bpatel
! src/share/classes/com/sun/tools/javadoc/SerialFieldTagImpl.java
+ test/com/sun/javadoc/T6735320/SerialFieldTest.java
+ test/com/sun/javadoc/T6735320/T6735320.java
! test/com/sun/javadoc/lib/JavadocTester.java
Changeset: 0d8edba73d70
Author: ksrini
Date: 2011-07-01 14:28 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/0d8edba73d70
7060642: (javadoc) improve performance on accessing inlinedTags
Reviewed-by: jjg, bpatel
! src/share/classes/com/sun/tools/javadoc/ParamTagImpl.java
! src/share/classes/com/sun/tools/javadoc/ThrowsTagImpl.java
Changeset: 111bbf1ad913
Author: darcy
Date: 2011-07-05 16:37 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/111bbf1ad913
7025809: Provided new utility visitors supporting SourceVersion.RELEASE_8
Reviewed-by: jjg, mcimadamore
! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java
! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java
! src/share/classes/com/sun/tools/javah/JavahTask.java
! src/share/classes/com/sun/tools/javah/LLNI.java
! src/share/classes/com/sun/tools/javah/TypeSignature.java
! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java
! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java
+ src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java
! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java
! src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java
+ src/share/classes/javax/lang/model/util/AbstractElementVisitor8.java
! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java
! src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java
+ src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java
! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java
! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java
+ src/share/classes/javax/lang/model/util/ElementKindVisitor8.java
! src/share/classes/javax/lang/model/util/ElementScanner6.java
! src/share/classes/javax/lang/model/util/ElementScanner7.java
+ src/share/classes/javax/lang/model/util/ElementScanner8.java
! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java
! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java
+ src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java
! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java
! src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java
+ src/share/classes/javax/lang/model/util/SimpleElementVisitor8.java
! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java
! src/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java
+ src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java
! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java
! src/share/classes/javax/lang/model/util/TypeKindVisitor7.java
+ src/share/classes/javax/lang/model/util/TypeKindVisitor8.java
! src/share/sample/javac/processing/src/CheckNamesProcessor.java
! test/tools/javac/6402516/CheckLocalElements.java
! test/tools/javac/api/TestOperators.java
! test/tools/javac/enum/6350057/T6350057.java
! test/tools/javac/enum/6424358/T6424358.java
! test/tools/javac/failover/FailOver15.out
! test/tools/javac/lib/JavacTestingAbstractProcessor.java
! test/tools/javac/multicatch/model/ModelChecker.java
! test/tools/javac/processing/model/6194785/T6194785.java
! test/tools/javac/processing/model/TestSymtabItems.java
! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java
! test/tools/javac/processing/model/element/TestResourceVariable.java
! test/tools/javac/processing/model/type/NoTypes.java
! test/tools/javac/processing/model/type/TestUnionType.java
! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java
Changeset: 7337295434b6
Author: jjg
Date: 2011-07-07 13:29 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/7337295434b6
7061125: Proposed javac argument processing performance improvement
Reviewed-by: jjg, dlsmith, mcimadamore, forax
Contributed-by: schlosna at gmail.com
! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java
! src/share/classes/com/sun/tools/javac/main/Main.java
! test/tools/javac/T6358166.java
! test/tools/javac/T6358168.java
Changeset: 025a370b9fc3
Author: lana
Date: 2011-07-14 18:58 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/025a370b9fc3
Merge
Changeset: 2d3096441387
Author: ohair
Date: 2011-07-22 17:35 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/2d3096441387
7069993: Adjust make/jprt.properties file for jdk8
Reviewed-by: katleman
! make/jprt.properties
Changeset: 36f31b87b0ab
Author: ohair
Date: 2011-07-22 21:31 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/36f31b87b0ab
Merge
Changeset: 0b5beb9562c6
Author: mcimadamore
Date: 2011-07-27 19:00 +0100
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/0b5beb9562c6
7062745: Regression: difference in overload resolution when two methods are maximally specific
Summary: Fix most specific when two methods are maximally specific and only one has non-raw return type
Reviewed-by: jjg, dlsmith
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
+ test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java
+ test/tools/javac/generics/rawOverride/7062745/T7062745neg.java
+ test/tools/javac/generics/rawOverride/7062745/T7062745neg.out
+ test/tools/javac/generics/rawOverride/7062745/T7062745pos.java
Changeset: d5f33267a06d
Author: mcimadamore
Date: 2011-07-27 19:01 +0100
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/d5f33267a06d
7046778: Project Coin: problem with diamond and member inner classes
Summary: Diamond inference generates spurious error messages when target type is a member inner class
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/comp/Attr.java
+ test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java
! test/tools/javac/generics/diamond/neg/Neg09.out
Changeset: e427c42e1a7e
Author: mcimadamore
Date: 2011-07-27 19:01 +0100
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/e427c42e1a7e
7057297: Project Coin: diamond erroneously accepts in array initializer expressions
Summary: Diamond in array initializer expressions should be rejected
Reviewed-by: jjg
! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
+ test/tools/javac/diags/examples/CannotCreateArrayWithDiamond.java
+ test/tools/javac/generics/diamond/7057297/T7057297.java
+ test/tools/javac/generics/diamond/7057297/T7057297.out
Changeset: 0d6d41563040
Author: ksrini
Date: 2011-07-27 11:53 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/0d6d41563040
7068902: (javac) allow enabling or disabling of String folding
Summary: Contributed by netbeans team, modified to suit by the langtools team.
Reviewed-by: jjg, mcimadamore
! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
+ test/tools/javac/parser/StringFoldingTest.java
Changeset: 64b9b7ae3366
Author: darcy
Date: 2011-08-04 11:15 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/64b9b7ae3366
7071246: Enclosing string literal in parenthesis in switch-case crashes javac
Reviewed-by: mcimadamore
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! test/tools/javac/StringsInSwitch/StringSwitches.java
Changeset: c0d5f93af048
Author: jjg
Date: 2011-08-05 15:57 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/c0d5f93af048
7074189: some javac tests fail with latest jtreg 4.1 b03
Reviewed-by: darcy
+ test/tools/javac/lib/CompileFail.java
! test/tools/javac/processing/errors/TestOptionSyntaxErrors.java
! test/tools/javac/processing/errors/TestReturnCode.java
! test/tools/javac/warnings/Serial.java
Changeset: e9f118c2bd3c
Author: ksrini
Date: 2011-08-05 19:41 -0700
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/e9f118c2bd3c
7064544: (javadoc) miscellaneous fixes requested by netbeans
Summary: Contributed by netbeans team, modified to suit by the langtools team.
Reviewed-by: jjg, bpatel
! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java
! src/share/classes/com/sun/tools/javadoc/Comment.java
! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java
! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java
! test/com/sun/javadoc/testLinkTaglet/pkg/C.java
This message is for the designated recipient only and may contain privileged, proprietary, or otherwise private information. If you have received it in error, please notify the sender immediately and delete the original. Any other use of the email by you is prohibited.
More information about the jdk8-dev
mailing list