Review request for IMF classes and Locale related classes

[Stuart Marks]

Hi Naoto,

A couple comments.

java/util/Currency.java --

The @SuppressWarnings covers the entire method. We're trying to use 
@SuppressWarnings with as narrow a scope as possible. Sometimes it's helpful to 
create a local variable declaration for this purpose; perhaps something like 
this will help:

     @SuppressedWarnings("unchecked")
     Set<Currency> result = (Set<Currency>) available.clone();
     return result;

You can probably do something similar in 
sun/util/LocaleServiceProviderPool.java in the getLocalizedObjectImpl() method.

The suppression of warnings on the static AllAvailableLocales class is a bit of 
a puzzle. Maybe it's OK to leave the suppression for that entire class.

s'marks


On 12/2/11 2:24 PM, Masayoshi Okutsu wrote:
> Looks good to me.
>
> Thanks,
> Masayoshi
>
> On 2011/12/02 10:56, Naoto Sato wrote:
>> Hello,
>>
>> Could you please review these two changesets for the WCD? One is for classes
>> that belongs to input method framework:
>>
>> http://cr.openjdk.java.net/~naoto/7117465/webrev.00/
>>
>> and the other is for (some of the) i18n related *.util.* classes:
>>
>> http://cr.openjdk.java.net/~naoto/7117469/webrev.00/
>>
>> Thanks!
>> Naoto