Code review request: 7068662 Reserve and restore the default locale

[Xuelei Fan]

new webrev: http://cr.openjdk.java.net/~xuelei/7068662.open/webrev.02/

On 7/21/2011 12:21 PM, Alan Bateman wrote:
> Xuelei Fan wrote:
>> Hi,
>>
>> There are a few regression tests that do not reserve and restore the
>> default locale. As will result in unexpected impact on other tests that
>> depends on the default locale. This fix try to reserve and restore
>> the default locale in regression tests under jdk/test folder.
>>
>> The fix includes update in:
>> test/com/sun/org/apache/xml
>> test/java/beans
>> test/java/io
>> test/java/net
>> test/java/util
>> test/javax/crypto
>> test/javax/swing
>> test/sun/security
>> test/sun/text
>> test/sun/util
>>
>> webrev: http://cr.openjdk.java.net/~xuelei/7068662.open/webrev.00/
>>
>> Thanks,
>> Xuelei
>>   
> Thanks for doing this as tests that don't restore the default locale can
> cause some hard to debug problems when running the tests in the same VM.
> 
> I think your changes to test/java/util/jar/JarFile/TurkCert.java mean
> that we can remove the @run tag that is currently forcing it to run in
> its own VM.
> 
The @run tag is removed in the new webrev.

> I see you've updated
> test/java/net/URLConnection/SetIfModifiedSince.java. I'm not sure if I'm
> reading that test correctly but it looks like it will pass even if there
> is a problem.
> 
There is no problem to pass the test. The problem is that it changes the
default locale to Locale.JAPAN, as may impact the following test cases.

> Minor nit in test/sun/util/resources/Locale/Bug4965260.java and
> test/sun/util/resources/TimeZone/Bug4640234.java is that they are using
> 2 space indenting whereas we use 4 spaces in java code.
> 
Tidied up.

Thanks,
Xuelei

> -Alan.
>