From john.coomes at oracle.com Tue Nov 1 16:09:37 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 01 Nov 2011 23:09:37 +0000 Subject: hg: jdk8/jdk8/hotspot: 10 new changesets Message-ID: <20111101230957.325CF471F8@hg.openjdk.java.net> Changeset: c9d25d93ddfe Author: jcoomes Date: 2011-10-21 16:00 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/c9d25d93ddfe 7103619: Bump the hs23 build number to 04 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5e5d4821bf07 Author: brutisso Date: 2011-10-20 10:21 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/5e5d4821bf07 7097516: G1: assert(0<= from_card && from_card ------- hs23-b04 has been integrated into jdk8-b12. http://hg.openjdk.java.net/jdk8/jdk8/rev/8e2104d565ba http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/31d70911b712 http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/1d3900713a67 http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/ca977d167697 http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/e6eed2ff5d5f http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/09fd2067f715 http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/f2d6ed25857d Component : VM Status : 0 major failures, 0 minor failures Date : 11/01/2011 at 09:43 Tested By : VM SQE & leonid.mesnik at oracle.com Cost(total man-days): 1 Workspace : /net/prt-archiver.us.oracle.com/data/jprt/archive/2011/10/2011-10-28-225753.jcoomes.hs23-b04-snapshot Bundles : /net/prt-archiver.us.oracle.com/data/jprt/archive/2011/10/2011-10-28-225753.jcoomes.hs23-b04-snapshot Platforms : Others Tests : /net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Browsers : NA Patches : NA Logs : http://sqeweb.us.oracle.com/nfs/results/vm/gtee/HSX/PIT/VM/hs23/b04/8/b12/ Number of Tests Executed : 0 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: 7096030: G1: PrintGCDetails enhancements 7097516: G1: assert(0<= from_card && from_cardFrom VM SQE & leonid.mesnik at oracle.com From david.katleman at sun.com Thu Nov 3 15:35:09 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 03 Nov 2011 22:35:09 +0000 Subject: hg: jdk8/jdk8: Added tag jdk8-b12 for changeset 8e2104d565ba Message-ID: <20111103223510.176B047226@hg.openjdk.java.net> Changeset: 26fb81a1e9ce Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/26fb81a1e9ce Added tag jdk8-b12 for changeset 8e2104d565ba ! .hgtags From david.katleman at sun.com Thu Nov 3 15:35:19 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 03 Nov 2011 22:35:19 +0000 Subject: hg: jdk8/jdk8/corba: Added tag jdk8-b12 for changeset 31d70911b712 Message-ID: <20111103223520.AAB1847227@hg.openjdk.java.net> Changeset: 5b9d9b839d3d Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/5b9d9b839d3d Added tag jdk8-b12 for changeset 31d70911b712 ! .hgtags From david.katleman at sun.com Thu Nov 3 15:37:36 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 03 Nov 2011 22:37:36 +0000 Subject: hg: jdk8/jdk8/hotspot: Added tag jdk8-b12 for changeset 1d3900713a67 Message-ID: <20111103223740.E908047228@hg.openjdk.java.net> Changeset: ddb34559f9a7 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ddb34559f9a7 Added tag jdk8-b12 for changeset 1d3900713a67 ! .hgtags From david.katleman at sun.com Thu Nov 3 15:40:05 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 03 Nov 2011 22:40:05 +0000 Subject: hg: jdk8/jdk8/jaxp: Added tag jdk8-b12 for changeset ca977d167697 Message-ID: <20111103224005.2D57347229@hg.openjdk.java.net> Changeset: bcc739229f63 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/bcc739229f63 Added tag jdk8-b12 for changeset ca977d167697 ! .hgtags From david.katleman at sun.com Thu Nov 3 15:40:14 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 03 Nov 2011 22:40:14 +0000 Subject: hg: jdk8/jdk8/jaxws: Added tag jdk8-b12 for changeset e6eed2ff5d5f Message-ID: <20111103224014.7714E4722A@hg.openjdk.java.net> Changeset: adf2a6b5fde1 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/adf2a6b5fde1 Added tag jdk8-b12 for changeset e6eed2ff5d5f ! .hgtags From david.katleman at sun.com Thu Nov 3 15:40:26 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 03 Nov 2011 22:40:26 +0000 Subject: hg: jdk8/jdk8/jdk: Added tag jdk8-b12 for changeset 09fd2067f715 Message-ID: <20111103224051.4009D4722B@hg.openjdk.java.net> Changeset: d636e737c478 Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/d636e737c478 Added tag jdk8-b12 for changeset 09fd2067f715 ! .hgtags From david.katleman at sun.com Thu Nov 3 15:42:23 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 03 Nov 2011 22:42:23 +0000 Subject: hg: jdk8/jdk8/langtools: Added tag jdk8-b12 for changeset f2d6ed25857d Message-ID: <20111103224227.1AFB64722C@hg.openjdk.java.net> Changeset: ae25163501bc Author: katleman Date: 2011-11-03 10:32 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/ae25163501bc Added tag jdk8-b12 for changeset f2d6ed25857d ! .hgtags From fweimer at bfk.de Mon Nov 7 04:20:15 2011 From: fweimer at bfk.de (Florian Weimer) Date: Mon, 07 Nov 2011 12:20:15 +0000 Subject: README-builds.html In-Reply-To: <82zkgo11c4.fsf@mid.bfk.de> (Florian Weimer's message of "Wed, 26 Oct 2011 10:42:03 +0000") References: <82zkgo11c4.fsf@mid.bfk.de> Message-ID: <82y5vsazuo.fsf@mid.bfk.de> * Florian Weimer: > README-builds.html is out of data (in jdk8/tl). It still refers to JDK > 6u18 as the bootstrap JDK. Furthermore, bootstrapping with the > jdk7u/jd7u tip does not work due to the following > warning-treated-as-error: > > | ##### Entering langtools for target(s) all ##### > | [...] > | -def-pcompile: > | [javac] Compiling 2 source files to [...]/build/linux-amd64/langtools/build/toolclasses > | [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.6 > | [javac] error: warnings found and -Werror specified > | [javac] 1 error > | [javac] 1 warning It turns out that this happens when I specify build/linux-amd64 instead of build/linux-amd64/j2sdk-image from an OpenJDK 7 build as ALT_BOOTDIR. If I use the j2sdk-image directory, the build proceeds. Once I feel a bit more confident about the build results, I'm going to propose suitable changes to README-builds.html. -- Florian Weimer BFK edv-consulting GmbH http://www.bfk.de/ Kriegsstra?e 100 tel: +49-721-96201-1 D-76133 Karlsruhe fax: +49-721-96201-99 From john.coomes at oracle.com Tue Nov 8 14:31:50 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 08 Nov 2011 22:31:50 +0000 Subject: hg: jdk8/jdk8/hotspot: 6 new changesets Message-ID: <20111108223201.E464F4729E@hg.openjdk.java.net> Changeset: 5c8c7bef6403 Author: jcoomes Date: 2011-10-28 18:30 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/5c8c7bef6403 7106092: Bump the hs23 build number to 05 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: d5c4c73aa855 Author: dholmes Date: 2011-10-27 18:04 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/d5c4c73aa855 7104173: sun/tools tests fail with debug build after 7012206 Summary: Disable PrintVMOptions in embedded debug builds so tests are unaffected by extra output Reviewed-by: twisti, coleenp, phh, fparain, dsamersoff ! src/share/vm/runtime/globals.hpp Changeset: 6da94c5a6746 Author: dholmes Date: 2011-10-30 18:40 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/6da94c5a6746 Merge Changeset: 95009f678859 Author: brutisso Date: 2011-11-01 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/95009f678859 7106766: Move the precompiled header from the src/share/vm directory Summary: Moved precompiled.hpp to src/share/vm/precompiled Reviewed-by: coleenp, dholmes Contributed-by: rbackman ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/gcc.make ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/gcc.make ! make/windows/makefiles/vm.make - src/share/vm/precompiled.hpp + src/share/vm/precompiled/precompiled.hpp Changeset: 3e609627e780 Author: jcoomes Date: 2011-11-04 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/3e609627e780 Merge - src/share/vm/precompiled.hpp Changeset: b92ca8e229d2 Author: jcoomes Date: 2011-11-04 12:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b92ca8e229d2 Added tag hs23-b05 for changeset 3e609627e780 ! .hgtags From alejandro.murillo at oracle.com Tue Nov 8 14:43:49 2011 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 08 Nov 2011 15:43:49 -0700 Subject: jdk8-b13: HotSpot Message-ID: <4EB9B0A5.8020201@oracle.com> hs23-b05 has been integrated into jdk8-b13. http://hg.openjdk.java.net/jdk8/jdk8/rev/26fb81a1e9ce http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/5b9d9b839d3d http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b92ca8e229d2 http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/bcc739229f63 http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/adf2a6b5fde1 http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/d636e737c478 http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/ae25163501bc Component : VM Status : 0 major failures, 1 minor failures Date : 11/08/2011 at 08:45 Tested By : VM SQE& leonid.mesnik at oracle.com Cost(total man-days): 1 Workspace : /net/prt-archiver.us.oracle.com/data/jprt/archive/2011/11/23.0-b05-internal-201111042009.jcoomes.hs23-b05-snapshot-fastdebug Bundles : /net/prt-archiver.us.oracle.com/data/jprt/archive/2011/11/23.0-b05-internal-201111042009.jcoomes.hs23-b05-snapshot-fastdebug Platforms : Others Tests : /net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Browsers : NA Patches : NA Logs : http://sqeweb.us.oracle.com/nfs/results/vm/gtee/HSX/PIT/VM/hs23/b05/8/b13/2011-11-05/ Number of Tests Executed : 805079 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: 7104173: sun/tools tests fail with debug build after 7012206 Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: Build change only: 7106092: Bump the hs23 build number to 05 7106766: Move the precompiled header from the src/share/vm directory New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: 7109620: nsk/jdi/VirtualMachineManager/connectedVirtualMachines/convm002 began to fail on 23.0-b03-fastdebug Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b13 Issues and Notes: This is PIT for HS23b05 for JDK8b13. ------------------------------- From VM SQE& leonid.mesnik at oracle.com -- Alejandro E Murillo, Java Performance Phone: (303) 955-2584. Timezone: US/Mountain (UTC-0700) From martin.desruisseaux at geomatys.fr Wed Nov 9 02:46:48 2011 From: martin.desruisseaux at geomatys.fr (Martin Desruisseaux) Date: Wed, 09 Nov 2011 11:46:48 +0100 Subject: Miscellaneous minor patches: javadoc typos, javac warnings, etc. In-Reply-To: <4E8BB9CB.9000601@oracle.com> References: <4E8B31B4.3010208@geomatys.fr> <20111004210757.GL29874@rivendell.redhat.com> <4E8B7B1F.7060009@geomatys.fr> <4E8B7C36.8000005@oracle.com> <4E8BB9CB.9000601@oracle.com> Message-ID: <4EBA5A18.4000603@geomatys.fr> Hello all It took me a while, but I finally posted the patches that I submitted last month as webrev pages. I tried to split them according different groups (core, Java2D...) to the best of my knowledge: http://webrev.geomatys.com/ I also signed the Oracle Contributor Agreement (OCA) and send it by email to oracle-ca_us at oracle.com. In the core classes, most patches can be grouped in two categories: * Documentation fixes (Class, Attributes) * Avoid creation of unnecessary temporary objects (AssertionError, Float, Double) The only real bug fix is in Java 2D (AffineTransform.hashCode() inconsistent with equals(Object) when some coefficients mix positive and negative zeros). However I'm not yet registered on the Java2D mailing list. Should I register on the mailing list of each group for which I may propose a patch? Regards, Martin From david.katleman at sun.com Wed Nov 9 14:35:36 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Wed, 09 Nov 2011 22:35:36 +0000 Subject: hg: jdk8/jdk8/jdk: 9 new changesets Message-ID: <20111109223729.EAEB3472BF@hg.openjdk.java.net> Changeset: bfd720647db2 Author: yhuang Date: 2011-10-31 20:14 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bfd720647db2 7077119: remove past transition dates from CurrencyData.properties file Reviewed-by: naoto ! src/share/classes/java/util/CurrencyData.properties ! test/java/util/Currency/CurrencyTest.java ! test/java/util/Currency/ValidateISO4217.java ! test/java/util/Currency/tablea1.txt Changeset: cfc6fd491b97 Author: yhuang Date: 2011-10-31 21:30 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/cfc6fd491b97 6755060: Collator.compare() does not compare correctly for the Thai locale Reviewed-by: naoto ! src/share/classes/sun/text/resources/CollationData_th.java + test/sun/text/resources/Collator/Bug6755060.java Changeset: 0549410acf26 Author: yhuang Date: 2011-10-31 21:38 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0549410acf26 Merge Changeset: f3227efde13d Author: yhuang Date: 2011-10-31 21:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f3227efde13d 7101495: In Latvia first day of week is Monday Reviewed-by: naoto, peytoia ! src/share/classes/sun/util/resources/CalendarData_lv.properties ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: ab837acc60fb Author: yhuang Date: 2011-10-31 21:45 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ab837acc60fb Merge Changeset: 631ee738378a Author: mfang Date: 2011-11-03 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/631ee738378a Merge Changeset: 94e5604022fa Author: ngmr Date: 2011-09-15 19:29 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/94e5604022fa 6988099: jvmti demos missing Publisher (COMPANY resource) in dlls/exes on windows Summary: Add creation/linking of resource data to link step for demos on Windows Reviewed-by: dcubed, zgu, ngmr, ohair Contributed-by: Sean Chou ! make/common/Demo.gmk Changeset: 5791714b9472 Author: ohair Date: 2011-11-04 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5791714b9472 Merge Changeset: 4cb2e8679b27 Author: katleman Date: 2011-11-09 13:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4cb2e8679b27 Merge From david.katleman at sun.com Thu Nov 10 12:59:37 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 10 Nov 2011 20:59:37 +0000 Subject: hg: jdk8/jdk8: Added tag jdk8-b13 for changeset 26fb81a1e9ce Message-ID: <20111110205937.2191B47301@hg.openjdk.java.net> Changeset: 8da26d5c32a7 Author: katleman Date: 2011-11-10 11:45 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/8da26d5c32a7 Added tag jdk8-b13 for changeset 26fb81a1e9ce ! .hgtags From david.katleman at sun.com Thu Nov 10 12:59:46 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 10 Nov 2011 20:59:46 +0000 Subject: hg: jdk8/jdk8/corba: Added tag jdk8-b13 for changeset 5b9d9b839d3d Message-ID: <20111110205947.E36E647302@hg.openjdk.java.net> Changeset: 6f601a737e0f Author: katleman Date: 2011-11-10 11:45 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/6f601a737e0f Added tag jdk8-b13 for changeset 5b9d9b839d3d ! .hgtags From david.katleman at sun.com Thu Nov 10 13:00:27 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 10 Nov 2011 21:00:27 +0000 Subject: hg: jdk8/jdk8/hotspot: Added tag jdk8-b13 for changeset b92ca8e229d2 Message-ID: <20111110210031.4AA9C47303@hg.openjdk.java.net> Changeset: 088d09a130ff Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/088d09a130ff Added tag jdk8-b13 for changeset b92ca8e229d2 ! .hgtags From david.katleman at sun.com Thu Nov 10 13:02:09 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 10 Nov 2011 21:02:09 +0000 Subject: hg: jdk8/jdk8/jaxp: Added tag jdk8-b13 for changeset bcc739229f63 Message-ID: <20111110210209.1408447304@hg.openjdk.java.net> Changeset: e7172d80a8f4 Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/e7172d80a8f4 Added tag jdk8-b13 for changeset bcc739229f63 ! .hgtags From david.katleman at sun.com Thu Nov 10 13:02:21 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 10 Nov 2011 21:02:21 +0000 Subject: hg: jdk8/jdk8/jaxws: Added tag jdk8-b13 for changeset adf2a6b5fde1 Message-ID: <20111110210221.15B1C47305@hg.openjdk.java.net> Changeset: f502a343a92e Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/f502a343a92e Added tag jdk8-b13 for changeset adf2a6b5fde1 ! .hgtags From david.katleman at sun.com Thu Nov 10 13:02:38 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 10 Nov 2011 21:02:38 +0000 Subject: hg: jdk8/jdk8/jdk: Added tag jdk8-b13 for changeset 4cb2e8679b27 Message-ID: <20111110210255.A685D47306@hg.openjdk.java.net> Changeset: 52bd7fc8fcb0 Author: katleman Date: 2011-11-10 11:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/52bd7fc8fcb0 Added tag jdk8-b13 for changeset 4cb2e8679b27 ! .hgtags From david.katleman at sun.com Thu Nov 10 13:04:24 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Thu, 10 Nov 2011 21:04:24 +0000 Subject: hg: jdk8/jdk8/langtools: Added tag jdk8-b13 for changeset ae25163501bc Message-ID: <20111110210428.84A2147307@hg.openjdk.java.net> Changeset: 65444e7998e3 Author: katleman Date: 2011-11-10 11:47 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/65444e7998e3 Added tag jdk8-b13 for changeset ae25163501bc ! .hgtags From artem.ananiev at oracle.com Tue Nov 15 06:47:27 2011 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 15 Nov 2011 18:47:27 +0400 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy Message-ID: <4EC27B7F.2050205@oracle.com> I hereby nominate Alexander Scherbatiy to JDK8 Committer. Alexander has contributed several changes in Swing, which is a part of JDK8. Here is the list of fixes: http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba Votes are due by Nov 29, 2011. Only current JDK8 Committers [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. Thanks, Artem [1] http://openjdk.java.net/census#jdk8 [2] http://openjdk.java.net/projects#committer-vote From daniel.daugherty at oracle.com Tue Nov 15 06:54:27 2011 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 15 Nov 2011 07:54:27 -0700 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <4EC27D23.4010701@oracle.com> Vote: yes Dan On 11/15/11 7:47 AM, Artem Ananiev wrote: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of > JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > > From alexander.kouznetsov at oracle.com Tue Nov 15 07:03:53 2011 From: alexander.kouznetsov at oracle.com (Alexander Kouznetsov) Date: Tue, 15 Nov 2011 19:03:53 +0400 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <4EC27F59.1080506@oracle.com> Vote: yes Best regards, Alexander Kouznetsov On 15.11.2011 18:47, Artem Ananiev wrote: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of > JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > From Dmitry.Samersoff at oracle.com Tue Nov 15 07:05:13 2011 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Tue, 15 Nov 2011 19:05:13 +0400 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <4EC27FA9.90604@oracle.com> Vote: yes On 2011-11-15 18:47, Artem Ananiev wrote: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of > JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From anthony.petrov at oracle.com Tue Nov 15 07:05:56 2011 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Tue, 15 Nov 2011 19:05:56 +0400 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <4EC27FD4.5080608@oracle.com> Vote: YES -- best regards, Anthony On 11/15/2011 6:47 PM, Artem Ananiev wrote: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of > JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > From alexander.zuev at oracle.com Tue Nov 15 08:07:17 2011 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Tue, 15 Nov 2011 19:07:17 +0300 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <4EC28E35.3060003@oracle.com> Vote: yes With best regards, Alexander Zuev On 11/15/11 5:47 PM, Artem Ananiev wrote: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of > JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > From sergey.bylokhov at oracle.com Tue Nov 15 07:15:04 2011 From: sergey.bylokhov at oracle.com (Sergey Bylokhov) Date: Tue, 15 Nov 2011 19:15:04 +0400 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <4EC281F8.8080801@oracle.com> |Vote: yes| 15.11.2011 18:47, Artem Ananiev wrote: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of > JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > -- Best regards, Sergey. From Abhi.Saha at Oracle.Com Tue Nov 15 07:25:58 2011 From: Abhi.Saha at Oracle.Com (Abhijit Saha) Date: Tue, 15 Nov 2011 07:25:58 -0800 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <4EC28486.5020202@Oracle.Com> |Vote: yes| On 11/15/2011 6:47 AM, Artem Ananiev wrote: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of > JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > -- Release Lead, Java SE Updates Java Platform Group Oracle Corporation. (408)276-7564 From pavel.porvatov at oracle.com Tue Nov 15 12:51:29 2011 From: pavel.porvatov at oracle.com (Pavel Porvatov) Date: Wed, 16 Nov 2011 00:51:29 +0400 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <4EC2D0D1.5040704@oracle.com> Vote: yes > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of > JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > From lana.steuck at oracle.com Tue Nov 15 15:50:59 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 15 Nov 2011 23:50:59 +0000 Subject: hg: jdk8/jdk8/jaxws: 7 new changesets Message-ID: <20111115235059.E9DA24737C@hg.openjdk.java.net> Changeset: 75a652e72489 Author: asaha Date: 2011-06-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/75a652e72489 Merge Changeset: b058cae6fd3b Author: asaha Date: 2011-06-28 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/b058cae6fd3b Merge Changeset: 61c046c6895a Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/61c046c6895a Merge Changeset: 9e82b46cd4fa Author: asaha Date: 2011-07-25 11:38 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/9e82b46cd4fa 7046794: Configurable behavior for server-side stacktraces Reviewed-by: ramap ! jaxws.properties Changeset: c78fccb01d4e Author: asaha Date: 2011-11-07 21:48 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/c78fccb01d4e Merge Changeset: cae6db74d6af Author: asaha Date: 2011-11-10 13:38 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/cae6db74d6af 7110676: Update jaf source download url for jaxws Reviewed-by: ramap ! jaxws.properties Changeset: 54c4bf4b83ec Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/54c4bf4b83ec Merge From lana.steuck at oracle.com Tue Nov 15 15:51:04 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 15 Nov 2011 23:51:04 +0000 Subject: hg: jdk8/jdk8/jaxp: 5 new changesets Message-ID: <20111115235105.1BAF84737D@hg.openjdk.java.net> Changeset: 7adf14d6060c Author: asaha Date: 2011-06-27 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/7adf14d6060c Merge Changeset: d239aa024b6e Author: asaha Date: 2011-06-28 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/d239aa024b6e Merge Changeset: eca33f89c823 Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/eca33f89c823 Merge Changeset: 0ed9ae36ee2a Author: asaha Date: 2011-11-07 21:47 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/0ed9ae36ee2a Merge Changeset: 9d0c9d638757 Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/9d0c9d638757 Merge From lana.steuck at oracle.com Tue Nov 15 15:50:55 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 15 Nov 2011 23:50:55 +0000 Subject: hg: jdk8/jdk8/corba: 6 new changesets Message-ID: <20111115235106.ABACA4737E@hg.openjdk.java.net> Changeset: d84682019b5f Author: asaha Date: 2011-06-27 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/d84682019b5f Merge Changeset: 9c20c1e7cdd9 Author: asaha Date: 2011-06-28 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/9c20c1e7cdd9 Merge Changeset: cb5aec0570a5 Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/cb5aec0570a5 Merge Changeset: 21369018a679 Author: mbankal Date: 2011-08-09 05:39 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/21369018a679 7055902: Oracle Java IIOP Deserialization Type Confusion Remote Code Execution Vulnerability Reviewed-by: coffeys ! src/share/classes/com/sun/corba/se/impl/io/IIOPInputStream.java Changeset: 058c18d237a9 Author: asaha Date: 2011-11-07 21:45 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/058c18d237a9 Merge Changeset: e59c47de1ad8 Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/e59c47de1ad8 Merge From lana.steuck at oracle.com Tue Nov 15 15:51:21 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 15 Nov 2011 23:51:21 +0000 Subject: hg: jdk8/jdk8/langtools: 12 new changesets Message-ID: <20111115235148.B82D94737F@hg.openjdk.java.net> Changeset: e52159ff8d0c Author: lana Date: 2011-10-25 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/e52159ff8d0c Merge Changeset: 897b72b2751b Author: lana Date: 2011-10-26 12:28 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/897b72b2751b Merge - src/share/classes/com/sun/tools/javac/file/Paths.java Changeset: 9e2eb4bc49eb Author: jjh Date: 2011-11-01 15:49 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/9e2eb4bc49eb 7101933: langtools jtreg tests do not work with jprt on windows Summary: Fixed langtools/test/Makefile to work on cygwin. Updated jtreg to 4.1 and JCK to JCK8. Reviewed-by: jjg, ohair ! test/Makefile Changeset: 56830d5cb5bb Author: mcimadamore Date: 2011-11-04 12:36 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/56830d5cb5bb 7104201: Refactor DocCommentScanner Summary: Add new Comment helper class to parse contents of comments in source code Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/JavadocTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java + test/tools/javac/depDocComment/DeprecatedDocComment4.java + test/tools/javac/depDocComment/DeprecatedDocComment4.out Changeset: 11c184155128 Author: lana Date: 2011-11-05 00:02 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/11c184155128 Merge Changeset: ca49d50318dc Author: jjg Date: 2011-11-08 11:51 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/ca49d50318dc 6921494: provide way to print javac tree tag values Reviewed-by: jjg, mcimadamore Contributed-by: vicenterz at yahoo.es ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/tree/AbstractTreeScannerTest.java ! test/tools/javac/tree/TreePosTest.java Changeset: b7003a6a530b Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/b7003a6a530b Merge Changeset: 15ea1c763273 Author: asaha Date: 2011-06-27 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/15ea1c763273 Merge - src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/inherit.gif Changeset: c79cf0f04be6 Author: asaha Date: 2011-06-28 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/c79cf0f04be6 Merge Changeset: 34e175c1fabc Author: asaha Date: 2011-07-19 11:05 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/34e175c1fabc Merge Changeset: c4478931e22d Author: asaha Date: 2011-11-07 21:52 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/c4478931e22d Merge Changeset: 58f1325d72b2 Author: lana Date: 2011-11-14 18:18 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/58f1325d72b2 Merge From lana.steuck at oracle.com Tue Nov 15 15:53:17 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 15 Nov 2011 23:53:17 +0000 Subject: hg: jdk8/jdk8/jdk: 55 new changesets Message-ID: <20111116000235.D1D0E47381@hg.openjdk.java.net> Changeset: 9de1dbf8c9be Author: lana Date: 2011-10-26 17:59 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/9de1dbf8c9be Merge - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/tools/jar/JarImageSource.java Changeset: 76defa20906a Author: ngmr Date: 2011-09-23 15:18 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/76defa20906a 7105640: Unix printing does not check the result of exec'd lpr/lp command Summary: Add checking, exception for spool process failure Reviewed-by: prr, jgodinez Contributed-by: Neil Richards ! src/share/classes/sun/print/PSPrinterJob.java ! src/solaris/classes/sun/print/UnixPrintJob.java Changeset: 4544585a3cea Author: lana Date: 2011-11-05 14:27 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4544585a3cea Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/native/sun/rmi/server/MarshalInputStream.c - test/java/net/DatagramSocket/ChangingAddress.java - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: aa3f5117c485 Author: rupashka Date: 2011-10-17 15:10 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/aa3f5117c485 7099251: javax.swing.text.html.HTMLDocument.insertAfterStart(null, something) throws NPE Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! src/share/classes/javax/swing/text/html/HTMLDocument.java Changeset: 4f74e3fdf86b Author: rupashka Date: 2011-10-17 16:40 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4f74e3fdf86b 7100004: javax.swing.JTable.setAutoCreateRowSorter(boolean autoCreateRowSorter) should mention default value Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! src/share/classes/javax/swing/JTable.java Changeset: f1dbc62c7c6d Author: rupashka Date: 2011-10-17 17:19 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f1dbc62c7c6d 7077293: javax/swing/JComponent/4337267/bug4337267.java failed on windows 2003 Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com ! src/share/classes/sun/swing/SwingUtilities2.java Changeset: a2f5d7049258 Author: dbuck Date: 2011-10-17 19:06 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a2f5d7049258 6887286: StackOverflowError at sun.awt.image.ImageWatched$WeakLink.isWatcher Summary: Fixed OffScreenImageSource to call imageComplete() with SINGLEFAMEDONE, not STATICIMAGEDONE. This fixed memory leak (that caused SOFE when we use recursion to iterate over linked list). Reviewed-by: bae ! src/share/classes/sun/awt/image/OffScreenImageSource.java Changeset: 7636a62aba7e Author: anthony Date: 2011-11-01 18:01 +0300 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/7636a62aba7e 7104625: sun.awt.X11.XEvent is creating 600 MB of char[] for no good reason Summary: Wrap logging calls with if(){} statements Reviewed-by: anthony, son Contributed-by: Federico Tello Gentile ! src/solaris/classes/sun/awt/X11/XComponentPeer.java Changeset: ac55f169fadd Author: anthony Date: 2011-11-01 18:03 +0300 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ac55f169fadd 7105529: XAWT: Optimize getFieldsAsString() methods generated by WrapperGenerator Summary: Replace string concatenation with StringBuilder.append() Reviewed-by: anthony, son Contributed-by: Federico Tello Gentile ! src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java Changeset: 41610a897379 Author: rupashka Date: 2011-11-02 14:17 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/41610a897379 6624077: Regression test fails: closed/javax/swing/ToolTipManager/6256140/bug6256140.java Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/ToolTipManager/Test6256140.java Changeset: 8068f1584715 Author: mrkam Date: 2011-11-02 17:39 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/8068f1584715 7074853: TransparentRuler demos Readme should mention the correct jar file name Reviewed-by: rupashka ! src/share/demo/jfc/TransparentRuler/README.txt Changeset: 323f6d046cc9 Author: rupashka Date: 2011-11-02 23:53 +0300 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/323f6d046cc9 7049024: DnD fails with JTextArea and JTextField Reviewed-by: rupashka Contributed-by: Sean Chou ! src/share/classes/javax/swing/text/DefaultCaret.java + test/javax/swing/JTextArea/7049024/bug7049024.java Changeset: 7c29751a9331 Author: rupashka Date: 2011-11-03 14:14 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/7c29751a9331 6955919: Intermittent ClassCastException in bug4492274 test Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JEditorPane/4492274/bug4492274.java + test/javax/swing/JEditorPane/4492274/test.html Changeset: 1c0624d9a2b6 Author: ngmr Date: 2011-10-13 13:02 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/1c0624d9a2b6 7107957: AWT: Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h Summary: Use POSIX defined includes for unistd.h and fcntl.h Reviewed-by: anthony, ngmr Contributed-by: Charles Lee ! src/solaris/native/sun/awt/splashscreen/splashscreen_config.h Changeset: adb31ff942ef Author: rupashka Date: 2011-11-07 16:50 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/adb31ff942ef 7080203: JTree.getSelectionPaths() now returns empty array instead of null Reviewed-by: malenkov ! src/share/classes/javax/swing/JTree.java Changeset: d219e0b11327 Author: lana Date: 2011-11-07 10:26 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/d219e0b11327 Merge - make/sun/rmi/rmi/mapfile-vers - src/share/classes/java/util/XMLUtils.java - src/share/classes/sun/security/pkcs/EncodingException.java - src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/pkcs/PKCS10Attribute.java - src/share/classes/sun/security/pkcs/PKCS10Attributes.java - src/share/classes/sun/security/util/BigInt.java - src/share/classes/sun/security/util/PathList.java - src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/classes/sun/tools/jar/JarImageSource.java - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c - src/share/native/sun/rmi/server/MarshalInputStream.c - test/sun/security/util/BigInt/BigIntEqualsHashCode.java Changeset: f8a3dff76b48 Author: rupashka Date: 2011-11-08 14:36 +0300 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f8a3dff76b48 7107585: Test incorrect calculate position of object on frame Reviewed-by: rupashka Contributed-by: alexandr.scherbatiy at oracle.com + test/javax/swing/JSlider/6348946/bug6348946.java Changeset: af4fb33fca29 Author: lana Date: 2011-11-08 15:37 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/af4fb33fca29 Merge Changeset: 88a260444e4d Author: chegar Date: 2011-10-26 13:58 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/88a260444e4d 7104650: rawtype warnings in several net, nio and security source files Summary: Also reviewed by Ulf.Zibis at gmx.de Reviewed-by: mcimadamore, alanb, dholmes ! make/sun/net/Makefile ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/java/security/Security.java ! src/share/classes/sun/nio/ch/Util.java Changeset: 0d371f2911a1 Author: peytoia Date: 2011-10-26 22:16 +0900 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0d371f2911a1 7090046: Lots of invalid link in java.text.BreakIterator comments Reviewed-by: okutsu ! src/share/classes/java/text/BreakIterator.java Changeset: 291b55aa9b1e Author: lana Date: 2011-10-25 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/291b55aa9b1e Merge - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c Changeset: 64faf533b99d Author: lana Date: 2011-10-26 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/64faf533b99d Merge Changeset: 449113aea001 Author: weijun Date: 2011-10-27 17:23 +0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/449113aea001 7104161: test/sun/tools/jinfo/Basic.sh fails on Ubuntu Reviewed-by: alanb ! test/sun/tools/jinfo/Basic.sh Changeset: 64ccf18bbad5 Author: coffeys Date: 2011-10-27 10:32 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/64ccf18bbad5 7099658: Properties.loadFromXML fails with ClassCastException Reviewed-by: alanb, mchung ! src/share/classes/sun/util/xml/XMLUtils.java Changeset: 56cc907fc8dc Author: mullan Date: 2011-10-27 10:57 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/56cc907fc8dc 7094155: JSR105 code throws javax.xml.crypto.URIReferenceException when running into Java 7 VM Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IdResolver.java ! test/javax/xml/crypto/dsig/GenerationTests.java Changeset: 8cd2e3b8127a Author: mullan Date: 2011-10-27 11:01 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/8cd2e3b8127a Merge - make/sun/rmi/rmi/mapfile-vers - src/share/native/sun/awt/libpng/pnggccrd.c - src/share/native/sun/awt/libpng/pngvcrd.c - src/share/native/sun/rmi/server/MarshalInputStream.c Changeset: 6e59c482e9b8 Author: xuelei Date: 2011-10-28 07:18 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/6e59c482e9b8 7105940: Test regression: KeyStore must be from provider SunPKCS11-NSSKeyStore Reviewed-by: weijun ! test/sun/security/pkcs11/fips/CipherTest.java ! test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java Changeset: bb2b9a8b6e77 Author: alanb Date: 2011-10-30 14:53 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bb2b9a8b6e77 7103889: (fs) Reduce String concatenation when iterating over directory Reviewed-by: alanb Contributed-by: mike.skells at talk21.com ! src/share/classes/java/nio/file/Files.java ! src/windows/classes/sun/nio/fs/WindowsDirectoryStream.java ! src/windows/classes/sun/nio/fs/WindowsPathParser.java Changeset: 30900a1a9cfc Author: xuelei Date: 2011-10-30 20:07 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/30900a1a9cfc 7106277: Brokenness in the seqNumberOverflow of MAC Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/MAC.java Changeset: 8681362a2f04 Author: wetmore Date: 2011-10-31 11:54 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/8681362a2f04 7105780: Add SSLSocket client/SSLEngine server to templates directory Reviewed-by: xuelei + test/sun/security/ssl/templates/SSLSocketSSLEngineTemplate.java Changeset: b60e88ef5d8d Author: wetmore Date: 2011-10-31 16:23 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/b60e88ef5d8d 7053252: New regression test does not compile on windows-amd64 Reviewed-by: valeriep ! test/ProblemList.txt ! test/sun/security/pkcs11/Provider/Absolute.java Changeset: 5f2838744544 Author: ysr Date: 2011-10-31 17:38 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5f2838744544 4243978: (ref) Race condition in Reference.enqueue() 4268317: (ref) Reference.isEnqueued() can return true when instance not enqueued Summary: The reference handler now declares, and assumes, that the discovered field, rather than the next field, is (to be) used to link the entries in the pending list, thus allowing a reference object to be safely enqueued even while it is in the pending state. Also added slightly modified regression tests from the two bug reports. Reviewed-by: mchung, alanb, jcoomes ! src/share/classes/java/lang/ref/Reference.java ! src/share/javavm/export/jvm.h ! src/share/native/common/jdk_util.c + test/java/lang/ref/ReferenceEnqueue.java + test/java/lang/ref/ReferenceEnqueuePending.java Changeset: 2f2f56ac8b82 Author: mduigou Date: 2011-11-03 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2f2f56ac8b82 4533691: Add Collections.emptySortedSet() Reviewed-by: mduigou, alanb, dholmes Contributed-by: darryl.mocek at oracle.com ! src/share/classes/java/util/Collections.java + test/java/util/Collections/EmptySortedSet.java Changeset: ead9dabe8c75 Author: lana Date: 2011-11-05 00:00 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ead9dabe8c75 Merge Changeset: 417d91754849 Author: sherman Date: 2011-11-07 13:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/417d91754849 7096080: UTF8 update and new CESU-8 charset 7082884: Incorrect UTF8 conversion for sequence ED 31 7082883: Incorrect UTF8 conversion for sequence fc 80 80 8f bf bf Summary: Updated UTF8 and added CESU-8 to following the latest Standard Reviewed-by: alanb ! make/java/nio/FILES_java.gmk + src/share/classes/sun/nio/cs/CESU_8.java ! src/share/classes/sun/nio/cs/UTF_8.java ! src/share/classes/sun/nio/cs/standard-charsets ! test/java/nio/charset/coders/Errors.java ! test/sun/nio/cs/TestStringCoding.java ! test/sun/nio/cs/TestStringCodingUTF8.java ! test/sun/nio/cs/TestUTF8.java Changeset: 0bb498332894 Author: lana Date: 2011-11-08 15:38 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0bb498332894 Merge Changeset: 51db54a3b953 Author: lana Date: 2011-11-14 18:15 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/51db54a3b953 Merge Changeset: 3b2128c89361 Author: alanb Date: 2011-06-15 14:49 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/3b2128c89361 7000600: InputStream.skip() makes sensitive data accessible to malicious code Reviewed-by: hawtin, chegar ! src/share/classes/java/io/InputStream.java Changeset: 06e0d91548b3 Author: anthony Date: 2011-06-21 20:20 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/06e0d91548b3 7022113: Security icon can be moved behind the window using the com.sun.SecurityWarning.setPosition() method Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Window.cpp Changeset: d32b75c73389 Author: alanb Date: 2011-06-27 20:30 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/d32b75c73389 7059259: (process) ProcessBuilder.start permission check should be improved when redirecting output to append Reviewed-by: hawtin ! src/windows/classes/java/lang/ProcessImpl.java Changeset: 446b13a08aca Author: asaha Date: 2011-06-27 12:30 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/446b13a08aca Merge Changeset: 4fdd1a44e846 Author: asaha Date: 2011-06-27 12:35 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4fdd1a44e846 Merge Changeset: 3e42f7893861 Author: asaha Date: 2011-06-28 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/3e42f7893861 Merge Changeset: f578448792b9 Author: ksrini Date: 2011-07-15 13:57 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f578448792b9 7057857: SIGSEGV [libunpack.so] store_Utf8_char(signed char*, unsigned short) in java.util.jar.pack200 Reviewed-by: jrose, asaha, hawtin ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/share/native/com/sun/java/util/jar/pack/utils.cpp ! src/share/native/com/sun/java/util/jar/pack/utils.h Changeset: 4b20375fe623 Author: asaha Date: 2011-07-19 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4b20375fe623 Merge - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: bc9c70e57f62 Author: asaha Date: 2011-07-20 09:01 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bc9c70e57f62 7032417: Fix for 6981922 does not address multiple VM case Reviewed-by: michaelm ! src/share/classes/sun/net/ResourceManager.java Changeset: a7177942302f Author: asaha Date: 2011-07-20 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a7177942302f 7023640: calculation for malloc size in TransformHelper.c could overflow an integer Reviewed-by: flar ! src/share/native/sun/java2d/loops/TransformHelper.c Changeset: 6c76f2a49061 Author: denis Date: 2011-07-22 21:14 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/6c76f2a49061 7019773: AWTKeyStroke.ctor is a mutable static Reviewed-by: art ! src/share/classes/java/awt/AWTKeyStroke.java Changeset: b25558c39ffc Author: smarks Date: 2011-08-30 14:30 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/b25558c39ffc 7077466: fix for RMI DGC Reviewed-by: valeriep ! src/share/classes/sun/rmi/server/UnicastServerRef.java Changeset: efd8035f3d14 Author: smarks Date: 2011-08-30 17:29 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/efd8035f3d14 7083012: fix for RMI Registry Reviewed-by: jdn, valeriep ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/rmi/server/LoaderHandler.java Changeset: 27bda11f1330 Author: smarks Date: 2011-09-21 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/27bda11f1330 7092186: adjust package access in rmiregistry Reviewed-by: asaha, coffeys ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! test/sun/tools/jstatd/jstatdExternalRegistry.sh Changeset: 42eb725f739c Author: xuelei Date: 2011-09-29 17:31 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/42eb725f739c 7064341: jsse/runtime security problem Reviewed-by: wetmore ! src/share/classes/javax/net/ssl/SSLEngine.java ! src/share/classes/sun/security/ssl/AppOutputStream.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/EngineOutputRecord.java ! src/share/classes/sun/security/ssl/Record.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/CheckStatus.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargeBufs.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargePacket.java Changeset: 53a16cf28db3 Author: xuelei Date: 2011-09-30 18:47 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/53a16cf28db3 7096936: issue in jsse/runtime 7096937: TEST: com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java need modification as a result of TLS fix Reviewed-by: wetmore, jdn, xuelei ! src/share/classes/com/sun/net/ssl/HttpsURLConnection.java ! src/share/classes/javax/net/ssl/HttpsURLConnection.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java Changeset: 27a8f4fc555a Author: asaha Date: 2011-11-14 11:52 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/27a8f4fc555a Merge ! src/share/classes/java/awt/AWTKeyStroke.java ! src/share/classes/javax/net/ssl/HttpsURLConnection.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargePacket.java ! test/sun/tools/jstatd/jstatdExternalRegistry.sh Changeset: 99632935785e Author: lana Date: 2011-11-14 18:18 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/99632935785e Merge From lana.steuck at oracle.com Tue Nov 15 15:50:51 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 15 Nov 2011 23:50:51 +0000 Subject: hg: jdk8/jdk8: 5 new changesets Message-ID: <20111115235052.0D0354737A@hg.openjdk.java.net> Changeset: a62a0f35eb9c Author: asaha Date: 2011-06-27 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/a62a0f35eb9c Merge Changeset: f9b3e6b2aa2c Author: asaha Date: 2011-06-28 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/f9b3e6b2aa2c Merge Changeset: ea2ab83ce564 Author: asaha Date: 2011-07-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/ea2ab83ce564 Merge Changeset: 8f525559ae73 Author: asaha Date: 2011-11-07 21:45 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/8f525559ae73 Merge Changeset: 23aa7f2c80a2 Author: lana Date: 2011-11-14 18:16 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/23aa7f2c80a2 Merge From lana.steuck at oracle.com Tue Nov 15 16:32:54 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 15 Nov 2011 16:32:54 -0800 (PST) Subject: jdk8-b14: JSN, Tools, Core Libraries, Serviceability, 2d, Awt, and Swing Message-ID: <201111160032.pAG0Wstd013190@jano-app.us.oracle.com> http://hg.openjdk.java.net/jdk8/jdk8/rev/23aa7f2c80a2 http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/58f1325d72b2 http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/99632935785e http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/54c4bf4b83ec http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/9d0c9d638757 http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/088d09a130ff http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/e59c47de1ad8 --- Component : 2d Status : 0 major failures, 0 minor failures Date : 11/09/2011 at 11:49 Tested By : Tony Cost(total man-days): 1 Workspace : http://sqe-hg.us.oracle.com/hg/index.cgi/testbase/javase/functional/8/2d/ Bundles : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/build-archive/2011-11-08-234419.jcg-integrator.tl-pit-2d-awt/link-to-jprt-build/bundles Platforms : Others Tests : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/repo.latest-pit/jdk Browsers : NA Patches : NA Logs : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/build-archive/2011-11-08-234419.jcg-integrator.tl-pit-2d-awt/logs/webrev/ Number of Tests Executed : 1 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: 6887286: StackOverflowError at sun.awt.image.ImageWatched$WeakLink.isWatcher Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: 7105640: Unix printing does not check the result of exec'd lpr/lp command Build change only: New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b14 Issues and Notes: ------------------------------- >From Tony Component : awt Status : 0 major failures, 0 minor failures Date : 11/14/2011 at 12:47 Tested By : Yinhe Cao Cost(total man-days): 1 Workspace : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/repo.latest-pit/jdk Bundles : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/build-archive/2011-11-08-234419.jcg-integrator.tl-pit-2d-awt/link-to-jprt-build/bundles Platforms : WinXP Prof(32), -client Tests : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/repo.latest-pit/jdk Browsers : NA Patches : NA Logs : http://sqeweb.sfbay.sun.com/nfs/results/awt/pit/8 Number of Tests Executed : 0 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: 7104625: sun.awt.X11.XEvent is creating 600 MB of char[] for no good reason 7105529: XAWT: Optimize getFieldsAsString() methods generated by WrapperGenerator 7107957: AWT: Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h Build change only: New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b14 Issues and Notes: all 3 fixes are waived. ------------------------------- >From Yinhe Cao The following fixes were waived by SQE: 4243978 java classes_lang (ref) Race condition in Reference.enqueue() 4268317 java classes_lang (ref) Reference.isEnqueued() can return true when instance n 4533691 java classes_util (coll) Please add Collections.EMPTY_SORTED_SET 6624077 java classes_swing Regression test fails: closed/javax/swing/ToolTipManager/625 6921494 java compiler provide way to print javac tree tag values 6955919 java classes_swing Intermittent ClassCastException in bug4492274 test 7000600 java classes_io Problem with java/classes_io 7019773 java classes_awt Problem with java/classes_awt 7022113 java classes_awt Problem with java/classes_awt 7023640 java classes_2d Problem with java/classes_2d 7032417 java classes_net Problem with java/classes_net 7044595 java security Problem with java_deployment/security 7046794 xml jax-ws Problem with xml/jax-ws 7049024 java classes_swing DnD fails with JTextArea and JTextField 7053252 jce runtime New regression test does not compile on windows-amd64 7055902 jets idl Problem with jets/idl 7057857 java classes_util_jar Problem with java/classes_util_jarzip 7059259 java classes_lang Problem with java/classes_lang 7064341 jsse runtime Problem with jsse/runtime 7074853 java demo TransparentRuler demos Readme should mention the correct jar 7077293 java classes_swing javax/swing/JComponent/4337267/bug4337267.java failed on win 7077466 java rmi Problem with java/rmi 7080203 java classes_swing JTree.getSelectionPaths() now returns empty array instead of 7082883 java char_encodings Incorrect UTF8 conversion for sequence fc 80 80 8f bf bf 7082884 java char_encodings Incorrect UTF8 conversion for sequence ED 31 7083012 java rmi Problem with java/rmi 7085305 java rmi TEST: need jtreg tests for 7077466 and 7083012 7086289 java monitoring Missing jdk/test/closed testcase. 7089987 java cte_test TEST: sun/rmi/registry/7083012/Test7083012.sh works incorrec 7090046 java classes_text Lots of invalid link in java.text.BreakIterator comments 7092186 java rmi AccessControlException for rmiregistry trying to reference c 7094155 java classes_security JSR105 code throws javax.xml.crypto.URIReferenceException wh 7096080 java char_encodings UTF8 update and new CESU-8 charset 7096936 jsse runtime Problem with jsse/runtime 7096937 jsse regtests TEST: com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java n 7099251 java classes_swing javax.swing.text.html.HTMLDocument.insertAfterStart(null, so 7099658 java classes_util Properties.loadFromXML fails with ClassCastException 7100004 java classes_swing javax.swing.JTable.setAutoCreateRowSorter(boolean autoCreate 7101933 java build langtools jtreg tests do not work with jprt on windows 7103889 java classes_nio (fs) Reduce String concatenation when iterating over directo 7104161 hots svc_agent test/sun/tools/jinfo/Basic.sh fails on Ubuntu 7104201 java compiler Refactor DocCommentScanner 7104650 java classes_other rawtype warnings in several net, nio and security source fil 7105780 jsse runtime Add SSLSocket client/SSLEngine server to templates directory 7105940 jsse regtests Test regression: KeyStore must be from provider SunPKCS11-NS 7106277 jsse runtime Brokenness in the seqNumberOverflow of MAC 7107585 java classes_swing Test incorrect calculate position of object on frame 7110676 xml jax-ws Update jaf source download url for jaxws From frederic.parain at oracle.com Wed Nov 16 02:30:52 2011 From: frederic.parain at oracle.com (Frederic Parain) Date: Wed, 16 Nov 2011 11:30:52 +0100 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <4EC390DC.9000702@oracle.com> Vote: yes On 11/15/11 03:47 PM, Artem Ananiev wrote: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of > JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > -- Frederic Parain - Oracle Grenoble Engineering Center - France Phone: +33 4 76 18 81 17 Email: Frederic.Parain at Oracle.com From david.katleman at sun.com Thu Nov 17 16:26:50 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Fri, 18 Nov 2011 00:26:50 +0000 Subject: hg: jdk8/jdk8: Added tag jdk8-b14 for changeset 23aa7f2c80a2 Message-ID: <20111118002650.829AB473BE@hg.openjdk.java.net> Changeset: a4f28069d44a Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/a4f28069d44a Added tag jdk8-b14 for changeset 23aa7f2c80a2 ! .hgtags From david.katleman at sun.com Thu Nov 17 16:27:01 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Fri, 18 Nov 2011 00:27:01 +0000 Subject: hg: jdk8/jdk8/corba: Added tag jdk8-b14 for changeset e59c47de1ad8 Message-ID: <20111118002701.A7349473BF@hg.openjdk.java.net> Changeset: 99925e8d1b86 Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/99925e8d1b86 Added tag jdk8-b14 for changeset e59c47de1ad8 ! .hgtags From david.katleman at sun.com Thu Nov 17 16:27:51 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Fri, 18 Nov 2011 00:27:51 +0000 Subject: hg: jdk8/jdk8/hotspot: Added tag jdk8-b14 for changeset 088d09a130ff Message-ID: <20111118002753.A7E19473C0@hg.openjdk.java.net> Changeset: 883328bfc472 Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/883328bfc472 Added tag jdk8-b14 for changeset 088d09a130ff ! .hgtags From david.katleman at sun.com Thu Nov 17 16:29:37 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Fri, 18 Nov 2011 00:29:37 +0000 Subject: hg: jdk8/jdk8/jaxp: Added tag jdk8-b14 for changeset 9d0c9d638757 Message-ID: <20111118002937.B1687473C1@hg.openjdk.java.net> Changeset: 804f666d6d44 Author: katleman Date: 2011-11-17 10:45 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/804f666d6d44 Added tag jdk8-b14 for changeset 9d0c9d638757 ! .hgtags From david.katleman at sun.com Thu Nov 17 16:29:48 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Fri, 18 Nov 2011 00:29:48 +0000 Subject: hg: jdk8/jdk8/jaxws: Added tag jdk8-b14 for changeset 54c4bf4b83ec Message-ID: <20111118002948.4B9FE473C2@hg.openjdk.java.net> Changeset: c9ab96ff23d5 Author: katleman Date: 2011-11-17 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/c9ab96ff23d5 Added tag jdk8-b14 for changeset 54c4bf4b83ec ! .hgtags From david.katleman at sun.com Thu Nov 17 16:30:06 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Fri, 18 Nov 2011 00:30:06 +0000 Subject: hg: jdk8/jdk8/jdk: Added tag jdk8-b14 for changeset 99632935785e Message-ID: <20111118003020.A8AFF473C3@hg.openjdk.java.net> Changeset: 00e2c88e2234 Author: katleman Date: 2011-11-17 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/00e2c88e2234 Added tag jdk8-b14 for changeset 99632935785e ! .hgtags From david.katleman at sun.com Thu Nov 17 16:31:53 2011 From: david.katleman at sun.com (david.katleman at sun.com) Date: Fri, 18 Nov 2011 00:31:53 +0000 Subject: hg: jdk8/jdk8/langtools: Added tag jdk8-b14 for changeset 58f1325d72b2 Message-ID: <20111118003157.8CA98473C4@hg.openjdk.java.net> Changeset: 16906df5bffc Author: katleman Date: 2011-11-17 10:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/16906df5bffc Added tag jdk8-b14 for changeset 58f1325d72b2 ! .hgtags From bengt.rutisson at oracle.com Thu Nov 17 23:09:01 2011 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Fri, 18 Nov 2011 08:09:01 +0100 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <4EC6048D.6000902@oracle.com> Vote: abstain I don't know Alexander Scherbatiy and I know too little about JDK development to judge whether or not his contributed changes are non-trivial. Bengt On 2011-11-15 15:47, Artem Ananiev wrote: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of > JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > From sajia at taobao.com Fri Nov 18 00:22:23 2011 From: sajia at taobao.com (=?gb2312?B?yPblyA==?=) Date: Fri, 18 Nov 2011 16:22:23 +0800 Subject: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor Message-ID: Hi all, I'd like to propose the following change to JDK's sun.nio.ch.SocketAdaptor: In OpenJDK 6, 7 and 8, sun.nio.ch.SocketAdaptor is used to adapt a SocketChannelImpl to a java.net.Socket. A comment in the constructor of SocketAdaptor says "super will create a useless impl", but it actually doesn't have to. AFAICT the SocksSocketImpl instance created here really isn't used at all in SocketAdaptor, unless someone invokes non-public methods on java.net.Socket via reflection. The attached patch is to get rid of creation of the useless SocksSocketImpl. At a glance, creating a useless SocksSocketImpl for every SocketAdaptor seems innocent. But that's not the case when the allocation rate/heap memory pressure is high. SocksSocketImpl has a finalizer (inherited from PlainSocketImpl), and when: * old generation is large * there are a lot of ready-to-die SocksSocketImpl instances these instances can be queued up in the finalizer queue, which increases the heap pressure. In one of our Hadoop NameNode nodes in production, excessive SocksSocketImpl instances had been causing frequent CMS collections + long reference processing pause. Using this patch helps side-steping the problem. I don't have a bug ID for this yet. Could anyone kindly open a bug for this? Regards, Kris Mok Software Engineer, Taobao (http://www.taobao.com) ________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. ??????(????????????)???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? From rednaxelafx at gmail.com Fri Nov 18 00:38:28 2011 From: rednaxelafx at gmail.com (Krystal Mok) Date: Fri, 18 Nov 2011 16:38:28 +0800 Subject: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor In-Reply-To: References: Message-ID: Oops, looks like my company email stripped the attachment. Here's that patch again: diff -r 00e2c88e2234 src/share/classes/sun/nio/ch/SocketAdaptor.java --- a/src/share/classes/sun/nio/ch/SocketAdaptor.java Thu Nov 17 10:46:02 2011 -0800 +++ b/src/share/classes/sun/nio/ch/SocketAdaptor.java Fri Nov 18 15:37:20 2011 +0800 @@ -57,13 +57,17 @@ // Timeout "option" value for reads private volatile int timeout = 0; - // ## super will create a useless impl - private SocketAdaptor(SocketChannelImpl sc) { + private SocketAdaptor(SocketChannelImpl sc) throws SocketException { + super((SocketImpl) null); this.sc = sc; } public static Socket create(SocketChannelImpl sc) { - return new SocketAdaptor(sc); + try { + return new SocketAdaptor(sc); + } catch (SocketException e) { + throw new RuntimeException("should not reach here"); + } } public SocketChannel getChannel() { - Kris 2011/11/18 ???? > Hi all, > > I'd like to propose the following change to JDK's sun.nio.ch.SocketAdaptor: > > In OpenJDK 6, 7 and 8, sun.nio.ch.SocketAdaptor is used to adapt a > SocketChannelImpl to a java.net.Socket. > > A comment in the constructor of SocketAdaptor says "super will create a > useless impl", but it actually doesn't have to. AFAICT the SocksSocketImpl > instance created here really isn't used at all in SocketAdaptor, unless > someone invokes non-public methods on java.net.Socket via reflection. > > The attached patch is to get rid of creation of the useless > SocksSocketImpl. > > At a glance, creating a useless SocksSocketImpl for every SocketAdaptor > seems innocent. But that's not the case when the allocation rate/heap > memory pressure is high. SocksSocketImpl has a finalizer (inherited from > PlainSocketImpl), and when: > * old generation is large > * there are a lot of ready-to-die SocksSocketImpl instances > these instances can be queued up in the finalizer queue, which increases > the heap pressure. > > In one of our Hadoop NameNode nodes in production, excessive > SocksSocketImpl instances had been causing frequent CMS collections + long > reference processing pause. Using this patch helps side-steping the problem. > > I don't have a bug ID for this yet. Could anyone kindly open a bug for > this? > > Regards, > Kris Mok > Software Engineer, Taobao (http://www.taobao.com) > > ________________________________ > This email (including any attachments) is confidential and may be legally > privileged. If you received this email in error, please delete it > immediately and do not copy it or use it for any purpose or disclose its > contents to any other person. Thank you. > > > ??????(????????????)???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? > From christian.thalinger at oracle.com Fri Nov 18 01:14:28 2011 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Fri, 18 Nov 2011 10:14:28 +0100 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <01AF6C0C-3244-4D24-A196-90B100BCCCFC@oracle.com> Vote: abstain The same what Bengt just said applies to me too. -- Chris On Nov 15, 2011, at 3:47 PM, Artem Ananiev wrote: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > From david.holmes at oracle.com Fri Nov 18 03:59:20 2011 From: david.holmes at oracle.com (David Holmes) Date: Fri, 18 Nov 2011 21:59:20 +1000 Subject: Suppress creation of SocksSocketImpl in SocketAdaptor's constructor In-Reply-To: References: Message-ID: <4EC64898.4090506@oracle.com> Probably better discussed on nio-dev list. David On 18/11/2011 6:22 PM, ???? wrote: > Hi all, > > I'd like to propose the following change to JDK's sun.nio.ch.SocketAdaptor: > > In OpenJDK 6, 7 and 8, sun.nio.ch.SocketAdaptor is used to adapt a SocketChannelImpl to a java.net.Socket. > > A comment in the constructor of SocketAdaptor says "super will create a useless impl", but it actually doesn't have to. AFAICT the SocksSocketImpl instance created here really isn't used at all in SocketAdaptor, unless someone invokes non-public methods on java.net.Socket via reflection. > > The attached patch is to get rid of creation of the useless SocksSocketImpl. > > At a glance, creating a useless SocksSocketImpl for every SocketAdaptor seems innocent. But that's not the case when the allocation rate/heap memory pressure is high. SocksSocketImpl has a finalizer (inherited from PlainSocketImpl), and when: > * old generation is large > * there are a lot of ready-to-die SocksSocketImpl instances > these instances can be queued up in the finalizer queue, which increases the heap pressure. > > In one of our Hadoop NameNode nodes in production, excessive SocksSocketImpl instances had been causing frequent CMS collections + long reference processing pause. Using this patch helps side-steping the problem. > > I don't have a bug ID for this yet. Could anyone kindly open a bug for this? > > Regards, > Kris Mok > Software Engineer, Taobao (http://www.taobao.com) > > ________________________________ > This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. > > ??????(????????????)???????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????????? From neugens.limasoftware at gmail.com Fri Nov 18 09:04:09 2011 From: neugens.limasoftware at gmail.com (Mario Torre) Date: Fri, 18 Nov 2011 18:04:09 +0100 Subject: CFV: New JDK8 Committer: Alexander Scherbatiy In-Reply-To: <4EC27B7F.2050205@oracle.com> References: <4EC27B7F.2050205@oracle.com> Message-ID: <1EA9B2C3-00CE-4E86-9B89-857A66979AB5@gmail.com> Vote: Yes Mario Il giorno 15/nov/2011, alle ore 15:47, Artem Ananiev ha scritto: > > I hereby nominate Alexander Scherbatiy to JDK8 Committer. > > Alexander has contributed several changes in Swing, which is a part of JDK8. Here is the list of fixes: > > http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=scherba > > Votes are due by Nov 29, 2011. > > Only current JDK8 Committers [1] are eligible to vote on this nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thanks, > > Artem > > [1] http://openjdk.java.net/census#jdk8 > [2] http://openjdk.java.net/projects#committer-vote > --- pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF http://www.ladybug-studio.com IcedRobot: www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ From matthew at matthewadams.me Fri Nov 18 10:16:07 2011 From: matthew at matthewadams.me (Matthew Adams) Date: Fri, 18 Nov 2011 12:16:07 -0600 Subject: Reflection syntax sugar Message-ID: Hi all, I'm hoping that reflection syntax sugar enhancements can make it into JDK8. It appears the consolidated issue, referencing several others & which looks the most promising IMHO, is at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5043025 It uses the javadoc-like syntax, primary the # operator, with some other suggestions by me & others. I entered my own issue that was closed as a duplicate of 5043025: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6915224 One thing about my request that deserves discussion is whether it's a compile-time error if the fields, annotations, constructors & methods referred to are not present. I was thinking that it should be selectable by the developer, but then it would require a new @SupressErrors annotation (like @SupressWarnings). That might open up a can of worms, though. Please review the issues above and those reachable from them. Is this feasible? It has good application in the area of query in JDO, JPA & others. Thanks, Matthew -- @matthewadams12 mailto:matthew at matthewadams.me skype:matthewadams12 yahoo:matthewadams aol:matthewadams12 google-talk:matthewadams12 at gmail.com msn:matthew at matthewadams.me http://matthewadams.me http://www.linkedin.com/in/matthewadams From forax at univ-mlv.fr Fri Nov 18 11:32:49 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Fri, 18 Nov 2011 20:32:49 +0100 Subject: Reflection syntax sugar In-Reply-To: References: Message-ID: <4EC6B2E1.704@univ-mlv.fr> JDK8 will include a method reference syntax which can be seen as a typesafe way to handle a reference to a method. By example, Runnable runnable = "foo"::length; should compile. The slide from Brian Goetz explaining lambda and method reference is available here: http://blogs.oracle.com/briangoetz/entry/slides_from_devoxx_talk_on You can test a prototype here: http://jdk8.java.net/lambda/ (the syntax implemented in the prototype for method reference use '#' instead of '::') Compared to reflection a method reference/lambda call through a functional interface should be faster than using the reflection (at least until the reflection is rewritten to use the same mechanism as the one used for implementing lambda). No syntax for typesafe property will be not included in jdk8, perhaps in 9 when JavaFX will be merged in the jdk. cheers, R?mi On 11/18/2011 07:16 PM, Matthew Adams wrote: > Hi all, > > I'm hoping that reflection syntax sugar enhancements can make it into JDK8. > > It appears the consolidated issue, referencing several others& which looks > the most promising IMHO, is at > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5043025 > > It uses the javadoc-like syntax, primary the # operator, with some other > suggestions by me& others. I entered my own issue that was closed as a > duplicate of 5043025: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6915224 > > One thing about my request that deserves discussion is whether it's a > compile-time error if the fields, annotations, constructors& methods > referred to are not present. I was thinking that it should be selectable > by the developer, but then it would require a new @SupressErrors annotation > (like @SupressWarnings). That might open up a can of worms, though. > > Please review the issues above and those reachable from them. Is this > feasible? It has good application in the area of query in JDO, JPA& > others. > > Thanks, > Matthew From matthew at matthewadams.me Fri Nov 18 13:03:57 2011 From: matthew at matthewadams.me (Matthew Adams) Date: Fri, 18 Nov 2011 15:03:57 -0600 Subject: Reflection syntax sugar In-Reply-To: <4EC6B2E1.704@univ-mlv.fr> References: <4EC6B2E1.704@univ-mlv.fr> Message-ID: Interesting slides, thanks. Not a big deal, but why the switch from "#" to operator "::"? Regardless of that answer, using the "::" operator for member access syntax sugar would lead to the following (taken from my comments in http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5043025). I think these are pretty promising. Your thoughts? // field syntax assert Foo::someField instanceof Field; // method syntax assert Foo::someMethod(String,int) instanceof Method; // constructor syntax assert Foo::() instanceof Constructor; // no-arg ctor assert Foo::(String,Bar) instanceof Constructor; // ctor w/args // package? assert package::org.example instanceof Package; // maybe? // class annotation assert Foo::@SomeAnnotation instanceof Annotation; // field annotation assert Foo::someField at SomeAnnotation // method annotation assert Foo::someMethod(String,int)@SomeAnnotation instanceof Annotation; // method parameter annotation assert Foo::someMethod(String at SomeAnnotation,int) instanceof Annotation; // constructor parameter annotation assert Foo::(String at SomeAnnotation,int) instanceof Annotation; // package annotation? assert package::org.example at SomeAnnotation instanceof Annotation; // ? On Fri, Nov 18, 2011 at 1:32 PM, R?mi Forax wrote: > > JDK8 will include a method reference syntax which can be seen > as a typesafe way to handle a reference to a method. > > By example, > ?Runnable runnable = "foo"::length; > should compile. > > The slide from Brian Goetz explaining lambda and method reference is available here: > http://blogs.oracle.com/briangoetz/entry/slides_from_devoxx_talk_on > > You can test a prototype here: > ?http://jdk8.java.net/lambda/ > (the syntax implemented in the prototype for method reference use '#' instead of '::') > > Compared to reflection a method reference/lambda call through > a functional interface should be faster than using the reflection > (at least until the reflection is rewritten to use the same mechanism > as the one used for implementing lambda). > > No syntax for typesafe property will be not included in jdk8, > perhaps in 9 when JavaFX will be merged in the jdk. > > cheers, > R?mi > > On 11/18/2011 07:16 PM, Matthew Adams wrote: >> >> Hi all, >> >> I'm hoping that reflection syntax sugar enhancements can make it into JDK8. >> >> It appears the consolidated issue, referencing several others& ?which looks >> the most promising IMHO, is at >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=5043025 >> >> It uses the javadoc-like syntax, primary the # operator, with some other >> suggestions by me& ?others. ?I entered my own issue that was closed as a >> duplicate of 5043025: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6915224 >> >> One thing about my request that deserves discussion is whether it's a >> compile-time error if the fields, annotations, constructors& ?methods >> referred to are not present. ?I was thinking that it should be selectable >> by the developer, but then it would require a new @SupressErrors annotation >> (like @SupressWarnings). ?That might open up a can of worms, though. >> >> Please review the issues above and those reachable from them. ?Is this >> feasible? ?It has good application in the area of query in JDO, JPA& >> others. >> >> Thanks, >> Matthew > -- @matthewadams12 mailto:matthew at matthewadams.me skype:matthewadams12 yahoo:matthewadams aol:matthewadams12 google-talk:matthewadams12 at gmail.com msn:matthew at matthewadams.me http://matthewadams.me http://www.linkedin.com/in/matthewadams From matthew at matthewadams.me Fri Nov 18 13:25:38 2011 From: matthew at matthewadams.me (Matthew Adams) Date: Fri, 18 Nov 2011 15:25:38 -0600 Subject: "it"? "#"? ""? Message-ID: I just got through the slides at http://blogs.oracle.com/briangoetz/entry/slides_from_devoxx_talk_on and noticed a nice feature inspired by Groovy that was missing from the slide code examples. I don't know if it's missing from the lambda proposal, though -- I can't tell from the slides. Groovy defaults the name of a single closure argument to "it". I think this would be nice to have in JDK8 lambdas, too. ===== // Without "it": void expire(File root, long before) { ... root.listFiles(File p -> p.lastModified() <= before); ... } ===== // With "it": void expire(File root, long before) { ... root.listFiles(it.lastModified() <= before); ... } ====== Is this possible to include, or will the grammar require "->" so that "it.lastModified <= before" isn't interpreted by the compiler as a boolean expression? If that's the case, how about considering "#" (or some other appropriate character) instead of "it"? That way, the compiler would know implicitly that if it encounters a "#", it *must* be a lambda expression taking a single variable of an inferred type: ===== // With "#": void expire(File root, long before) { ... root.listFiles(#.lastModified() <= before); ... } ====== You could even reduce "it" or "#" to an empty string and just use the "." with no preceding scope. I don't know if the grammar could support it, but it's interesting. I'm not sure I like it, but is sure is compact! ===== // With "": void expire(File root, long before) { ... root.listFiles(.lastModified() <= before); ... } ====== Another example: ===== // explicit lambda param name Set favs = albums .filter(a -> a.tracks.anyMatch(t -> (t.rating >= 4))) .into(new HashSet<>()); ===== // "it" Set favs = albums .filter(it.tracks.anyMatch(it.rating >= 4)) // 2 its!?!? .into(new HashSet<>()); ===== // "#" Set favs = albums .filter(#.tracks.anyMatch(#.rating >= 4)) .into(new HashSet<>()); ===== // "" Set favs = albums .filter(.tracks.anyMatch(.rating >= 4)) .into(new HashSet<>()); ===== Thoughts? -matthew From forax at univ-mlv.fr Fri Nov 18 15:12:35 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Sat, 19 Nov 2011 00:12:35 +0100 Subject: "it"? "#"? ""? In-Reply-To: References: Message-ID: <4EC6E663.6050908@univ-mlv.fr> Matthew, there is a special list for discussing about lambdas: lambda-dev at openjdk.java.net that is better for this kind of proposal. Also you can take a look to the archive, or ask google to dig in it, http://mail.openjdk.java.net/pipermail/lambda-dev/ there is a good chance that there is a thread about 'it'. R?mi On 11/18/2011 10:25 PM, Matthew Adams wrote: > I just got through the slides at > http://blogs.oracle.com/briangoetz/entry/slides_from_devoxx_talk_on > and noticed a nice feature inspired by Groovy that was missing from the > slide code examples. I don't know if it's missing from the lambda > proposal, though -- I can't tell from the slides. > > Groovy defaults the name of a single closure argument to "it". I think > this would be nice to have in JDK8 lambdas, too. > > ===== > // Without "it": > void expire(File root, long before) { > ... > root.listFiles(File p -> p.lastModified()<= before); > ... > } > ===== > // With "it": > void expire(File root, long before) { > ... > root.listFiles(it.lastModified()<= before); > ... > } > ====== > > Is this possible to include, or will the grammar require "->" so that > "it.lastModified<= before" isn't interpreted by the compiler as a boolean > expression? If that's the case, how about considering "#" (or some other > appropriate character) instead of "it"? That way, the compiler would know > implicitly that if it encounters a "#", it *must* be a lambda expression > taking a single variable of an inferred type: > > ===== > // With "#": > void expire(File root, long before) { > ... > root.listFiles(#.lastModified()<= before); > ... > } > ====== > > You could even reduce "it" or "#" to an empty string and just use the "." > with no preceding scope. I don't know if the grammar could support it, but > it's interesting. I'm not sure I like it, but is sure is compact! > > ===== > // With "": > void expire(File root, long before) { > ... > root.listFiles(.lastModified()<= before); > ... > } > ====== > > Another example: > ===== > // explicit lambda param name > Set favs = albums > .filter(a -> a.tracks.anyMatch(t -> (t.rating>= 4))) > .into(new HashSet<>()); > ===== > // "it" > Set favs = albums > .filter(it.tracks.anyMatch(it.rating>= 4)) // 2 its!?!? > .into(new HashSet<>()); > ===== > // "#" > Set favs = albums > .filter(#.tracks.anyMatch(#.rating>= 4)) > .into(new HashSet<>()); > ===== > // "" > Set favs = albums > .filter(.tracks.anyMatch(.rating>= 4)) > .into(new HashSet<>()); > ===== > > Thoughts? > > -matthew From eirik.lygre at gmail.com Sun Nov 20 14:34:27 2011 From: eirik.lygre at gmail.com (Eirik Lygre) Date: Sun, 20 Nov 2011 23:34:27 +0100 Subject: Syntactic sugar for method chaining / fluent interfaces Syntactic sugar for method chaining / fluent interfaces Syntactic sugar for method chaining / fluent interfaces Message-ID: It seems that the various Java SE 8 projects have lots of care for simple and expressive code, for example as demonstrated by the "Language / Library / VM co-evolution in Java SE 8" presentation from Devoxx. Hence, I wonder if there is any interest for reviving an older suggestion about simple method chaining / fluent interface. I'm not really qualified to suggest the formal syntax, but it probably boils down to this: A void method call "object.function(...)" evaluates to the object itself This will be syntactic sugar (compiler only, no jvm changes), making it possible to chain method calls across void methods. For example: Socket so = new SSLSocket() .setSendBufferSize(1024) // void Socket.setSendBufferSize(int) .setReceiveBufferSize(1024) // void Socket.setSendBufferSize(int) .setNeedClientAuth(true); // void SSLSocket.setNeedClientAuth(boolean) A couple of points on the rationale for the suggestion: * First, it will enable method chaining on a large body of existing code. The javabeans spec says that setters should return void, and this suggestion would automatically allow fluent use of such beans. * It will allow a level of fluent interfaces that are otherwise not possible, in that it will simulate a "self" return type. If you want to implement a fluent interface today, you would return your own type. If somebody then created a subclass, and wanted to maintain fluency, they would have to override all parent methods, as shown below. Of course, this means that fluent methods added to the superclass must also be added to all subclasses, which isn't really an ideal situation if you want to evolve an api. class Socket { Socket setSendBufferSize(...); // Can be chained } class SSLSocket extends Socket { SSLSocket setSendBufferSize(...) { // Change return type, to maintain chainability return (SSLSocket)super.setSendBufferSize(...); // Cast required. } } This is not a new idea. It was suggested for project coin, where there are more references: * It was suggested for project coin by Ulf Zibis ( http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/001180.html). * I've not found much discussion, other than a quick email from Joe Darcy ( http://mail.openjdk.java.net/pipermail/coin-dev/2009-May/001768.html), where the idea is rejected: "While fluent interfaces are fine, I don't think using a language change to retrofit this pattern of API usage on code not written that way is the best use of the language change budget." While it was considered (and rejected) for SE 7, it might still be proper for SE 8. Method chaning / fluent interfaces are used in pretty much all lambda examples, as a useful code pattern. I think it's useful, too, and think it should be made easier accessible across the language. I've got two hopes for this email: * First, feedback on whether the community considers this to be useful, or not * Second, feedback on how to proceed, if it is in fact considered useful Eirik Lygre eirik.lygre at gmail.com From develop4lasu at gmail.com Mon Nov 21 06:07:12 2011 From: develop4lasu at gmail.com (=?UTF-8?Q?Marek_Kozie=C5=82?=) Date: Mon, 21 Nov 2011 15:07:12 +0100 Subject: Syntactic sugar for method chaining / fluent interfaces Syntactic sugar for method chaining / fluent interfaces Syntactic sugar for method chaining / fluent interfaces In-Reply-To: References: Message-ID: 2011/11/20 Eirik Lygre : > It seems that the various Java SE 8 projects have lots of care for simple > and expressive code, for example as demonstrated by the "Language / Library > / VM co-evolution in Java SE 8" presentation from Devoxx. Hence, I wonder > if there is any interest for reviving an older suggestion about simple > method chaining / fluent interface. > > I'm not really qualified to suggest the formal syntax, but it probably > boils down to this: > > ? ?A void method call "object.function(...)" evaluates to the object itself > > This will be syntactic sugar (compiler only, no jvm changes), making it > possible to chain method calls across void methods. For example: > > ? ?Socket so = new SSLSocket() > ? ? ? ? ? ? ? ?.setSendBufferSize(1024) ? ? ? ?// void > Socket.setSendBufferSize(int) > ? ? ? ? ? ? ? ?.setReceiveBufferSize(1024) ? ? // void > Socket.setSendBufferSize(int) > ? ? ? ? ? ? ? ?.setNeedClientAuth(true); ? ? ? // void > SSLSocket.setNeedClientAuth(boolean) > > A couple of points on the rationale for the suggestion: > > * First, it will enable method chaining on a large body of existing code. > The javabeans spec says that setters should return void, and this > suggestion would automatically allow fluent use of such beans. > > * It will allow a level of fluent interfaces that are otherwise not > possible, in that it will simulate a "self" return type. If you want to > ?implement a fluent interface today, you would return your own type. If > somebody then created a subclass, and wanted to maintain fluency, they > would have to override all parent methods, as shown below. Of course, this > means that fluent methods added to the superclass must also be added to all > subclasses, which isn't really an ideal situation if you want to evolve an > api. > > ? ?class Socket { > ? ? ? ?Socket setSendBufferSize(...); ? // Can be chained > ? ?} > > ? ?class SSLSocket extends Socket { > ? ? ? ?SSLSocket setSendBufferSize(...) { ? ? ? ? ? ? ? ? ? ? ?// Change > return type, to maintain chainability > ? ? ? ? ? ?return (SSLSocket)super.setSendBufferSize(...); ? ? // Cast > required. > ? ? ? ?} > ? ?} > > This is not a new idea. It was suggested for project coin, where there are > more references: > > * It was suggested for project coin by Ulf Zibis ( > http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/001180.html). > * I've not found much discussion, other than a quick email from Joe Darcy ( > http://mail.openjdk.java.net/pipermail/coin-dev/2009-May/001768.html), > where the idea is rejected: "While fluent interfaces are fine, I don't > think using a language change ?to retrofit this pattern of API usage on > code not written that way is ?the best use of the language change budget." > > While it was considered (and rejected) for SE 7, it might still be proper > for SE 8. Method chaning / fluent interfaces are used in pretty much all > lambda examples, as a useful code pattern. I think it's useful, too, and > think it should be made easier accessible across the language. > > I've got two hopes for this email: > > * First, feedback on whether the community considers this to be useful, or > not > * Second, feedback on how to proceed, if it is in fact considered useful > > Eirik Lygre > eirik.lygre at gmail.com > There are more reasons against. One of the most important problem occurs when void will be changed into other type in future. How hard to track bugs can be when new return type will have same methods as 'this'? 'Return 'this' proposal' was made to fill that gap. Some of discussion can be found under (but there where more about it): http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/000523.html and little under: http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/000107.html -- Regards. Lasu aka Marek Kozie? From eirik.lygre at gmail.com Mon Nov 21 17:22:18 2011 From: eirik.lygre at gmail.com (Eirik Lygre) Date: Tue, 22 Nov 2011 02:22:18 +0100 Subject: Syntactic sugar for method chaining / fluent interfaces Syntactic sugar for method chaining / fluent interfaces Syntactic sugar for method chaining / fluent interfaces In-Reply-To: References: Message-ID: On Mon, Nov 21, 2011 at 3:07 PM, Marek Kozie? wrote: > 2011/11/20 Eirik Lygre : > > It seems that the various Java SE 8 projects have lots of care for simple > > and expressive code, for example as demonstrated by the "Language / > Library > > / VM co-evolution in Java SE 8" presentation from Devoxx. Hence, I wonder > > if there is any interest for reviving an older suggestion about simple > > method chaining / fluent interface. > > > > I'm not really qualified to suggest the formal syntax, but it probably > > boils down to this: > > > > A void method call "object.function(...)" evaluates to the object > itself > > > > This will be syntactic sugar (compiler only, no jvm changes), making it > > possible to chain method calls across void methods. For example: > > > > Socket so = new SSLSocket() > > .setSendBufferSize(1024) // void > > Socket.setSendBufferSize(int) > > .setReceiveBufferSize(1024) // void > > Socket.setSendBufferSize(int) > > .setNeedClientAuth(true); // void > > SSLSocket.setNeedClientAuth(boolean) > > > > A couple of points on the rationale for the suggestion: > > > > * First, it will enable method chaining on a large body of existing code. > > The javabeans spec says that setters should return void, and this > > suggestion would automatically allow fluent use of such beans. > > > > * It will allow a level of fluent interfaces that are otherwise not > > possible, in that it will simulate a "self" return type. If you want to > > implement a fluent interface today, you would return your own type. If > > somebody then created a subclass, and wanted to maintain fluency, they > > would have to override all parent methods, as shown below. Of course, > this > > means that fluent methods added to the superclass must also be added to > all > > subclasses, which isn't really an ideal situation if you want to evolve > an > > api. > > > > class Socket { > > Socket setSendBufferSize(...); // Can be chained > > } > > > > class SSLSocket extends Socket { > > SSLSocket setSendBufferSize(...) { // Change > > return type, to maintain chainability > > return (SSLSocket)super.setSendBufferSize(...); // Cast > > required. > > } > > } > > > > This is not a new idea. It was suggested for project coin, where there > are > > more references: > > > > * It was suggested for project coin by Ulf Zibis ( > > http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/001180.html). > > * I've not found much discussion, other than a quick email from Joe > Darcy ( > > http://mail.openjdk.java.net/pipermail/coin-dev/2009-May/001768.html), > > where the idea is rejected: "While fluent interfaces are fine, I don't > > think using a language change to retrofit this pattern of API usage on > > code not written that way is the best use of the language change > budget." > > > > While it was considered (and rejected) for SE 7, it might still be proper > > for SE 8. Method chaning / fluent interfaces are used in pretty much all > > lambda examples, as a useful code pattern. I think it's useful, too, and > > think it should be made easier accessible across the language. > > > > I've got two hopes for this email: > > > > * First, feedback on whether the community considers this to be useful, > or > > not > > * Second, feedback on how to proceed, if it is in fact considered useful > > > > Eirik Lygre > > eirik.lygre at gmail.com > > > > > There are more reasons against. > One of the most important problem occurs when void will be changed > into other type in future. How hard to track bugs can be when new return type will have same > methods as 'this'? 'Return 'this' proposal' was made to fill that gap. > Some of discussion can be found under (but there where more about it): > http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/000523.html > > > and little under: > http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/000107.html > > -- > Regards. > Lasu aka Marek Kozie? > Since you give only one example, I'll have to limit my comment to that one. On the other hand, you have a suggestion for an alternative syntax to the same problem, so I guess we have a common goal :-) You say that the problem occurs when "void will be changed into other type in the future". That problem, however, applies to any fluent interface, whether manually specified, using the mechanism I described, or the mechanism you described. For example, using an abstract class that writes to somewhere: class Output { public Output append (char c); // Manual fluent interface public void append (CharSeq csq); // My suggestion public this append (CharSeq csq, int s, int e); // Your suggestion } Now, all of these would suffer from hard debugging if the return type was changed from one of Output, void or append to, say, java.lang.Appendable, as the following would all compile: // All of these will first call Output.append(), then // Appendable.append new Output().append('a').append('b'); new Output().append("a").append("b"); new Output().append("a",0,1).append("a",0.1); My suggestion has the advantage, or disadvantage, of "just working" with a lot of existing api's (including all api's that comply to the javabeans specification). To me, that is a great advantage. It is correct that opening for auto-fluency using void methods, or whatever this proposal should be called, will "lock down" existing void methods. However, that is pretty much the case already today, since changing the return type of a method will invalidate any subclass which tries to override the method ("sub cannot override func() in super; attempting to use incompatible return type") And, the benefits are there. They are not purely cosmetic, but also functional. * It will significantly simplify fluent programming * It will enable fluent apis that cannot be made today * It will enable fluent thinking on existing code * No existing programs will fail or change behavior -- Eirik From john.coomes at oracle.com Wed Nov 23 13:13:28 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Wed, 23 Nov 2011 21:13:28 +0000 Subject: hg: jdk8/jdk8/hotspot: 42 new changesets Message-ID: <20111123211449.E52E94743E@hg.openjdk.java.net> Changeset: 869804b759e7 Author: jcoomes Date: 2011-11-04 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/869804b759e7 7108553: Bump the hs23 build number to 06 Reviewed-by: johnc Contributed-by: alejandro.murillo at oracle.com ! make/hotspot_version Changeset: 5bda8dae4e14 Author: never Date: 2011-10-23 20:23 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/5bda8dae4e14 7103784: enable some flags by default Reviewed-by: kvn ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 754110e02bd5 Author: never Date: 2011-10-23 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/754110e02bd5 7103380: assertion failure with -XX:+PrintNativeNMethods Reviewed-by: kvn, iveresov ! src/share/vm/asm/codeBuffer.cpp Changeset: 42783d1414b2 Author: never Date: 2011-10-23 23:57 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/42783d1414b2 Merge - make/templates/bsd-header Changeset: b20d64f83668 Author: twisti Date: 2011-10-24 07:53 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b20d64f83668 7090904: JSR 292: JRuby junit test crashes in PSScavengeRootsClosure::do_oop Reviewed-by: kvn, never, jrose ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/share/vm/interpreter/bytecodeTracer.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/thread.cpp Changeset: 12d38ffcba2a Author: twisti Date: 2011-10-25 00:55 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/12d38ffcba2a 7094138: JSR 292: JRuby junit test fails in CallSite.setTargetNormal: obj->is_oop() failed: sanity check Reviewed-by: iveresov, never ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/unsafe.cpp Changeset: 2ec638646e86 Author: twisti Date: 2011-10-25 04:07 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/2ec638646e86 7101642: JSR 292: SIGSEGV in java.lang.invoke.MethodHandleImpl$FieldAccessor.getFieldI(Ljava/lang/Object;)I Reviewed-by: kvn, iveresov ! src/share/vm/runtime/sharedRuntime.cpp Changeset: a6eef545f1a2 Author: never Date: 2011-10-25 08:17 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/a6eef545f1a2 7103224: collision between __LEAF define in interfaceSupport.hpp and /usr/include/sys/cdefs.h with gcc Reviewed-by: never Contributed-by: Omair Majid ! src/share/vm/opto/addnode.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/interfaceSupport.hpp Changeset: e69a66a1457b Author: kvn Date: 2011-10-25 12:51 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e69a66a1457b 7059039: EA: don't change non-escaping state of NULL pointer Summary: NULL pointers do not escape but escape state propagation may change it leading to worser results. Reviewed-by: never ! src/share/vm/opto/escape.cpp Changeset: d8cb48376797 Author: kvn Date: 2011-10-26 06:08 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/d8cb48376797 7097546: Optimize use of CMOVE instructions Summary: Avoid CMove in a loop if possible. May generate CMove if it could be moved outside a loop. Reviewed-by: never ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/matcher.hpp Changeset: cec1757a0134 Author: twisti Date: 2011-10-27 04:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/cec1757a0134 7102657: JSR 292: C1 deoptimizes unlinked invokedynamic call sites infinitely Reviewed-by: never, bdelsart ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/opto/runtime.cpp Changeset: e0658a9b3f87 Author: kvn Date: 2011-10-27 09:39 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e0658a9b3f87 7105364: JDK8 b10 hotspot: src/share/vm/ci/ciMethodHandle.cpp Error: Use "." or "->" Summary: Define ciMethodHandle::print_chain_impl() and ciMethodHandle::print_chain() bodies only in debug builds. Reviewed-by: never, twisti ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciMethodHandle.hpp Changeset: 34535d2cb362 Author: iveresov Date: 2011-10-27 14:40 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/34535d2cb362 7104177: Tiered: -XX:+PrintCanonicalization doesn't work with -XX:+TieredCompilation Summary: Initialize printable_bci of instruction when passed to Canonicalizer Reviewed-by: kvn, never ! src/share/vm/c1/c1_Canonicalizer.hpp Changeset: f350490a45fd Author: kvn Date: 2011-10-27 18:20 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/f350490a45fd 7105611: Set::print() is broken Summary: Reimplemented class VSetI_ to restore Set::print(). Reviewed-by: never ! src/share/vm/libadt/vectset.cpp ! src/share/vm/libadt/vectset.hpp Changeset: eba044a722a4 Author: never Date: 2011-10-28 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/eba044a722a4 7103261: crash with jittester on sparc Reviewed-by: iveresov, kvn ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp + test/compiler/7103261/Test7103261.java Changeset: e3b0dcc327b9 Author: twisti Date: 2011-10-31 03:06 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e3b0dcc327b9 7104561: UseRDPCForConstantTableBase doesn't work after shorten branches changes Reviewed-by: never, kvn ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/share/vm/opto/machnode.cpp Changeset: 71699e9d8673 Author: kvn Date: 2011-10-31 15:52 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/71699e9d8673 7106907: 64 bit VM fails test compiler/6865265/StackOverflowBug.java Summary: Use -Xss224k instead of -Xss128k. Reviewed-by: never ! test/compiler/6865265/StackOverflowBug.java Changeset: e342a5110bed Author: twisti Date: 2011-11-03 01:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e342a5110bed 7106774: JSR 292: nightly test inlineMHTarget fails with wrong result Reviewed-by: kvn ! src/share/vm/interpreter/bytecode.hpp ! src/share/vm/runtime/deoptimization.cpp Changeset: 448691f285a5 Author: twisti Date: 2011-11-03 04:12 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/448691f285a5 7106944: assert(_pc == *pc_addr) failed may be too strong Reviewed-by: kvn, never ! src/cpu/x86/vm/frame_x86.cpp Changeset: 1feb272af3a7 Author: never Date: 2011-11-04 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/1feb272af3a7 6636110: unaligned stackpointer leads to crash during deoptimization Reviewed-by: never, kvn Contributed-by: Andreas Schoesser ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp Changeset: 59e515ee9354 Author: kvn Date: 2011-11-07 14:33 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/59e515ee9354 7059047: EA: can't find initializing store with several CheckCastPP Summary: Split adjust_escape_state() method into two methods to find initializing stores. Reviewed-by: never ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp Changeset: 44ce519bc3d1 Author: never Date: 2011-11-08 10:31 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/44ce519bc3d1 7104960: JSR 292: +VerifyMethodHandles in product JVM can overflow buffer Reviewed-by: kvn, jrose, twisti ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/globals.hpp Changeset: c9a03402fe56 Author: never Date: 2011-11-08 17:29 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/c9a03402fe56 7105305: assert check_method_context proper context Reviewed-by: jrose, kvn ! src/share/vm/code/dependencies.cpp ! src/share/vm/oops/constantPoolKlass.cpp Changeset: e3e363b2bf19 Author: never Date: 2011-11-08 20:42 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e3e363b2bf19 7108242: jinfo -permstat shouldn't report interned strings as part of perm Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! agent/src/share/classes/sun/jvm/hotspot/tools/PermStat.java Changeset: 83d0b5cd1438 Author: twisti Date: 2011-11-09 00:42 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/83d0b5cd1438 7087727: JSR 292: C2 crash if ScavengeRootsInCode=2 when "static final" MethodHandle constants are in use Reviewed-by: jrose, kvn, never ! src/share/vm/opto/callGenerator.cpp Changeset: 7e0e43cf86d6 Author: kvn Date: 2011-11-09 06:14 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/7e0e43cf86d6 7109887: java/util/Arrays/CopyMethods.java fails with -XX:+DeoptimizeALot Summary: zero array when compiled code is deoptimized. Reviewed-by: never, twisti ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp Changeset: 670a74b863fc Author: kvn Date: 2011-11-09 07:25 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/670a74b863fc 7107042: assert(no_dead_loop) failed: dead loop detected Summary: Use dead nodes elimination code in PhaseIdealLoop before executing EA. Reviewed-by: never, twisti ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/runtime/globals.hpp Changeset: 78bef05801ca Author: twisti Date: 2011-11-10 04:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/78bef05801ca Merge - src/share/vm/precompiled.hpp ! src/share/vm/runtime/globals.hpp Changeset: 3c7d67df8d07 Author: dholmes Date: 2011-11-10 06:23 -0500 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/3c7d67df8d07 7108264: Fix for 7104173 is insufficient Summary: Disable PrintVMOptions by default for all builds Reviewed-by: dsamersoff, twisti ! src/share/vm/runtime/globals.hpp Changeset: f9a80a035a4a Author: coleenp Date: 2011-11-15 12:40 -0500 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/f9a80a035a4a Merge ! src/share/vm/runtime/globals.hpp Changeset: 5a5ed80bea5b Author: ysr Date: 2011-10-26 21:07 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/5a5ed80bea5b 7105163: CMS: some mentions of MinChunkSize should be IndexSetStart Summary: Fixed the instances that were missed in the changeset for 7099817. Reviewed-by: stefank ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp Changeset: 59519b7d7b9d Author: tonyp Date: 2011-10-28 13:04 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/59519b7d7b9d Merge Changeset: 6fd81579526f Author: brutisso Date: 2011-10-31 08:01 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/6fd81579526f 7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise Summary: arrayOopDesc::max_array_length() should return a value that does not overflow a size_t if it is converted to bytes. Reviewed-by: kvn, dholmes ! make/jprt.properties ! src/share/vm/oops/arrayOop.cpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/utilities/quickSort.cpp ! test/Makefile Changeset: ed80554efa25 Author: brutisso Date: 2011-11-02 08:04 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ed80554efa25 7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV Summary: _cset_rs_update_cl[] was indexed with values beyond what it is set up to handle. Reviewed-by: ysr, jmasa, johnc ! src/share/vm/gc_implementation/g1/g1RemSet.cpp Changeset: 8aae2050e83e Author: tonyp Date: 2011-11-07 22:11 -0500 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/8aae2050e83e 7092309: G1: introduce old region set Summary: Keep track of all the old regions in the heap with a heap region set. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.cpp ! src/share/vm/gc_implementation/g1/heapRegionSets.hpp Changeset: 53074c2c4600 Author: tonyp Date: 2011-11-08 00:41 -0500 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/53074c2c4600 7099849: G1: include heap region information in hs_err files Reviewed-by: johnc, brutisso, poonam ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/utilities/vmError.cpp Changeset: ab5107bee78c Author: brutisso Date: 2011-11-09 23:21 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ab5107bee78c 7110190: GCCause::to_string missing case for _adaptive_size_policy Summary: Added case for _adaptive_size_policy Reviewed-by: johnc, ysr ! src/share/vm/gc_interface/gcCause.cpp Changeset: aa4c21b00f7f Author: brutisso Date: 2011-11-15 20:17 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/aa4c21b00f7f 7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow Summary: Reduce what arrayOopDesc::max_array_length() returns to avoid int overflow Reviewed-by: kvn, dholmes, tonyp ! src/share/vm/oops/arrayOop.hpp Changeset: 2ceafe3ceb65 Author: poonam Date: 2011-11-16 16:27 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/2ceafe3ceb65 7110428: Crash during HeapDump operation Reviewed-by: ysr, dholmes ! src/share/vm/services/heapDumper.cpp Changeset: b1754f3fbbd8 Author: tonyp Date: 2011-11-17 13:14 -0500 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b1754f3fbbd8 Merge Changeset: 6c2a55d4902f Author: jcoomes Date: 2011-11-18 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/6c2a55d4902f Merge Changeset: fde2a39ed7f3 Author: jcoomes Date: 2011-11-18 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/fde2a39ed7f3 Added tag hs23-b06 for changeset 6c2a55d4902f ! .hgtags From john.coomes at oracle.com Wed Nov 23 13:15:52 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Wed, 23 Nov 2011 21:15:52 +0000 Subject: hg: jdk8/jdk8/jdk: 3 new changesets Message-ID: <20111123211624.9E2554743F@hg.openjdk.java.net> Changeset: 2a147f854257 Author: twisti Date: 2011-11-02 02:03 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2a147f854257 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods Reviewed-by: jrose, never ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java + test/java/lang/invoke/CallSiteTest.java Changeset: 5c34ed65176e Author: twisti Date: 2011-11-09 00:46 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5c34ed65176e 7109063: JSR 292: fix for 7085860 is incomplete Reviewed-by: iveresov, alanb, jrose ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! test/ProblemList.txt ! test/java/lang/invoke/CallSiteTest.java ! test/java/lang/invoke/InvokeDynamicPrintArgs.java Changeset: bdb2d63c176c Author: jcoomes Date: 2011-11-18 16:57 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bdb2d63c176c Merge ! test/ProblemList.txt From John.Coomes at oracle.com Wed Nov 23 13:27:28 2011 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 23 Nov 2011 13:27:28 -0800 Subject: jdk8-b15: HotSpot Message-ID: <20173.25920.970655.526527@oracle.com> hs23-b06 has been integrated into jdk8-b15. This integration also includes two jsr-292 fixes to the jdk repo. http://hg.openjdk.java.net/jdk8/jdk8/rev/a4f28069d44a http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/99925e8d1b86 http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/fde2a39ed7f3 http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/804f666d6d44 http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/c9ab96ff23d5 http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bdb2d63c176c http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/16906df5bffc Component : VM Status : 0 major failures, 0 minor failures Date : 11/23/2011 at 09:13 Tested By : VM SQE & leonid.mesnik at oracle.com Cost(total man-days): 1 Workspace : /net/prt-archiver.us.oracle.com/data/jprt/archive/2011/11/2011-11-19-014930.jcoomes.hs23-b06-jdk8-b15-control Bundles : /net/prt-archiver.us.oracle.com/data/jprt/archive/2011/11/2011-11-19-014930.jcoomes.hs23-b06-jdk8-b15-control Platforms : Others Tests : /net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Browsers : NA Patches : NA Logs : http://sqeweb.us.oracle.com/nfs/results/vm/gtee/HSX/PIT/VM/hs23/b06/8/ Number of Tests Executed : 345817 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: 6636110: unaligned stackpointer leads to crash during deoptimization 7059039: EA: don't change non escaping state of NULL pointer 7087727: JSR 292: C2 crash if ScavengeRootsInCode=2 when "static final" MethodHandle constants are in use 7090904: JSR 292: JRuby junit test crashes in PSScavengeRootsClosure::do_oop 7094138: JSR 292: JRuby junit test fails in CallSite.setTargetNormal: obj->is_oop() failed: sanity check 7099849: G1: include heap region information in hs_err files 7101642: JSR 292: SIGSEGV in java.lang.invoke.MethodHandleImpl$FieldAccessor.getFieldI(Ljava/lang/Object;)I 7102044: G1: VM crashes with assert(old_end != new_end) failed: don't call this otherwise 7103261: crash with jittester on sparc 7103380: assertion failure with -XX:+PrintNativeNMethods 7104177: Tiered: -XX:+PrintCanonicalization doesn't work with -XX:+TieredCompilation 7106774: JSR 292: nightly test inlineMHTarget fails with wrong result 7106907: 64 bit VM fails test compiler/6865265/StackOverflowBug.java 7107042: assert(no_dead_loop) failed: dead loop detected 7108242: jinfo -permstat shouldn't report interned strings as part of perm 7108264: Fix for 7104173 is insufficient 7109887: java/util/Arrays/CopyMethods.java fails with -XX:+DeoptimizeALot 7110152: assert(size_in_words <= (julong)max_jint) failed: no overflow 7110190: GCCause::to_string missing case for _adaptive_size_policy 7110428: Crash during HeapDump operation Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: 7059047: EA: can't find initializing store with several CheckCastPP 7085860: JSR 292: implement CallSite.setTargetNormal and setTargetVolatile as native methods 7092309: G1: introduce old region set 7097546: Optimize use of CMOVE instructions 7102657: JSR 292: C1 deoptimizes unlinked invokedynamic call sites infinitely 7103784: enable some flags by default 7104561: UseRDPCForConstantTableBase doesn't work after shorten branches changes 7104960: JSR 292: +VerifyMethodHandles in product JVM can overflow buffer 7105163: CMS: some mentions of MinChunkSize should be IndexSetStart 7105305: assert check_method_context proper context 7105364: JDK8 b10 hotspot: src/share/vm/ci/ciMethodHandle.cpp Error: Use "." or "->" .... 7105611: Set::print() is broken 7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV 7106944: assert(_pc == *pc_addr) failed may be too strong 7109063: JSR 292: fix for 7085860 is incomplete Build change only: 7103224: collision between __LEAF define in interfaceSupport.hpp and /usr/include/sys/cdefs.h with gcc 7108553: Bump the hs23 build number to 06 New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b15 Issues and Notes: This is PIT for HS23b06 for JDK8 b15. ------------------------------- >From VM SQE & leonid.mesnik at oracle.com From xiomara.jayasena at oracle.com Mon Nov 28 18:10:06 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Mon, 28 Nov 2011 18:10:06 -0800 (PST) Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 Message-ID: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. We would like to invite you to participate. To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. If you decide to participate then please reply to this e-mail with the area that you intend to work on. I will keep track of the areas so that there is no overlap of work. . A group of us working on this project will create bugs for the areas that developers sign up for. . The focus will be on java warnings, since these are less risky. . For this exercise please avoid making any API changes or any large scale refactorings. . Avoid @SuppressWarnings except where it is clearly necessary. . We would like to have the code changes completed by 5pm (PST) on Dec. 1st. . A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings. The java files are in java.io, java.lang, java.util and a variety of related packages. Process to follow: 1. Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on. 2. A bug ID will be generated for this. 3. Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk 4. Post your changes for review. If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment. If the patch is too cumbersome to review, we can generate a webrev for you. 5. All of the changes must go through the usual build, test and review process before being pushed. If you are a JDK8 committer you may push after completing the usual process. If you aren't a committer we will help you review and test your changes. 6. In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! Lastly to get a build with warnings enable use the following flags: make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" Tip: Make sure to redirect output to a file. To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below." -Xiomara From forax at univ-mlv.fr Tue Nov 29 01:35:53 2011 From: forax at univ-mlv.fr (=?ISO-8859-1?Q?R=E9mi_Forax?=) Date: Tue, 29 Nov 2011 10:35:53 +0100 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: <4ED4A779.8030604@univ-mlv.fr> On 11/29/2011 03:10 AM, Xiomara Jayasena wrote: > A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. We would like to invite you to participate. > > > > To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. If you decide to participate then please reply to this e-mail with the area that you intend to work on. I will keep track of the areas so that there is no overlap of work. > > > > . A group of us working on this project will create bugs for the areas that developers sign up for. > > . The focus will be on java warnings, since these are less risky. > > . For this exercise please avoid making any API changes or any large scale refactorings. > > . Avoid @SuppressWarnings except where it is clearly necessary. > > . We would like to have the code changes completed by 5pm (PST) on Dec. 1st. > > . A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings. The java files are in java.io, java.lang, java.util and a variety of related packages. > > > > Process to follow: > > > > 1. Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on. > > 2. A bug ID will be generated for this. > > 3. Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk > > 4. Post your changes for review. If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment. If the patch is too cumbersome to review, we can generate a webrev for you. > > 5. All of the changes must go through the usual build, test and review process before being pushed. If you are a JDK8 committer you may push after completing the usual process. If you aren't a committer we will help you review and test your changes. > > 6. In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! > > > > Lastly to get a build with warnings enable use the following flags: > > make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" > > > > Tip: Make sure to redirect output to a file. To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below." > > > > -Xiomara I don't think I will have the time to participate this week, anyway, I was browsing the source of java.util recently, and found that at several places the code was generified (during transition from 1.4 to 1.5) with a light sabre (raw type everywhere, dubious unsafe cast, etc) and it will never work if generics are reified in the future. If these warnings are still not removed this week-end, I will provide a patch :) R?mi From Alan.Bateman at oracle.com Tue Nov 29 02:31:44 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 29 Nov 2011 10:31:44 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: <4ED4B490.8040209@oracle.com> On 29/11/2011 02:10, Xiomara Jayasena wrote: > : > > 3. Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk > The AWT/Swing folks might want to chime in here but I suspect they may prefer to have fixes for the client area (java.awt.**, javax.swing.** etc) to be based on jdk8/awt rather than the TL forest. It's no big deal if they are pushed to jdk8/tl but it may reduce the merge effort if the client area changes are pushed via the jdk8/awt forest. -Alan From benjamin.john.evans at gmail.com Tue Nov 29 03:47:04 2011 From: benjamin.john.evans at gmail.com (Ben Evans) Date: Tue, 29 Nov 2011 11:47:04 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: Hi Xiomara, This looks like a great project, and is definitely the sort of participation that the user group community can help with. However, we need more lead time to effectively participate. In our experience the best way for the community to help with something like this is to have a physical meet. That way the relatively small number of people in our communities who can build OpenJDK are able to help the others bootstrap ("teach them to fish"), and thereby increase overall participation. As this is an out-of-work activity for the vast majority of our members, we need time to plan and promote our events - especially if this is to be done as an after-work activity. We probably won't be able to manage to put an event together for this week - but on the assumption that there'll still be plenty of warnings to squish - can we plan for a later date when we can help? >From the community side, some of the right people to reach out to are myself and Martijn Verburg from LJC (London), and Bruno Souza and Yara Senger from SouJava (Brazil) - we can then ensure the message gets out to the rest of the global JUG community. Shame that it's probably too close for us to do much this time - but let us know how it goes, and we'd definitely love to do something if we had more notice. Thanks, Ben On Tue, Nov 29, 2011 at 2:10 AM, Xiomara Jayasena wrote: > A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. ?We would like to invite you to participate. > > > > To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. ?If you decide to participate then please reply to this e-mail with the area that you intend to work on. ?I will keep track of the areas so that there is no overlap of work. > > > > . ? ? ? ? A group of us working on this project will create bugs for the areas that developers sign up for. > > . ? ? ? ? The focus will be on java warnings, since these are less risky. > > . ? ? ? ? For this exercise please avoid making any API changes or any large scale refactorings. > > . ? ? ? ? Avoid @SuppressWarnings except where it is clearly necessary. > > . ? ? ? ? We would like to have the code changes completed by 5pm (PST) on Dec. 1st. > > . ? ? ? ? A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings. ?The java files are in java.io, java.lang, java.util and a variety of related packages. > > > > Process to follow: > > > > 1. ? ? ? Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on. > > 2. ? ? ? A bug ID will be generated for this. > > 3. ? ? ? Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk > > 4. ? ? ? Post your changes for review. ?If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment. ?If the patch is too cumbersome to review, we can generate a webrev for you. > > 5. ? ? ? All of the changes must go through the usual build, test and review process before being pushed. ?If you are a JDK8 committer you may push after completing the usual process. ?If you aren't a committer we will help you review and test your changes. > > 6. ? ? ? In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! > > > > Lastly to get a build with warnings enable use the following flags: > > make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" > > > > Tip: Make sure to redirect output to a file. ?To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below." > > > > -Xiomara > From artem.ananiev at oracle.com Tue Nov 29 04:21:39 2011 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 29 Nov 2011 16:21:39 +0400 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED4B490.8040209@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED4B490.8040209@oracle.com> Message-ID: <4ED4CE53.7040509@oracle.com> On 11/29/2011 2:31 PM, Alan Bateman wrote: > On 29/11/2011 02:10, Xiomara Jayasena wrote: >> : >> >> 3. Pull this repo to base your changes on it: >> http://hg.openjdk.java.net/jdk8/tl/jdk >> > The AWT/Swing folks might want to chime in here but I suspect they may > prefer to have fixes for the client area (java.awt.**, javax.swing.** > etc) to be based on jdk8/awt rather than the TL forest. It's no big deal > if they are pushed to jdk8/tl but it may reduce the merge effort if the > client area changes are pushed via the jdk8/awt forest. Yes, we (AWT and Swing) would definitely like to participate. However, pushing to jdk8/tl forest doesn't look as the right choice: we'll get conflicts with our own changes on synchronization with jdk8 master. As java/sun.awt.* and javax.swing.* packages are quite separate from other JDK parts, wouldn't it be easier to integrate fixes to awt-swing forest? Thanks, Artem > -Alan From xiomara.jayasena at oracle.com Tue Nov 29 07:04:25 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Tue, 29 Nov 2011 07:04:25 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED4CE53.7040509@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED4B490.8040209@oracle.com> <4ED4CE53.7040509@oracle.com> Message-ID: <4ED4F479.3000501@oracle.com> On 11/29/11 4:21 AM, Artem Ananiev wrote: > > On 11/29/2011 2:31 PM, Alan Bateman wrote: >> On 29/11/2011 02:10, Xiomara Jayasena wrote: >>> : >>> >>> 3. Pull this repo to base your changes on it: >>> http://hg.openjdk.java.net/jdk8/tl/jdk >>> >> The AWT/Swing folks might want to chime in here but I suspect they may >> prefer to have fixes for the client area (java.awt.**, javax.swing.** >> etc) to be based on jdk8/awt rather than the TL forest. It's no big deal >> if they are pushed to jdk8/tl but it may reduce the merge effort if the >> client area changes are pushed via the jdk8/awt forest. > > Yes, we (AWT and Swing) would definitely like to participate. However, > pushing to jdk8/tl forest doesn't look as the right choice: we'll get > conflicts with our own changes on synchronization with jdk8 master. As > java/sun.awt.* and javax.swing.* packages are quite separate from > other JDK parts, wouldn't it be easier to integrate fixes to awt-swing > forest? Yes, I agree if there are client changes, those should go to the jdk8/awt client forest. Happy to see that you guys will participate. -Xiomara > > Thanks, > > Artem > >> -Alan From xiomara.jayasena at oracle.com Tue Nov 29 07:58:59 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Tue, 29 Nov 2011 07:58:59 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: <4ED50143.6020507@oracle.com> Sure, if we do this again we'll send something out more in advance. -Xiomara On 11/29/11 3:47 AM, Ben Evans wrote: > Hi Xiomara, > > This looks like a great project, and is definitely the sort of > participation that the user group community can help with. > > However, we need more lead time to effectively participate. In our > experience the best way for the community to help with something like > this is to have a physical meet. That way the relatively small number > of people in our communities who can build OpenJDK are able to help > the others bootstrap ("teach them to fish"), and thereby increase > overall participation. > > As this is an out-of-work activity for the vast majority of our > members, we need time to plan and promote our events - especially if > this is to be done as an after-work activity. > > We probably won't be able to manage to put an event together for this > week - but on the assumption that there'll still be plenty of warnings > to squish - can we plan for a later date when we can help? > > From the community side, some of the right people to reach out to are > myself and Martijn Verburg from LJC (London), and Bruno Souza and Yara > Senger from SouJava (Brazil) - we can then ensure the message gets out > to the rest of the global JUG community. > > Shame that it's probably too close for us to do much this time - but > let us know how it goes, and we'd definitely love to do something if > we had more notice. > > Thanks, > > Ben > > On Tue, Nov 29, 2011 at 2:10 AM, Xiomara Jayasena > wrote: >> A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. We would like to invite you to participate. >> >> >> >> To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. If you decide to participate then please reply to this e-mail with the area that you intend to work on. I will keep track of the areas so that there is no overlap of work. >> >> >> >> . A group of us working on this project will create bugs for the areas that developers sign up for. >> >> . The focus will be on java warnings, since these are less risky. >> >> . For this exercise please avoid making any API changes or any large scale refactorings. >> >> . Avoid @SuppressWarnings except where it is clearly necessary. >> >> . We would like to have the code changes completed by 5pm (PST) on Dec. 1st. >> >> . A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings. The java files are in java.io, java.lang, java.util and a variety of related packages. >> >> >> >> Process to follow: >> >> >> >> 1. Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on. >> >> 2. A bug ID will be generated for this. >> >> 3. Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk >> >> 4. Post your changes for review. If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment. If the patch is too cumbersome to review, we can generate a webrev for you. >> >> 5. All of the changes must go through the usual build, test and review process before being pushed. If you are a JDK8 committer you may push after completing the usual process. If you aren't a committer we will help you review and test your changes. >> >> 6. In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! >> >> >> >> Lastly to get a build with warnings enable use the following flags: >> >> make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" >> >> >> >> Tip: Make sure to redirect output to a file. To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below." >> >> >> >> -Xiomara >> From jonathan.gibbons at oracle.com Tue Nov 29 08:53:07 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 29 Nov 2011 08:53:07 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: <4ED50DF3.9040600@oracle.com> I've written a small utility to summarize which javac warnings are found where in JDK. The program is a wrapper around javac. It accepts files or packages, and monitors the diagnostics reported by javac. The results from running it on the java.** packages are listed below. The source for the program is on http://cr.openjdk.java.net/~jjg/JavacWarnings. It's a simple one-file program, so should be easy for anyone to compile and run for themselves if they'd like to: you just need to compile and run against a recent JDK 8 tools.jar, to get at the javac classes. -- Jon $ /opt/jdk/1.8.0/bin/java -Xmx768m -jar dist/JavacWarnings.jar -bootclasspath /w/jjg/work/tl/build/linux-i586/classes/ -sourcepath /w/jjg/work/tl/jdk/src/share/classes/ 'java.**' Compiling 1497 files cast dep_ann deprecat fallthro raw serial static try unchecke varargs (total) java.applet 1 0 4 0 0 0 0 0 0 0 5 java.awt 46 0 41 1 156 1 7 0 133 0 385 java.awt.color 0 0 0 0 1 2 0 0 2 0 5 java.awt.datatransfer 3 0 5 0 101 1 0 0 78 0 188 java.awt.dnd 4 0 2 1 1 1 0 0 2 0 11 java.awt.font 1 0 0 0 25 0 4 0 13 0 43 java.awt.geom 1 0 0 40 13 2 0 0 0 0 56 java.awt.im 0 0 0 0 1 0 0 0 1 0 2 java.awt.image 41 0 0 0 21 2 15 0 18 0 97 java.awt.image.renderable 0 0 0 0 12 1 0 0 9 0 22 java.awt.print 0 0 0 0 3 2 0 0 5 0 10 java.beans 0 0 0 0 221 0 0 0 91 0 312 java.beans.beancontext 0 0 0 0 104 0 0 0 14 0 118 java.io 0 0 2 4 41 1 1 0 8 0 57 java.lang 2 0 3 0 71 0 1 1 24 0 102 java.lang.instrument 0 0 0 0 1 0 0 0 0 0 1 java.lang.invoke 5 0 0 0 6 0 0 0 2 0 13 java.lang.management 0 0 0 0 3 0 0 0 1 0 4 java.lang.ref 0 0 0 0 11 0 0 0 7 0 18 java.rmi 0 0 0 0 1 0 0 0 1 0 2 java.rmi.dgc 1 0 0 0 0 0 0 0 0 0 1 java.rmi.server 0 0 0 0 3 0 0 0 1 0 4 java.sql 0 15 12 0 1 0 0 0 0 0 28 java.text 7 0 3 1 99 1 0 0 54 0 165 java.util 1 0 0 1 122 1 30 0 208 2 365 java.util.concurrent 0 0 0 0 74 4 36 0 82 0 196 java.util.concurrent.atomic 1 0 0 0 12 0 0 0 2 0 15 java.util.jar 0 1 4 0 73 1 0 0 37 0 116 java.util.logging 0 0 8 0 13 0 0 0 0 0 21 java.util.prefs 0 0 0 0 7 0 0 0 2 0 9 java.util.regex 0 0 0 4 0 0 0 0 0 0 4 java.util.zip 1 0 7 0 0 0 0 0 0 0 8 (total) 115 16 91 52 1197 20 94 1 795 2 2383 warning: 1497, mandatory_warning: 886 From artem.ananiev at oracle.com Tue Nov 29 09:00:19 2011 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 29 Nov 2011 21:00:19 +0400 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED50DF3.9040600@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED50DF3.9040600@oracle.com> Message-ID: <4ED50FA3.6000705@oracle.com> Do you have stats for javax.* packages? Thanks, Artem On 11/29/2011 8:53 PM, Jonathan Gibbons wrote: > I've written a small utility to summarize which javac warnings are found > where in JDK. The program is a wrapper around javac. It accepts files or > packages, and monitors the diagnostics reported by javac. > > The results from running it on the java.** packages are listed below. > > The source for the program is on > http://cr.openjdk.java.net/~jjg/JavacWarnings. It's a simple one-file > program, so should be easy for anyone to compile and run for themselves > if they'd like to: you just need to compile and run against a recent JDK > 8 tools.jar, to get at the javac classes. > > -- Jon > > > $ /opt/jdk/1.8.0/bin/java -Xmx768m -jar dist/JavacWarnings.jar > -bootclasspath /w/jjg/work/tl/build/linux-i586/classes/ -sourcepath > /w/jjg/work/tl/jdk/src/share/classes/ 'java.**' > Compiling 1497 files > cast dep_ann deprecat fallthro raw serial static try unchecke varargs > (total) > java.applet 1 0 4 0 0 0 0 0 0 0 5 > java.awt 46 0 41 1 156 1 7 0 133 0 385 > java.awt.color 0 0 0 0 1 2 0 0 2 0 5 > java.awt.datatransfer 3 0 5 0 101 1 0 0 78 0 188 > java.awt.dnd 4 0 2 1 1 1 0 0 2 0 11 > java.awt.font 1 0 0 0 25 0 4 0 13 0 43 > java.awt.geom 1 0 0 40 13 2 0 0 0 0 56 > java.awt.im 0 0 0 0 1 0 0 0 1 0 2 > java.awt.image 41 0 0 0 21 2 15 0 18 0 97 > java.awt.image.renderable 0 0 0 0 12 1 0 0 9 0 22 > java.awt.print 0 0 0 0 3 2 0 0 5 0 10 > java.beans 0 0 0 0 221 0 0 0 91 0 312 > java.beans.beancontext 0 0 0 0 104 0 0 0 14 0 118 > java.io 0 0 2 4 41 1 1 0 8 0 57 > java.lang 2 0 3 0 71 0 1 1 24 0 102 > java.lang.instrument 0 0 0 0 1 0 0 0 0 0 1 > java.lang.invoke 5 0 0 0 6 0 0 0 2 0 13 > java.lang.management 0 0 0 0 3 0 0 0 1 0 4 > java.lang.ref 0 0 0 0 11 0 0 0 7 0 18 > java.rmi 0 0 0 0 1 0 0 0 1 0 2 > java.rmi.dgc 1 0 0 0 0 0 0 0 0 0 1 > java.rmi.server 0 0 0 0 3 0 0 0 1 0 4 > java.sql 0 15 12 0 1 0 0 0 0 0 28 > java.text 7 0 3 1 99 1 0 0 54 0 165 > java.util 1 0 0 1 122 1 30 0 208 2 365 > java.util.concurrent 0 0 0 0 74 4 36 0 82 0 196 > java.util.concurrent.atomic 1 0 0 0 12 0 0 0 2 0 15 > java.util.jar 0 1 4 0 73 1 0 0 37 0 116 > java.util.logging 0 0 8 0 13 0 0 0 0 0 21 > java.util.prefs 0 0 0 0 7 0 0 0 2 0 9 > java.util.regex 0 0 0 4 0 0 0 0 0 0 4 > java.util.zip 1 0 7 0 0 0 0 0 0 0 8 > (total) 115 16 91 52 1197 20 94 1 795 2 2383 > > warning: 1497, mandatory_warning: 886 > From jonathan.gibbons at oracle.com Tue Nov 29 09:05:06 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 29 Nov 2011 09:05:06 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED50FA3.6000705@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED50DF3.9040600@oracle.com> <4ED50FA3.6000705@oracle.com> Message-ID: <4ED510C2.3070402@oracle.com> On 11/29/2011 09:00 AM, Artem Ananiev wrote: > > Do you have stats for javax.* packages? > > Thanks, > > Artem $ /opt/jdk/1.8.0/bin/java -Xmx768m -jar dist/JavacWarnings.jar -bootclasspath /w/jjg/work/tl/build/linux-i586/classes/ -sourcepath /w/jjg/work/tl/jdk/src/share/classes/ 'javax.**' Compiling 1489 files cast dep_ann deprecat fallthro finally raw serial static unchecke varargs (total) javax.accessibility 7 0 0 0 0 12 0 0 8 0 27 javax.imageio 45 0 0 0 0 37 1 0 25 0 108 javax.imageio.metadata 5 0 0 0 0 38 2 0 35 0 80 javax.imageio.plugins.jpeg 14 0 0 0 0 0 0 0 0 0 14 javax.imageio.spi 18 0 0 0 0 48 1 0 28 0 95 javax.imageio.stream 0 0 0 0 0 6 0 0 4 0 10 javax.management.remote.rmi 0 0 0 0 0 2 0 0 0 0 2 javax.net.ssl 2 0 0 0 0 0 0 0 0 0 2 javax.print 1 0 1 0 0 57 2 0 28 0 89 javax.print.attribute 1 0 0 0 0 11 11 0 8 0 31 javax.print.attribute.standard 15 0 0 0 0 13 0 0 11 0 39 javax.script 0 0 0 0 0 2 1 0 0 0 3 javax.security.auth.kerberos 0 0 0 1 0 0 0 0 0 0 1 javax.sound.midi 4 0 0 0 0 53 2 0 13 0 72 javax.sound.sampled 3 0 0 0 0 54 4 0 14 0 75 javax.sql 0 0 0 0 0 0 1 0 0 0 1 javax.sql.rowset 0 1 0 0 0 6 1 0 0 0 8 javax.sql.rowset.serial 7 0 0 2 0 10 0 0 37 0 56 javax.sql.rowset.spi 0 0 0 0 0 6 0 0 3 0 9 javax.swing 0 0 45 0 1 143 219 4 35 1 448 javax.swing.border 0 0 0 0 0 0 9 0 0 0 9 javax.swing.colorchooser 0 0 1 0 0 0 14 0 0 0 15 javax.swing.event 0 0 0 0 0 5 18 0 3 0 26 javax.swing.filechooser 0 0 0 0 0 0 2 0 0 0 2 javax.swing.plaf 0 0 1 0 0 11 17 0 0 0 29 javax.swing.plaf.basic 0 0 24 0 0 110 92 0 29 0 255 javax.swing.plaf.metal 0 0 12 1 0 25 80 2 6 0 126 javax.swing.plaf.multi 0 0 0 0 0 68 1 0 2 0 71 javax.swing.plaf.nimbus 0 0 0 0 0 31 4 0 12 0 47 javax.swing.plaf.synth 0 0 0 0 0 29 27 0 10 0 66 javax.swing.table 0 0 1 0 0 35 8 0 7 0 51 javax.swing.text 0 0 2 1 0 64 88 1 6 0 162 javax.swing.text.html 0 0 9 2 0 51 49 4 17 0 132 javax.swing.text.html.parser 0 0 0 10 0 2 4 1 3 0 20 javax.swing.text.rtf 0 0 0 2 0 14 1 1 3 0 21 javax.swing.tree 0 0 0 0 0 26 10 0 2 0 38 javax.swing.undo 0 0 0 0 0 4 6 0 0 0 10 javax.xml.crypto 0 0 0 0 0 1 0 0 0 0 1 javax.xml.crypto.dom 0 0 0 0 0 9 0 0 6 0 15 javax.xml.crypto.dsig 0 0 0 0 0 23 0 0 0 0 23 javax.xml.crypto.dsig.keyinfo 0 0 0 0 0 10 0 0 0 0 10 javax.xml.crypto.dsig.spec 0 0 0 0 0 21 0 0 12 0 33 (total) 122 1 96 19 1 1037 675 13 367 1 2332 warning: 1869, mandatory_warning: 463 From jonathan.gibbons at oracle.com Tue Nov 29 09:11:02 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Tue, 29 Nov 2011 09:11:02 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED510C2.3070402@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED50DF3.9040600@oracle.com> <4ED50FA3.6000705@oracle.com> <4ED510C2.3070402@oracle.com> Message-ID: <4ED51226.1030907@oracle.com> On 11/29/2011 09:05 AM, Jonathan Gibbons wrote: > On 11/29/2011 09:00 AM, Artem Ananiev wrote: >> >> Do you have stats for javax.* packages? >> >> Thanks, >> >> Artem > > $ /opt/jdk/1.8.0/bin/java -Xmx768m -jar dist/JavacWarnings.jar > -bootclasspath /w/jjg/work/tl/build/linux-i586/classes/ -sourcepath > /w/jjg/work/tl/jdk/src/share/classes/ 'javax.**' > Compiling 1489 files Artem, A word on these numbers. The warnings are just those in the given packages, and do not include warnings in impl packages, such as sun.*, com.sun.*, etc. Also note from the command line that I was just compiling stuff in src/share/classes. For more complete counts you'd want to include platform-specific directories and/or gensrc/ directories. So at some point, you need to download the utility, and run it for yourself, using the sources and packages you are most interested in. -- Jon From artem.ananiev at oracle.com Tue Nov 29 09:54:46 2011 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Tue, 29 Nov 2011 21:54:46 +0400 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED51226.1030907@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED50DF3.9040600@oracle.com> <4ED50FA3.6000705@oracle.com> <4ED510C2.3070402@oracle.com> <4ED51226.1030907@oracle.com> Message-ID: <4ED51C66.4070804@oracle.com> On 11/29/2011 9:11 PM, Jonathan Gibbons wrote: > On 11/29/2011 09:05 AM, Jonathan Gibbons wrote: >> On 11/29/2011 09:00 AM, Artem Ananiev wrote: >>> >>> Do you have stats for javax.* packages? >>> >>> Thanks, >>> >>> Artem >> >> $ /opt/jdk/1.8.0/bin/java -Xmx768m -jar dist/JavacWarnings.jar >> -bootclasspath /w/jjg/work/tl/build/linux-i586/classes/ -sourcepath >> /w/jjg/work/tl/jdk/src/share/classes/ 'javax.**' >> Compiling 1489 files > > > Artem, > > A word on these numbers. The warnings are just those in the given > packages, and do not include warnings in impl packages, such as sun.*, > com.sun.*, etc. Also note from the command line that I was just > compiling stuff in src/share/classes. For more complete counts you'd > want to include platform-specific directories and/or gensrc/ > directories. So at some point, you need to download the utility, and run > it for yourself, using the sources and packages you are most interested in. Thanks for this clarification. Given the number of warnings in java.awt and javax.swing packages, let's start from public API classes and then proceed to sun.* :) Thanks, Artem > -- Jon From xiomara.jayasena at oracle.com Tue Nov 29 09:55:46 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Tue, 29 Nov 2011 09:55:46 -0800 (PST) Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <7DFAAF38-9D38-4440-A4BF-1E1D1761BC13@javaman.com.br> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: <08eef3ff-d630-4a18-8d7a-8e7266b3ecd1@default> Thank you for your feedback. As we go through this exercise this first time we will learn as to what to do differently next time we have this. Dec. 1st was a day that worked for us but in the future we will let you guys know in advance. -Xiomara > -----Original Message----- > From: Bruno F. Souza [mailto:bruno at javaman.com.br] > Sent: Tuesday, November 29, 2011 7:51 AM > To: Ben Evans > Cc: Xiomara Jayasena; jdk8-dev at openjdk.java.net; jdk7- > dev at openjdk.java.net; build-dev at openjdk.java.net; Martijn Verburg; Yara > Senger > Subject: Re: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 > > > Yes, I agree with Ben, it is just too short notice for us to do > anything more then promote it. > We will promote it anyway, no worries about it, but it would be nice to > use this opportunity to help people get involved. > We'll look forward for a next opportunity! > Thanks! > Bruno. > > > On 29/11/2011, at 09:47, Ben Evans wrote: > > > Hi Xiomara, > > > > This looks like a great project, and is definitely the sort of > > participation that the user group community can help with. > > > > However, we need more lead time to effectively participate. In our > > experience the best way for the community to help with something like > > this is to have a physical meet. That way the relatively small number > > of people in our communities who can build OpenJDK are able to help > > the others bootstrap ("teach them to fish"), and thereby increase > > overall participation. > > > > As this is an out-of-work activity for the vast majority of our > > members, we need time to plan and promote our events - especially if > > this is to be done as an after-work activity. > > > > We probably won't be able to manage to put an event together for this > > week - but on the assumption that there'll still be plenty of > warnings > > to squish - can we plan for a later date when we can help? > > > > From the community side, some of the right people to reach out to are > > myself and Martijn Verburg from LJC (London), and Bruno Souza and > Yara > > Senger from SouJava (Brazil) - we can then ensure the message gets > out > > to the rest of the global JUG community. > > > > Shame that it's probably too close for us to do much this time - but > > let us know how it goes, and we'd definitely love to do something if > > we had more notice. > > > > Thanks, > > > > Ben > > > > On Tue, Nov 29, 2011 at 2:10 AM, Xiomara Jayasena > > wrote: > >> A few teams are planning on cleaning up warnings generated during > the JDK build on Dec. 1st. We would like to invite you to participate. > >> > >> > >> > >> To be able to participate a prerequisite is that you are able build > the JDK. The source that we will target is JDK8. If you decide to > participate then please reply to this e-mail with the area that you > intend to work on. I will keep track of the areas so that there is no > overlap of work. > >> > >> > >> > >> . A group of us working on this project will create bugs for > the areas that developers sign up for. > >> > >> . The focus will be on java warnings, since these are less > risky. > >> > >> . For this exercise please avoid making any API changes or > any large scale refactorings. > >> > >> . Avoid @SuppressWarnings except where it is clearly > necessary. > >> > >> . We would like to have the code changes completed by 5pm > (PST) on Dec. 1st. > >> > >> . A suggested area to work on is the build step defined by: > jdk/make/java/java/ which compiles close to 500 .java files and > produces over 1200 warnings. The java files are in java.io, java.lang, > java.util and a variety of related packages. > >> > >> > >> > >> Process to follow: > >> > >> > >> > >> 1. Pick a file or a few files to work on and send mail to > jdk8-dev by 8am PT on Thursday to let us know which area you would like > to work on. > >> > >> 2. A bug ID will be generated for this. > >> > >> 3. Pull this repo to base your changes on it: > http://hg.openjdk.java.net/jdk8/tl/jdk > >> > >> 4. Post your changes for review. If you have webrev, please > use it. If you don't have webrev, please generate a patch and post it > here as a .txt attachment. If the patch is too cumbersome to review, > we can generate a webrev for you. > >> > >> 5. All of the changes must go through the usual build, test > and review process before being pushed. If you are a JDK8 committer > you may push after completing the usual process. If you aren't a > committer we will help you review and test your changes. > >> > >> 6. In order to streamlines the process, Stuart Marks will be > consolidating patches and running build and test jobs - thanks to > Stuart for doing this! > >> > >> > >> > >> Lastly to get a build with warnings enable use the following flags: > >> > >> make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= > OTHER_JAVACFLAGS="-Xmaxwarns 10000" > >> > >> > >> > >> Tip: Make sure to redirect output to a file. To find the > jdk/make/java/java/Makefile build step mentioned above, open the log > file and look for the first occurrence of '# Running javac'. Voluminous > warning output should appear below." > >> > >> > >> > >> -Xiomara > >> > > Bruno. > ______________________________________________________________________ > Bruno Peres Ferreira de Souza Brazil's JavaMan > http://www.javaman.com.br bruno at javaman.com.br > if I fail, if I succeed, at least I live as I believe > > > From lana.steuck at oracle.com Tue Nov 29 11:01:47 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 29 Nov 2011 19:01:47 +0000 Subject: hg: jdk8/jdk8/langtools: 6 new changesets Message-ID: <20111129190211.49C5147499@hg.openjdk.java.net> Changeset: 36553cb94345 Author: jjg Date: 2011-11-08 17:06 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/36553cb94345 7108668: allow Log to be initialized and used earlier Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/JavacMessages.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/Options.java ! src/share/classes/com/sun/tools/javadoc/Start.java Changeset: ae361e7f435a Author: jjg Date: 2011-11-08 17:06 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/ae361e7f435a 7108669: cleanup Log methods for direct printing to streams Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/main/Main.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/JavacOption.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/6410653/T6410653.java ! test/tools/javac/diags/ArgTypeCompilerFactory.java Changeset: c1238fcc9515 Author: ksrini Date: 2011-11-14 08:09 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/c1238fcc9515 7110974: (javac) add coding conventions and style checkers for langtools Reviewed-by: jjg ! make/build.properties ! make/build.xml + make/conf/checkstyle-emacs.xsl + make/conf/checkstyle-langtools.xml Changeset: 7375d4979bd3 Author: ksrini Date: 2011-11-14 15:11 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/7375d4979bd3 7106166: (javac) re-factor EndPos parser Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java - src/share/classes/com/sun/tools/javac/parser/EndPosParser.java + src/share/classes/com/sun/tools/javac/parser/EndPosTable.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/ParserFactory.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/6304921/TestLog.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/tree/TreePosTest.java Changeset: f07d6f55d39a Author: lana Date: 2011-11-18 11:12 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/f07d6f55d39a Merge Changeset: 07599bd780ca Author: jjh Date: 2011-11-19 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/07599bd780ca 7110611: compiler message file broken for javac -fullversion Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/Main.java From lana.steuck at oracle.com Tue Nov 29 11:02:10 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 29 Nov 2011 19:02:10 +0000 Subject: hg: jdk8/jdk8/corba: 2 new changesets Message-ID: <20111129190211.C42284749A@hg.openjdk.java.net> Changeset: 44c269731425 Author: coffeys Date: 2011-11-11 10:16 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/44c269731425 7091388: Regular unexplained npe's from corba libs after system has been running for days Reviewed-by: alanb ! src/share/classes/com/sun/corba/se/impl/encoding/CDRInputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDRInputStream_1_0.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDROutputStream.java ! src/share/classes/com/sun/corba/se/impl/encoding/CDROutputStream_1_0.java Changeset: 7da69e7175a7 Author: lana Date: 2011-11-18 11:01 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/7da69e7175a7 Merge From lana.steuck at oracle.com Tue Nov 29 11:02:53 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 29 Nov 2011 19:02:53 +0000 Subject: hg: jdk8/jdk8/jdk: 33 new changesets Message-ID: <20111129190812.571294749B@hg.openjdk.java.net> Changeset: 89952dc5be8e Author: prr Date: 2011-11-17 10:32 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/89952dc5be8e 7113017: Use POSIX compliant include file headers in sun/awt/medialib/mlib_types.h Reviewed-by: prr, bae Contributed-by: littlee at linux.vnet.ibm.com ! src/share/native/sun/awt/medialib/mlib_types.h Changeset: 60331bbcf4ad Author: lana Date: 2011-11-18 16:16 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/60331bbcf4ad Merge Changeset: f410b91caf45 Author: weijun Date: 2011-11-09 09:30 +0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f410b91caf45 7107019: sun.security.krb5.internal.ccache.CCacheInputStream.readCred does not use auth data Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ccache/CCacheInputStream.java ! src/share/classes/sun/security/krb5/internal/ccache/Credentials.java Changeset: 52be75d060f9 Author: weijun Date: 2011-11-09 15:51 +0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/52be75d060f9 7109096: keytool -genkeypair needn't call -selfcert Reviewed-by: xuelei ! src/share/classes/sun/security/tools/CertAndKeyGen.java ! src/share/classes/sun/security/tools/KeyTool.java Changeset: d6a5da5f6ba0 Author: dl Date: 2011-11-10 12:21 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/d6a5da5f6ba0 7107516: LinkedBlockingQueue/Deque.drainTo(Collection, int) returns 'maxElements' if its value is negative Reviewed-by: chegar, mduigou, dholmes ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java Changeset: 0ccfb35cce26 Author: michaelm Date: 2011-11-10 15:30 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0ccfb35cce26 7110484: HttpServer.stop() not closing selector Reviewed-by: chegar ! src/share/classes/sun/net/httpserver/ServerImpl.java Changeset: e5d65a583c15 Author: michaelm Date: 2011-11-10 15:41 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/e5d65a583c15 Merge Changeset: 830d2e46023a Author: lancea Date: 2011-11-10 11:41 -0500 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/830d2e46023a 7110111: Minor Java SE javadoc & Constructor clean up Reviewed-by: alanb, darcy Contributed-by: Martin Desruisseaux ! src/share/classes/java/io/Writer.java ! src/share/classes/java/lang/AssertionError.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/Statement.java ! src/share/classes/java/util/jar/Attributes.java Changeset: 9dd994f319ee Author: coffeys Date: 2011-11-11 10:08 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/9dd994f319ee 7105952: Improve finalisation for FileInputStream/FileOutputStream/RandomAccessFile Reviewed-by: alanb ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/RandomAccessFile.java ! src/solaris/classes/java/io/FileDescriptor.java ! src/windows/classes/java/io/FileDescriptor.java - test/java/io/FileDescriptor/FileChannelFDTest.java + test/java/io/FileDescriptor/Sharing.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 5c7c83a6ee24 Author: xuelei Date: 2011-11-14 01:21 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5c7c83a6ee24 7111548: unexpected debug log message Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 68fc55d12ae6 Author: chegar Date: 2011-11-14 10:06 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/68fc55d12ae6 7107020: java.net.PlainSocketImpl.socketSetOption() calls itself Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! src/windows/classes/java/net/PlainSocketImpl.java Changeset: c740519fe83a Author: weijun Date: 2011-11-16 11:53 +0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c740519fe83a 7111579: klist starttime, renewtill, ticket etype Reviewed-by: mullan ! src/share/classes/sun/security/krb5/internal/ccache/Credentials.java ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java Changeset: cd6d236e863b Author: okutsu Date: 2011-11-16 12:57 +0900 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/cd6d236e863b 7111903: (tz) Windows-only: tzmappings needs update for KB2570791 Reviewed-by: peytoia ! src/windows/lib/tzmappings Changeset: 1266e72f7896 Author: okutsu Date: 2011-11-16 13:17 +0900 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/1266e72f7896 Merge Changeset: 398442b00b2b Author: ksrini Date: 2011-11-16 12:23 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/398442b00b2b 7112160: jdk8 javadoc failure in jdk/make/docs javadoc: error - java.lang.OutOfMemoryError Reviewed-by: ohair, katleman ! make/docs/Makefile Changeset: 3cd7dcf4a302 Author: mchung Date: 2011-11-17 15:47 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/3cd7dcf4a302 7067691: java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java failing intermittently Reviewed-by: alanb, mchung Contributed-by: gary.adams at oracle.com ! test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java ! test/java/lang/management/PlatformLoggingMXBean/PlatformLoggingMXBeanTest.java Changeset: 5bfff9616b86 Author: weijun Date: 2011-11-18 16:13 +0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5bfff9616b86 7077172: KerberosTime does not take into account system clock adjustement Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/KerberosTime.java Changeset: cd37d8066437 Author: lana Date: 2011-11-18 11:11 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/cd37d8066437 Merge ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: c98235762b30 Author: alanb Date: 2011-11-19 19:55 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c98235762b30 6818464: TEST_BUG: java/util/Timer/KillThread.java failing intermittently Reviewed-by: dholmes, alanb, forax Contributed-by: gary.adams at oracle.com ! test/java/util/Timer/KillThread.java Changeset: 8be37eae9598 Author: alanb Date: 2011-11-19 19:59 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/8be37eae9598 6731620: TEST_BUG: java/util/Timer/Args.java is too optimistic about the execution time of System.out.printf Reviewed-by: dholmes, forax Contributed-by: gary.adams at oracle.com ! test/java/util/Timer/Args.java Changeset: 450c17e4808d Author: alanb Date: 2011-11-19 20:03 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/450c17e4808d 6860309: TEST_BUG: Insufficient sleep time in java/lang/Runtime/exec/StreamsSurviveDestroy.java Reviewed-by: alanb, dholmes, forax Contributed-by: gary.adams at oracle.com ! test/java/lang/Runtime/exec/StreamsSurviveDestroy.java Changeset: 184578f3e8b9 Author: alanb Date: 2011-11-21 12:51 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/184578f3e8b9 7084033: TEST_BUG: test/java/lang/ThreadGroup/Stop.java fails intermittently Reviewed-by: forax, chegar, dholmes Contributed-by: gary.adams at oracle.com ! test/java/lang/ThreadGroup/Stop.java Changeset: 2db942c7eb9c Author: alanb Date: 2011-11-21 12:57 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2db942c7eb9c 7114125: TEST_BUG: java/util/Timer/KillThread.java should use volatile cross thread variable declaration Reviewed-by: dholmes, alanb Contributed-by: gary.adams at oracle.com ! test/java/util/Timer/KillThread.java Changeset: 81987765cb81 Author: ngmr Date: 2011-11-11 14:40 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/81987765cb81 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo Reviewed-by: chegar, alanb, mduigou, ngmr Contributed-by: Charles Lee ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/net/net_util_md.h Changeset: ee2fa62fb09f Author: ngmr Date: 2011-11-22 09:51 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ee2fa62fb09f 7114558: Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN) Reviewed-by: chegar Contributed-by: Neil Richards ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c Changeset: 1945abeb82a0 Author: mullan Date: 2011-11-22 08:58 -0500 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/1945abeb82a0 7093090: Reduce synchronization in java.security.Policy.getPolicyNoCheck Reviewed-by: valeriep ! src/share/classes/java/security/Policy.java Changeset: bb8f19b80557 Author: mullan Date: 2011-11-22 09:00 -0500 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bb8f19b80557 Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: b4d7020c2a40 Author: mullan Date: 2011-11-22 09:17 -0500 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/b4d7020c2a40 Merge Changeset: 82151e860a64 Author: xuelei Date: 2011-11-23 03:40 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/82151e860a64 7113275: compatibility issue with MD2 trust anchor and old X509TrustManager Summary: also reviewed by Dennis.Gu at oracle.com Reviewed-by: mullan ! src/share/classes/sun/security/ssl/SSLContextImpl.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/MD2InTrustAnchor.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/TrustTrustedCert.java Changeset: 7eb0debca9b3 Author: chegar Date: 2011-11-23 12:30 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/7eb0debca9b3 6776144: java/lang/ThreadGroup/NullThreadName.java fails with Thread group is not destroyed ,fastdebug LINUX Reviewed-by: chegar, dholmes Contributed-by: gary.adams at oracle.com ! test/java/lang/ThreadGroup/NullThreadName.java Changeset: d27f0b2f1476 Author: coffeys Date: 2011-11-23 14:55 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/d27f0b2f1476 7102369: remove java.rmi.server.codebase property parsing from registyimpl 7094468: rmiregistry clean up Reviewed-by: smarks ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/rmi/server/LoaderHandler.java + test/java/rmi/registry/readTest/readTest.java + test/java/rmi/registry/readTest/readTest.sh + test/java/rmi/registry/readTest/testPkg/Client.java + test/java/rmi/registry/readTest/testPkg/Hello.java + test/java/rmi/registry/readTest/testPkg/Server.java Changeset: 855675a4235b Author: lana Date: 2011-11-23 11:37 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/855675a4235b Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java Changeset: 3c248d0e2c48 Author: lana Date: 2011-11-28 15:15 -0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/3c248d0e2c48 Merge - test/java/io/FileDescriptor/FileChannelFDTest.java - test/java/io/etc/FileDescriptorSharing.java From philip.race at oracle.com Tue Nov 29 11:45:44 2011 From: philip.race at oracle.com (Phil Race) Date: Tue, 29 Nov 2011 11:45:44 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED4B490.8040209@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED4B490.8040209@oracle.com> Message-ID: <4ED53668.4040004@oracle.com> I'd be surprised if there was any merge effort unless folks work on the same files. If client folks do client files and core folks don't then that would avoid it. And any merge effort would seem to me to be the same anyway, just where/when it occurs. Am I overlooking something ? -phil. On 11/29/2011 2:31 AM, Alan Bateman wrote: > On 29/11/2011 02:10, Xiomara Jayasena wrote: >> : >> >> 3. Pull this repo to base your changes on it: >> http://hg.openjdk.java.net/jdk8/tl/jdk >> > The AWT/Swing folks might want to chime in here but I suspect they may > prefer to have fixes for the client area (java.awt.**, javax.swing.** > etc) to be based on jdk8/awt rather than the TL forest. It's no big > deal if they are pushed to jdk8/tl but it may reduce the merge effort > if the client area changes are pushed via the jdk8/awt forest. > > -Alan From philip.race at oracle.com Tue Nov 29 11:48:58 2011 From: philip.race at oracle.com (Phil Race) Date: Tue, 29 Nov 2011 11:48:58 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED53668.4040004@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED4B490.8040209@oracle.com> <4ED53668.4040004@oracle.com> Message-ID: <4ED5372A.6050509@oracle.com> Apologies .. I read your comment opposite to your meaning. Yes, you are right. Less merges if AWT changes go to the AWT forest. -phil. On 11/29/2011 11:45 AM, Phil Race wrote: > I'd be surprised if there was any merge effort unless folks work on > the same files. > If client folks do client files and core folks don't then that would > avoid it. > And any merge effort would seem to me to be the same anyway, just > where/when it occurs. > > Am I overlooking something ? > > -phil. > > On 11/29/2011 2:31 AM, Alan Bateman wrote: >> On 29/11/2011 02:10, Xiomara Jayasena wrote: >>> : >>> >>> 3. Pull this repo to base your changes on it: >>> http://hg.openjdk.java.net/jdk8/tl/jdk >>> >> The AWT/Swing folks might want to chime in here but I suspect they >> may prefer to have fixes for the client area (java.awt.**, >> javax.swing.** etc) to be based on jdk8/awt rather than the TL >> forest. It's no big deal if they are pushed to jdk8/tl but it may >> reduce the merge effort if the client area changes are pushed via the >> jdk8/awt forest. >> >> -Alan > From lana.steuck at oracle.com Tue Nov 29 14:36:38 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 29 Nov 2011 14:36:38 -0800 (PST) Subject: jdk8-b15: JSN, Tools, Core Libraries, Serviceability, 2d, Awt, and Swing Message-ID: <201111292236.pATMac6D003233@jano-app.us.oracle.com> http://hg.openjdk.java.net/jdk8/jdk8/rev/a4f28069d44a http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/07599bd780ca http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/3c248d0e2c48 http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/c9ab96ff23d5 http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/804f666d6d44 http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/fde2a39ed7f3 http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/7da69e7175a7 --- Component : 2d Status : 0 major failures, 0 minor failures Date : 11/28/2011 at 12:56 Tested By : Tony Cost(total man-days): 1 Workspace : http://sqe-hg.us.oracle.com/hg/index.cgi/testbase/javase/functional/8/2d/ Bundles : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/build-archive/2011-11-23-194218.jcg-integrator.tl-pit-2d/link-to-jprt-build/bundles Platforms : Others Tests : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/repo.latest-pit/jdk Browsers : NA Patches : NA Logs : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/build-archive/2011-11-23-194218.jcg-integrator.tl-pit-2d/logs/webrev/ Number of Tests Executed : 0 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: 7113017: Use POSIX compliant include file headers in sun/awt/medialib/mlib_types.h Build change only: New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b16 Issues and Notes: ------------------------------- >From Tony Component : JDBC Status : 0 major failures, 0 minor failures Date : 11/29/2011 at 05:09 Tested By : Eugene Cost(total man-days): 1 Workspace : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/build-archive/2011-11-23-194218.jcg-integrator.tl-pit-2d Bundles : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/build-archive/2011-11-23-194218.jcg-integrator.tl-pit-2d/link-to-jprt-build/bundles Platforms : Others Tests : http://stt-13.ru.oracle.com/hg/quality/index.cgi/170_int_ws/jdbc/ Browsers : NA Patches : NA Logs : http://vice.russia.sun.com/newroot/results/1.8.0/b16/pit/jdbc/workDir/tonga.output/ Number of Tests Executed : 1117 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: 7110111: Minor Java SE javadoc & constructor cleanup Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: Build change only: New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b16 Issues and Notes: no new unknown issues ------------------------------- >From Eugene Component : i18n Status : 0 major failures, 0 minor failures Date : 11/27/2011 at 23:45 Tested By : Jenny Huang Cost(total man-days): 1 Workspace : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/repo.latest-pit/jdk Bundles : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/build-archive/2011-11-23-194218.jcg-integrator.tl-pit-2d/link-to-jprt-build/bundles Platforms : WinXP Prof(32), -client Tests : /net/jano1.us.oracle.com/export1/jcg/ws-depot/8/tl/build-archive/2011-11-23-194218.jcg-integrator.tl-pit-2d/link-to-jprt-build/bundles Browsers : NA Patches : NA Logs : N/A Number of Tests Executed : 1 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: 7111903: (tz) Windows-only: tzmappings needs update for KB2570791 Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: Build change only: New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b16 Issues and Notes: ------------------------------- >From Jenny Huang The following fixes were waived by SQE: 6731620 java classes_util TEST_BUG: java/util/Timer/Args.java is too optimistic about 6776144 java classes_lang java/lang/ThreadGroup/NullThreadName.java fails with Thread 6818464 java classes_util TEST_BUG: java/util/Timer/KillThread.java failing intermitte 6860309 java classes_lang TEST_BUG: Insufficient sleep time in java/lang/Runtime/exec/ 7067691 java classes_manageme java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest 7077172 jgss krb5plugin KerberosTime does not take into account system clock adjuste 7084033 java classes_lang TEST_BUG: test/java/lang/ThreadGroup/Stop.java fails intermi 7091388 jets jets Regular unexplained npe's from corba libs after system has b 7093090 java classes_security Reduce synchronization in java.security.Policy.getPolicyNoCh 7094468 java rmi rmiregistry needs more relaxed file permissions 7102369 java rmi remove java.rmi.server.codebase property parsing from regist 7105952 java classes_io Improve finalisation for FileInputStream/FileOutputStream/Ra 7106166 java compiler (javac) re-factor EndPos parser 7107019 java classes_security sun.security.krb5.internal.ccache.CCacheInputStream.readCred 7107020 java classes_net java.net.PlainSocketImpl.socketSetOption() calls itself 7107516 java classes_util_con LinkedBlockingQueue/Deque.drainTo(Collection,int) returns 'm 7108668 java compiler allow Log to be initialized and used earlier 7108669 java compiler cleanup Log methods for direct printing to streams 7109096 java classes_security keytool -genkeypair needn't call -selfcert 7110484 java classes_net HttpServer.stop() not closing selector 7110611 java compiler compiler message file broken for javac -fullversion 7110974 java compiler (javac) add coding conventions and style checkers for langto 7111548 jsse runtime unexpected debug log message 7111579 java classes_security klist starttime, renewtill, ticket etype 7112160 java tools jdk8 javadoc failure in jdk/make/docs javadoc: error - java. 7112670 java classes_net Inet4AddressImpl should use getaddrinfo/getnameinfo ( modern 7113275 jsse runtime compatibility issue with MD2 trust anchor and old X509TrustM 7114125 java classes_util TEST_BUG: java/util/Timer/KillThread.java should use volatil 7114558 java classes_net Inet4AddressImpl should use memset (rather than bzero) and N From stuart.marks at oracle.com Tue Nov 29 15:05:53 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 29 Nov 2011 15:05:53 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED4CE53.7040509@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED4B490.8040209@oracle.com> <4ED4CE53.7040509@oracle.com> Message-ID: <4ED56551.2030501@oracle.com> On 11/29/11 4:21 AM, Artem Ananiev wrote: > > On 11/29/2011 2:31 PM, Alan Bateman wrote: >> On 29/11/2011 02:10, Xiomara Jayasena wrote: >>> : >>> >>> 3. Pull this repo to base your changes on it: >>> http://hg.openjdk.java.net/jdk8/tl/jdk >>> >> The AWT/Swing folks might want to chime in here but I suspect they may >> prefer to have fixes for the client area (java.awt.**, javax.swing.** >> etc) to be based on jdk8/awt rather than the TL forest. It's no big deal >> if they are pushed to jdk8/tl but it may reduce the merge effort if the >> client area changes are pushed via the jdk8/awt forest. > > Yes, we (AWT and Swing) would definitely like to participate. However, pushing > to jdk8/tl forest doesn't look as the right choice: we'll get conflicts with > our own changes on synchronization with jdk8 master. As java/sun.awt.* and > javax.swing.* packages are quite separate from other JDK parts, wouldn't it be > easier to integrate fixes to awt-swing forest? It sounds like it makes more sense for you to integrate your changes through the awt-swing forest, so by all means go ahead and do so. I'm only equipped to test and push changes to TL. If you're going through a different forest, perhaps you could help to coordinate and test the changes going through there. Thanks. s'marks From stuart.marks at oracle.com Tue Nov 29 17:42:57 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 29 Nov 2011 17:42:57 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: <4ED58A21.4040005@oracle.com> [I've removed jdk7-dev and build-dev] Hi Ben, Bruno, et al, I'm working with Xiomara on this Warnings Cleanup Day. Sorry for the short notice. For this effort we wanted to get something put together really quickly, mainly to see what happens, and also to see who might be interested. With such short notice the best we could hope for would be to get patches from a couple motivated individuals. That alone would be a great outcome. For future efforts it would be great to get the JUGs involved! Of course, this would require more lead time and more planning effort. Would we try to get JUG events and an Oracle JDK developer event all on the same day? That would truly be an International Warnings Cleanup Day. Or would it be easier for individual JUGs to run their own individual events, and then to work with us to get the patches reviewed and tested? You tell me. We'd be happy to help support such efforts. As for what to work on, I'm sure there will still be plenty of warnings remaining after this week's Cleanup Day. (Recent patches from Alan Bateman and Lance Andersen on core-libs-dev have pulled us below 10,000 by my count.) There are also warnings from findbugs, and there is also the potential to continue of the Coinification work that I did during JDK7 development. So there's no shortage of stuff to work on. Of course, anybody can work on this stuff at any time, but it'd probably be much more fun (and more likely to get done) if it were done as part of some kind of event. Anyway, I'd love to hear your ideas for how to structure a follow-up event. s'marks On 11/29/11 3:47 AM, Ben Evans wrote: > Hi Xiomara, > > This looks like a great project, and is definitely the sort of > participation that the user group community can help with. > > However, we need more lead time to effectively participate. In our > experience the best way for the community to help with something like > this is to have a physical meet. That way the relatively small number > of people in our communities who can build OpenJDK are able to help > the others bootstrap ("teach them to fish"), and thereby increase > overall participation. > > As this is an out-of-work activity for the vast majority of our > members, we need time to plan and promote our events - especially if > this is to be done as an after-work activity. > > We probably won't be able to manage to put an event together for this > week - but on the assumption that there'll still be plenty of warnings > to squish - can we plan for a later date when we can help? > >> From the community side, some of the right people to reach out to are > myself and Martijn Verburg from LJC (London), and Bruno Souza and Yara > Senger from SouJava (Brazil) - we can then ensure the message gets out > to the rest of the global JUG community. > > Shame that it's probably too close for us to do much this time - but > let us know how it goes, and we'd definitely love to do something if > we had more notice. > > Thanks, > > Ben > > On Tue, Nov 29, 2011 at 2:10 AM, Xiomara Jayasena > wrote: >> A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. We would like to invite you to participate. >> >> >> >> To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. If you decide to participate then please reply to this e-mail with the area that you intend to work on. I will keep track of the areas so that there is no overlap of work. >> >> >> >> . A group of us working on this project will create bugs for the areas that developers sign up for. >> >> . The focus will be on java warnings, since these are less risky. >> >> . For this exercise please avoid making any API changes or any large scale refactorings. >> >> . Avoid @SuppressWarnings except where it is clearly necessary. >> >> . We would like to have the code changes completed by 5pm (PST) on Dec. 1st. >> >> . A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings. The java files are in java.io, java.lang, java.util and a variety of related packages. >> >> >> >> Process to follow: >> >> >> >> 1. Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on. >> >> 2. A bug ID will be generated for this. >> >> 3. Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk >> >> 4. Post your changes for review. If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment. If the patch is too cumbersome to review, we can generate a webrev for you. >> >> 5. All of the changes must go through the usual build, test and review process before being pushed. If you are a JDK8 committer you may push after completing the usual process. If you aren't a committer we will help you review and test your changes. >> >> 6. In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! >> >> >> >> Lastly to get a build with warnings enable use the following flags: >> >> make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" >> >> >> >> Tip: Make sure to redirect output to a file. To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below." >> >> >> >> -Xiomara >> From xiomara.jayasena at oracle.com Tue Nov 29 19:19:13 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Tue, 29 Nov 2011 19:19:13 -0800 (PST) Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <20111130012602.GC32372@rivendell.middle-earth.co.uk> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default 20111130012602.GC32372@rivendell.middle-earth.co.uk> Message-ID: <88458a64-7381-4936-a0c3-8eecbd88ff99@default> > > A few questions: > > 1. Is this the JDK as in just the jdk repository or are we also > including the Java code in CORBA and HotSpot here? (langtools is > already clean IIRC) We are including java code warnings under the JDK8 forest, which includes langtools, hotspot, etc. (http://hg.openjdk.java.net/). > > 2. As has already been noted, the timing leaves something to be > desired and it would be good to have more notice of future such events, > so that the community as a whole can participate and not just those > employed by Oracle. With regard to this event, I assume we can work on > this prior to 8am PT on Thursday as that translates to around close-of- > business (4pm GMT, 5pm CET and so on) in Europe (see > http://en.wikipedia.org/wiki/Central_European_Time)? 8am PT is the deadline for you guys to figure out what files you would like to work on and let us know that by replying to jdk8-dev alias so that there are no overlaps in the work. Other than that, those times are just a guideline for people to all work together so that reviews and builds and tests can happen around the same time which will hopefully make them faster. You guys are welcome to send in the files that you would like to work on earlier than the times above and you can get a head start on fixing them. You are also welcome to continue fixing warnings beyond the warnings day. It would be nice however, to get a count of how many warnings are fixed on that day. -Xiomara > > Thanks, > -- > Andrew :) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and IcedTea > http://www.gnu.org/software/classpath > http://icedtea.classpath.org > PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E > C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From sebastian.sickelmann at gmx.de Tue Nov 29 20:01:47 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Wed, 30 Nov 2011 05:01:47 +0100 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: <4ED5AAAB.6070404@gmx.de> This is a great idea. Don't know how many time i can invest in the timeframe (till 02:00 am GMT+1) but i want to look at java.io -- Sebastian Am 29.11.2011 03:10, schrieb Xiomara Jayasena: > A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st. We would like to invite you to participate. > > > > To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8. If you decide to participate then please reply to this e-mail with the area that you intend to work on. I will keep track of the areas so that there is no overlap of work. > > > > . A group of us working on this project will create bugs for the areas that developers sign up for. > > . The focus will be on java warnings, since these are less risky. > > . For this exercise please avoid making any API changes or any large scale refactorings. > > . Avoid @SuppressWarnings except where it is clearly necessary. > > . We would like to have the code changes completed by 5pm (PST) on Dec. 1st. > > . A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings. The java files are in java.io, java.lang, java.util and a variety of related packages. > > > > Process to follow: > > > > 1. Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on. > > 2. A bug ID will be generated for this. > > 3. Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk > > 4. Post your changes for review. If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment. If the patch is too cumbersome to review, we can generate a webrev for you. > > 5. All of the changes must go through the usual build, test and review process before being pushed. If you are a JDK8 committer you may push after completing the usual process. If you aren't a committer we will help you review and test your changes. > > 6. In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! > > > > Lastly to get a build with warnings enable use the following flags: > > make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000" > > > > Tip: Make sure to redirect output to a file. To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below." > > > > -Xiomara From niklas.schlimm at provinzial.com Tue Nov 29 20:11:59 2011 From: niklas.schlimm at provinzial.com (niklas.schlimm at provinzial.com) Date: Wed, 30 Nov 2011 05:11:59 +0100 Subject: =?windows-1252?Q?AUTO=3A_Schlimm=2C_Niklas_is_out_of_the_office=2E_=28?= =?windows-1252?Q?R=FCckkehr_am_02=2E12=2E2011=29?= Message-ID: Ich bin bis 02.12.2011 abwesend. Ich werde Ihre Nachricht nach meiner R?ckkehr beantworten. Themen rund um Releaseverfahren und Tabex/4 betreut Oliver Krebs (stellv. Gruppenleiter). Continuous Integration und Testautomatisierung betreut Nils Gottschaldt. Java und Framework-Themen werden von Herrn Andreas Fritz betreut. Hinweis: Dies ist eine automatische Antwort auf Ihre Nachricht "jdk8-dev Digest, Vol 7, Issue 19" gesendet am 30.11.2011 05:01:47. Diese ist die einzige Benachrichtigung, die Sie empfangen werden, w?hrend diese Person abwesend ist. Provinzial Rheinland Versicherung AG ? Die Versicherung der Sparkassen ; Amtsgericht D?sseldorf HRB 41241; Provinzial Rheinland Lebensversicherung AG ? Die Versicherung der Sparkassen; Amtsgericht D?sseldorf HRB 41741; Sitz der Gesellschaften: Provinzialplatz 1, D-40591 D?sseldorf; Vorsitzender der Aufsichtsr?te: Michael Breuer Vorst?nde: Ulrich Jansen, Vorsitzender; Patric Fedlmeier, Sabine Krummenerl, Guido Schaefers, Peter Slawik Die Berufsunf?higkeitsversicherung der Provinzial erh?lt mit f?nf Sternen Spitzenbewertung der Ratingagentur Morgen und Morgen! www.provinzial.com Denken Sie an die Umwelt, bevor Sie diese E-Mail ausdrucken! From david.holmes at oracle.com Tue Nov 29 21:33:33 2011 From: david.holmes at oracle.com (David Holmes) Date: Wed, 30 Nov 2011 15:33:33 +1000 Subject: 7116404: Miscellaneous warnings (java.rmi.**, serialization, some core classes) In-Reply-To: <4ED503EB.6000708@oracle.com> References: <4ED503EB.6000708@oracle.com> Message-ID: <4ED5C02D.6080303@oracle.com> cc'ing to jdk8-dev so that people know these classes have already been tackled. David On 30/11/2011 2:10 AM, Alan Bateman wrote: > > I don't have time on Thursday to get involved in the warnings fest [1]. > However I would like to contribute something and to that end the > following webrev proposes changes to eliminate the warnings from several > classes including java.rmi.**, the serialization classes, and several > core classes: > > http://cr.openjdk.java.net/~alanb/7116404/webrev/ > > The changes are mostly trivial, and mostly to raw type usages. One > tricky one ObjectInputStream.readEnum where I had to use a raw type > (Maurizio and I chatted about this one and there doesn't seem to be a > better workaround). There is one non-warnings change in > java.rmi.server.LogStream where I replaced a usage of legacy Hashtable > with a HashMap. > > -Alan. > > [1] > http://mail.openjdk.java.net/pipermail/jdk8-dev/2011-November/000302.html From david.holmes at oracle.com Tue Nov 29 21:50:23 2011 From: david.holmes at oracle.com (David Holmes) Date: Wed, 30 Nov 2011 15:50:23 +1000 Subject: 7116445: Miscellaneous warnings in the JDBC/RowSet classes In-Reply-To: References: Message-ID: <4ED5C41F.9010504@oracle.com> cc'ing to jdk8-dev so that people know these classes have already been tackled. David On 30/11/2011 4:02 AM, Lance Andersen - Oracle wrote: > Please review the following changes for JDBC area as part of the warnings clean up day. I will not be able to participate on Thursday so I wanted to try and get this done ahead of time. > > The changes can be found at http://cr.openjdk.java.net/~lancea/7116445/webrev.00/ > > Best > Lance > > Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > Lance.Andersen at oracle.com > From xiomara.jayasena at oracle.com Tue Nov 29 22:04:18 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Tue, 29 Nov 2011 22:04:18 -0800 (PST) Subject: Oracle Contributor Agreement Message-ID: Hi, I wanted to take this time to remind folks that if you haven't signed the Oracle Contributor Agreement (OCA) and would like to contribute changes to the JDK, then please be sure to sign the agreement. The process for how to contribute to the JDK projects can be found here: http://openjdk.java.net/contribute/ and this is the direct link to the document: http://www.oracle.com/technetwork/oca-405177.pdf The FAQ regarding the agreement can also found in the how to contribute link above. -Xiomara From mikeb01 at gmail.com Wed Nov 30 01:03:08 2011 From: mikeb01 at gmail.com (Michael Barker) Date: Wed, 30 Nov 2011 09:03:08 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 Message-ID: Hi, We have a team together from the LJC who are going to run a build/hack-fest tomorrow evening: http://www.meetup.com/Londonjavacommunity/events/42736622/ I can't seem to see anybody claim anything other than swing and awt packages, so if no one has taken them we'll look at the subpackages of java.util: java.util.concurrent java.util.concurrent.atomic java.util.jar java.util.logging java.util.prefs java.util.regex java.util.zip If we get through those we'll drop another message to the list and claim some more. If those are already taken then could you send me a a couple of packages that aren't. Around ~200 warnings would probably be a reasonable attempt for us (we're not sure how many will get a working build). Regards, Michael Barker. From weijun.wang at oracle.com Wed Nov 30 01:32:17 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Wed, 30 Nov 2011 17:32:17 +0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> Message-ID: <4ED5F821.3040906@oracle.com> On 11/29/2011 10:10 AM, Xiomara Jayasena wrote: > 6. In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this! I cd into several security-related directories, call make clobber, and then call make. Only one warning in javax/security, others are inside sun/misc. The fix is trivial so I won't create a CR or a webrev. Thanks Max diff --git a/src/share/classes/javax/security/auth/kerberos/ServicePermission.java b/src/share/classes/javax/security/auth/kerberos/ServicePermission.java --- a/src/share/classes/javax/security/auth/kerberos/ServicePermission.java +++ b/src/share/classes/javax/security/auth/kerberos/ServicePermission.java @@ -301,7 +301,7 @@ * @param action the action string * @return the action mask */ - + @SuppressWarnings("fallthrough") private static int getMask(String action) { if (action == null) { diff --git a/src/share/classes/sun/misc/BASE64Decoder.java b/src/share/classes/sun/misc/BASE64Decoder.java --- a/src/share/classes/sun/misc/BASE64Decoder.java +++ b/src/share/classes/sun/misc/BASE64Decoder.java @@ -102,6 +102,7 @@ /** * Decode one BASE64 atom into 1, 2, or 3 bytes of data. */ + @SuppressWarnings({"fallthrough"}) protected void decodeAtom(PushbackInputStream inStream, OutputStream outStream, int rem) throws java.io.IOException { diff --git a/src/share/classes/sun/misc/CEFormatException.java b/src/share/classes/sun/misc/CEFormatException.java --- a/src/share/classes/sun/misc/CEFormatException.java +++ b/src/share/classes/sun/misc/CEFormatException.java @@ -28,7 +28,9 @@ import java.io.IOException; public class CEFormatException extends IOException { - public CEFormatException(String s) { - super(s); - } + static final long serialVersionUID = -7139121221067081482L; + public CEFormatException(String s) { + super(s); + } } + diff --git a/src/share/classes/sun/misc/CEStreamExhausted.java b/src/share/classes/sun/misc/CEStreamExhausted.java --- a/src/share/classes/sun/misc/CEStreamExhausted.java +++ b/src/share/classes/sun/misc/CEStreamExhausted.java @@ -27,4 +27,7 @@ import java.io.IOException; /** This exception is thrown when EOF is reached */ -public class CEStreamExhausted extends IOException { }; +public class CEStreamExhausted extends IOException { + static final long serialVersionUID = -5889118049525891904L; +} + From Alan.Bateman at oracle.com Wed Nov 30 01:34:50 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 30 Nov 2011 09:34:50 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: References: Message-ID: <4ED5F8BA.5080903@oracle.com> On 30/11/2011 09:03, Michael Barker wrote: > Hi, > > We have a team together from the LJC who are going to run a > build/hack-fest tomorrow evening: > http://www.meetup.com/Londonjavacommunity/events/42736622/ > > I can't seem to see anybody claim anything other than swing and awt > packages, so if no one has taken them we'll look at the subpackages of > java.util: > > java.util.concurrent > java.util.concurrent.atomic > java.util.jar > java.util.logging > java.util.prefs > java.util.regex > java.util.zip > java.util.concurrent.** is maintained by Doug Lea in an upstream CVS and we (Chris Hegarty in recent times) periodically pull the updates into OpenJDK to keep us in sync. We don't want the code in OpenJDK to diverge so typically any changes go into the upstream CVS first. So for j.u.c I would suggest sending a follow-up to core-libs-dev. Both Doug and Chris are on that list and I'm sure something can be worked out. -Alan. From stuart.marks at oracle.com Wed Nov 30 01:39:29 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 30 Nov 2011 01:39:29 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED5AAAB.6070404@gmx.de> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED5AAAB.6070404@gmx.de> Message-ID: <4ED5F9D1.10104@oracle.com> Thanks for your interest! Note that Alan Bateman has already submitted a patch [1] that fixes some warnings in java.io. There may be other warnings in java.io, though; I haven't checked. I'd encourage you to look at even a small number of warnings. There is no requirement to fix all the warnings in a package or anything like that. s'marks [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-November/008400.html On 11/29/11 8:01 PM, Sebastian Sickelmann wrote: > This is a great idea. > > Don't know how many time i can invest in the timeframe (till 02:00 am GMT+1) > but i want to look at java.io > > -- Sebastian > > Am 29.11.2011 03:10, schrieb Xiomara Jayasena: >> A few teams are planning on cleaning up warnings generated during the JDK >> build on Dec. 1st. We would like to invite you to participate. >> >> >> >> To be able to participate a prerequisite is that you are able build the JDK. >> The source that we will target is JDK8. If you decide to participate then >> please reply to this e-mail with the area that you intend to work on. I will >> keep track of the areas so that there is no overlap of work. >> >> >> >> . A group of us working on this project will create bugs for the areas that >> developers sign up for. >> >> . The focus will be on java warnings, since these are less risky. >> >> . For this exercise please avoid making any API changes or any large scale >> refactorings. >> >> . Avoid @SuppressWarnings except where it is clearly necessary. >> >> . We would like to have the code changes completed by 5pm (PST) on Dec. 1st. >> >> . A suggested area to work on is the build step defined by: >> jdk/make/java/java/ which compiles close to 500 .java files and produces over >> 1200 warnings. The java files are in java.io, java.lang, java.util and a >> variety of related packages. >> >> >> >> Process to follow: >> >> >> >> 1. Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT >> on Thursday to let us know which area you would like to work on. >> >> 2. A bug ID will be generated for this. >> >> 3. Pull this repo to base your changes on it: >> http://hg.openjdk.java.net/jdk8/tl/jdk >> >> 4. Post your changes for review. If you have webrev, please use it. If you >> don't have webrev, please generate a patch and post it here as a .txt >> attachment. If the patch is too cumbersome to review, we can generate a >> webrev for you. >> >> 5. All of the changes must go through the usual build, test and review >> process before being pushed. If you are a JDK8 committer you may push after >> completing the usual process. If you aren't a committer we will help you >> review and test your changes. >> >> 6. In order to streamlines the process, Stuart Marks will be consolidating >> patches and running build and test jobs - thanks to Stuart for doing this! >> >> >> >> Lastly to get a build with warnings enable use the following flags: >> >> make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= >> OTHER_JAVACFLAGS="-Xmaxwarns 10000" >> >> >> >> Tip: Make sure to redirect output to a file. To find the >> jdk/make/java/java/Makefile build step mentioned above, open the log file and >> look for the first occurrence of '# Running javac'. Voluminous warning output >> should appear below." >> >> >> >> -Xiomara > From chris.hegarty at oracle.com Wed Nov 30 01:58:33 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 30 Nov 2011 09:58:33 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED5F8BA.5080903@oracle.com> References: <4ED5F8BA.5080903@oracle.com> Message-ID: <4ED5FE49.6000201@oracle.com> On 30/11/2011 09:34, Alan Bateman wrote: > On 30/11/2011 09:03, Michael Barker wrote: >> ..... > java.util.concurrent.** is maintained by Doug Lea in an upstream CVS and > we (Chris Hegarty in recent times) periodically pull the updates into > OpenJDK to keep us in sync. We don't want the code in OpenJDK to diverge > so typically any changes go into the upstream CVS first. So for j.u.c I > would suggest sending a follow-up to core-libs-dev. Both Doug and Chris > are on that list and I'm sure something can be worked out. Right, we can still propose a patch and discuss it on core-libs-dev, but we really would prefer to have agreement with Doug that he will apply the same to his upstream CVS. We really don't want to diverge what we have in OpenJDK to that of Doug's CVS. This is the typical process we follow for j.u.c. Thanks, -Chris. > > -Alan. From mikeb01 at gmail.com Wed Nov 30 01:59:02 2011 From: mikeb01 at gmail.com (Michael Barker) Date: Wed, 30 Nov 2011 09:59:02 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED5FE49.6000201@oracle.com> References: <4ED5F8BA.5080903@oracle.com> <4ED5FE49.6000201@oracle.com> Message-ID: Might be easier for us to skip j.u.c and work on the other subpackages of java.util. java.util.jar java.util.logging java.util.prefs java.util.regex java.util.zip Regards, Michael Barker. On Wed, Nov 30, 2011 at 9:58 AM, Chris Hegarty wrote: > > > On 30/11/2011 09:34, Alan Bateman wrote: >> >> On 30/11/2011 09:03, Michael Barker wrote: >>> >>> ..... >> >> java.util.concurrent.** is maintained by Doug Lea in an upstream CVS and >> we (Chris Hegarty in recent times) periodically pull the updates into >> OpenJDK to keep us in sync. We don't want the code in OpenJDK to diverge >> so typically any changes go into the upstream CVS first. So for j.u.c I >> would suggest sending a follow-up to core-libs-dev. Both Doug and Chris >> are on that list and I'm sure something can be worked out. > > Right, we can still propose a patch and discuss it on core-libs-dev, but we > really would prefer to have agreement with Doug that he will apply the same > to his upstream CVS. We really don't want to diverge what we have in OpenJDK > to that of Doug's CVS. This is the typical process we follow for j.u.c. > > Thanks, > -Chris. > >> >> -Alan. > From Alan.Bateman at oracle.com Wed Nov 30 02:13:50 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 30 Nov 2011 10:13:50 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED5F9D1.10104@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED5AAAB.6070404@gmx.de> <4ED5F9D1.10104@oracle.com> Message-ID: <4ED601DE.9080308@oracle.com> On 30/11/2011 09:39, Stuart Marks wrote: > Thanks for your interest! > > Note that Alan Bateman has already submitted a patch [1] that fixes > some warnings in java.io. There may be other warnings in java.io, > though; I haven't checked. > Yes, I tackled the serialization code as that is where the majority of the warnings are in java.io and it can be a tricky area. I didn't claim the java.io package and there are 14 other warnings that need attention, some of which are screaming "re-write me, re-write me". -Alan. From sebastian.sickelmann at gmx.de Wed Nov 30 07:09:00 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Wed, 30 Nov 2011 16:09:00 +0100 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED601DE.9080308@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED5AAAB.6070404@gmx.de> <4ED5F9D1.10104@oracle.com> <4ED601DE.9080308@oracle.com> Message-ID: <4ED6470C.5060606@gmx.de> Am 30.11.2011 11:13, schrieb Alan Bateman: > On 30/11/2011 09:39, Stuart Marks wrote: >> Thanks for your interest! >> >> Note that Alan Bateman has already submitted a patch [1] that fixes >> some warnings in java.io. There may be other warnings in java.io, >> though; I haven't checked. >> > Yes, I tackled the serialization code as that is where the majority of > the warnings are in java.io and it can be a tricky area. I didn't > claim the java.io package and there are 14 other warnings that need > attention, some of which are screaming "re-write me, re-write me". > > -Alan. > Ok. I just read this mail and Alan's webrev look pretty much the same in the main part. I will import this change and will make a merge with my changes and look through the merge conflicts. Than i will look at the "re-write, re-write me" parts. Don't found them yet, but i think i will see them. -- Sebastian From martijnverburg at teamsparq.net Wed Nov 30 07:22:08 2011 From: martijnverburg at teamsparq.net (Martijn Verburg) Date: Wed, 30 Nov 2011 15:22:08 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED58A21.4040005@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED58A21.4040005@oracle.com> Message-ID: Hi Stuart, This is slightly faster timing than I anticipated, but we do have an 'Adopt the OpenJDK' program in the pipeline that (like the 'Adopt a JSR' program) would start with the LJC (quickly followed by SouJava) and then spread out globally to the other JUGs once we found an efficient way of working with the OpenJDK community. You can find the very early beginnings of the program at http://java.net/projects/ljc-london-jug/pages/AdoptTheOpenJDKProgram in-line responses follow. > [I've removed jdk7-dev and build-dev] > > Hi Ben, Bruno, et al, > > I'm working with Xiomara on this Warnings Cleanup Day. Sorry for the short > notice. For this effort we wanted to get something put together really > quickly, mainly to see what happens, and also to see who might be > interested. With such short notice the best we could hope for would be to > get patches from a couple motivated individuals. That alone would be a great > outcome. As you saw from Mike Barker, you've got ~20 enthusiasts from London :-). 23 minutes after we put up the impromptu event (with a limit of 20 places), it was full, so I think it's fair to say that there's the potential here to get a lot done with JUG members (if channelled correctly). The LJC this time around will organise itself with Mike leading the effort and he'll gather together the results into a single patch (or group of patches) so that you don't get 20 separate submissions. This of course is slightly dependant on everyone getting to the stage where they can build! > For future efforts it would be great to get the JUGs involved! Of course, > this would require more lead time and more planning effort. Would we try to > get JUG events and an Oracle JDK developer event all on the same day? That > would truly be an International Warnings Cleanup Day. Or would it be easier > for individual JUGs to run their own individual events, and then to work > with us to get the patches reviewed and tested? You tell me. We'd be happy > to help support such efforts. I think it might be difficult to have a single day where everyone does the work. However, if you nominated, say a 2-3 day period with a drop dead date that you'll accept patches by, then that would work? That way the JUGs can organise themselves to meet on a day that suits them. I think a dedicated IRC channel will also help where JUGs can provide assistance to each other on a purely voluntary basis (I'm not necessarily advocating or expecting core committers to be hanging out there, but of course that would be welcome). The other key factor is that there should be a single point of contact within each JUG group who is the person most experienced with the OpenJDK (and how the OpenJDK culture/workflow works) who can gather together results/patches and send them in. I think flooding you guys would be counter productive. > As for what to work on, I'm sure there will still be plenty of warnings > remaining after this week's Cleanup Day. (Recent patches from Alan Bateman > and Lance Andersen on core-libs-dev have pulled us below 10,000 by my > count.) There are also warnings from findbugs, and there is also the > potential to continue of the Coinification work that I did during JDK7 > development. So there's no shortage of stuff to work on. This sort of low hanging yet numerous work is perfect for JUG enthusiasts and hopefully some of those enthusiasts will be encouraged to stick around and really get to know the OpenJDK and then give more in depth contributions in the future. > Of course, anybody can work on this stuff at any time, but it'd probably be > much more fun (and more likely to get done) if it were done as part of some > kind of event. Definitely, it creates a real buzz and I think there are a bunch of developers who are secretly scared of the OpenJDK and would prefer to approach it in a team as part of an event for the first time :-). That's my initial ideas on it anyhow, thoughts? Cheers, Martijn From jonathan.gibbons at oracle.com Wed Nov 30 08:30:51 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 30 Nov 2011 08:30:51 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED58A21.4040005@oracle.com> Message-ID: <4ED65A3B.4090504@oracle.com> On 11/30/2011 07:22 AM, Martijn Verburg wrote: > As you saw from Mike Barker, you've got ~20 enthusiasts from London > :-). 23 minutes after we put up the impromptu event (with a limit of > 20 places), it was full, so I think it's fair to say that there's the > potential here to get a lot done with JUG members (if channelled > correctly). The LJC this time around will organise itself with Mike > leading the effort and he'll gather together the results into a single > patch (or group of patches) so that you don't get 20 separate > submissions. This of course is slightly dependant on everyone getting > to the stage where they can build! Martijn, It is great to see this sort of enthusiasm. As a reviewer for similar efforts in the past, I note that it can help to group changes by the amount of analysis needed for each change. For example, changes to remove redundant casts are pretty easy to do, and to review, but other changes might need more analysis, especially anything involving method signatures. -- Jon From martijnverburg at teamsparq.net Wed Nov 30 08:33:45 2011 From: martijnverburg at teamsparq.net (Martijn Verburg) Date: Wed, 30 Nov 2011 16:33:45 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED65A3B.4090504@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED58A21.4040005@oracle.com> <4ED65A3B.4090504@oracle.com> Message-ID: Hi John, > Martijn, > > It is great to see this sort of enthusiasm. > > As a reviewer for similar efforts in the past, I note that it can help to > group changes by the amount of analysis needed for each change. For example, > changes to remove redundant casts are pretty easy to do, and to review, but > other changes might need more analysis, especially anything involving method > signatures. Thanks! We'll do just that - any other suggestions on how people want to receive patches/effort/results please let us know. We really don't want to add unnecessary burden. Cheers, Martijn From jonathan.gibbons at oracle.com Wed Nov 30 08:41:57 2011 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 30 Nov 2011 08:41:57 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED58A21.4040005@oracle.com> <4ED65A3B.4090504@oracle.com> Message-ID: <4ED65CD5.3090508@oracle.com> On 11/30/2011 08:33 AM, Martijn Verburg wrote: > Hi John, > >> Martijn, >> >> It is great to see this sort of enthusiasm. >> >> As a reviewer for similar efforts in the past, I note that it can help to >> group changes by the amount of analysis needed for each change. For example, >> changes to remove redundant casts are pretty easy to do, and to review, but >> other changes might need more analysis, especially anything involving method >> signatures. > Thanks! We'll do just that - any other suggestions on how people want > to receive patches/effort/results please let us know. We really don't > want to add unnecessary burden. > > Cheers, > Martijn Martijn, I think there is going to be some amount of "figuring it out as we go", so there will probably need to be some amount of back and forth to begin with regarding what are "safe" changes to make, and what are not. We'll be using chat rooms and responding to email to help those joining in the fun. -- Jon From martijnverburg at teamsparq.net Wed Nov 30 08:45:15 2011 From: martijnverburg at teamsparq.net (Martijn Verburg) Date: Wed, 30 Nov 2011 16:45:15 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED65CD5.3090508@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED58A21.4040005@oracle.com> <4ED65A3B.4090504@oracle.com> <4ED65CD5.3090508@oracle.com> Message-ID: Hi Jon, > Martijn, > > I think there is going to be some amount of "figuring it out as we go", so > there will probably need to be some amount of back and forth to begin with > regarding what are "safe" changes to make, and what are not. ? We'll be > using chat rooms and responding to email to help those joining in the fun. Sounds good - Just to be clear - is there a chat room we should use? Or do you prefer email? Cheers, Martijn From maurizio.cimadamore at oracle.com Wed Nov 30 08:45:31 2011 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Wed, 30 Nov 2011 16:45:31 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED58A21.4040005@oracle.com> <4ED65A3B.4090504@oracle.com> Message-ID: <4ED65DAB.3050609@oracle.com> On 30/11/11 16:33, Martijn Verburg wrote: > Hi John, > >> Martijn, >> >> It is great to see this sort of enthusiasm. >> >> As a reviewer for similar efforts in the past, I note that it can help to >> group changes by the amount of analysis needed for each change. For example, >> changes to remove redundant casts are pretty easy to do, and to review, but >> other changes might need more analysis, especially anything involving method >> signatures. > Thanks! We'll do just that - any other suggestions on how people want > to receive patches/effort/results please let us know. We really don't > want to add unnecessary burden. Martijn, as many of the warnings out there are indeed related to generics, we need to make sure that, when fixing such warnings, we don't end up changing signatures of public API (i.e. by adding/removing generics/wildcards), as these changes are potentially harmful for JDK consumers. I think it would be best to focus on low-hanging fruits first - these are: *) changes that involve the body of a method (i.e. changes to the declared type of a local variable) *) Adding @SuppressWarnings is always safe (retention policy of this annotation is sourcefile, so that classfile won't be affected) *) changing initializer (even of public fields) is always safe - as the initializer is part of the constructor - therefore it's part of the implementation I think those rules are quite useful in distinguishing safe changes from potentially harmful changes. I would also refrain from relying on modifiers to establish whether a method is public or private API - remember that a package-private method can be overriden in a subclass and given a public modifier! Maurizio > Cheers, > Martijn From forax at univ-mlv.fr Wed Nov 30 09:00:40 2011 From: forax at univ-mlv.fr (=?UTF-8?B?UsOpbWkgRm9yYXg=?=) Date: Wed, 30 Nov 2011 18:00:40 +0100 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED65DAB.3050609@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED58A21.4040005@oracle.com> <4ED65A3B.4090504@oracle.com> <4ED65DAB.3050609@oracle.com> Message-ID: <4ED66138.4000206@univ-mlv.fr> On 11/30/2011 05:45 PM, Maurizio Cimadamore wrote: > On 30/11/11 16:33, Martijn Verburg wrote: >> Hi John, >> >>> Martijn, >>> >>> It is great to see this sort of enthusiasm. >>> >>> As a reviewer for similar efforts in the past, I note that it can >>> help to >>> group changes by the amount of analysis needed for each change. For >>> example, >>> changes to remove redundant casts are pretty easy to do, and to >>> review, but >>> other changes might need more analysis, especially anything >>> involving method >>> signatures. >> Thanks! We'll do just that - any other suggestions on how people want >> to receive patches/effort/results please let us know. We really don't >> want to add unnecessary burden. > Martijn, > as many of the warnings out there are indeed related to generics, we > need to make sure that, when fixing such warnings, we don't end up > changing signatures of public API (i.e. by adding/removing > generics/wildcards), as these changes are potentially harmful for JDK > consumers. I think it would be best to focus on low-hanging fruits > first - these are: > > *) changes that involve the body of a method (i.e. changes to the > declared type of a local variable) > > *) Adding @SuppressWarnings is always safe (retention policy of this > annotation is sourcefile, so that classfile won't be affected) It's a binary compatible change but it's not safe. > > *) changing initializer (even of public fields) is always safe - as > the initializer is part of the constructor - therefore it's part of > the implementation static fields initialized with a constant primitive values or strings are not part of the constructor. > > I think those rules are quite useful in distinguishing safe changes > from potentially harmful changes. I would also refrain from relying on > modifiers to establish whether a method is public or private API - > remember that a package-private method can be overriden in a subclass > and given a public modifier! > > Maurizio cheers, R?mi From maurizio.cimadamore at oracle.com Wed Nov 30 09:07:43 2011 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Wed, 30 Nov 2011 17:07:43 +0000 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED66138.4000206@univ-mlv.fr> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED58A21.4040005@oracle.com> <4ED65A3B.4090504@oracle.com> <4ED65DAB.3050609@oracle.com> <4ED66138.4000206@univ-mlv.fr> Message-ID: <4ED662DF.4080807@oracle.com> On 30/11/11 17:00, R?mi Forax wrote: > On 11/30/2011 05:45 PM, Maurizio Cimadamore wrote: >> On 30/11/11 16:33, Martijn Verburg wrote: >>> Hi John, >>> >>>> Martijn, >>>> >>>> It is great to see this sort of enthusiasm. >>>> >>>> As a reviewer for similar efforts in the past, I note that it can >>>> help to >>>> group changes by the amount of analysis needed for each change. For >>>> example, >>>> changes to remove redundant casts are pretty easy to do, and to >>>> review, but >>>> other changes might need more analysis, especially anything >>>> involving method >>>> signatures. >>> Thanks! We'll do just that - any other suggestions on how people want >>> to receive patches/effort/results please let us know. We really don't >>> want to add unnecessary burden. >> Martijn, >> as many of the warnings out there are indeed related to generics, we >> need to make sure that, when fixing such warnings, we don't end up >> changing signatures of public API (i.e. by adding/removing >> generics/wildcards), as these changes are potentially harmful for JDK >> consumers. I think it would be best to focus on low-hanging fruits >> first - these are: >> >> *) changes that involve the body of a method (i.e. changes to the >> declared type of a local variable) >> >> *) Adding @SuppressWarnings is always safe (retention policy of this >> annotation is sourcefile, so that classfile won't be affected) > > It's a binary compatible change but it's not safe. I was trying to sketch a list of things that can be done without worrying about public API-ness - in that sense adding a @SuppressWarnings does no harm > >> >> *) changing initializer (even of public fields) is always safe - as >> the initializer is part of the constructor - therefore it's part of >> the implementation > > static fields initialized with a constant primitive values or strings > are not part of the constructor. uhmm - which generic warnings can be issued in a static final field whose initializer is a primitive value/String? Maurizio > >> >> I think those rules are quite useful in distinguishing safe changes >> from potentially harmful changes. I would also refrain from relying >> on modifiers to establish whether a method is public or private API - >> remember that a package-private method can be overriden in a subclass >> and given a public modifier! >> >> Maurizio > > cheers, > R?mi > From forax at univ-mlv.fr Wed Nov 30 10:30:45 2011 From: forax at univ-mlv.fr (=?UTF-8?B?UsOpbWkgRm9yYXg=?=) Date: Wed, 30 Nov 2011 19:30:45 +0100 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED662DF.4080807@oracle.com> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED58A21.4040005@oracle.com> <4ED65A3B.4090504@oracle.com> <4ED65DAB.3050609@oracle.com> <4ED66138.4000206@univ-mlv.fr> <4ED662DF.4080807@oracle.com> Message-ID: <4ED67655.1010007@univ-mlv.fr> On 11/30/2011 06:07 PM, Maurizio Cimadamore wrote: > On 30/11/11 17:00, R?mi Forax wrote: >> On 11/30/2011 05:45 PM, Maurizio Cimadamore wrote: >>> On 30/11/11 16:33, Martijn Verburg wrote: >>>> Hi John, >>>> >>>>> Martijn, >>>>> >>>>> It is great to see this sort of enthusiasm. >>>>> >>>>> As a reviewer for similar efforts in the past, I note that it can >>>>> help to >>>>> group changes by the amount of analysis needed for each change. >>>>> For example, >>>>> changes to remove redundant casts are pretty easy to do, and to >>>>> review, but >>>>> other changes might need more analysis, especially anything >>>>> involving method >>>>> signatures. >>>> Thanks! We'll do just that - any other suggestions on how people want >>>> to receive patches/effort/results please let us know. We really don't >>>> want to add unnecessary burden. >>> Martijn, >>> as many of the warnings out there are indeed related to generics, we >>> need to make sure that, when fixing such warnings, we don't end up >>> changing signatures of public API (i.e. by adding/removing >>> generics/wildcards), as these changes are potentially harmful for >>> JDK consumers. I think it would be best to focus on low-hanging >>> fruits first - these are: >>> >>> *) changes that involve the body of a method (i.e. changes to the >>> declared type of a local variable) >>> >>> *) Adding @SuppressWarnings is always safe (retention policy of this >>> annotation is sourcefile, so that classfile won't be affected) > >> >> It's a binary compatible change but it's not safe. > I was trying to sketch a list of things that can be done without > worrying about public API-ness - in that sense adding a > @SuppressWarnings does no harm >> >>> >>> *) changing initializer (even of public fields) is always safe - as >>> the initializer is part of the constructor - therefore it's part of >>> the implementation >> >> static fields initialized with a constant primitive values or strings >> are not part of the constructor. > uhmm - which generic warnings can be issued in a static final field > whose initializer is a primitive value/String? String implements Comparable. > > Maurizio R?mi From stuart.marks at oracle.com Wed Nov 30 10:35:22 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 30 Nov 2011 10:35:22 -0800 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED6470C.5060606@gmx.de> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED5AAAB.6070404@gmx.de> <4ED5F9D1.10104@oracle.com> <4ED601DE.9080308@oracle.com> <4ED6470C.5060606@gmx.de> Message-ID: <4ED6776A.1050703@oracle.com> On 11/30/11 7:09 AM, Sebastian Sickelmann wrote: > Am 30.11.2011 11:13, schrieb Alan Bateman: >> On 30/11/2011 09:39, Stuart Marks wrote: >>> Thanks for your interest! >>> >>> Note that Alan Bateman has already submitted a patch [1] that fixes some >>> warnings in java.io. There may be other warnings in java.io, though; I >>> haven't checked. >>> >> Yes, I tackled the serialization code as that is where the majority of the >> warnings are in java.io and it can be a tricky area. I didn't claim the >> java.io package and there are 14 other warnings that need attention, some of >> which are screaming "re-write me, re-write me". >> >> -Alan. >> > Ok. I just read this mail and Alan's webrev look pretty much the same in the > main part. > I will import this change and will make a merge with my changes and look > through the merge conflicts. > Than i will look at the "re-write, re-write me" parts. Don't found them yet, > but i think i will see them. Wonderful! Note that Alan modified his webrev and then pushed his changset, so you should just pull and update from the jdk8/tl/jdk repo instead of applying the patches from the webrev. Looking forward to your contribution. s'marks From forax at univ-mlv.fr Wed Nov 30 10:52:09 2011 From: forax at univ-mlv.fr (=?UTF-8?B?UsOpbWkgRm9yYXg=?=) Date: Wed, 30 Nov 2011 19:52:09 +0100 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: <4ED67655.1010007@univ-mlv.fr> References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default> <4ED58A21.4040005@oracle.com> <4ED65A3B.4090504@oracle.com> <4ED65DAB.3050609@oracle.com> <4ED66138.4000206@univ-mlv.fr> <4ED662DF.4080807@oracle.com> <4ED67655.1010007@univ-mlv.fr> Message-ID: <4ED67B59.8070902@univ-mlv.fr> On 11/30/2011 07:30 PM, R?mi Forax wrote: > On 11/30/2011 06:07 PM, Maurizio Cimadamore wrote: >> On 30/11/11 17:00, R?mi Forax wrote: >>> On 11/30/2011 05:45 PM, Maurizio Cimadamore wrote: >>>> On 30/11/11 16:33, Martijn Verburg wrote: >>>>> Hi John, >>>>> >>>>>> Martijn, >>>>>> >>>>>> It is great to see this sort of enthusiasm. >>>>>> >>>>>> As a reviewer for similar efforts in the past, I note that it can >>>>>> help to >>>>>> group changes by the amount of analysis needed for each change. >>>>>> For example, >>>>>> changes to remove redundant casts are pretty easy to do, and to >>>>>> review, but >>>>>> other changes might need more analysis, especially anything >>>>>> involving method >>>>>> signatures. >>>>> Thanks! We'll do just that - any other suggestions on how people want >>>>> to receive patches/effort/results please let us know. We really >>>>> don't >>>>> want to add unnecessary burden. >>>> Martijn, >>>> as many of the warnings out there are indeed related to generics, >>>> we need to make sure that, when fixing such warnings, we don't end >>>> up changing signatures of public API (i.e. by adding/removing >>>> generics/wildcards), as these changes are potentially harmful for >>>> JDK consumers. I think it would be best to focus on low-hanging >>>> fruits first - these are: >>>> >>>> *) changes that involve the body of a method (i.e. changes to the >>>> declared type of a local variable) >>>> >>>> *) Adding @SuppressWarnings is always safe (retention policy of >>>> this annotation is sourcefile, so that classfile won't be affected) >> >>> >>> It's a binary compatible change but it's not safe. >> I was trying to sketch a list of things that can be done without >> worrying about public API-ness - in that sense adding a >> @SuppressWarnings does no harm >>> >>>> >>>> *) changing initializer (even of public fields) is always safe - as >>>> the initializer is part of the constructor - therefore it's part of >>>> the implementation >>> >>> static fields initialized with a constant primitive values or >>> strings are not part of the constructor. >> uhmm - which generic warnings can be issued in a static final field >> whose initializer is a primitive value/String? > > String implements Comparable. > >> >> Maurizio > > R?mi > Sorry, this thread should have been private. The rules given by Maurizio are good ones. R?mi From xiomara.jayasena at oracle.com Wed Nov 30 12:14:37 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Wed, 30 Nov 2011 12:14:37 -0800 (PST) Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) Message-ID: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Hi, So far the following people have signed up and I have put the area of interest to work on next to their names. - Sebastian Sickelmann - java.io - Alan Bateman / Chris Hegarty - java.rmi.**, the serialization classes, and several core classes [1] - Andrew John - Corba - Mario Torre -- src/share/classes/sun/java2d/SurfaceData.java - Weijun Wang - src/share/classes/javax/security/auth/Kerberos/ and ./sun/misc/. - Michael Barker (London Jug) * java.util.jar * java.util.logging * java.util.prefs * java.util.regex * java.util.zip - Hinkmond Wong - jdk/make/sun/misc/* [1] http://cr.openjdk.java.net/~alanb/7116404/webrev/ Please let me know if you do not see something that you have sent in and should be added above. The above is a summary of what we have so far, there is still time to send in names of files/areas that you would like to work on. -Xiomara From Alan.Bateman at oracle.com Wed Nov 30 12:27:39 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 30 Nov 2011 20:27:39 +0000 Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <868c0635-11fc-4bc7-9ee9-64513092526e@default> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Message-ID: <4ED691BB.2080100@oracle.com> On 30/11/2011 20:14, Xiomara Jayasena wrote: > Hi, > > So far the following people have signed up and I have put the area of interest to work on next to their names. > > - Sebastian Sickelmann - java.io > - Alan Bateman / Chris Hegarty - java.rmi.**, the serialization classes, and several core classes [1] > - Andrew John - Corba > - Mario Torre -- src/share/classes/sun/java2d/SurfaceData.java > - Weijun Wang - src/share/classes/javax/security/auth/Kerberos/ and ./sun/misc/. > - Michael Barker (London Jug) > * java.util.jar > * java.util.logging > * java.util.prefs > * java.util.regex > * java.util.zip > - Hinkmond Wong - jdk/make/sun/misc/* > Xiomara - Lance has a patch out for review that fixes the warnings in java.sql.* and javax.sql.**. Also Chris has a webrev out that fixes several warnings in sun.misc. I don't think we saw a mail from Hinkmond on sun.misc but there's lots more to be done there. -Alan From xiomara.jayasena at oracle.com Wed Nov 30 12:54:01 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Wed, 30 Nov 2011 12:54:01 -0800 (PST) Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <4ED691BB.2080100@oracle.com> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default 4ED691BB.2080100@oracle.com> Message-ID: <4cf0b17f-c8e8-41d0-b0c8-1932b52d5ce0@default> Thanks Alan -- I'll include Lance's patch to the list when I resend it later. Chris, Hinkmond can you please either send your webrevs or file(s) that you intend to fix? This way we can see that your work doesn't overlap. All, In general, please include jdk8-dev when replying to the areas you will work on, this way we can all see the planned changes. Thanks, -Xiomara > > > Xiomara - Lance has a patch out for review that fixes the warnings in > java.sql.* and javax.sql.**. Also Chris has a webrev out that fixes > several warnings in sun.misc. I don't think we saw a mail from Hinkmond > on sun.misc but there's lots more to be done there. > > -Alan > From martijnverburg at gmail.com Wed Nov 30 13:33:20 2011 From: martijnverburg at gmail.com (Martijn Verburg) Date: Wed, 30 Nov 2011 21:33:20 +0000 Subject: Chat room for JDK8 bug hunt on Dec 1 Message-ID: Hi all, I know that some people will be unable to connect, but I've set up a chat room for this effort on IRC: server/url: irc.freenode.net room: #jdk8bughunters Feel free to join any time starting now - I'm currently working building a VirtualBox VM with Mike Barker to hand out to attendees our tomorrow night. Cheers, Martijn From kurchi.subhra.hazra at oracle.com Wed Nov 30 13:46:18 2011 From: kurchi.subhra.hazra at oracle.com (Kurchi Hazra) Date: Wed, 30 Nov 2011 13:46:18 -0800 Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <868c0635-11fc-4bc7-9ee9-64513092526e@default> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Message-ID: <4ED6A42A.7060204@oracle.com> If java.util.concurrent is not yet taken up, I can work on that tomorrow. Thanks, Kurchi On 11/30/2011 12:14 PM, Xiomara Jayasena wrote: > Hi, > > So far the following people have signed up and I have put the area of interest to work on next to their names. > > - Sebastian Sickelmann - java.io > - Alan Bateman / Chris Hegarty - java.rmi.**, the serialization classes, and several core classes [1] > - Andrew John - Corba > - Mario Torre -- src/share/classes/sun/java2d/SurfaceData.java > - Weijun Wang - src/share/classes/javax/security/auth/Kerberos/ and ./sun/misc/. > - Michael Barker (London Jug) > * java.util.jar > * java.util.logging > * java.util.prefs > * java.util.regex > * java.util.zip > - Hinkmond Wong - jdk/make/sun/misc/* > > [1] http://cr.openjdk.java.net/~alanb/7116404/webrev/ > > Please let me know if you do not see something that you have sent in and should be added above. The above is a summary of what we have so far, there is still time to send in names of files/areas that you would like to work on. > > > -Xiomara > > -- -Kurchi From neugens.limasoftware at gmail.com Wed Nov 30 13:47:01 2011 From: neugens.limasoftware at gmail.com (Mario Torre) Date: Wed, 30 Nov 2011 22:47:01 +0100 Subject: Chat room for JDK8 bug hunt on Dec 1 In-Reply-To: References: Message-ID: Il giorno 30/nov/2011, alle ore 22:33, Martijn Verburg ha scritto: > > jdk8bughunters We will do a bug hnting day? Wow, this sounds fun! :) Anyway, why not the usual #openjdk? Is not very noisy and you will get more chance to get people involved to help out. Cheers, Mario --- pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF http://www.ladybug-studio.com IcedRobot: www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ From omajid at redhat.com Wed Nov 30 13:50:39 2011 From: omajid at redhat.com (Omair Majid) Date: Wed, 30 Nov 2011 16:50:39 -0500 Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <868c0635-11fc-4bc7-9ee9-64513092526e@default> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Message-ID: <4ED6A52F.6010406@redhat.com> On 11/30/2011 03:14 PM, Xiomara Jayasena wrote: > > So far the following people have signed up and I have put the area of > interest to work on next to their names. > I would like to take a look at java.lang if it's still available. Cheers, Omair From martijnverburg at gmail.com Wed Nov 30 13:56:42 2011 From: martijnverburg at gmail.com (Martijn Verburg) Date: Wed, 30 Nov 2011 21:56:42 +0000 Subject: Chat room for JDK8 bug hunt on Dec 1 In-Reply-To: References: Message-ID: Hi all, I simply wasn't aware of #openjdk - what IRC server does that run on? The freenode version of that channel seems empty.. Cheers, Martijn On 30 November 2011 21:47, Mario Torre wrote: > Il giorno 30/nov/2011, alle ore 22:33, Martijn Verburg ha scritto: >> >> jdk8bughunters > > We will do a bug hnting day? Wow, this sounds fun! :) > > Anyway, why not the usual #openjdk? > > Is not very noisy and you will get more chance to get people involved to help out. > > Cheers, > Mario > --- > pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF > Fingerprint: BA39 9666 94EC 8B73 27FA ?FC7C 4086 63E3 80F2 40CF > > http://www.ladybug-studio.com > > IcedRobot: www.icedrobot.org > Proud GNU Classpath developer: http://www.classpath.org/ > Read About us at: http://planet.classpath.org > OpenJDK: http://openjdk.java.net/projects/caciocavallo/ > > Please, support open standards: > http://endsoftpatents.org/ > > > > > From xiomara.jayasena at oracle.com Wed Nov 30 14:03:41 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Wed, 30 Nov 2011 14:03:41 -0800 (PST) Subject: Chat room for JDK8 bug hunt on Dec 1 In-Reply-To: References: Message-ID: <9ef02b62-dbb3-4f28-8340-eb9d077607b2@default> Thanks Martinjn! Yes, let use the usual #openjdk chat room as well. http://openjdk.java.net/irc/ Some of us are having difficulties logging in from behind the firewall but those who can login feel free to discuss WCD activities there. -Xiomara > -----Original Message----- > From: Mario Torre [mailto:neugens.limasoftware at gmail.com] > Sent: Wednesday, November 30, 2011 1:47 PM > To: Martijn Verburg > Cc: jdk8-dev > Subject: Re: Chat room for JDK8 bug hunt on Dec 1 > > Il giorno 30/nov/2011, alle ore 22:33, Martijn Verburg ha scritto: > > > > jdk8bughunters > > We will do a bug hnting day? Wow, this sounds fun! :) > > Anyway, why not the usual #openjdk? > > Is not very noisy and you will get more chance to get people involved > to help out. > > Cheers, > Mario > --- > pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF > Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF > > http://www.ladybug-studio.com > > IcedRobot: www.icedrobot.org > Proud GNU Classpath developer: http://www.classpath.org/ Read About us > at: http://planet.classpath.org > OpenJDK: http://openjdk.java.net/projects/caciocavallo/ > > Please, support open standards: > http://endsoftpatents.org/ > > > > From martijnverburg at gmail.com Wed Nov 30 14:11:45 2011 From: martijnverburg at gmail.com (Martijn Verburg) Date: Wed, 30 Nov 2011 22:11:45 +0000 Subject: Chat room for JDK8 bug hunt on Dec 1 In-Reply-To: <9ef02b62-dbb3-4f28-8340-eb9d077607b2@default> References: <9ef02b62-dbb3-4f28-8340-eb9d077607b2@default> Message-ID: Hi all, I've actually close the jdk8bughunter room - might as well just use the regular #openjdk channel Cheers, Martijn On 30 November 2011 22:03, Xiomara Jayasena wrote: > Thanks Martinjn! > > Yes, let use the usual #openjdk chat room as well. > http://openjdk.java.net/irc/ > > Some of us are having difficulties logging in from behind the firewall but those who can login feel free to discuss WCD activities there. > > -Xiomara > > >> -----Original Message----- >> From: Mario Torre [mailto:neugens.limasoftware at gmail.com] >> Sent: Wednesday, November 30, 2011 1:47 PM >> To: Martijn Verburg >> Cc: jdk8-dev >> Subject: Re: Chat room for JDK8 bug hunt on Dec 1 >> >> Il giorno 30/nov/2011, alle ore 22:33, Martijn Verburg ha scritto: >> > >> > jdk8bughunters >> >> We will do a bug hnting day? Wow, this sounds fun! :) >> >> Anyway, why not the usual #openjdk? >> >> Is not very noisy and you will get more chance to get people involved >> to help out. >> >> Cheers, >> Mario >> --- >> pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF >> Fingerprint: BA39 9666 94EC 8B73 27FA ?FC7C 4086 63E3 80F2 40CF >> >> http://www.ladybug-studio.com >> >> IcedRobot: www.icedrobot.org >> Proud GNU Classpath developer: http://www.classpath.org/ Read About us >> at: http://planet.classpath.org >> OpenJDK: http://openjdk.java.net/projects/caciocavallo/ >> >> Please, support open standards: >> http://endsoftpatents.org/ >> >> >> >> > From neugens.limasoftware at gmail.com Wed Nov 30 14:22:04 2011 From: neugens.limasoftware at gmail.com (Mario Torre) Date: Wed, 30 Nov 2011 23:22:04 +0100 Subject: Chat room for JDK8 bug hunt on Dec 1 In-Reply-To: References: <9ef02b62-dbb3-4f28-8340-eb9d077607b2@default> Message-ID: <0DDEE3E9-403D-4BBD-8905-912A44014705@gmail.com> Il giorno 30/nov/2011, alle ore 23:11, Martijn Verburg ha scritto: > Hi all, > > I've actually close the jdk8bughunter room - might as well just use > the regular #openjdk channel > > Cheers, > Martijn Very cool! At what time (and timezone) do the party starts? Cheers, Mario --- pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF http://www.ladybug-studio.com IcedRobot: www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ From mikeb01 at gmail.com Wed Nov 30 14:25:43 2011 From: mikeb01 at gmail.com (Michael Barker) Date: Wed, 30 Nov 2011 22:25:43 +0000 Subject: Chat room for JDK8 bug hunt on Dec 1 In-Reply-To: <0DDEE3E9-403D-4BBD-8905-912A44014705@gmail.com> References: <9ef02b62-dbb3-4f28-8340-eb9d077607b2@default> <0DDEE3E9-403D-4BBD-8905-912A44014705@gmail.com> Message-ID: For us around 6:30/7:00 GMT. Mike. On Wed, Nov 30, 2011 at 10:22 PM, Mario Torre wrote: > Il giorno 30/nov/2011, alle ore 23:11, Martijn Verburg ha scritto: >> Hi all, >> >> I've actually close the jdk8bughunter room - might as well just use >> the regular #openjdk channel >> >> Cheers, >> Martijn > > > Very cool! > > At what time (and timezone) do the party starts? > > Cheers, > Mario > --- > pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF > Fingerprint: BA39 9666 94EC 8B73 27FA ?FC7C 4086 63E3 80F2 40CF > > http://www.ladybug-studio.com > > IcedRobot: www.icedrobot.org > Proud GNU Classpath developer: http://www.classpath.org/ > Read About us at: http://planet.classpath.org > OpenJDK: http://openjdk.java.net/projects/caciocavallo/ > > Please, support open standards: > http://endsoftpatents.org/ > > > > > From jon.vanalten at redhat.com Wed Nov 30 14:33:12 2011 From: jon.vanalten at redhat.com (Jon VanAlten) Date: Wed, 30 Nov 2011 17:33:12 -0500 (EST) Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Message-ID: Hi, I'll throw my hat in here, with a modest effort to ferret out the warnings in java.lang.instrument, java.lang.invoke, and java.lang.management cheers, jon ----- Original Message ----- > From: "Xiomara Jayasena" > To: jdk8-dev at openjdk.java.net > Sent: Wednesday, November 30, 2011 3:14:37 PM > Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) > > > Hi, > > So far the following people have signed up and I have put the area of > interest to work on next to their names. > > - Sebastian Sickelmann - java.io > - Alan Bateman / Chris Hegarty - java.rmi.**, the serialization > classes, and several core classes [1] > - Andrew John - Corba > - Mario Torre -- src/share/classes/sun/java2d/SurfaceData.java > - Weijun Wang - src/share/classes/javax/security/auth/Kerberos/ and > ./sun/misc/. > - Michael Barker (London Jug) > * java.util.jar > * java.util.logging > * java.util.prefs > * java.util.regex > * java.util.zip > - Hinkmond Wong - jdk/make/sun/misc/* > > [1] http://cr.openjdk.java.net/~alanb/7116404/webrev/ > > Please let me know if you do not see something that you have sent in > and should be added above. The above is a summary of what we have > so far, there is still time to send in names of files/areas that you > would like to work on. > > > -Xiomara > > > From neugens.limasoftware at gmail.com Wed Nov 30 14:35:18 2011 From: neugens.limasoftware at gmail.com (Mario Torre) Date: Wed, 30 Nov 2011 23:35:18 +0100 Subject: Chat room for JDK8 bug hunt on Dec 1 In-Reply-To: References: <9ef02b62-dbb3-4f28-8340-eb9d077607b2@default> <0DDEE3E9-403D-4BBD-8905-912A44014705@gmail.com> Message-ID: <2EBF8EB6-88CC-4B15-AB5E-E1DE1923C960@gmail.com> Il giorno 30/nov/2011, alle ore 23:25, Michael Barker ha scritto: > For us around 6:30/7:00 GMT. > > Mike. Thanks a lot, I hope I can make it. Maybe we can also post an update (decisions, bugs, issues etc...) on this mailing list? This would help who will not be able to attend. Cheers, Mario --- pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF http://www.ladybug-studio.com IcedRobot: www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ From dbhole at redhat.com Wed Nov 30 14:45:08 2011 From: dbhole at redhat.com (Deepak Bhole) Date: Wed, 30 Nov 2011 17:45:08 -0500 Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <868c0635-11fc-4bc7-9ee9-64513092526e@default> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Message-ID: <20111130224507.GI2461@redhat.com> * Xiomara Jayasena [2011-11-30 15:16]: > > Hi, > > So far the following people have signed up and I have put the area of interest to work on next to their names. > > - Sebastian Sickelmann - java.io > - Alan Bateman / Chris Hegarty - java.rmi.**, the serialization classes, and several core classes [1] > - Andrew John - Corba > - Mario Torre -- src/share/classes/sun/java2d/SurfaceData.java > - Weijun Wang - src/share/classes/javax/security/auth/Kerberos/ and ./sun/misc/. > - Michael Barker (London Jug) > * java.util.jar > * java.util.logging > * java.util.prefs > * java.util.regex > * java.util.zip > - Hinkmond Wong - jdk/make/sun/misc/* > > [1] http://cr.openjdk.java.net/~alanb/7116404/webrev/ > > Please let me know if you do not see something that you have sent in and should be added above. The above is a summary of what we have so far, there is still time to send in names of files/areas that you would like to work on. > > Sent this privately but sending here just so no one else picks it up by mistake and starts working on it... I will take java.text.** Cheers, Deepak > From xiomara.jayasena at oracle.com Wed Nov 30 15:05:06 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Wed, 30 Nov 2011 15:05:06 -0800 (PST) Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <868c0635-11fc-4bc7-9ee9-64513092526e@default> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Message-ID: Hi, I continue to track the different areas that are being picked up to work on for tomorrow here: http://wikis.sun.com/display/OpenJDK/JDK8+warning+cleanup+day+%282011-12-01%29 (thanks to Deepak Bhole for reminding us of this!) The above wiki will help us figure out who has signed up. Still, please continue to send messages to this alias (jdk8-dev) for the areas that you plan to work on. Thanks, -Xiomara From jason.uh at oracle.com Wed Nov 30 15:08:23 2011 From: jason.uh at oracle.com (Jason Uh) Date: Wed, 30 Nov 2011 15:08:23 -0800 Subject: Warnings Day Message-ID: <4ED6B767.3060902@oracle.com> Hey all, I'd like to work on the java.util.concurrent.atomic area for Warnings Day. Thanks, Jason From weijun.wang at oracle.com Wed Nov 30 15:22:05 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 1 Dec 2011 07:22:05 +0800 Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <868c0635-11fc-4bc7-9ee9-64513092526e@default> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Message-ID: <20D72F6E-4035-4174-B022-EDA211823309@oracle.com> So Hinkmond and I both work on sun.misc? So far I've found one switch-case fall through and 2 serializeID missing there. Those were discovered when I try to search for warnings in other security -related area. Max On Dec 1, 2011, at 4:14 AM, Xiomara Jayasena wrote: > > Hi, > > So far the following people have signed up and I have put the area of interest to work on next to their names. > > - Sebastian Sickelmann - java.io > - Alan Bateman / Chris Hegarty - java.rmi.**, the serialization classes, and several core classes [1] > - Andrew John - Corba > - Mario Torre -- src/share/classes/sun/java2d/SurfaceData.java > - Weijun Wang - src/share/classes/javax/security/auth/Kerberos/ and ./sun/misc/. > - Michael Barker (London Jug) > * java.util.jar > * java.util.logging > * java.util.prefs > * java.util.regex > * java.util.zip > - Hinkmond Wong - jdk/make/sun/misc/* > > [1] http://cr.openjdk.java.net/~alanb/7116404/webrev/ > > Please let me know if you do not see something that you have sent in and should be added above. The above is a summary of what we have so far, there is still time to send in names of files/areas that you would like to work on. > > > -Xiomara > > From brandon.passanisi at oracle.com Wed Nov 30 15:26:08 2011 From: brandon.passanisi at oracle.com (Brandon Passanisi) Date: Wed, 30 Nov 2011 15:26:08 -0800 Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Message-ID: <4ED6BB90.9000005@oracle.com> I'd like to sign up for java.applet and java.util.PropertyPermission. On 11/30/2011 3:05 PM, Xiomara Jayasena wrote: > Hi, > > I continue to track the different areas that are being picked up to work on for tomorrow here: > http://wikis.sun.com/display/OpenJDK/JDK8+warning+cleanup+day+%282011-12-01%29 (thanks to Deepak Bhole for reminding us of this!) > > The above wiki will help us figure out who has signed up. Still, please continue to send messages to this alias (jdk8-dev) for the areas that you plan to work on. > > Thanks, > -Xiomara -- Oracle Brandon Passanisi | Principle Member of Technical Staff Oracle Java Standards Conformance Green Oracle Oracle is committed to developing practices and products that help protect the environment From masayoshi.okutsu at oracle.com Wed Nov 30 15:22:16 2011 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Wed, 30 Nov 2011 15:22:16 -0800 Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <868c0635-11fc-4bc7-9ee9-64513092526e@default> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Message-ID: <4ED6BAA8.5030909@oracle.com> Hi, The I18N team will work on the following files. Please let me know if there are any duplicates. Naoto Sato: java/awt/im/InputMethodHighlight.java java/lang/ConditionalSpecialCasing.java java/util/Currency.java sun/awt/im/CompositionArea.java sun/awt/im/CompositionAreaHandler.java sun/awt/im/InputContext.java sun/awt/im/InputMethodContext.java sun/awt/im/InputMethodJFrame.java sun/awt/im/InputMethodManager.java sun/awt/im/SimpleInputMethodWindow.java sun/util/LocaleServiceProviderPool.java sun/util/resources/LocaleData.java sun/util/resources/TimeZoneNamesBundle.java Yuka Kamiya: sun/text/CompactByteArray.java sun/text/IntHashtable.java sun/text/bidi/BidiBase.java sun/text/normalizer/ICUData.java sun/text/normalizer/NormalizerBase.java sun/text/normalizer/NormalizerImpl.java sun/text/normalizer/RuleCharacterIterator.java sun/text/normalizer/SymbolTable.java sun/text/normalizer/UnicodeSet.java sun/text/normalizer/UnicodeSetIterator.java sun/text/normalizer/VersionInfo.java Masayoshi Okutsu: java/util/Date.java java/util/GregorianCalendar.java java/util/JapaneseImperialCalendar.java java/util/ResourceBundle.java sun/util/calendar/BaseCalendar.java sun/util/calendar/CalendarSystem.java sun/util/calendar/LocalGregorianCalendar.java sun/util/calendar/ZoneInfo.java sun/util/calendar/ZoneInfoFile.java sun/util/resources/OpenListResourceBundle.java Thanks, Masayoshi On 2011/11/30 12:14, Xiomara Jayasena wrote: > Hi, > > So far the following people have signed up and I have put the area of interest to work on next to their names. > > - Sebastian Sickelmann - java.io > - Alan Bateman / Chris Hegarty - java.rmi.**, the serialization classes, and several core classes [1] > - Andrew John - Corba > - Mario Torre -- src/share/classes/sun/java2d/SurfaceData.java > - Weijun Wang - src/share/classes/javax/security/auth/Kerberos/ and ./sun/misc/. > - Michael Barker (London Jug) > * java.util.jar > * java.util.logging > * java.util.prefs > * java.util.regex > * java.util.zip > - Hinkmond Wong - jdk/make/sun/misc/* > > [1] http://cr.openjdk.java.net/~alanb/7116404/webrev/ > > Please let me know if you do not see something that you have sent in and should be added above. The above is a summary of what we have so far, there is still time to send in names of files/areas that you would like to work on. > > > -Xiomara > > From forax at univ-mlv.fr Wed Nov 30 15:27:17 2011 From: forax at univ-mlv.fr (=?UTF-8?B?UsOpbWkgRm9yYXg=?=) Date: Thu, 01 Dec 2011 00:27:17 +0100 Subject: Warnings Day In-Reply-To: <4ED6B767.3060902@oracle.com> References: <4ED6B767.3060902@oracle.com> Message-ID: <4ED6BBD5.6090200@univ-mlv.fr> On 12/01/2011 12:08 AM, Jason Uh wrote: > Hey all, > > I'd like to work on the java.util.concurrent.atomic area for Warnings > Day. > > Thanks, > Jason > Good luck with the AtomicFooUpdater :) R?mi From weijun.wang at oracle.com Wed Nov 30 15:34:12 2011 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 1 Dec 2011 07:34:12 +0800 Subject: Warnings Day In-Reply-To: <4ED6B767.3060902@oracle.com> References: <4ED6B767.3060902@oracle.com> Message-ID: Chris said the codes in this package are from an upstream repo maintained by Doug Lea, so any change should go there first. Max On Dec 1, 2011, at 7:08 AM, Jason Uh wrote: > Hey all, > > I'd like to work on the java.util.concurrent.atomic area for Warnings Day. > > Thanks, > Jason > From brandon.passanisi at oracle.com Wed Nov 30 15:50:07 2011 From: brandon.passanisi at oracle.com (Brandon Passanisi) Date: Wed, 30 Nov 2011 15:50:07 -0800 Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> Message-ID: <4ED6C12F.1030309@oracle.com> (Resending as I didn't see the first e-mail reach the alias...) I'd like to sign up for java.applet and java.util.PropertyPermission. On 11/30/2011 3:05 PM, Xiomara Jayasena wrote: > Hi, > > I continue to track the different areas that are being picked up to work on for tomorrow here: > http://wikis.sun.com/display/OpenJDK/JDK8+warning+cleanup+day+%282011-12-01%29 (thanks to Deepak Bhole for reminding us of this!) > > The above wiki will help us figure out who has signed up. Still, please continue to send messages to this alias (jdk8-dev) for the areas that you plan to work on. > > Thanks, > -Xiomara -- Oracle Brandon Passanisi | Principle Member of Technical Staff Oracle Java Standards Conformance Green Oracle Oracle is committed to developing practices and products that help protect the environment From chris.hegarty at oracle.com Wed Nov 30 15:47:50 2011 From: chris.hegarty at oracle.com (chris hegarty) Date: Wed, 30 Nov 2011 23:47:50 +0000 Subject: Warnings Day In-Reply-To: References: <4ED6B767.3060902@oracle.com> Message-ID: <4ED6C0A6.3000200@oracle.com> On 30/11/2011 23:34, Weijun Wang wrote: > Chris said the codes in this package are from an upstream repo maintained by Doug Lea, so any change should go there first. Right, we can discuss any proposed patch on core-libs-dev and then present it to Doug for inclusion in his CVS. We really need to keep in sycn with Doug's CVS as maintaining separate source would be a real pain. I also believe Doug provides a version of these classes suitable for running on Java 6, so we need to be able to build with javac from 6. -Chris. > > Max > > > > On Dec 1, 2011, at 7:08 AM, Jason Uh wrote: > >> Hey all, >> >> I'd like to work on the java.util.concurrent.atomic area for Warnings Day. >> >> Thanks, >> Jason >> From yuka.kamiya at oracle.com Wed Nov 30 16:08:45 2011 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Thu, 01 Dec 2011 09:08:45 +0900 Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <4ED6BAA8.5030909@oracle.com> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> <4ED6BAA8.5030909@oracle.com> Message-ID: <4ED6C58D.7020702@oracle.com> Hi, (11/12/01 8:22), Masayoshi Okutsu wrote: > The I18N team will work on the following files. Please let me know if there are any duplicates. For Xiomara, I provide a shorter list. :-) > Naoto Sato: > java/awt/im > sun/awt/im > java/util/Currency.java > sun/util/LocaleServiceProviderPool.java > sun/util/resources/LocaleData.java > sun/util/resources/TimeZoneNamesBundle.java > > Yuka Kamiya: > sun/text > > Masayoshi Okutsu: > java/util/Date.java > java/util/GregorianCalendar.java > java/util/JapaneseImperialCalendar.java > java/util/ResourceBundle.java > sun/util/calendar > sun/util/resources/OpenListResourceBundle.java Note that sun.util.calendar and sun.util.resources are fully covered by Naoto and Masayoshi. As for java.util, we work on only files which are related to Internationalization(I18N). (And, files which are related to I18N but don't give warnings are not listed above.) I think many files in the package are still waiting for a volunteer (unless I have overlooked sign-up emails). Thanks, -- Yuka From xiomara.jayasena at oracle.com Wed Nov 30 16:31:41 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Wed, 30 Nov 2011 16:31:41 -0800 (PST) Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <20D72F6E-4035-4174-B022-EDA211823309@oracle.com> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default 20D72F6E-4035-4174-B022-EDA211823309@oracle.com> Message-ID: Max, I don't think Hinkmond has finalized his decision just yet from the e-mails I have seen, of course he can reply to this if that is not the case as of now. Note that Chris Hegarty has done some work on the sun.misc area as well: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7795c41ed54c -Xiomara > -----Original Message----- > From: Weijun Wang > Sent: Wednesday, November 30, 2011 3:22 PM > To: Xiomara Jayasena; hinkmond.wang at oracle.com > Cc: jdk8-dev at openjdk.java.net > Subject: Re: Areas of work: JDK8 Warnings Cleanup Day (WCD) > > So Hinkmond and I both work on sun.misc? So far I've found one switch- > case fall through and 2 serializeID missing there. Those were > discovered when I try to search for warnings in other security -related > area. > > Max > > > > On Dec 1, 2011, at 4:14 AM, Xiomara Jayasena > wrote: > > > > > Hi, > > > > So far the following people have signed up and I have put the area of > interest to work on next to their names. > > > > - Sebastian Sickelmann - java.io > > - Alan Bateman / Chris Hegarty - java.rmi.**, the serialization > classes, and several core classes [1] > > - Andrew John - Corba > > - Mario Torre -- src/share/classes/sun/java2d/SurfaceData.java > > - Weijun Wang - src/share/classes/javax/security/auth/Kerberos/ and > ./sun/misc/. > > - Michael Barker (London Jug) > > * java.util.jar > > * java.util.logging > > * java.util.prefs > > * java.util.regex > > * java.util.zip > > - Hinkmond Wong - jdk/make/sun/misc/* > > > > [1] http://cr.openjdk.java.net/~alanb/7116404/webrev/ > > > > Please let me know if you do not see something that you have sent in > and should be added above. The above is a summary of what we have so > far, there is still time to send in names of files/areas that you would > like to work on. > > > > > > -Xiomara > > > > From xiomara.jayasena at oracle.com Wed Nov 30 16:46:44 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Wed, 30 Nov 2011 16:46:44 -0800 (PST) Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: References: <868c0635-11fc-4bc7-9ee9-64513092526e@default 20D72F6E-4035-4174-B022-EDA211823309@oracle.com cd9959c6-1dda-4ffb-982d-6fbc3d4b6907@default> Message-ID: <797d2954-b548-424d-9b7d-45fee8e231f4@default> Resending with Hinkmond's correct e-mail. -Xiomara > -----Original Message----- > From: Xiomara Jayasena > Sent: Wednesday, November 30, 2011 4:32 PM > To: Weijun Wang; hinkmond.wang at oracle.com > Cc: jdk8-dev at openjdk.java.net > Subject: RE: Areas of work: JDK8 Warnings Cleanup Day (WCD) > > > Max, I don't think Hinkmond has finalized his decision just yet from > the e-mails I have seen, of course he can reply to this if that is not > the case as of now. > > Note that Chris Hegarty has done some work on the sun.misc area as > well: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7795c41ed54c > > -Xiomara > > > > -----Original Message----- > > From: Weijun Wang > > Sent: Wednesday, November 30, 2011 3:22 PM > > To: Xiomara Jayasena; hinkmond.wang at oracle.com > > Cc: jdk8-dev at openjdk.java.net > > Subject: Re: Areas of work: JDK8 Warnings Cleanup Day (WCD) > > > > So Hinkmond and I both work on sun.misc? So far I've found one > switch- > > case fall through and 2 serializeID missing there. Those were > > discovered when I try to search for warnings in other security > > -related area. > > > > Max > > > > > > > > On Dec 1, 2011, at 4:14 AM, Xiomara Jayasena > > wrote: > > > > > > > > Hi, > > > > > > So far the following people have signed up and I have put the area > > > of > > interest to work on next to their names. > > > > > > - Sebastian Sickelmann - java.io > > > - Alan Bateman / Chris Hegarty - java.rmi.**, the serialization > > classes, and several core classes [1] > > > - Andrew John - Corba > > > - Mario Torre -- src/share/classes/sun/java2d/SurfaceData.java > > > - Weijun Wang - src/share/classes/javax/security/auth/Kerberos/ and > > ./sun/misc/. > > > - Michael Barker (London Jug) > > > * java.util.jar > > > * java.util.logging > > > * java.util.prefs > > > * java.util.regex > > > * java.util.zip > > > - Hinkmond Wong - jdk/make/sun/misc/* > > > > > > [1] http://cr.openjdk.java.net/~alanb/7116404/webrev/ > > > > > > Please let me know if you do not see something that you have sent > in > > and should be added above. The above is a summary of what we have so > > far, there is still time to send in names of files/areas that you > > would like to work on. > > > > > > > > > -Xiomara > > > > > > From david.holmes at oracle.com Wed Nov 30 18:42:44 2011 From: david.holmes at oracle.com (David Holmes) Date: Thu, 01 Dec 2011 12:42:44 +1000 Subject: Areas of work: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: <4ED6A42A.7060204@oracle.com> References: <868c0635-11fc-4bc7-9ee9-64513092526e@default> <4ED6A42A.7060204@oracle.com> Message-ID: <4ED6E9A4.7040806@oracle.com> On 1/12/2011 7:46 AM, Kurchi Hazra wrote: > If java.util.concurrent is not yet taken up, I can work on that tomorrow. As Alan Bateman wrote in response to a similar suggestion: "java.util.concurrent.** is maintained by Doug Lea in an upstream CVS and we (Chris Hegarty in recent times) periodically pull the updates into OpenJDK to keep us in sync. We don't want the code in OpenJDK to diverge so typically any changes go into the upstream CVS first. So for j.u.c I would suggest sending a follow-up to core-libs-dev. Both Doug and Chris are on that list and I'm sure something can be worked out. " Regards, David Holmes > > Thanks, > Kurchi > > On 11/30/2011 12:14 PM, Xiomara Jayasena wrote: >> Hi, >> >> So far the following people have signed up and I have put the area of >> interest to work on next to their names. >> >> - Sebastian Sickelmann - java.io >> - Alan Bateman / Chris Hegarty - java.rmi.**, the serialization >> classes, and several core classes [1] >> - Andrew John - Corba >> - Mario Torre -- src/share/classes/sun/java2d/SurfaceData.java >> - Weijun Wang - src/share/classes/javax/security/auth/Kerberos/ and >> ./sun/misc/. >> - Michael Barker (London Jug) >> * java.util.jar >> * java.util.logging >> * java.util.prefs >> * java.util.regex >> * java.util.zip >> - Hinkmond Wong - jdk/make/sun/misc/* >> >> [1] http://cr.openjdk.java.net/~alanb/7116404/webrev/ >> >> Please let me know if you do not see something that you have sent in >> and should be added above. The above is a summary of what we have so >> far, there is still time to send in names of files/areas that you >> would like to work on. >> >> >> -Xiomara >> >> > From stuart.marks at oracle.com Wed Nov 30 19:12:18 2011 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 30 Nov 2011 19:12:18 -0800 Subject: Bugs for JDK8 Warnings Cleanup Day Message-ID: <4ED6F092.5080001@oracle.com> Hi all, Looks like we have lot of folks on board for the warnings cleanup. Great! I wanted to ask the Oracle folks participating to file bugs for the warnings cleanups they intend to do. After you've done so, please update the table on the WCD wiki page [1]. For external folks, when you get to the point of pulling together patches, contact us here (on jdk8-dev at openjdk.java.net) or on IRC [2] and we'll file a bug on your behalf. Sometimes the right granularity is hard to discern. A single file or a group of closely related files is usually OK. Hundreds of files spread around the system usually isn't. But we'll figure it out. Thanks! s'marks [1] http://wikis.sun.com/display/OpenJDK/JDK8+warning+cleanup+day+%282011-12-01%29 [2] http://openjdk.java.net/irc/ From xiomara.jayasena at oracle.com Wed Nov 30 20:16:36 2011 From: xiomara.jayasena at oracle.com (Xiomara Jayasena) Date: Wed, 30 Nov 2011 20:16:36 -0800 (PST) Subject: Wiki: JDK8 Warnings Cleanup Day (WCD) In-Reply-To: References: <868c0635-11fc-4bc7-9ee9-64513092526e@default b26a573f-c4c6-46f6-92d8-3250af008c4e@default> Message-ID: <71af17d2-86d1-427d-a08a-768ad867e841@default> Hi, I know there have been many e-mails flying around with information so I have put together a wiki with what I think is the pertinent information for this project. Wiki: http://wikis.sun.com/display/OpenJDK/JDK8+Warnings+Cleanup+Day Remember the bar for contributing to the JDK is high, I am sure you wouldn't want it any other way! -Xiomara _____________________________________________ From: Xiomara Jayasena Sent: Wednesday, November 30, 2011 3:05 PM To: jdk8-dev at openjdk.java.net Subject: RE: Areas of work: JDK8 Warnings Cleanup Day (WCD) Hi, I continue to track the different areas that are being picked up to work on for tomorrow here: http://wikis.sun.com/display/OpenJDK/JDK8+warning+cleanup+day+%282011-12-01%29 (thanks to Deepak Bhole for reminding us of this!) The above wiki will help us figure out who has signed up. Still, please continue to send messages to this alias (jdk8-dev) for the areas that you plan to work on. Thanks, -Xiomara From sebastian.sickelmann at gmx.de Wed Nov 30 20:33:30 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Thu, 01 Dec 2011 05:33:30 +0100 Subject: Request for Review (Warning Cleanup java.io) Message-ID: <4ED7039A.2080903@gmx.de> Hi, i have a webrev[0] that contains some warning cleanup for java.io It is based on rev 7795c41ed54c http://hg.openjdk.java.net/jdk8/tl/jdk/ Some comments to the changes: ExpiringCache.java: Changed anonymous inner class to inner class with the intention to put serialversion inside of it. But serialver doesn't want to give my the serialver. I also think that ExpiringCache is not serializable but the warning was clear: the anonymous inner class is seriallizable and has no explicit serialversionuid. FilePermission.java: I have starred at the code between line 453 and 547 for over an hour, because i thought that there is a bug within the expression "i >= matchlen" in line 530 and the both "i != -1" in lines 457 and 461. But there is no bug. But i wanted to left this code slightly more readable. I introduced the method skipBeforePreviousComma to make it possible to work-around the fallthought warning with an return statement. This code-change need's some more review attention. Maybe we should split this up for another cleanup. I think the whole method needs some rewrite. Some classes had no change at all. Maybe webrev created them because there where changes in my history/branches. There were some patches from alan i saw to late. Maybe webrev is confused of the multiple merges. Can someone please create a CR for this and [0] http://dl.dropbox.com/u/43692695/oss-patches/openjdk8/Warning_Cleanup_Java_io/webrev0_based_on_7795c41ed54c/index.html From sebastian.sickelmann at gmx.de Wed Nov 30 21:01:25 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Thu, 01 Dec 2011 06:01:25 +0100 Subject: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 In-Reply-To: References: <391b7649-4f85-47c2-805c-03aecc0ce5ac@default 4ED5AAAB.6070404@gmx.de> Message-ID: <4ED70A25.2030609@gmx.de> Am 30.11.2011 06:21, schrieb Xiomara Jayasena: > Thanks Sebastian. Can you please send me the full path to the file that you plan to work on? > > -Xiomara A few moments ago i send and review request to the lists. Unfortunately i saw Alans patches and push a little bit to late. Alan had fixed most warnings in java.io already ;-) But i have merged it. I try to be online on irc (nickname sebastian_sickelmann) during the day with my mobile. -- Sebastian > >> -----Original Message----- >> From: Sebastian Sickelmann [mailto:sebastian.sickelmann at gmx.de] >> Sent: Tuesday, November 29, 2011 8:02 PM >> To: Xiomara Jayasena >> Cc: jdk8-dev at openjdk.java.net; jdk7-dev at openjdk.java.net; build- >> dev at openjdk.java.net >> Subject: Re: JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011 >> >> This is a great idea. >> >> Don't know how many time i can invest in the timeframe (till 02:00 am >> GMT+1) but i want to look at java.io >> >> -- Sebastian >> >> Am 29.11.2011 03:10, schrieb Xiomara Jayasena: >>> A few teams are planning on cleaning up warnings generated during the >> JDK build on Dec. 1st. We would like to invite you to participate. >>> >>> >>> To be able to participate a prerequisite is that you are able build >> the JDK. The source that we will target is JDK8. If you decide to >> participate then please reply to this e-mail with the area that you >> intend to work on. I will keep track of the areas so that there is no >> overlap of work. >>> >>> >>> . A group of us working on this project will create bugs for >> the areas that developers sign up for. >>> . The focus will be on java warnings, since these are less >> risky. >>> . For this exercise please avoid making any API changes or >> any large scale refactorings. >>> . Avoid @SuppressWarnings except where it is clearly >> necessary. >>> . We would like to have the code changes completed by 5pm >> (PST) on Dec. 1st. >>> . A suggested area to work on is the build step defined by: >> jdk/make/java/java/ which compiles close to 500 .java files and >> produces over 1200 warnings. The java files are in java.io, java.lang, >> java.util and a variety of related packages. >>> >>> >>> Process to follow: >>> >>> >>> >>> 1. Pick a file or a few files to work on and send mail to jdk8- >> dev by 8am PT on Thursday to let us know which area you would like to >> work on. >>> 2. A bug ID will be generated for this. >>> >>> 3. Pull this repo to base your changes on it: >> http://hg.openjdk.java.net/jdk8/tl/jdk >>> 4. Post your changes for review. If you have webrev, please >> use it. If you don't have webrev, please generate a patch and post it >> here as a .txt attachment. If the patch is too cumbersome to review, >> we can generate a webrev for you. >>> 5. All of the changes must go through the usual build, test and >> review process before being pushed. If you are a JDK8 committer you >> may push after completing the usual process. If you aren't a committer >> we will help you review and test your changes. >>> 6. In order to streamlines the process, Stuart Marks will be >> consolidating patches and running build and test jobs - thanks to >> Stuart for doing this! >>> >>> >>> Lastly to get a build with warnings enable use the following flags: >>> >>> make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= >> OTHER_JAVACFLAGS="-Xmaxwarns 10000" >>> >>> >>> Tip: Make sure to redirect output to a file. To find the >> jdk/make/java/java/Makefile build step mentioned above, open the log >> file and look for the first occurrence of '# Running javac'. Voluminous >> warning output should appear below." >>> >>> >>> -Xiomara