JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011

[Rémi Forax]

On 11/29/2011 03:10 AM, Xiomara Jayasena wrote:
> A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st.  We would like to invite you to participate.
>
>
>
> To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8.  If you decide to participate then please reply to this e-mail with the area that you intend to work on.  I will keep track of the areas so that there is no overlap of work.
>
>
>
> .         A group of us working on this project will create bugs for the areas that developers sign up for.
>
> .         The focus will be on java warnings, since these are less risky.
>
> .         For this exercise please avoid making any API changes or any large scale refactorings.
>
> .         Avoid @SuppressWarnings except where it is clearly necessary.
>
> .         We would like to have the code changes completed by 5pm (PST) on Dec. 1st.
>
> .         A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings.  The java files are in java.io, java.lang, java.util and a variety of related packages.
>
>
>
> Process to follow:
>
>
>
> 1.       Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on.
>
> 2.       A bug ID will be generated for this.
>
> 3.       Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk
>
> 4.       Post your changes for review.  If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment.  If the patch is too cumbersome to review, we can generate a webrev for you.
>
> 5.       All of the changes must go through the usual build, test and review process before being pushed.  If you are a JDK8 committer you may push after completing the usual process.  If you aren't a committer we will help you review and test your changes.
>
> 6.       In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this!
>
>
>
> Lastly to get a build with warnings enable use the following flags:
>
> make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000"
>
>
>
> Tip: Make sure to redirect output to a file.  To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below."
>
>
>
> -Xiomara

I don't think I will have the time to participate this week,
anyway, I was browsing the source of java.util recently,
and found that at several places the code was generified (during 
transition from 1.4 to 1.5)
with a light sabre (raw type everywhere, dubious unsafe cast, etc)
and it will never work if generics are reified in the future.

If these warnings are still not removed this week-end, I will provide a 
patch :)

Rémi