JDK 8 Warnings Cleanup Day -- Dec. 1st, 2011

[Stuart Marks]

[I've removed jdk7-dev and build-dev]

Hi Ben, Bruno, et al,

I'm working with Xiomara on this Warnings Cleanup Day. Sorry for the short 
notice. For this effort we wanted to get something put together really quickly, 
mainly to see what happens, and also to see who might be interested. With such 
short notice the best we could hope for would be to get patches from a couple 
motivated individuals. That alone would be a great outcome.

For future efforts it would be great to get the JUGs involved! Of course, this 
would require more lead time and more planning effort. Would we try to get JUG 
events and an Oracle JDK developer event all on the same day? That would truly 
be an International Warnings Cleanup Day. Or would it be easier for individual 
JUGs to run their own individual events, and then to work with us to get the 
patches reviewed and tested? You tell me. We'd be happy to help support such 
efforts.

As for what to work on, I'm sure there will still be plenty of warnings 
remaining after this week's Cleanup Day. (Recent patches from Alan Bateman and 
Lance Andersen on core-libs-dev have pulled us below 10,000 by my count.) There 
are also warnings from findbugs, and there is also the potential to continue of 
the Coinification work that I did during JDK7 development. So there's no 
shortage of stuff to work on.

Of course, anybody can work on this stuff at any time, but it'd probably be 
much more fun (and more likely to get done) if it were done as part of some 
kind of event.

Anyway, I'd love to hear your ideas for how to structure a follow-up event.

s'marks

On 11/29/11 3:47 AM, Ben Evans wrote:
> Hi Xiomara,
>
> This looks like a great project, and is definitely the sort of
> participation that the user group community can help with.
>
> However, we need more lead time to effectively participate. In our
> experience the best way for the community to help with something like
> this is to have a physical meet. That way the relatively small number
> of people in our communities who can build OpenJDK are able to help
> the others bootstrap ("teach them to fish"), and thereby increase
> overall participation.
>
> As this is an out-of-work activity for the vast majority of our
> members, we need time to plan and promote our events - especially if
> this is to be done as an after-work activity.
>
> We probably won't be able to manage to put an event together for this
> week - but on the assumption that there'll still be plenty of warnings
> to squish - can we plan for a later date when we can help?
>
>> From the community side, some of the right people to reach out to are
> myself and Martijn Verburg from LJC (London), and Bruno Souza and Yara
> Senger from SouJava (Brazil) - we can then ensure the message gets out
> to the rest of the global JUG community.
>
> Shame that it's probably too close for us to do much this time - but
> let us know how it goes, and we'd definitely love to do something if
> we had more notice.
>
> Thanks,
>
> Ben
>
> On Tue, Nov 29, 2011 at 2:10 AM, Xiomara Jayasena
> <xiomara.jayasena at oracle.com>  wrote:
>> A few teams are planning on cleaning up warnings generated during the JDK build on Dec. 1st.  We would like to invite you to participate.
>>
>>
>>
>> To be able to participate a prerequisite is that you are able build the JDK. The source that we will target is JDK8.  If you decide to participate then please reply to this e-mail with the area that you intend to work on.  I will keep track of the areas so that there is no overlap of work.
>>
>>
>>
>> .         A group of us working on this project will create bugs for the areas that developers sign up for.
>>
>> .         The focus will be on java warnings, since these are less risky.
>>
>> .         For this exercise please avoid making any API changes or any large scale refactorings.
>>
>> .         Avoid @SuppressWarnings except where it is clearly necessary.
>>
>> .         We would like to have the code changes completed by 5pm (PST) on Dec. 1st.
>>
>> .         A suggested area to work on is the build step defined by: jdk/make/java/java/ which compiles close to 500 .java files and produces over 1200 warnings.  The java files are in java.io, java.lang, java.util and a variety of related packages.
>>
>>
>>
>> Process to follow:
>>
>>
>>
>> 1.       Pick a file or a few files to work on and send mail to jdk8-dev by 8am PT on Thursday to let us know which area you would like to work on.
>>
>> 2.       A bug ID will be generated for this.
>>
>> 3.       Pull this repo to base your changes on it: http://hg.openjdk.java.net/jdk8/tl/jdk
>>
>> 4.       Post your changes for review.  If you have webrev, please use it. If you don't have webrev, please generate a patch and post it here as a .txt attachment.  If the patch is too cumbersome to review, we can generate a webrev for you.
>>
>> 5.       All of the changes must go through the usual build, test and review process before being pushed.  If you are a JDK8 committer you may push after completing the usual process.  If you aren't a committer we will help you review and test your changes.
>>
>> 6.       In order to streamlines the process, Stuart Marks will be consolidating patches and running build and test jobs - thanks to Stuart for doing this!
>>
>>
>>
>> Lastly to get a build with warnings enable use the following flags:
>>
>> make JAVAC_MAX_WARNINGS=true JAVAC_WARNINGS_FATAL= OTHER_JAVACFLAGS="-Xmaxwarns 10000"
>>
>>
>>
>> Tip: Make sure to redirect output to a file.  To find the jdk/make/java/java/Makefile build step mentioned above, open the log file and look for the first occurrence of '# Running javac'. Voluminous warning output should appear below."
>>
>>
>>
>> -Xiomara
>>