Miscellaneous minor patches: javadoc typos, javac warnings, etc.

Phil Race philip.race at oracle.com
Tue Oct 4 18:58:35 PDT 2011


On 10/4/2011 2:35 PM, David Holmes wrote:
> Hi Martin,
>
> Your patches also touch files "owned" by different areas so you 
> probably need to split them up into different groups. java.lang 
> changes go through core-libs at openjdk.java.net, AWT through 
> awt-dev at openjdk.java.net. I don't know if the imageio stuff belongs to 
> AWT or 2D or ...

All of the ones I see with "awt" in the package name are in fact 2D 
classes, not AWT.
Also imageio is also 2D.  So 2d-dev at openjdk.java.net

The swing ones are [obviously] swing-dev at openjdk.javanet

Webrev is far better than inline patches. It has all the pieces you need 
to review, including
the old file, the new file, the diff in different formats, the patch .. 
I'd definitely want to see
the changes in webrev before approving any 2D changes.

-phil.

>
> Of course if someone sponsors these simple patches they may be able to 
> do the split for you.
>
> David
>
> On 5/10/2011 7:31 AM, Martin Desruisseaux wrote:
>> Hello Andrew and Xiomara
>>
>> Thanks lot for your tip. I have successfully installed and ran webrev. I
>> will try to find some web space where to put the proposed patches during
>> the next days and get familiar with the contribution process. I will
>> send a new email when the patches will be posted on a web site.
>>
>> Regards,
>>
>> Martin
>>
>>
>> Le 04/10/11 23:07, Dr Andrew John Hughes a écrit :
>>> On 18:17 Tue 04 Oct , Martin Desruisseaux wrote:
>>>> Hello all
>>>>
>>>> I have a set of minor patches that I would like to submit for JDK8.
>>>> I'm not yet
>>>> familiar with the contribution process. I presume that sending
>>>> patches by email
>>>> is not the preferred way, but I'm not sure which process I should use.
>>> Personally I think patches by email works best; you can commit inline
>>> on them,
>>> everything can take place within the mail client and the patches are
>>> then archived
>>> along with the mails.
>>>
>>> However, the Oracle developers seem to prefer their own tool for this:
>>>
>>> http://blogs.oracle.com/jcc/resource/webrev-doc.html
>>>
>>> the results of which then need to be posted on some web space 
>>> somewhere.
>>



More information about the jdk8-dev mailing list