Objective-C and jcheck

[Kelly O'Hair]

CC John Coomes...

First, the jcheck script contains:
    normext_re = re.compile(".*\.(java|c|h|cpp|hpp)$")
I don't understand how you are getting this error, it isn't checking *.m files. Did something change?

Second, it was my understanding that additions of Objective-C source code into the JDK was going to be very very limited.
The more Objective-C code we add, the fewer developers we will have to fix issues with it.
Not everyone is skilled at Objective-C. I understand we need to bridge a little, but I really hope it is limited
and very well documented.

-kto

On Aug 28, 2012, at 4:22 AM, Sergey Bylokhov wrote:

> Hi Everybody.
> Looks like on the server we still use jcheck without fix for Objective-C files? Does anybody know how to apply the fix to jdk8? (see attachment)
> 
> [jdk]
> pulling from http://hg.openjdk.java.net/jdk8/awt/jdk
> searching for changes
> adding changesets
> adding manifests
> adding file changes
> added 1 changesets with 10 changes to 10 files
> [jcheck 25e85a608db1 2011-07-08 09:19 -0700]
> 
> > Changeset: 5305:0fad89bd606b
> > Author:    alexsch
> > Date:      2012-05-02 17:54
> >
> > 7154048: [macosx] At least drag twice, the toolbar can be dragged to the left
> side
> > Reviewed-by: anthony, leonidr
> 
> src/macosx/native/sun/awt/AWTView.m:84: Trailing whitespace
> src/macosx/native/sun/awt/AWTWindow.m:173: Trailing whitespace
> 
> transaction abort!
> rollback completed
> skipped: pretxnchangegroup.jcheck hook failed
> 
> 02.05.2012 17:53, alexandr.scherbatiy at oracle.com wrote
>> Changeset: 0fad89bd606b
>> Author:    alexsch
>> Date:      2012-05-02 17:54 +0400
>> URL:       http://hg.openjdk.java.net/jdk8/awt/jdk/rev/0fad89bd606b
>> 
>> 7154048: [macosx] At least drag twice, the toolbar can be dragged to the left side
>> Reviewed-by: anthony, leonidr
>> 
>> ! src/macosx/classes/sun/lwawt/LWWindowPeer.java
>> ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java
>> ! src/macosx/native/sun/awt/AWTView.h
>> ! src/macosx/native/sun/awt/AWTView.m
>> ! src/macosx/native/sun/awt/AWTWindow.h
>> ! src/macosx/native/sun/awt/AWTWindow.m
>> + test/java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java
>> + test/java/awt/Mouse/EnterExitEvents/DragWindowTest.java
>> + test/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java
>> ! test/java/awt/regtesthelpers/Util.java
>> 
> 
> 
> <Вложенное сообщение.eml>