RFR: 7113349 JDK8 port to macosx

Kumar Srinivasan kumar.x.srinivasan at oracle.COM
Mon Feb 27 17:03:56 PST 2012


Hi Michael,

I looked at the launcher and pack200 files:

General comment, the copyrights are out of sync.

can we make MACOSX consistent ? we have _ALLBSD_SOURCE and MACOSX,
in the following files:
src/share/native/com/sun/java/util/jar/pack/main.cpp
src/share/native/com/sun/java/util/jar/pack/defines.h

In make/com/sun/java/pack/Makefile

OTHER_CXXFLAGS += -DSYSTEM_ZLIB
we don't use this conditional in pack source ?
also the indent is not correct 1 space.

Kumar



> This is an updated webrev for the Mac OS X changes after comments so far:
>
> http://cr.openjdk.java.net/~michaelm/7113349/jdk8/webrev.3/
>
> The main changes from the original webrev are:
>
> - jprt configuration for macosx
> - problem list updates
> - removal of dud source files brought in from 7u-dev by mistake
> - langtools test updates
> - synchronized with TL now as opposed to master
> - removal of fix for 7087956, which wasn't part of mac os work
>
> Comments welcome.
>
> Thanks,
> Michael.
>
> On 22/02/12 21:50, Michael McMahon wrote:
>> This is the webrev for the Mac OS changes for JDK8. It is pretty much
>> a straight merge of the current jdk7u-dev changes. It builds and 
>> passes most
>> JCK and regression tests with only a small number of failures.
>>
>> http://cr.openjdk.java.net/~michaelm/7113349/jdk8/webrev.1/
>>
>> There are three separate webrevs at the link above for the three 
>> separate
>> repositories affected (the top-level, corba and jdk). Obviously most 
>> of the changes
>> are in the jdk webrev. Comments welcome!
>>
>> Thanks,
>> Michael.
>



More information about the jdk8-dev mailing list