Java User Group - Warnings clean-up hack day - 31st of Jan

Stuart Marks stuart.marks at oracle.com
Mon Jan 30 16:08:51 PST 2012


Hi Martijn,

Great to hear that you're doing this!

I don't know if anyone from Oracle will be involved in this. I can try to hang 
out on the #openjdk IRC channel, and I can review and push a couple of the 
patches if you need help doing so. What time do you guys think you'll be online?

If you need to track the work on a wiki, the obvious place is a page next to 
the previous Warnings Cleanup Day wiki, which has been moved from wikis.sun.com 
to wikis.oracle.com [1]. Unfortunately that's actually an Oracle wiki, not an 
OpenJDK wiki, though we do have OpenJDK material on there. It's not entirely 
clear to me how external folks can get access to this wiki. (I know that some 
external folks do have access, but it's through a process different from 
OpenJDK.) Dalibor might have a better idea.

I've added an awk script to the main Warnings Cleanup page [2] that does some 
analysis of warnings from a build log. I used this script to keep track of the 
warnings counts as the cleanup fixes were integrated. This script breaks down 
the warnings by "build step", that is, a run of javac from a particular 
Makefile in a jdk/make subdirectory. It might be effective to use the report 
from this script to target a build step with relatively few warnings and to get 
it all the way to zero. When this occurs, -Werror can be added to its Makefile 
to prevent warnings from being reintroduced. Another approach would be to find 
a build step with hundreds or thousands (!) of warnings and then further break 
it down to file granularity.

(Crap. I've just realized that I never pushed Deepak Bhole's java.text patches 
from December. To avoid conflicts, I'd suggest avoiding changes to 
src/share/classes/java/text. Other areas should be fair game.)

In any case, this script counts warnings the same way I did for the previous 
warning stats, so we can get consistent numbers.

Good luck with the event, and I hope to see you on IRC tomorrow.

s'marks


[1] 
https://wikis.oracle.com/display/OpenJDK/JDK8+warning+cleanup+day+%282011-12-01%29

[2] https://wikis.oracle.com/display/OpenJDK/JDK8+Warnings+Cleanup+Day


On 1/27/12 6:52 AM, Martijn Verburg wrote:
> Hi all,
>
> We've finally managed to find a space that lets us stay late enough in
> the evening (not everyone has the hardware to build the openjdk
> quickly ;p) of the 31st of Jan and so the LJC is going to host another
> OpenJDK hack day. This will basically be a repeat of the last one,
> that is, focusing on reducing more compiler warnings and giving people
> like Mike and myself more practise in reviewing patches and getting
> them into a state that can be easily reviewed by OpenJDK committers
> (and are hopefully already at a decent quality level).
>
> We've now also got an enhanced VM with the jtreg test support in place
> as well, so this time round we'll be able to run those.
>
> John Yeary in the US is also going to try and co-ordinate some teams
> over there and I'm happy to get other user groups involved as well,
> but I thought I'd better check here first to co-ordinate.
>
> What is the best way for us to liaise this time around?  Should we use
> the Wiki again to track changes or..?
>
> Cheers,
> Martijn


More information about the jdk8-dev mailing list